mm/memory-failure.c: A few cleanup patches for memory failure
Subsystems (2)
Miaohe Lin
maintainercover mm/memory-failure.c: A few cleanup patches for memory failure
Hi,
This series contains a few patches to simplify the code logic, remove unneeded variable and remove obsolete comment. More details can be found in the respective changelogs. Thanks!
Miaohe Lin (8):
mm/memory-failure.c: minor clean up for memory_failure_dev_pagemap mm/memory-failure.c: avoid walking page table when vma_address()
return -EFAULT
mm/memory-failure.c: rework the signaling logic in kill_proc mm/memory-failure.c: remove unneeded orig_head mm/memory-failure.c: remove PageSlab check in hwpoison_filter_dev mm/memory-failure.c: rework the try_to_unmap logic in
hwpoison_user_mappings()
mm/memory-failure.c: remove obsolete comment in __soft_offline_page mm/memory-failure.c: remove unnecessary PageTransTail check
mm/memory-failure.c | 74 ++++++++++++++++++--------------------------- 1 file changed, 29 insertions(+), 45 deletions(-)
Signature · 1 line
2.23.0
Miaohe Lin
maintainerPATCH 1/8 mm/memory-failure.c: minor clean up for memory_failure_dev_pagemap
The flags always has MF_ACTION_REQUIRED and MF_MUST_KILL set. So we do not need to check these flags again.
--- mm/memory-failure.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
mm/memory-failure.c +2 -2
@@ -1644,7 +1644,7 @@ static int memory_failure_dev_pagemap(unsigned long pfn, int flags,* SIGBUS (i.e. MF_MUST_KILL) */ flags |=MF_ACTION_REQUIRED |MF_MUST_KILL ; -collect_procs (page, &tokill, flags &MF_ACTION_REQUIRED ); +collect_procs (page, &tokill, true);list_for_each_entry (tk, &tokill, nd)if (tk->size_shift)
@@ -1659,7 +1659,7 @@ static int memory_failure_dev_pagemap(unsigned long pfn, int flags, start = (page->index <<PAGE_SHIFT ) & ~(size -1 );unmap_mapping_range (page->mapping, start, size,0 ); } -kill_procs (&tokill, flags &MF_MUST_KILL , false, pfn, flags); +kill_procs (&tokill, true, false, pfn, flags); rc =0 ; unlock:dax_unlock_page (page, cookie);
Signature · 1 line
2.23.0
Re: [PATCH 1/8] mm/memory-failure.c: minor clean up for memory_failure_dev_pagemap
Quoted 4 lines · Miaohe Lin
The flags always has
MF_ACTION_REQUIREDandMF_MUST_KILLset. So we do not need to check these flags again.Signed-off-by Miaohe Lin <[email protected]>
Miaohe Lin
maintainerPATCH 2/8 mm/memory-failure.c: avoid walking page table when vma_address() return -EFAULT
In reply to Miaohe LinIt's unnecessary to walk the page table when vma_address() return -EFAULT. Return early if so to save some cpu cycles.
--- mm/memory-failure.c | 2 ++ 1 file changed, 2 insertions(+)
mm/memory-failure.c +2 -0
@@ -315,6 +315,8 @@ static unsigned long dev_pagemap_mapping_shift(struct page *page,pmd_t *pmd;pte_t *pte; +if (address == -EFAULT ) +return 0 ; pgd =pgd_offset (vma->vm_mm, address);if (!pgd_present (*pgd))return 0 ;
Signature · 1 line
2.23.0
Re: [PATCH 2/8] mm/memory-failure.c: avoid walking page table when vma_address() return -EFAULT
Quoted 4 lines · Miaohe Lin
It's unnecessary to walk the page table when
vma_address()return-EFAULT. Return early if so to save some cpu cycles.Signed-off-by Miaohe Lin <[email protected]>
Does this patch fix the real problem rather than just saving cpu cycles? Without this patch, "address == -EFAULT" seems to make pgd_offset() return invalid pointer and result in some serious result like general protection fault. If that's the case, this patch might be worth sending to stable.
Thanks,
Naoya Horiguchi
Quoted 20 lines
--- mm/memory-failure.c | 2 ++ 1 file changed, 2 insertions(+)mm/memory-failure.c +2
-1@@ -315,6 +315,8 @@ static unsigned long dev_pagemap_mapping_shift(struct page *page,pmd_t *pmd;pte_t *pte; +if (address == -EFAULT ) +return 0 ; pgd =pgd_offset (vma->vm_mm, address);if (!pgd_present (*pgd))return 0 ; ---2.23.0
Miaohe Lin
maintainerRe: [PATCH 2/8] mm/memory-failure.c: avoid walking page table when vma_address() return -EFAULT
Quoted 7 lines · Naoya Horiguchi
Quoted 4 lines · Miaohe Lin
It's unnecessary to walk the page table when
vma_address()return-EFAULT. Return early if so to save some cpu cycles.Signed-off-by Miaohe Lin <[email protected]>Acked-by Naoya Horiguchi <[email protected]>
Many thanks for your review and Acked-by tag!
Quoted 4 lines
Does this patch fix the real problem rather than just saving cpu cycles? Without this patch, "address ==
-EFAULT" seems to makepgd_offset()return invalid pointer and result in some serious result like general protection fault.
I think you're right. We might dereference the invalid pointer in the following pagetable walk and results in general protection fault.
Quoted 1 line
If that's the case, this patch might be worth sending to stable.
But I'am not sure vma_address will return -EFAULT for dax pages in the real workload? If so, I will send a v2 with Fixes tag.
Thanks again.
Quoted 26 lines
Thanks,
Naoya HoriguchiQuoted 18 lines
--- mm/memory-failure.c | 2 ++ 1 file changed, 2 insertions(+)mm/memory-failure.c +2
-1@@ -315,6 +315,8 @@ static unsigned long dev_pagemap_mapping_shift(struct page *page,pmd_t *pmd;pte_t *pte; +if (address == -EFAULT ) +return 0 ; pgd =pgd_offset (vma->vm_mm, address);if (!pgd_present (*pgd))return 0 ; ---Quoted 2 lines
2.23.0
.
Re: [PATCH 2/8] mm/memory-failure.c: avoid walking page table when vma_address() return -EFAULT
Quoted 10 lines · Miaohe Lin
Quoted 7 lines · Naoya Horiguchi
Quoted 4 lines · Miaohe Lin
It's unnecessary to walk the page table when
vma_address()return-EFAULT. Return early if so to save some cpu cycles.Signed-off-by Miaohe Lin <[email protected]>Acked-by Naoya Horiguchi <[email protected]>Many thanks for your review and Acked-by tag!
You're welcome :)
Quoted 6 lines
Quoted 5 lines
Does this patch fix the real problem rather than just saving cpu cycles? Without this patch, "address ==
-EFAULT" seems to makepgd_offset()return invalid pointer and result in some serious result like general protection fault.
Quoted 7 lines
I think you're right. We might dereference the invalid pointer in the following pagetable walk and results in general protection fault.
Quoted 1 line
If that's the case, this patch might be worth sending to stable.
But I'am not sure
vma_addresswill return-EFAULTfor dax pages in the real workload? If so, I will send a v2 with Fixes tag.
Hm, actually I'm not sure either. But dev_pagemap_mapping_shift() is called only when vma associated to the error page is found already in collect_procs_{file,anon}, so vma_address() should not return -EFAULT except with some bug.
So VM_BUG_ON() might be more suitable?
Thanks,
Naoya Horiguchi
Miaohe Lin
maintainerRe: [PATCH 2/8] mm/memory-failure.c: avoid walking page table when vma_address() return -EFAULT
Quoted 25 lines · HORIGUCHI NAOYA(堀口 直也)
Quoted 10 lines · Miaohe Lin
Quoted 7 lines · Naoya Horiguchi
Quoted 4 lines · Miaohe Lin
It's unnecessary to walk the page table when
vma_address()return-EFAULT. Return early if so to save some cpu cycles.Signed-off-by Miaohe Lin <[email protected]>Acked-by Naoya Horiguchi <[email protected]>Many thanks for your review and Acked-by tag!
You're welcome :)
Quoted 11 lines
Quoted 5 lines
Does this patch fix the real problem rather than just saving cpu cycles? Without this patch, "address ==
-EFAULT" seems to makepgd_offset()return invalid pointer and result in some serious result like general protection fault.I think you're right. We might dereference the invalid pointer in the following pagetable walk and results in general protection fault.
Quoted 1 line
If that's the case, this patch might be worth sending to stable.
Quoted 7 lines
Quoted 2 lines
But I'am not sure
vma_addresswill return-EFAULTfor dax pages in the real workload? If so, I will send a v2 with Fixes tag.Hm, actually I'm not sure either. But
dev_pagemap_mapping_shift()is called only when vma associated to the error page is found already in collect_procs_{file,anon}, sovma_address()should not return-EFAULTexcept with some bug.
SoVM_BUG_ON()might be more suitable?
Agree. anon_vma_interval_tree_foreach/vma_interval_tree_foreach in collect_procs_{file,anon} should have guaranteed the validity of the vma_address(). And rmap_walk_anon and rmap_walk_file do the VM_BUG_ON_VMA(address == -EFAULT, vma). So VM_BUG_ON() might be really more suitable. Will do this in v2.
Many thanks.
Quoted 4 lines
Thanks,
Naoya Horiguchi
Miaohe Lin
maintainerPATCH 3/8 mm/memory-failure.c: rework the signaling logic in kill_proc
In reply to Miaohe LinBUS_MCEERR_AR code is only sent when MF_ACTION_REQUIRED is set and the target is current. Rework the code to make this clear.
--- mm/memory-failure.c | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-)
mm/memory-failure.c +6 -10
@@ -258,16 +258,13 @@ static int kill_proc(struct to_kill *tk, unsigned long pfn, int flags)pr_err ("Memory failure: %#lx: Sending SIGBUS to %s:%d due to hardware memory corruption\n" , pfn, t->comm, t->pid); -if (flags &MF_ACTION_REQUIRED ) { -if (t == current) - ret =force_sig_mceerr (BUS_MCEERR_AR , - (void __user *)tk->addr, addr_lsb); -else -/* Signal other processes sharing the page if they have PF_MCE_EARLY set. */ - ret =send_sig_mceerr (BUS_MCEERR_AO , (void __user *)tk->addr, - addr_lsb, t); - }else { +if ((flags &MF_ACTION_REQUIRED ) && (t == current)) + ret =force_sig_mceerr (BUS_MCEERR_AR , + (void __user *)tk->addr, addr_lsb); +else /* +* Signal other processes sharing the page if they have +* PF_MCE_EARLY set. * Don't use force here, it's convenient if the signal * can be temporarily blocked. * This could cause a loop when the user sets SIGBUS
@@ -275,7 +272,6 @@ static int kill_proc(struct to_kill *tk, unsigned long pfn, int flags)*/ ret =send_sig_mceerr (BUS_MCEERR_AO , (void __user *)tk->addr, addr_lsb, t);/* synchronous? */ - }if (ret <0 )pr_info ("Memory failure: Error sending signal to %s:%d: %d\n" , t->comm, t->pid, ret);
Signature · 1 line
2.23.0
Re: [PATCH 3/8] mm/memory-failure.c: rework the signaling logic in kill_proc
Quoted 4 lines · Miaohe Lin
BUS_MCEERR_ARcode is only sent whenMF_ACTION_REQUIREDis set and the target is current. Rework the code to make this clear.Signed-off-by Miaohe Lin <[email protected]>
Miaohe Lin
maintainerPATCH 4/8 mm/memory-failure.c: remove unneeded orig_head
In reply to Miaohe Linorig_head is used to check whether the page have changed compound pages during the locking. But it's always equal to hpage. So we can use hpage directly and remove this redundant one.
--- mm/memory-failure.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
mm/memory-failure.c +2 -3
@@ -1691,7 +1691,6 @@ int memory_failure(unsigned long pfn, int flags) {struct page *p;struct page *hpage; -struct page *orig_head;struct dev_pagemap *pgmap;int res =0 ;unsigned long page_flags;
@@ -1737,7 +1736,7 @@ int memory_failure(unsigned long pfn, int flags) goto unlock_mutex; } - orig_head = hpage =compound_head (p); + hpage =compound_head (p);num_poisoned_pages_inc ();/*
@@ -1821,7 +1820,7 @@ int memory_failure(unsigned long pfn, int flags)* The page could have changed compound pages during the locking. * If this happens just bail out. */ -if (PageCompound (p) &&compound_head (p) != orig_head) { +if (PageCompound (p) &&compound_head (p) != hpage) {action_result (pfn,MF_MSG_DIFFERENT_COMPOUND ,MF_IGNORED ); res = -EBUSY ; goto unlock_page;
Signature · 1 line
2.23.0
Re: [PATCH 4/8] mm/memory-failure.c: remove unneeded orig_head
Quoted 31 lines · Miaohe Lin
orig_headis used to check whether the page have changed compound pages during the locking. But it's always equal to hpage. So we can use hpage directly and remove this redundant one.Signed-off-by Miaohe Lin <[email protected]>--- mm/memory-failure.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)mm/memory-failure.c +1
-2@@ -1691,7 +1691,6 @@ int memory_failure(unsigned long pfn, int flags) {struct page *p;struct page *hpage; -struct page *orig_head;struct dev_pagemap *pgmap;int res =0 ;unsigned long page_flags;@@ -1737,7 +1736,7 @@ int memory_failure(unsigned long pfn, int flags) goto unlock_mutex; } - orig_head = hpage =compound_head (p); + hpage =compound_head (p);num_poisoned_pages_inc ();/*
mm/memory-failure.c int memory_failure(unsigned long pfn, int flags) · line 1823
Quoted 5 lines
mm/memory-failure.c +1
-1@@ -1821,7 +1820,7 @@ int memory_failure(unsigned long pfn, int flags)* The page could have changed compound pages during the locking. * If this happens just bail out. */ -if (PageCompound (p) &&compound_head (p) != orig_head) { +if (PageCompound (p) &&compound_head (p) != hpage) {
I think that this if-check was intended to detect the case that page p belongs to a thp when memory_failure() is called and belongs to a compound page in different size (like slab or some driver page) after the thp is split. But your suggestion makes me aware that the page p could be embedded on a thp again after thp split. I think this might be rare, but if it happens the current if-check (or suggested one) cannot detect it. So I feel that simply dropping compound_head() check might be better?
- if (PageCompound(p) && compound_head(p) != orig_head) {
+ if (PageCompound(p)) {
This should ensure the assumption (mentioned in 8/8 patch) more that the error page never belongs to compound page after taking page lock.
Thanks,
Naoya Horiguchi
Miaohe Lin
maintainerRe: [PATCH 4/8] mm/memory-failure.c: remove unneeded orig_head
Quoted 30 lines · Naoya Horiguchi
Quoted 29 lines · Miaohe Lin
orig_headis used to check whether the page have changed compound pages during the locking. But it's always equal to hpage. So we can use hpage directly and remove this redundant one.Signed-off-by Miaohe Lin <[email protected]>--- mm/memory-failure.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)mm/memory-failure.c +1
-2@@ -1691,7 +1691,6 @@ int memory_failure(unsigned long pfn, int flags) {struct page *p;struct page *hpage; -struct page *orig_head;struct dev_pagemap *pgmap;int res =0 ;unsigned long page_flags;@@ -1737,7 +1736,7 @@ int memory_failure(unsigned long pfn, int flags) goto unlock_mutex; } - orig_head = hpage =compound_head (p); + hpage =compound_head (p);num_poisoned_pages_inc ();
Quoted 13 lines
mm/memory-failure.c int memory_failure(unsigned long pfn, int flags) · line 1823
Quoted 7 lines
mm/memory-failure.c +1
-1/* @@ -1821,7 +1820,7 @@ int memory_failure(unsigned long pfn, int flags)* The page could have changed compound pages during the locking. * If this happens just bail out. */ -if (PageCompound (p) &&compound_head (p) != orig_head) { +if (PageCompound (p) &&compound_head (p) != hpage) {I think that this if-check was intended to detect the case that page p belongs to a thp when
memory_failure()is called and belongs to a compound page in different size (like slab or some driver page) after the thp is split. But your suggestion makes me aware that the page p could be embedded on a thp again after thp split. I think this might be rare, but if it
IIUC, this page can't be embedded on a thp again after thp split because memory_failure hold an __extra__ page refcnt. I think there exist below race windows:
memory_failure
orig_head = hpage = compound_head(p); -- page is Non-compound yet
< -- Page becomes compound page, like thp, slab, some driver page and even hugetlb page -- > get_hwpoison_page
failed to split thp page, as hpage is Non-compound ...
lock_page
Review
Quoted 5 lines
happens the current if-check (or suggested one) cannot detect it. So I feel that simply dropping
compound_head()check might be better?(quoted diff) +1
-1- if (PageCompound(p) && compound_head(p) != orig_head) { + if (PageCompound(p)) {
However this change could also catch the above race correctly. In fact, we can't handle compound page here. But is it enough to just return -EBUSY here as it's really rare or we should do more things (like split thp, retry if in PageHuge case)?
Quoted 3 lines
This should ensure the assumption (mentioned in 8/8 patch) more that the error page never belongs to compound page after taking page lock.
Agree, this really helps.
Quoted 4 lines
mm/memory-failure.c int memory_failure(unsigned long pfn, int flags) · line 1824
Quoted 1 line
mm/memory-failure.c +0
-0Thanks,Naoya Horiguchi
.
Many thanks.
Re: [PATCH 4/8] mm/memory-failure.c: remove unneeded orig_head
Quoted 58 lines · Miaohe Lin
Quoted 30 lines · Naoya Horiguchi
Quoted 29 lines · Miaohe Lin
orig_headis used to check whether the page have changed compound pages during the locking. But it's always equal to hpage. So we can use hpage directly and remove this redundant one.Signed-off-by Miaohe Lin <[email protected]>--- mm/memory-failure.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)mm/memory-failure.c +1
-2@@ -1691,7 +1691,6 @@ int memory_failure(unsigned long pfn, int flags) {struct page *p;struct page *hpage; -struct page *orig_head;struct dev_pagemap *pgmap;int res =0 ;unsigned long page_flags;@@ -1737,7 +1736,7 @@ int memory_failure(unsigned long pfn, int flags) goto unlock_mutex; } - orig_head = hpage =compound_head (p); + hpage =compound_head (p);num_poisoned_pages_inc ();Quoted 13 lines
mm/memory-failure.c int memory_failure(unsigned long pfn, int flags) · line 1823
Quoted 7 lines
mm/memory-failure.c +1
-1/* @@ -1821,7 +1820,7 @@ int memory_failure(unsigned long pfn, int flags)* The page could have changed compound pages during the locking. * If this happens just bail out. */ -if (PageCompound (p) &&compound_head (p) != orig_head) { +if (PageCompound (p) &&compound_head (p) != hpage) {I think that this if-check was intended to detect the case that page p belongs to a thp when
memory_failure()is called and belongs to a compound page in different size (like slab or some driver page) after the thp is split. But your suggestion makes me aware that the page p could be embedded on a thp again after thp split. I think this might be rare, but if itIIUC, this page can't be embedded on a thp again after thp split because
memory_failurehold an__extra__page refcnt. I think there exist below race windows:
memory_failure
orig_head= hpage =compound_head(p); -- page is Non-compound yet
< -- Page becomes compound page, like thp, slab, some driver page and even hugetlb page -- >get_hwpoison_page
failed to split thp page, as hpage is Non-compound ...
lock_pageQuoted 3 lines
happens the current if-check (or suggested one) cannot detect it. So I feel that simply dropping
compound_head()check might be better?
Quoted 6 lines
Review
Quoted 2 lines
(quoted diff) +1
-1- if (PageCompound(p) && compound_head(p) != orig_head) { + if (PageCompound(p)) {However this change could also catch the above race correctly. In fact, we can't handle compound page here. But is it enough to just return
-EBUSYhere as it's really rare or we should do more things (like split thp, retry if in PageHuge case)?
Hmm, both could make sense and hard to judge to me, so it's upto you. We already have goto label "try_again" so retrying might not be so surprising.
Thanks,
Naoya Horiguchi
Miaohe Lin
maintainerRe: [PATCH 4/8] mm/memory-failure.c: remove unneeded orig_head
Quoted 66 lines · HORIGUCHI NAOYA(堀口 直也)
Quoted 58 lines · Miaohe Lin
Quoted 30 lines · Naoya Horiguchi
Quoted 29 lines · Miaohe Lin
orig_headis used to check whether the page have changed compound pages during the locking. But it's always equal to hpage. So we can use hpage directly and remove this redundant one.Signed-off-by Miaohe Lin <[email protected]>--- mm/memory-failure.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)mm/memory-failure.c +1
-2@@ -1691,7 +1691,6 @@ int memory_failure(unsigned long pfn, int flags) {struct page *p;struct page *hpage; -struct page *orig_head;struct dev_pagemap *pgmap;int res =0 ;unsigned long page_flags;@@ -1737,7 +1736,7 @@ int memory_failure(unsigned long pfn, int flags) goto unlock_mutex; } - orig_head = hpage =compound_head (p); + hpage =compound_head (p);num_poisoned_pages_inc ();Quoted 13 lines
mm/memory-failure.c int memory_failure(unsigned long pfn, int flags) · line 1823
Quoted 7 lines
mm/memory-failure.c +1
-1/* @@ -1821,7 +1820,7 @@ int memory_failure(unsigned long pfn, int flags)* The page could have changed compound pages during the locking. * If this happens just bail out. */ -if (PageCompound (p) &&compound_head (p) != orig_head) { +if (PageCompound (p) &&compound_head (p) != hpage) {I think that this if-check was intended to detect the case that page p belongs to a thp when
memory_failure()is called and belongs to a compound page in different size (like slab or some driver page) after the thp is split. But your suggestion makes me aware that the page p could be embedded on a thp again after thp split. I think this might be rare, but if itIIUC, this page can't be embedded on a thp again after thp split because
memory_failurehold an__extra__page refcnt. I think there exist below race windows:
memory_failure
orig_head= hpage =compound_head(p); -- page is Non-compound yet
< -- Page becomes compound page, like thp, slab, some driver page and even hugetlb page -- >get_hwpoison_page
failed to split thp page, as hpage is Non-compound ...
lock_pageQuoted 3 lines
happens the current if-check (or suggested one) cannot detect it. So I feel that simply dropping
compound_head()check might be better?Quoted 6 lines
Review
Quoted 2 lines
(quoted diff) +1
-1- if (PageCompound(p) && compound_head(p) != orig_head) { + if (PageCompound(p)) {However this change could also catch the above race correctly. In fact, we can't handle compound page here. But is it enough to just return
-EBUSYhere as it's really rare or we should do more things (like split thp, retry if in PageHuge case)?
Quoted 3 lines
Hmm, both could make sense and hard to judge to me, so it's upto you. We already have goto label "
try_again" so retrying might not be so surprising.
try_again sounds a good idea. Will send a V2. Many thanks.
Quoted 3 lines
Thanks,
Naoya Horiguchi
Miaohe Lin
maintainerPATCH 5/8 mm/memory-failure.c: remove PageSlab check in hwpoison_filter_dev
In reply to Miaohe LinSince commit 03e5ac2fc3bf ("mm: fix crash when using XFS on loopback"), page_mapping() can handle the Slab pages. So remove this unnecessary PageSlab check and obsolete comment.
--- mm/memory-failure.c | 6 ------ 1 file changed, 6 deletions(-)
mm/memory-failure.c +0 -6
@@ -130,12 +130,6 @@ static int hwpoison_filter_dev(struct page *p) hwpoison_filter_dev_minor == ~0U)return 0 ; -/* -* page_mapping() does not accept slab pages. -*/ -if (PageSlab (p)) -return -EINVAL ; - mapping =page_mapping (p);if (mapping ==NULL || mapping->host ==NULL )return -EINVAL ;
Signature · 1 line
2.23.0
Re: [PATCH 5/8] mm/memory-failure.c: remove PageSlab check in hwpoison_filter_dev
Quoted 5 lines · Miaohe Lin
Since commit
03e5ac2fc3bf("mm: fix crash when using XFS on loopback"),page_mapping()can handle the Slab pages. So remove this unnecessary PageSlab check and obsolete comment.Signed-off-by Miaohe Lin <[email protected]>
Miaohe Lin
maintainerPATCH 6/8 mm/memory-failure.c: rework the try_to_unmap logic in hwpoison_user_mappings()
In reply to Miaohe LinOnly for hugetlb pages in shared mappings, try_to_unmap should take semaphore in write mode here. Rework the code to make it clear.
--- mm/memory-failure.c | 34 +++++++++++++++------------------- 1 file changed, 15 insertions(+), 19 deletions(-)
mm/memory-failure.c +15 -19
@@ -1405,26 +1405,22 @@ static bool hwpoison_user_mappings(struct page *p, unsigned long pfn,if (kill)collect_procs (hpage, &tokill, flags &MF_ACTION_REQUIRED ); -if (!PageHuge (hpage)) { -try_to_unmap (hpage, ttu); +if (PageHuge (hpage) && !PageAnon (hpage)) { +/* +* For hugetlb pages in shared mappings, try_to_unmap +* could potentially call huge_pmd_unshare. Because of +* this, take semaphore in write mode here and set +* TTU_RMAP_LOCKED to indicate we have taken the lock +* at this higher level. +*/ + mapping =hugetlb_page_mapping_lock_write (hpage); +if (mapping) { +try_to_unmap (hpage, ttu|TTU_RMAP_LOCKED ); +i_mmap_unlock_write (mapping); + }else +pr_info ("Memory failure: %#lx: could not lock mapping for mapped huge page\n" , pfn); }else { -if (!PageAnon (hpage)) { -/* -* For hugetlb pages in shared mappings, try_to_unmap -* could potentially call huge_pmd_unshare. Because of -* this, take semaphore in write mode here and set -* TTU_RMAP_LOCKED to indicate we have taken the lock -* at this higher level. -*/ - mapping =hugetlb_page_mapping_lock_write (hpage); -if (mapping) { -try_to_unmap (hpage, ttu|TTU_RMAP_LOCKED ); -i_mmap_unlock_write (mapping); - }else -pr_info ("Memory failure: %#lx: could not lock mapping for mapped huge page\n" , pfn); - }else { -try_to_unmap (hpage, ttu); - } +try_to_unmap (hpage, ttu); } unmap_success = !page_mapped (hpage);
Signature · 1 line
2.23.0
Re: [PATCH 6/8] mm/memory-failure.c: rework the try_to_unmap logic in hwpoison_user_mappings()
Quoted 4 lines · Miaohe Lin
Only for hugetlb pages in shared mappings,
try_to_unmapshould take semaphore in write mode here. Rework the code to make it clear.Signed-off-by Miaohe Lin <[email protected]>
Miaohe Lin
maintainerPATCH 7/8 mm/memory-failure.c: remove obsolete comment in __soft_offline_page
In reply to Miaohe LinSince commit add05cecef80 ("mm: soft-offline: don't free target page in successful page migration"), set_migratetype_isolate logic is removed. Remove this obsolete comment.
--- mm/memory-failure.c | 4 ---- 1 file changed, 4 deletions(-)
mm/memory-failure.c +0 -4
@@ -2161,10 +2161,6 @@ static int __soft_offline_page(struct page *page) ret =invalidate_inode_page (page);unlock_page (page); -/* -* RED-PEN would be better to keep it isolated here, but we -* would need to fix isolation locking first. -*/ if (ret) {pr_info ("soft_offline: %#lx: invalidated\n" , pfn);page_handle_poison (page, false, true);
Signature · 1 line
2.23.0
Miaohe Lin
maintainerPATCH 8/8 mm/memory-failure.c: remove unnecessary PageTransTail check
In reply to Miaohe LinWhen we reach here, we're guaranteed to have non-compound page as thp is already splited. Remove this unnecessary PageTransTail check.
--- mm/memory-failure.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
mm/memory-failure.c +1 -1
@@ -1838,7 +1838,7 @@ int memory_failure(unsigned long pfn, int flags)* page_lock. We need wait writeback completion for this page or it * may trigger vfs BUG while evict inode. */ -if (!PageTransTail (p) && !PageLRU (p) && !PageWriteback (p)) +if (!PageLRU (p) && !PageWriteback (p)) goto identify_page_state;/*
Signature · 1 line
2.23.0
Re: [PATCH 8/8] mm/memory-failure.c: remove unnecessary PageTransTail check
Quoted 4 lines · Miaohe Lin
When we reach here, we're guaranteed to have non-compound page as thp is already splited. Remove this unnecessary PageTransTail check.
Signed-off-by Miaohe Lin <[email protected]>