can, tty: elmcan CAN/ldisc driver for ELM327 based OBD-II adapters
PATCH v2 1/1 can, tty: elmcan CAN/ldisc driver for ELM327 based OBD-II adapters
This is the elmcan driver. It does a surprisingly good job at turning ELM327 based OBD-II interfaces into cheap CAN interfaces for simple homebrew projects.
Please see the included documentation for details and limitations:Documentation/networking/device_drivers/can/elmcan.rst
CC TTY maintainers for their opinion as this patch adds a new ldisc, taking the very last ldisc number available (29) without increasing NR_LDISCS (beyond the current 30).
---
Changes in v2:
- Moved to SocketCAN's rx-offload wrapper for NAPI, thus avoiding packets being reordered.
- Updated TTY ldisc code for Linux v5.17-rc3. A lot of cleanup has happened there lately.
- netif_stop_queue() is called earlier in _netdev_close().
- Minor cleanup: More helpful strings and return values.
My sincere apologies for not submitting these requested fixes earlier. If you could still review this, that'd be much appreciated. This code has lived out-of-tree for quite a while now, and yet has gathered a surprising amount of users in the meantime.
--- .../networking/device_drivers/can/elmcan.rst | 328 +++++ .../networking/device_drivers/can/index.rst | 1 + MAINTAINERS | 7 + drivers/net/can/Kconfig | 17 + drivers/net/can/Makefile | 1 + drivers/net/can/elmcan.c | 1299 +++++++++++++++++ include/uapi/linux/tty.h | 1 + 7 files changed, 1654 insertions(+) create mode 100644 Documentation/networking/device_drivers/can/elmcan.rst create mode 100644 drivers/net/can/elmcan.c
Documentation/networking/device_drivers/can/elmcan.rst new file +328 -0
@@ -0,0 +1,328 @@ +.. SPDX-License-Identifier: (GPL-2.0-only OR BSD-3-Clause) + +ELM327 driver for Linux SocketCAN +================================== + +Authors +-------- + +Max Staudt <[email protected]> + + + +Motivation +----------- + +This driver aims to lower the initial cost for hackers interested in +working with CAN buses. + +CAN adapters are expensive, few, and far between. +ELM327 interfaces are cheap and plentiful. +Let's use ELM327s as CAN adapters. + + + +Introduction +------------- + +This driver is an effort to turn abundant ELM327 based OBD interfaces +into full fledged (as far as possible) CAN interfaces. + +Since the ELM327 was never meant to be a stand alone CAN controller, +the driver has to switch between its modes as quickly as possible in +order to fake full-duplex operation. + +As such, elmcan is a best effort driver. However, this is more than +enough to implement simple request-response protocols (such as OBD II), +and to monitor broadcast messages on a bus (such as in a vehicle). + +Most ELM327s come as nondescript serial devices, attached via USB or +Bluetooth. The driver cannot recognize them by itself, and as such it +is up to the user to attach it in form of a TTY line discipline +(similar to PPP, SLIP, slcan, ...). + +This driver is meant for ELM327 versions 1.4b and up, see below for +known limitations in older controllers and clones. + + + +Data sheet +----------- + +The official data sheets can be found at ELM electronics' home page: + + https://www.elmelectronics.com/ + + + +How to check the controller version +------------------------------------ + +Use a terminal program to attach to the controller. +The default settings are 38400 baud/s, 8 data bits, no parity, 1 stopbit. + +After issuing the "``AT WS``" command, the controller will respond with +its version:: + + >AT WS + + + ELM327 v1.4b + + > + +Note that clones may claim to be any version they like. +It is not indicative of their actual feature set. + + + +How to attach the line discipline +---------------------------------- + +Every ELM327 chip is factory programmed to operate at a serial setting +of 38400 baud/s, 8 data bits, no parity, 1 stopbit. + +The line discipline can be attached on a command prompt as follows:: + + sudo ldattach \ + --debug \ + --speed 38400 \ + --eightbits \ + --noparity \ + --onestopbit \ + --iflag -ICRNL,INLCR,-IXOFF \ + 29 \ + /dev/ttyUSB0 + +To change the ELM327's serial settings, please refer to its data +sheet. This needs to be done before attaching the line discipline. + + + +Module parameters +------------------ + +- ``accept_flaky_uart`` - Try to live with a bad controller or UART line + + Some adapters and/or their connection are unreliable. Enable this + option to try and work around the situation. This is a best effort + workaround, so undefined behavior will likely occur sooner or later. + Without this option, the driver will bail on the first unrecognized + character it receives from the TTY. + + LOAD TIME:: + + module/kernel parameter: accept_flaky_uart=[0|1] + + + +Known limitations of the controller +------------------------------------ + +- Clone devices ("v1.5" and others) + + Sending RTR frames is not supported and will be dropped silently. + + Receiving RTR with DLC 8 will appear to be a regular frame with + the last received frame's DLC and payload. + + "``AT CSM``" not supported, thus no ACK-ing frames while listening: + "``AT MA``" will always be silent. However, immediately after + sending a frame, the ELM327 will be in "receive reply" mode, in + which it *does* ACK any received frames. Once the bus goes silent + or an error occurs (such as BUFFER FULL), the ELM327 will end reply + reception mode on its own and elmcan will fall back to "``AT MA``" + in order to keep monitoring the bus. + + +- All versions + + No full duplex operation is supported. The driver will switch + between input/output mode as quickly as possible. + + The length of outgoing RTR frames cannot be set. In fact, some + clones (tested with one identifying as "``v1.5``") are unable to + send RTR frames at all. + + We don't have a way to get real-time notifications on CAN errors. + While there is a command (``AT CS``) to retrieve some basic stats, + we don't poll it as it would force us to interrupt reception mode. + + +- Versions prior to 1.4b + + These versions do not send CAN ACKs when in monitoring mode (AT MA). + However, they do send ACKs while waiting for a reply immediately + after sending a frame. The driver maximizes this time to make the + controller as useful as possible. + + Starting with version 1.4b, the ELM327 supports the "``AT CSM``" + command, and the "listen-only" CAN option will take effect. + + +- Versions prior to 1.4 + + These chips do not support the "``AT PB``" command, and thus cannot + change bitrate or SFF/EFF mode on-the-fly. This will have to be + programmed by the user before attaching the line discipline. See the + data sheet for details. + + +- Versions prior to 1.3 + + These chips cannot be used at all with elmcan. They do not support + the "``AT D1``", which is necessary to avoid parsing conflicts on + incoming data, as well as distinction of RTR frame lengths. + + Specifically, this allows for easy distinction of SFF and EFF + frames, and to check whether frames are complete. While it is possible + to deduce the type and length from the length of the line the ELM327 + sends us, this method fails when the ELM327's UART output buffer + overruns. It may abort sending in the middle of the line, which will + then be mistaken for something else. + + + +Known limitations of the driver +-------------------------------- + +- No 8/7 timing. + + ELM327 can only set CAN bitrates that are of the form 500000/n, where + n is an integer divisor. + However there is an exception: With a separate flag, it may set the + speed to be 8/7 of the speed indicated by the divisor. + This mode is not currently implemented. + +- No evaluation of command responses. + + The ELM327 will reply with OK when a command is understood, and with ? + when it is not. The driver does not currently check this, and simply + assumes that the chip understands every command. + The driver is built such that functionality degrades gracefully + nevertheless. See the section on known limitations of the controller. + +- No use of hardware CAN ID filtering + + An ELM327's UART sending buffer will easily overflow on heavy CAN bus + load, resulting in the "``BUFFER FULL``" message. Using the hardware + filters available through "``AT CF xxx``" and "``AT CM xxx``" would be + helpful here, however SocketCAN does not currently provide a facility + to make use of such hardware features. + + + +Communication example +---------------------- + +This is a short and incomplete introduction on how to talk to an ELM327. + + +The ELM327 has two modes: + +- Command mode +- Reception mode + +In command mode, it expects one command per line, terminated by CR. +By default, the prompt is a "``>``", after which a command can be +entered:: + + >ATE1 + OK + > + +The init script in the driver switches off several configuration options +that are only meaningful in the original OBD scenario the chip is meant +for, and are actually a hindrance for elmcan. + + +When a command is not recognized, such as by an older version of the +ELM327, a question mark is printed as a response instead of OK:: + + >ATUNKNOWN + ? + > + +At present, elmcan does not evaluate this response and silently assumes +that all commands are recognized. It is structured such that it will +degrade gracefully when a command is unknown. See the sections above on +known limitations for details. + + +When a CAN frame is to be sent, the target address is configured, after +which the frame is sent as a command that consists of the data's hex +dump:: + + >ATSH123 + OK + >DEADBEEF12345678 + OK + > + +The above interaction sends the frame "``DE AD BE EF 12 34 56 78``" with +the 11 bit CAN ID ``0x123``. +For this to function, the controller must be configured for 11 bit CAN +ID sending mode (using "``AT PB``", see code or datasheet). + + +Once a frame has been sent and wait-for-reply mode is on (``ATR1``, +configured on ``listen-only=off``), or when the reply timeout expires and +the driver sets the controller into monitoring mode (``ATMA``), the ELM327 +will send one line for each received CAN frame, consisting of CAN ID, +DLC, and data:: + + 123 8 DEADBEEF12345678 + +For 29 bit CAN frames, the address format is slightly different, which +elmcan uses to tell the two apart:: + + 12 34 56 78 8 DEADBEEF12345678 + +The ELM327 will receive both 11 and 29 bit frames - the current CAN +config (``ATPB``) does not matter. + + +If the ELM327's internal UART sending buffer runs full, it will abort +the monitoring mode, print "BUFFER FULL" and drop back into command +mode. Note that in this case, unlike with other error messages, the +error message may appear on the same line as the last (usually +incomplete) data frame:: + + 12 34 56 78 8 DEADBEEF123 BUFFER FULL + + + +Rationale behind the chosen configuration +------------------------------------------ + +``AT E1`` + Echo on + + We need this to be able to get a prompt reliably. + +``AT S1`` + Spaces on + + We need this to distinguish 11/29 bit CAN addresses received. + + Note: + We can usually do this using the line length (odd/even), + but this fails if the line is not transmitted fully to + the host (BUFFER FULL). + +``AT D1`` + DLC on + + We need this to tell the "length" of RTR frames. + + + +A note on CAN bus termination +------------------------------ + +Your adapter may have resistors soldered in which are meant to terminate +the bus. This is correct when it is plugged into a OBD-II socket, but +not helpful when trying to tap into the middle of an existing CAN bus. + +If communications don't work with the adapter connected, check for the +termination resistors on its PCB and try removing them.
Documentation/networking/device_drivers/can/index.rst +1 -0
@@ -10,6 +10,7 @@ Contents: .. toctree:: :maxdepth: 2 + elmcan freescale/flexcan .. only:: subproject and html
MAINTAINERS +7 -0
@@ -7064,6 +7064,13 @@ L: [email protected] S: Maintained F: drivers/net/ethernet/ibm/ehea/ +ELM327 CAN NETWORK DRIVER +M: Max Staudt <[email protected]> +L: [email protected] +S: Maintained +F: Documentation/networking/device_drivers/can/elmcan.rst +F: drivers/net/can/elmcan.c + EM28XX VIDEO4LINUX DRIVER M: Mauro Carvalho Chehab <[email protected]> L: [email protected]
drivers/net/can/Kconfig +17 -0
@@ -180,6 +180,23 @@ source "drivers/net/can/softing/Kconfig" source "drivers/net/can/spi/Kconfig" source "drivers/net/can/usb/Kconfig" +config CAN_ELMCAN + tristate "Serial / USB serial ELM327 based OBD-II Interfaces (elmcan)" + depends on TTY + help + CAN driver for several 'low cost' OBD-II interfaces based on the + ELM327 OBD-II interpreter chip. + + This is a best effort driver - the ELM327 interface was never + designed to be used as a standalone CAN interface. However, it can + still be used for simple request-response protocols (such as OBD II), + and to monitor broadcast messages on a bus (such as in a vehicle). + + Please refer to the documentation for information on how to use it: + Documentation/networking/device_drivers/can/elmcan.rst + + If this driver is built as a module, it will be called elmcan. + endif config CAN_DEBUG_DEVICES
drivers/net/can/Makefile +1 -0
@@ -6,6 +6,7 @@ obj-$(CONFIG_CAN_VCAN) += vcan.o obj-$(CONFIG_CAN_VXCAN) += vxcan.o obj-$(CONFIG_CAN_SLCAN) += slcan.o +obj-$(CONFIG_CAN_ELMCAN) += elmcan.o obj-y += dev/ obj-y += rcar/
drivers/net/can/elmcan.c new file +1299 -0
1,299 lines not on this page · raw message
include/uapi/linux/tty.h +1 -0
@@ -39,5 +39,6 @@#define N_SPEAKUP 26/* Speakup communication with synths */ #define N_NULL 27/* Null ldisc used for error handling */ #define N_MCTP 28/* MCTP-over-serial */ +#define N_ELMCAN 29/* Serial / USB serial OBD-II Interfaces */ #endif /* _UAPI_LINUX_TTY_H */
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerQuoted 13 lines · Max Staudt
drivers/net/can/elmcan.c new file +10
-0@@ -0,0 +1,1299 @@ +// SPDX-License-Identifier: GPL-2.0 +/* elmcan.c - ELM327 based CAN interface driver +* (tty line discipline) +* +* This driver started as a derivative of linux/drivers/net/can/slcan.c +* and my thanks go to the original authors for their inspiration. +* +* elmcan.c Author : Max Staudt <[email protected]> +* slcan.c Author : Oliver Hartkopp <[email protected]> +* slip.c Authors : Laurence Culhane <[email protected]>
drivers/net/can/elmcan.c line 20
Quoted 10 lines
drivers/net/can/elmcan.c new file +10
-0+* Fred N. van Kempen <[email protected]> +* +* This code barely bears any resemblance to slcan anymore, and whatever +* may be left is Linux specific boilerplate anyway, however I am leaving +* the GPL-2.0 identifier at the top just to be sure. +* +* Please feel free to use my own code, especially the ELM327 communication +* logic, in accordance with SPDX-License-Identifier BSD-3-Clause to port +* this driver to other systems. +* - Max
That is too hard to unwind and determine by anyone. Please don't do stuff like that, it just gives lawyers nightmares :(
Quoted 36 lines
drivers/net/can/elmcan.c new file +36
-0+* +*/ + +#define pr_fmt (fmt) "[elmcan] " fmt + +#include <linux/init.h> +#include <linux/module.h> +#include <linux/moduleparam.h> + +#include <linux/atomic.h> +#include <linux/bitops.h> +#include <linux/ctype.h> +#include <linux/delay.h> +#include <linux/errno.h> +#include <linux/if_ether.h> +#include <linux/kernel.h> +#include <linux/list.h> +#include <linux/netdevice.h> +#include <linux/skbuff.h> +#include <linux/spinlock.h> +#include <linux/string.h> +#include <linux/tty.h> +#include <linux/tty_ldisc.h> +#include <linux/workqueue.h> + +#include <uapi/linux/tty.h> + +#include <linux/can.h> +#include <linux/can/dev.h> +#include <linux/can/error.h> +#include <linux/can/led.h> +#include <linux/can/rx-offload.h> + +MODULE_ALIAS_LDISC (N_ELMCAN ); +MODULE_DESCRIPTION ("ELM327 based CAN interface" ); +MODULE_LICENSE ("GPL" );
drivers/net/can/elmcan.c line 66
Quoted 10 lines
drivers/net/can/elmcan.c new file +10
-0+MODULE_AUTHOR ("Max Staudt <[email protected]>" ); + +/* If this is enabled, we'll try to make the best of the situation +* even if we receive unexpected characters on the line. +* No guarantees. +* Handle with care, it's likely your hardware is unreliable! +*/ +static bool accept_flaky_uart; +module_param_named (accept_flaky_uart, accept_flaky_uart, bool,0444 ); +MODULE_PARM_DESC (accept_flaky_uart,"Don't bail at the first invalid character. Behavior undefined." );
Module parameters are from the 1990's, please no. This is a per-code setting, when you want it to be a per-device setting, right? Please just drop this.
drivers/net/can/elmcan.c line 313
Quoted 7 lines
drivers/net/can/elmcan.c new file +7
-0+/*********************************************************************** +* ELM327: Reception -> netdev glue * +* * +* (assumes elm->lock taken) * +***********************************************************************/ + +static void elm327_feed_frame_to_netdev(struct elmcan *elm,
Please use normal kernel function comment formats. kernel-doc for global functions, simpler stuff for static functions.
drivers/net/can/elmcan.c line 380
Quoted 11 lines
drivers/net/can/elmcan.c new file +11
-0+static void elm327_parse_error (struct elmcan *elm,int len) +{ +struct can_frame frame; + +memset (&frame,0 ,sizeof (frame)); + frame.can_id =CAN_ERR_FLAG ; + frame.can_dlc =CAN_ERR_DLC ; + +switch (len) { +case 17 : +if (!memcmp (elm->rxbuf,"UNABLE TO CONNECT" ,17 )) {
hard-coded numbers here and everywhere. If you have these strings as a define or array somewhere, you can calculate the length automatically.
drivers/net/can/elmcan.c line 1119
Quoted 4 lines
drivers/net/can/elmcan.c new file +4
-0+/* Dummy needed to use bitrate_const */ +static int elmcan_do_set_bittiming (struct net_device *netdev) +{ + (void )netdev;
No need for this line.
Quoted 3 lines
drivers/net/can/elmcan.c new file +3
-0+ +return 0 ; +}
...
drivers/net/can/elmcan.c line 1281
Quoted 6 lines
drivers/net/can/elmcan.c new file +6
-0+static int __init elmcan_init (void ) +{ +int status; + +pr_info ("ELM327 based best effort CAN interface driver\n" ); +pr_info ("This device is severely limited as a CAN interface, see documentation.\n" );
When all works properly, kernel drivers are quiet. No need for these two lines at all.
Quoted 23 lines
drivers/net/can/elmcan.c new file +18
-0+ + status =tty_register_ldisc (&elmcan_ldisc); +if (status) +pr_err ("Can't register line discipline\n" ); + +return status; +} + +static void __exit elmcan_exit(void) +{ +/* This will only be called when all channels have been closed by +* userspace - tty_ldisc.c takes care of the module's refcount. +*/ +tty_unregister_ldisc (&elmcan_ldisc); +} + +module_init (elmcan_init); +module_exit (elmcan_exit);include/uapi/linux/tty.h +0
-0
include/uapi/linux/tty.h line 42
Quoted 4 lines
include/uapi/linux/tty.h +1
-0@@ -39,5 +39,6 @@#define N_SPEAKUP 26/* Speakup communication with synths */ #define N_NULL 27/* Null ldisc used for error handling */ #define N_MCTP 28/* MCTP-over-serial */ +#define N_ELMCAN 29/* Serial / USB serial OBD-II Interfaces */
We are now full, no more new ones to ever add! :)
This looks fine, we can always bump up the number if we want more.
thanks,
greg k-h
Thanks Greg for your quick feedback!
I'll include it and send a new version after waiting for more comments.
A few questions/suggestions below.
Quoted 14 lines · On Thu, 10 Feb 2022 18:41:14 +0100 Greg Kroah-Hartman…
Quoted 9 lines · Max Staudt
drivers/net/can/elmcan.c new file +7
-0+/* If this is enabled, we'll try to make the best of the situation +* even if we receive unexpected characters on the line. +* No guarantees. +* Handle with care, it's likely your hardware is unreliable! +*/ +static bool accept_flaky_uart; +module_param_named(accept_flaky_uart, accept_flaky_uart, bool,0444); +MODULE_PARM_DESC(accept_flaky_uart, "Don't bail at the first invalid character. Behavior undefined.");
Module parameters are from the 1990's, please no. This is a per-code setting, when you want it to be a per-device setting, right? Please just drop this.
Agreed.
Ideally, this option would be part of the ldattach moment. But that ABI for ldattach doesn't exist.
I'll hardcode the driver to be more lenient - i.e. accept_flaky_uart=1. Whoever relies on it for critical systems likely hasn't read the disclaimer anyway :)
How about inverting the option, thus having a debug_extra_strict module option for debugging purposes, so users can more easily see if their adapter is at fault?
Quoted 13 lines
Quoted 10 lines
include/uapi/linux/tty.h +0
-0@@ -39,5 +39,6 @@#define N_SPEAKUP 26/* Speakup communication with synths */ #define
N_NULL27 /* Null ldisc
used for error handling */ #defineN_MCTP28
/* MCTP-over-serial */ +#defineN_ELMCAN29 /* Serial
/ USB serial OBD-II Interfaces */We are now full, no more new ones to ever add! :)
Quoted 1 line
This looks fine, we can always bump up the number if we want more.
Phew! :)
May I suggest increasing NR_LDISCS right now, while we're at it?
Also, I could set N_ELMCAN to 30 and leave #29 free for out-of-tree uses. It was quite handy having an unused ldisc number while developing this driver, and I assume there are other users out there.
#29 is the highest number available for the last eons, so people are bound to have used it, and (unknowingly) expect it to work even after forward porting their out-of-tree modules to v5.17's ldisc API. Things could break in ugly unexpected ways for people who have been using #29 internally and have it hardcoded in scripts using ldattach.
Maybe
#define N_DEVELOPMENT 29
or something like that?
And then from this point onwards, NR_LDISCS needs only be incremented once a new ldisc is actually upstreamed.
Thanks,
Max
Greg Kroah-Hartman
maintainerQuoted 31 lines · Max Staudt
Thanks Greg for your quick feedback!
I'll include it and send a new version after waiting for more comments.
A few questions/suggestions below.
Quoted 14 lines · On Thu, 10 Feb 2022 18:41:14 +0100 Greg Kroah-Hartman…
Quoted 9 lines · Max Staudt
drivers/net/can/elmcan.c new file +7
-0+/* If this is enabled, we'll try to make the best of the situation +* even if we receive unexpected characters on the line. +* No guarantees. +* Handle with care, it's likely your hardware is unreliable! +*/ +static bool accept_flaky_uart; +module_param_named(accept_flaky_uart, accept_flaky_uart, bool,0444); +MODULE_PARM_DESC(accept_flaky_uart, "Don't bail at the first invalid character. Behavior undefined.");
Module parameters are from the 1990's, please no. This is a per-code setting, when you want it to be a per-device setting, right? Please just drop this.
Agreed.
Ideally, this option would be part of the ldattach moment. But that ABI for ldattach doesn't exist.
Quoted 8 lines
I'll hardcode the driver to be more lenient - i.e. accept_flaky_uart=1. Whoever relies on it for critical systems likely hasn't read the disclaimer anyway :)
How about inverting the option, thus having a
debug_extra_strictmodule option for debugging purposes, so users can more easily see if their adapter is at fault?
Will anyone really do that? And if so, what can they do about it? The kernel's job is to work around broken hardware, so we might as well just deal with it :(
Quoted 23 lines
Quoted 13 lines
Quoted 10 lines
include/uapi/linux/tty.h +0
-0@@ -39,5 +39,6 @@#define N_SPEAKUP 26/* Speakup communication with synths */ #define
N_NULL27 /* Null ldisc
used for error handling */ #defineN_MCTP28
/* MCTP-over-serial */ +#defineN_ELMCAN29 /* Serial
/ USB serial OBD-II Interfaces */We are now full, no more new ones to ever add! :)
Quoted 1 line
This looks fine, we can always bump up the number if we want more.
Phew! :)
May I suggest increasing
NR_LDISCSright now, while we're at it?Also, I could set
N_ELMCANto 30 and leave #29 free for out-of-tree uses. It was quite handy having an unused ldisc number while developing this driver, and I assume there are other users out there.
Quoted 5 lines
#29 is the highest number available for the last eons, so people are bound to have used it, and (unknowingly) expect it to work even after forward porting their out-of-tree modules to v5.17's ldisc API. Things could break in ugly unexpected ways for people who have been using #29 internally and have it hardcoded in scripts using ldattach.
We really can not do anything about out-of-tree code.
Quoted 6 lines
Maybe
#defineN_DEVELOPMENT29
or something like that?And then from this point onwards,
NR_LDISCSneeds only be incremented once a new ldisc is actually upstreamed.
That would work, want to send a patch right now for that?
thanks,
greg k-h
Quoted 6 lines · On Fri, 11 Feb 2022 10:01:42 +0100 Greg Kroah-Hartman…
Quoted 5 lines · Max Staudt
I'll hardcode the driver to be more lenient - i.e. accept_flaky_uart=1. Whoever relies on it for critical systems likely hasn't read the disclaimer anyway :)
Quoted 7 lines
Quoted 3 lines
How about inverting the option, thus having a
debug_extra_strictmodule option for debugging purposes, so users can more easily see if their adapter is at fault?Will anyone really do that? And if so, what can they do about it? The kernel's job is to work around broken hardware, so we might as well just deal with it :(
True, let's hardcode a behaviour.
I've thought about it a bit more and flipped the switch though :)
The rationale is as follows:
1) In my latest tests, my hardware behaved just fine, so I likely had an EMI problem in my setup when I wrote that option years ago.
2) The errors I was working around were random insertions and bitflips. Which can lead to incorrect rather than dropped data. The driver can report obvious errors, but there is no way to detect a bitflip in those places where it really hurts (i.e. the data packets). If the driver has reason to believe there is a problem, I'd rather it avoid forwarding possibly incorrect data to the user.
3) If the driver's users DO wish for a change, it's always easier to make the driver more lenient rather than more strict. The only thing it can do then is to restart the device anyway...
So, I'll kick the option out and keep the driver strict.
Quoted 8 lines
Quoted 6 lines
Maybe
#defineN_DEVELOPMENT29
or something like that?And then from this point onwards,
NR_LDISCSneeds only be incremented once a new ldisc is actually upstreamed.That would work, want to send a patch right now for that?
Just did:
Message-Id: <[email protected]>
Max