Skip to contentSkip to conversation

clk: qcom: ipq8074: Use floor ops for SDCC1 clock

PATCH Applied Robert Marko 4 participants 4 messages Feb 10, 2022 – Feb 24, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 clk: qcom: ipq8074: Use floor ops for SDCC1 clock

From: Dirk Buchwalder <[email protected]>

Use floor ops on SDCC1 APPS clock in order to round down selected clock frequency and avoid overclocking SD/eMMC cards.

For example, currently HS200 cards were failling tuning as they were actually being clocked at 384MHz instead of 192MHz.
This caused some boards to disable 1.8V I/O and force the eMMC into the standard HS mode (50MHz) and that appeared to work despite the eMMC being overclocked to 96Mhz in that case.

There was a previous commit to use floor ops on SDCC clocks, but it looks to have only covered SDCC2 clock.

Fixes 9607f6224b39 ("clk: qcom: ipq8074: add PCIE, USB and SDCC clocks")
---
 drivers/clk/qcom/gcc-ipq8074.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/qcom/gcc-ipq8074.c +1 -1
index 1e493f19fa44..c24e33321f72 100644
@@ -1074,7 +1074,7 @@ static struct clk_rcg2 sdcc1_apps_clk_src = {
 		.name = "sdcc1_apps_clk_src",
 		.parent_names = gcc_xo_gpll0_gpll2_gpll0_out_main_div2,
 		.num_parents = 4,
-		.ops = &clk_rcg2_ops,
+		.ops = &clk_rcg2_floor_ops,
 	},
 };
 
Signature · 1 line
2.35.1
maintainer Reviewed-by on v1 1/1
#1 lore raw

Quoting Robert Marko (2022-02-10 09:31:00)

Quoted 11 lines

From: Dirk Buchwalder <[email protected]>

Use floor ops on SDCC1 APPS clock in order to round down selected clock frequency and avoid overclocking SD/eMMC cards.

For example, currently HS200 cards were failling tuning as they were actually being clocked at 384MHz instead of 192MHz.
This caused some boards to disable 1.8V I/O and force the eMMC into the standard HS mode (50MHz) and that appeared to work despite the eMMC being overclocked to 96Mhz in that case.

Quoted 8 lines

There was a previous commit to use floor ops on SDCC clocks, but it looks to have only covered SDCC2 clock.

Fixes 9607f6224b39 ("clk: qcom: ipq8074: add PCIE, USB and SDCC clocks")

---

#2 lore raw
In reply to Robert Marko
This patch was applied to qcom/linux.git (for-next) by Bjorn Andersson <[email protected]>:

Hello:

This patch was applied to qcom/linux.git (for-next) by Bjorn Andersson <[email protected]>:

Quoted 5 lines · On Thu, 10 Feb 2022 18:31:00 +0100 you wrote:

From: Dirk Buchwalder <[email protected]>

Use floor ops on SDCC1 APPS clock in order to round down selected clock frequency and avoid overclocking SD/eMMC cards.

Quoted 7 lines

For example, currently HS200 cards were failling tuning as they were actually being clocked at 384MHz instead of 192MHz.
This caused some boards to disable 1.8V I/O and force the eMMC into the standard HS mode (50MHz) and that appeared to work despite the eMMC being overclocked to 96Mhz in that case.

[...]

Here is the summary with links:
- clk: qcom: ipq8074: Use floor ops for SDCC1 clock

    https://git.kernel.org/qcom/c/b77d8306d84f

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
#3 lore raw

Re: (subset) [PATCH] clk: qcom: ipq8074: Use floor ops for SDCC1 clock

In reply to Robert Marko
Quoted 5 lines · Robert Marko

From: Dirk Buchwalder <[email protected]>

Use floor ops on SDCC1 APPS clock in order to round down selected clock frequency and avoid overclocking SD/eMMC cards.

Quoted 7 lines

For example, currently HS200 cards were failling tuning as they were actually being clocked at 384MHz instead of 192MHz.
This caused some boards to disable 1.8V I/O and force the eMMC into the standard HS mode (50MHz) and that appeared to work despite the eMMC being overclocked to 96Mhz in that case.

[...]

Applied, thanks!

[1/1] clk: qcom: ipq8074: Use floor ops for SDCC1 clock

      commit: b77d8306d84f83d1da68028a68c91da9c867b6f6

Best regards,

Signature · 1 line
Bjorn Andersson <[email protected]>