Skip to contentSkip to conversation

atl1c: fix tx timeout after link flap on Mikrotik 10/25G NIC

PATCH Applied Gatis Peisenieks 2 participants 2 messages Feb 11, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 atl1c: fix tx timeout after link flap on Mikrotik 10/25G NIC

If NIC had packets in tx queue at the moment link down event happened, it could result in tx timeout when link got back up.

Since device has more than one tx queue we need to reset them accordingly.

Fixes 057f4af2b171 ("atl1c: add 4 RX/TX queue support for Mikrotik 10/25G NIC")
---
 drivers/net/ethernet/atheros/atl1c/atl1c_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/atheros/atl1c/atl1c_main.c +1 -1
index da595242bc13..f50604f3e541 100644
@@ -900,7 +900,7 @@ static void atl1c_clean_tx_ring(struct atl1c_adapter *adapter,
 		atl1c_clean_buffer(pdev, buffer_info);
 	}
 
-	netdev_reset_queue(adapter->netdev);
+	netdev_tx_reset_queue(netdev_get_tx_queue(adapter->netdev, queue));
 
 	/* Zero out Tx-buffers */
 	memset(tpd_ring->desc, 0, sizeof(struct atl1c_tpd_desc) *
Signature · 1 line
2.31.1
#1 lore raw
This patch was applied to netdev/net.git (master) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <[email protected]>:

Quoted 10 lines · On Fri, 11 Feb 2022 08:51:23 +0200 you wrote:

If NIC had packets in tx queue at the moment link down event happened, it could result in tx timeout when link got back up.

Since device has more than one tx queue we need to reset them accordingly.

Fixes 057f4af2b171 ("atl1c: add 4 RX/TX queue support for Mikrotik 10/25G NIC")

[...]

Here is the summary with links:
- [net] atl1c: fix tx timeout after link flap on Mikrotik 10/25G NIC

    https://git.kernel.org/netdev/net/c/bf8e59fd315f

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html