Skip to contentSkip to conversation

btrfs: qgroup: Remove an oudated comment

PATCH In review Sidong Yang 2 participants 3 messages Feb 10, 2022 – Feb 11, 2022 Btrfs file system

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 btrfs: qgroup: Remove an oudated comment

It seems that btrfs_qgroup_inherit() works on subvolume creation and it copies limits when BTRFS_QGROUP_INHERIT_SET_LIMITS flags on.

---
 fs/btrfs/qgroup.c | 1 -
 1 file changed, 1 deletion(-)
fs/btrfs/qgroup.c +0 -1
index 8928275823a1..bfd45d52b1f5 100644
@@ -30,7 +30,6 @@
  *  - reorganize keys
  *  - compressed
  *  - sync
- *  - copy also limits on subvol creation
  *  - limit
  *  - caches for ulists
  *  - performance benchmarks
Signature · 1 line
2.25.1
#1 lore raw
Quoted 2 lines · Sidong Yang

It seems that btrfs_qgroup_inherit() works on subvolume creation and it copies limits when BTRFS_QGROUP_INHERIT_SET_LIMITS flags on.

I think we can delete the whole TODO comment from 2012.

#2 lore raw
Quoted 5 lines · David Sterba
Quoted 2 lines · Sidong Yang

It seems that btrfs_qgroup_inherit() works on subvolume creation and it copies limits when BTRFS_QGROUP_INHERIT_SET_LIMITS flags on.

I think we can delete the whole TODO comment from 2012.

Agree. It's written very long ago. I'll write another patch to delete it.