tests: i915_pm_rpm : Dump i915_runtime_pm_status
PATCH 1/1 tests: i915_pm_rpm : Dump i915_runtime_pm_status
Dump i915_runtime_pm_status conditionally whenever runtime pm status got active and it was expected to be suspended.
--- tests/i915/i915_pm_rpm.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-)
tests/i915/i915_pm_rpm.c +10 -3
@@ -201,10 +201,17 @@ static bool wait_for_pc8_status(enum pc8_status status)static bool wait_for_suspended (void ) { -if (has_pc8 && !has_runtime_pm) +bool suspended = false; + +if (has_pc8 && !has_runtime_pm) {return wait_for_pc8_status (PC8_ENABLED ); -else -return igt_wait_for_pm_status (IGT_RUNTIME_PM_STATUS_SUSPENDED ); + }else { + suspended =igt_wait_for_pm_status (IGT_RUNTIME_PM_STATUS_SUSPENDED ); +if (!suspended) +igt_debugfs_dump (drm_fd,"i915_runtime_pm_status" ); + +return suspended; + } }static bool wait_for_active (void )
Signature · 1 line
2.26.2
Patchwork
CI[igt-dev] ✗ Fi.CI.BAT: failure for tests: i915_pm_rpm : Dump i915_runtime_pm_status
== Series Details ==
== Series Details ==
Series: tests: i915_pm_rpm : Dump i915_runtime_pm_status
URL : https://patchwork.freedesktop.org/series/100038/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11219 -> IGTPW_6614
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_6614 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in IGTPW_6614, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6614/index.html
Participating hosts (48 -> 43)
------------------------------
Additional (1): fi-pnv-d510
Missing (6): shard-tglu fi-bsw-cyan bat-adlp-4 shard-rkl shard-dg1 bat-jsl-2
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_6614:
### IGT changes ###
#### Possible regressions ####
* igt@gem_exec_suspend@basic-s0@smem:
- fi-kbl-soraka: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11219/fi-kbl-soraka/igt@gem_exec_suspend@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6614/fi-kbl-soraka/igt@gem_exec_suspend@[email protected]
Known issues
------------
Here are the changes found in IGTPW_6614 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@semaphore:
- fi-hsw-4770: NOTRUN -> [SKIP][3] ([fdo#109271] / [fdo#109315]) +17 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6614/fi-hsw-4770/igt@amdgpu/[email protected]
* igt@gem_huc_copy@huc-copy:
- fi-skl-6600u: NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#2190])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6614/fi-skl-6600u/igt@[email protected]
- fi-pnv-d510: NOTRUN -> [SKIP][5] ([fdo#109271]) +57 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6614/fi-pnv-d510/igt@[email protected]
* igt@gem_lmem_swapping@verify-random:
- fi-skl-6600u: NOTRUN -> [SKIP][6] ([fdo#109271] / [i915#4613]) +3 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6614/fi-skl-6600u/igt@[email protected]
* igt@kms_chamelium@vga-edid-read:
- fi-skl-6600u: NOTRUN -> [SKIP][7] ([fdo#109271] / [fdo#111827]) +8 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6614/fi-skl-6600u/igt@[email protected]
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- fi-skl-6600u: NOTRUN -> [SKIP][8] ([fdo#109271]) +2 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6614/fi-skl-6600u/igt@[email protected]
* igt@kms_frontbuffer_tracking@basic:
- fi-cml-u2: [PASS][9] -> [DMESG-WARN][10] ([i915#4269])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11219/fi-cml-u2/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6614/fi-cml-u2/igt@[email protected]
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-skl-6600u: NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#533])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6614/fi-skl-6600u/igt@[email protected]
* igt@kms_psr@primary_page_flip:
- fi-skl-6600u: NOTRUN -> [FAIL][12] ([i915#4547])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6614/fi-skl-6600u/igt@kms_psr@primary_page_flip.html
* igt@runner@aborted:
- fi-skl-6600u: NOTRUN -> [FAIL][13] ([i915#4312])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6614/fi-skl-6600u/igt@[email protected]
#### Possible fixes ####
* igt@gem_flink_basic@bad-flink:
- fi-skl-6600u: [INCOMPLETE][14] ([i915#4547]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11219/fi-skl-6600u/igt@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6614/fi-skl-6600u/igt@[email protected]
* igt@i915_selftest@live@hangcheck:
- fi-hsw-4770: [INCOMPLETE][16] ([i915#4785]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11219/fi-hsw-4770/igt@i915_selftest@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6614/fi-hsw-4770/igt@i915_selftest@[email protected]
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#4269]: https://gitlab.freedesktop.org/drm/intel/issues/4269
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4547]: https://gitlab.freedesktop.org/drm/intel/issues/4547
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_6342 -> IGTPW_6614
CI-20190529: 20190529
CI_DRM_11219: 1129051ad132beede618ec95745886d59c14e266 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_6614: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6614/index.html
IGT_6342: 1bd167a3af9e8f6168ac89c64c64b929694d9be7 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6614/index.html
Quoted 14 lines · Anshuman Gupta
Dump
i915_runtime_pm_statusconditionally whenever runtime pm status got active and it was expected to be suspended.Signed-off-by Anshuman Gupta <[email protected]>--- tests/i915/i915_pm_rpm.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-)tests/i915/i915_pm_rpm.c +0
-0
tests/i915/i915_pm_rpm.c static bool wait_for_pc8_status(enum pc8_status status) · line 204
Quoted 5 lines
tests/i915/i915_pm_rpm.c +1
-1@@ -201,10 +201,17 @@ static bool wait_for_pc8_status(enum pc8_status status)static bool wait_for_suspended (void ) { -if (has_pc8 && !has_runtime_pm) +bool suspended = false;
Nit but maybe let's move this into the else, I'll move and merge it:
Quoted 18 lines
tests/i915/i915_pm_rpm.c +9
-3+ +if (has_pc8 && !has_runtime_pm) {return wait_for_pc8_status (PC8_ENABLED ); - else - return igt_wait_for_pm_status(IGT_RUNTIME_PM_STATUS_SUSPENDED); + }else { + suspended =igt_wait_for_pm_status (IGT_RUNTIME_PM_STATUS_SUSPENDED ); +if (!suspended) +igt_debugfs_dump (drm_fd,"i915_runtime_pm_status" ); + +return suspended; + } }static bool wait_for_active (void ) --2.26.2
Quoted 26 lines
-----Original Message-----
From: Dixit, Ashutosh <[email protected]>
Sent: Saturday, February 12, 2022 6:54 AM
To: Gupta, Anshuman <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH i-g-t] tests:i915_pm_rpm: Dumpi915_runtime_pm_statusQuoted 16 lines · Anshuman Gupta
Dump
i915_runtime_pm_statusconditionally whenever runtime pm status got active and it was expected to be suspended.Signed-off-by Anshuman Gupta <[email protected]>--- tests/i915/i915_pm_rpm.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-)tests/i915/i915_pm_rpm.c index renamed from tests/i915/i915_pm_rpm.c +0
-0
648b0cffb..d1ba69af4100644tests/i915/i915_pm_rpm.c +0
-0@@ -201,10 +201,17 @@ static bool wait_for_pc8_status(enum pc8_status status)
Quoted 8 lines
tests/i915/i915_pm_rpm.c static bool wait_for_pc8_status(enum pc8_status status) · line 204
Quoted 4 lines
tests/i915/i915_pm_rpm.c +1
-1static bool wait_for_suspended (void ) { -if (has_pc8 && !has_runtime_pm) +bool suspended = false;Nit but maybe let's move this into the else, I'll move and merge it:
Reviewed-by Ashutosh Dixit <[email protected]>
Thanks Ashutosh for merging , do I need to backport it to IGT. I see this patch is also part of internal IGT tree. Thanks,
Anshuman Gupta.
Quoted 22 lines
tests/i915/i915_pm_rpm.c static bool wait_for_pc8_status(enum pc8_status status)
Quoted 6 lines
tests/i915/i915_pm_rpm.c +2
-2+ +if (has_pc8 && !has_runtime_pm) {return wait_for_pc8_status (PC8_ENABLED ); - else - return
igt_wait_for_pm_status(IGT_RUNTIME_PM_STATUS_SUSPENDED);tests/i915/i915_pm_rpm.c static bool wait_for_pc8_status(enum pc8_status · line 210
Quoted 2 lines
tests/i915/i915_pm_rpm.c +2
-0+ }else { + suspended =
igt_wait_for_pm_status(IGT_RUNTIME_PM_STATUS_SUSPENDED);tests/i915/i915_pm_rpm.c static bool wait_for_pc8_status(enum pc8_status · line 212
Quoted 2 lines
tests/i915/i915_pm_rpm.c +2
-0+if (!suspended) + igt_debugfs_dump(drm_fd,"
i915_runtime_pm_status");Quoted 9 lines
tests/i915/i915_pm_rpm.c +3
-0+ +return suspended; + } }static bool
wait_for_active(void)
--
2.26.2