m68k: ERROR: "usb_hid_driver" [drivers/hid/wacom.ko] undefined
Jason Self
Tested-by Benjamin TissoiresSince version 4.9.293 I have been getting this USB error when building the kernel. m68k is too old to have USB.
cp vmlinux vmlinux.tmp
m68k-linux-strip vmlinux.tmp
Building modules, stage 2.
gzip -9c vmlinux.tmp >vmlinux.gz
MODPOST 894 modules
rm vmlinux.tmp
ERROR: "usb_hid_driver" [drivers/hid/wacom.ko] undefined! scripts/Makefile.modpost:91: recipe for target '__modpost' failed make[1]: *** [__modpost] Error 1
Makefile:1251: recipe for target 'modules' failed
make: *** [modules] Error 2
Version 4.9.292 works. Running git bisect tells me:
1309eb2ef1001c4cc7e07b867ad9576d2cfeab47 is the first bad commit commit 1309eb2ef1001c4cc7e07b867ad9576d2cfeab47
Author: Greg Kroah-Hartman <[email protected]> Date: Wed Dec 1 19:35:02 2021 +0100
HID: wacom: fix problems when device is not a valid USB device
commit 720ac467204a70308bd687927ed475afb904e11b upstream.
The wacom driver accepts devices of more than just USB types, but some code paths can cause problems if the device being controlled is not a USB device due to a lack of checking. Add the needed checks to ensure that the USB device accesses are only happening on a "real" USB device, and not one on some other bus.
Link:
https://lore.kernel.org/r/[email protected]
drivers/hid/wacom_sys.c | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-)
Quoted 2 lines · Jason Self
Since version 4.9.293 I have been getting this USB error when building the kernel. m68k is too old to have USB.
Just so I understand correctly: m68k is too old for USB, so is it really necessary to have these USB patches on m68k then if this is the outcome?
Quoted 10 lines
Version 4.9.292 works. Running git bisect tells me:
1309eb2ef1001c4cc7e07b867ad9576d2cfeab47is the first bad commit commit1309eb2ef1001c4cc7e07b867ad9576d2cfeab47Author: Greg Kroah-Hartman <[email protected]> Date: Wed Dec 1 19:35:02 2021 +0100HID: wacom: fix problems when device is not a valid USB device
commit
720ac467204a70308bd687927ed475afb904e11bupstream.
(If I'm understanding this incorrectly, let me know. I've only had a small number of run-ins with m68k issues in the past.)
Thanks,
Slade
Greg KH
maintainerQuoted 39 lines · Jason Self
Since version 4.9.293 I have been getting this USB error when building the kernel. m68k is too old to have USB.
cp vmlinux vmlinux.tmp
m68k-linux-strip vmlinux.tmp
Building modules, stage 2.
gzip -9c vmlinux.tmp >vmlinux.gz
MODPOST 894 modules
rm vmlinux.tmp
ERROR: "usb_hid_driver" [drivers/hid/wacom.ko] undefined!scripts/Makefile.modpost:91: recipe for target '__modpost' failed make[1]: *** [__modpost] Error 1
Makefile:1251: recipe for target 'modules' failed
make: *** [modules] Error 2Version 4.9.292 works. Running git bisect tells me:
1309eb2ef1001c4cc7e07b867ad9576d2cfeab47is the first bad commit commit1309eb2ef1001c4cc7e07b867ad9576d2cfeab47Author: Greg Kroah-Hartman <[email protected]> Date: Wed Dec 1 19:35:02 2021 +0100HID: wacom: fix problems when device is not a valid USB device
commit
720ac467204a70308bd687927ed475afb904e11bupstream.The wacom driver accepts devices of more than just USB types, but some code paths can cause problems if the device being controlled is not a USB device due to a lack of checking. Add the needed checks to ensure that the USB device accesses are only happening on a "real" USB device, and not one on some other bus.
Cc Jiri Kosina <[email protected]>Cc Benjamin Tissoires <[email protected]>Tested-by Benjamin Tissoires <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>Signed-off-by Benjamin Tissoires <[email protected]>
Quoted 6 lines
Link:
https://lore.kernel.org/r/[email protected]Signed-off-by Greg Kroah-Hartman <[email protected]>drivers/hid/wacom_sys.c | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-)
Ah, looks like I need to backport 9d14201c7444 ("HID: wacom: add USB_HID dependency") to the 4.9 tree. I'll go do that now.
thanks,
greg k-h