drm/amdgpu: check return status before using stable_pstate
Subsystems (2)
PATCH 1/1 drm/amdgpu: check return status before using stable_pstate
From: Tom Rix <[email protected]>
Clang static analysis reports this problem amdgpu_ctx.c:616:26: warning: Assigned value is garbage
or undefined
args->out.pstate.flags = stable_pstate;
^ ~~~~~~~~~~~~~amdgpu_ctx_stable_pstate can fail without settingstable_pstate. So check.
Fixes 8cda7a4f96e4 ("drm/amdgpu/UAPI: add new CTX OP to get/set stable pstates")
Signed-off-by Tom Rix <[email protected]>
--- drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c +2 -1
@@ -613,7 +613,8 @@ int amdgpu_ctx_ioctl(struct drm_device *dev, void *data,if (args->in.flags)return -EINVAL ; r =amdgpu_ctx_stable_pstate (adev, fpriv, id, false, &stable_pstate); - args->out.pstate.flags = stable_pstate; +if (!r) + args->out.pstate.flags = stable_pstate;break ;case AMDGPU_CTX_OP_SET_STABLE_PSTATE :if (args->in.flags & ~AMDGPU_CTX_STABLE_PSTATE_FLAGS_MASK )
Signature · 1 line
2.26.3
Alex Deucher
AppliedApplied. Thanks!
Alex
Quoted 34 lines · On Mon, Feb 14, 2022 at 1:22 PM <[email protected]> wrote:
From: Tom Rix <[email protected]>
Clang static analysis reports this problem amdgpu_ctx.c:616:26: warning: Assigned value is garbage
or undefinedargs->out.pstate.flags = stable_pstate; ^ ~~~~~~~~~~~~~
amdgpu_ctx_stable_pstatecan fail without settingstable_pstate. So check.Fixes 8cda7a4f96e4 ("drm/amdgpu/UAPI: add new CTX OP to get/set stable pstates")Signed-off-by Tom Rix <[email protected]>--- drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c +2
-2@@ -613,7 +613,8 @@ int amdgpu_ctx_ioctl(struct drm_device *dev, void *data,if (args->in.flags)return -EINVAL ; r =amdgpu_ctx_stable_pstate (adev, fpriv, id, false, &stable_pstate); - args->out.pstate.flags = stable_pstate; +if (!r) + args->out.pstate.flags = stable_pstate;break ;case AMDGPU_CTX_OP_SET_STABLE_PSTATE :if (args->in.flags & ~AMDGPU_CTX_STABLE_PSTATE_FLAGS_MASK ) --2.26.3