Skip to contentSkip to conversation

ASoC: tegra20: spdif: make const array rates static

PATCH In review Colin Ian King 2 participants 2 messages Feb 14, 2022 – Feb 15, 2022

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: tegra20: spdif: make const array rates static

Don't populate the read-only const array rates on the stack but instead it static. Also makes the object code a little smaller.

---
 sound/soc/tegra/tegra20_spdif.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/tegra/tegra20_spdif.c +1 -1
index d09cd7ee6879..64c2f304f254 100644
@@ -186,7 +186,7 @@ static int tegra20_spdif_filter_rates(struct snd_pcm_hw_params *params,
 	struct snd_soc_dai *dai = rule->private;
 	struct tegra20_spdif *spdif = dev_get_drvdata(dai->dev);
 	struct clk *parent = clk_get_parent(spdif->clk_spdif_out);
-	const unsigned int rates[] = { 32000, 44100, 48000 };
+	static const unsigned int rates[] = { 32000, 44100, 48000 };
 	long i, parent_rate, valid_rates = 0;
 
 	parent_rate = clk_get_rate(parent);
Signature · 1 line
2.34.1
maintainer
#1 lore raw
Quoted 4 lines · Colin Ian King

Don't populate the read-only const array rates on the stack but instead it static. Also makes the object code a little smaller.

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: tegra20: spdif: make const array rates static

      commit: 83a1bed1f49869ea0fc7de321d5dcc598d0dfb15

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark