vhost: use colon in version.map

PATCH Applied Peng Yu 3 participants 3 messages Feb 15, 2022 – Mar 4, 2022

Share & tools

Peng Yu

author

2022-02-15 05:56 UTC #0 lore raw

PATCH 1/1 vhost: use colon in version.map

The punctuation after the global keyword should be colon, not semicolon. The default gcc linker accepts both colon and semicolon, but the gold linker will report syntax error if we use semicolon after the global keyword.

Signed-off-by Peng Yu <[email protected]>

---
 lib/vhost/version.map | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

lib/vhost/version.map +1 -1

index 1202ba9c1a..0a66c5840c 100644
@@ -90,7 +90,7 @@ EXPERIMENTAL {
 };
 
 INTERNAL {
-	global;
+	global:
 
 	rte_vdpa_register_device;
 	rte_vdpa_relay_vring_used;

Signature · 1 line

2.16.6

Xia, Chenbo

Reviewed-by on v1 1/1

2022-03-03 11:32 UTC #1 lore raw

Quoted 32 lines

-----Original Message-----
From: Peng Yu <[email protected]>
Sent: Tuesday, February 15, 2022 1:56 PM
To: [email protected]
Cc: Peng Yu <[email protected]>; Ray Kinsella <[email protected]>; Maxime Coquelin <[email protected]>; Xia, Chenbo <[email protected]>
Subject: [PATCH] vhost: use colon in version.map
The punctuation after the global keyword should be colon, not semicolon. The default gcc linker accepts both colon and semicolon, but the gold linker will report syntax error if we use semicolon after the global keyword.
Signed-off-by Peng Yu <[email protected]>
---
 lib/vhost/version.map | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/vhost/version.map +1 -2
index 1202ba9c1a..0a66c5840c 100644
@@ -90,7 +90,7 @@ EXPERIMENTAL {
 };
 
 INTERNAL {
-	global;
+	global:
 
 	rte_vdpa_register_device;
 	rte_vdpa_relay_vring_used;
--

Quoted 1 line

2.16.6

Reviewed-by Chenbo Xia <[email protected]>

Ferruh Yigit

Applied

2022-03-04 13:57 UTC #2 lore raw

Quoted 8 lines · Chenbo

Quoted 8 lines
-----Original Message-----
From: Peng Yu <[email protected]>
Sent: Tuesday, February 15, 2022 1:56 PM
To: [email protected]
Cc: Peng Yu <[email protected]>; Ray Kinsella <[email protected]>; Maxime Coquelin <[email protected]>; Xia, Chenbo <[email protected]>
Subject: [PATCH] vhost: use colon in version.map

Quoted 8 lines

Quoted 6 lines
The punctuation after the global keyword should be colon, not semicolon. The default gcc linker accepts both colon and semicolon, but the gold linker will report syntax error if we use semicolon after the global keyword.
Signed-off-by Peng Yu <[email protected]>
Reviewed-by Chenbo Xia <[email protected]>

Applied to dpdk-next-net/main, thanks.