Skip to contentSkip to conversation

net/mlx5: fix error infomation missing

PATCH In review Suanming Mou 2 participants 2 messages Feb 15, 2022 – Feb 22, 2022 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/mlx5: fix error infomation missing

While mlx5_hlist_create() failed, the rte_flow_error was not filled with the corresponding error information.

This commit adds the missing rte_flow_error_set() for the failure case.

Fixes f3020a331dca ("net/mlx5: optimize hash list table allocate on demand")
---
 drivers/net/mlx5/mlx5_flow_dv.c | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)
drivers/net/mlx5/mlx5_flow_dv.c +11 -5
index ef9c66eddf..05456ff196 100644
@@ -312,7 +312,8 @@ flow_dv_hlist_prepare(struct mlx5_dev_ctx_shared *sh, struct mlx5_hlist **phl,
 		     mlx5_list_match_cb cb_match,
 		     mlx5_list_remove_cb cb_remove,
 		     mlx5_list_clone_cb cb_clone,
-		     mlx5_list_clone_free_cb cb_clone_free)
+		     mlx5_list_clone_free_cb cb_clone_free,
+		     struct rte_flow_error *error)
 {
 	struct mlx5_hlist *hl;
 	struct mlx5_hlist *expected = NULL;
@@ -327,7 +328,9 @@ flow_dv_hlist_prepare(struct mlx5_dev_ctx_shared *sh, struct mlx5_hlist **phl,
 			cb_clone_free);
 	if (!hl) {
 		DRV_LOG(ERR, "%s hash creation failed", name);
-		rte_errno = ENOMEM;
+		rte_flow_error_set(error, ENOMEM,
+				   RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL,
+				   "cannot allocate resource memory");
 		return NULL;
 	}
 	if (!__atomic_compare_exchange_n(phl, &expected, hl, false,
@@ -3725,7 +3728,8 @@ flow_dv_encap_decap_resource_register
 				flow_dv_encap_decap_match_cb,
 				flow_dv_encap_decap_remove_cb,
 				flow_dv_encap_decap_clone_cb,
-				flow_dv_encap_decap_clone_free_cb);
+				flow_dv_encap_decap_clone_free_cb,
+				error);
 	if (unlikely(!encaps_decaps))
 		return -rte_errno;
 	resource->flags = dev_flow->dv.group ? 0 : 1;
@@ -5821,7 +5825,8 @@ flow_dv_modify_hdr_resource_register
 				flow_dv_modify_match_cb,
 				flow_dv_modify_remove_cb,
 				flow_dv_modify_clone_cb,
-				flow_dv_modify_clone_free_cb);
+				flow_dv_modify_clone_free_cb,
+				error);
 	if (unlikely(!modify_cmds))
 		return -rte_errno;
 	resource->root = !dev_flow->dv.group;
@@ -10758,7 +10763,8 @@ flow_dv_tag_resource_register
 				      flow_dv_tag_match_cb,
 				      flow_dv_tag_remove_cb,
 				      flow_dv_tag_clone_cb,
-				      flow_dv_tag_clone_free_cb);
+				      flow_dv_tag_clone_free_cb,
+				      error);
 	if (unlikely(!tag_table))
 		return -rte_errno;
 	entry = mlx5_hlist_register(tag_table, tag_be24, &ctx);
Signature · 1 line
2.25.1
#1 lore raw

Hi,

Quoted 9 lines

-----Original Message-----
From: Suanming Mou <[email protected]>
Sent: Tuesday, February 15, 2022 12:11 PM
To: Slava Ovsiienko <[email protected]>; Matan Azrad <[email protected]>
Cc: Raslan Darawsheh <[email protected]>; [email protected]; [email protected]
Subject: [PATCH] net/mlx5: fix error infomation missing

Fixed typo in the title:
infomation => information

Quoted 10 lines

While mlx5_hlist_create() failed, the rte_flow_error was not filled with the corresponding error information.

This commit adds the missing rte_flow_error_set() for the failure case.

Fixes f3020a331dca ("net/mlx5: optimize hash list table allocate on demand")

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh