Skip to contentSkip to conversation

ram: aspeed: Rework kconfig options

PATCH In review Joel Stanley 3 participants 3 messages Feb 16, 2022 – Mar 14, 2022 Arm/Aspeed machine support

lore
Share & tools
lore

Joel Stanley

author maintainer
#0 lore raw

PATCH 1/1 ram: aspeed: Rework kconfig options

Ensure the ASPEED related options are grouped together under the RAM option when enabling support.

This also makes some minor grammar corrections and renames options so they present cleanly in menuconfig.

There should be no functional change to the configuration or binary.

---
 drivers/ram/aspeed/Kconfig | 91 +++++++++++++++++++++-----------------
 1 file changed, 51 insertions(+), 40 deletions(-)
drivers/ram/aspeed/Kconfig +51 -40
index 576d5af8688e..0deab8649b64 100644
@@ -1,66 +1,77 @@
-if RAM || SPL_RAM
+menuconfig ASPEED_RAM
+	bool "ASPEED SDRAM configuration"
+	depends on RAM && ARCH_ASPEED
+	default ARCH_ASPEED
+	help
+	 Configuration options for DDR SDRAM on ASPEED systems.
+
+	 RAM initialisation is always built in for the platform. This menu
+	 allows customisation of the configuration used.
+
+if ASPEED_RAM
 
 config ASPEED_DDR4_DUALX8
 	bool "Enable Dual X8 DDR4 die"
-	depends on DM && OF_CONTROL && ARCH_ASPEED
+	depends on ASPEED_RAM
+	help
+	 Say Y if dual X8 DDR4 die is used on the board. The ASPEED DDRM
+	 SRAM controller needs to know if the memory chip mounted on the
+	 board is dual x8 die or not, otherwise it may get the wrong
+	 size of the memory space.
+
+config ASPEED_BYPASS_SELFTEST
+	depends on ASPEED_RAM
+	depends on ASPEED_AST2600
+	bool "Bypass self test during initialization"
+	help
+	  Say Y here to bypass DRAM self test to speed up the boot time.
+
+config ASPEED_ECC
+	bool "ASPEED SDRAM ECC"
+	depends on ASPEED_RAM
+	depends on ASPEED_AST2600
 	help
-		Say Y if dual X8 DDR4 die is used on the board.  The aspeed ddr sdram
-		controller needs to know if the memory chip mounted on the board is dual
-		 x8 die or not.  Or it may get the wrong size of the memory space.
+	  Enable SDRAM ECC function. This configures the SDRAM controller to
+	  perform error detection and correction, sacrificing 1/9th of the
+	  installed RAM to do so.
 
-if ASPEED_AST2600
+
+config ASPEED_ECC_SIZE
+	int "ECC size: 0=driver auto-caluated"
+	depends on ASPEED_ECC
+	default 0
+	help
+	  SDRAM size with the error correcting code enabled. The unit is
+	  in Megabytes.  Noted that only the 8/9 of the configured size
+	  can be used by the system.  The remaining 1/9 will be used by
+	  the ECC engine.  If the size is set to 0, the sdram driver will
+	  calculate the SDRAM size and set the whole range be ECC enabled.
 
 choice
-	prompt "DDR4 target date rate"
+	prompt "AST2600 DDR4 target date rate"
 	default ASPEED_DDR4_1600
+	depends on ASPEED_RAM
+	depends on ASPEED_AST2600
 
 config ASPEED_DDR4_400
-	bool "DDR4 targets at 400Mbps"
-	depends on DM && OF_CONTROL && ARCH_ASPEED
+	bool "400Mbps"
 	help
 	  select DDR4 target data rate at 400M
 
 config ASPEED_DDR4_800
-	bool "DDR4 targets at 800Mbps"
-	depends on DM && OF_CONTROL && ARCH_ASPEED
+	bool "800Mbps"
 	help
 	  select DDR4 target data rate at 800M
 
 config ASPEED_DDR4_1333
-	bool "DDR4 targets at 1333Mbps"
-	depends on DM && OF_CONTROL && ARCH_ASPEED
+	bool "1333Mbps"
 	help
 	  select DDR4 target data rate at 1333M
 
 config ASPEED_DDR4_1600
-	bool "DDR4 targets at 1600Mbps"
-	depends on DM && OF_CONTROL && ARCH_ASPEED
+	bool "1600Mbps"
 	help
 	  select DDR4 target data rate at 1600M
 endchoice
 
-config ASPEED_BYPASS_SELFTEST
-	bool "bypass self test during DRAM initialization"
-	help
-	  Say Y here to bypass DRAM self test to speed up the boot time
-
-config ASPEED_ECC
-	bool "aspeed SDRAM error correcting code"
-	depends on DM && OF_CONTROL && ARCH_ASPEED
-	help
-	  enable SDRAM ECC function
-
-if ASPEED_ECC
-config ASPEED_ECC_SIZE
-	int "ECC size: 0=driver auto-caluated"
-	depends on ASPEED_ECC
-	default 0
-	help
-	  SDRAM size with the error correcting code enabled. The unit is
-	  in Megabytes.  Noted that only the 8/9 of the configured size
-	  can be used by the system.  The remaining 1/9 will be used by
-	  the ECC engine.  If the size is set to 0, the sdram driver will
-	  calculate the SDRAM size and set the whole range be ECC enabled.
-endif # end of ASPEED_ECC
-endif # end of ASPEED_AST2600
-endif # end of RAM || SPL_RAM
+endif # End of ASPEED_RAM
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 146 lines

-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Joel Stanley
Sent: 2022年2月16日 3:53 PM
To: ChiaWei Wang <[email protected]>; Ryan Chen <[email protected]>; BMC-SW <[email protected]>
Cc: Cédric Le Goater <[email protected]>; [email protected]
Subject: [PATCH] ram: aspeed: Rework kconfig options

Ensure the ASPEED related options are grouped together under the RAM option when enabling support.

This also makes some minor grammar corrections and renames options so they present cleanly in menuconfig.

There should be no functional change to the configuration or binary.

---
 drivers/ram/aspeed/Kconfig | 91 +++++++++++++++++++++-----------------
 1 file changed, 51 insertions(+), 40 deletions(-)
drivers/ram/aspeed/Kconfig index renamed from drivers/ram/aspeed/Kconfig +0 -0

576d5af8688e..0deab8649b64 100644

drivers/ram/aspeed/Kconfig +29 -3
@@ -1,66 +1,77 @@
-if RAM || SPL_RAM
+menuconfig ASPEED_RAM
+	bool "ASPEED SDRAM configuration"
+	depends on RAM && ARCH_ASPEED
+	default ARCH_ASPEED
+	help
+	 Configuration options for DDR SDRAM on ASPEED systems.
+
+	 RAM initialisation is always built in for the platform. This menu
+	 allows customisation of the configuration used.
+
+if ASPEED_RAM
 
 config ASPEED_DDR4_DUALX8
 	bool "Enable Dual X8 DDR4 die"
-	depends on DM && OF_CONTROL && ARCH_ASPEED
+	depends on ASPEED_RAM
+	help
+	 Say Y if dual X8 DDR4 die is used on the board. The ASPEED DDRM
+	 SRAM controller needs to know if the memory chip mounted on the
+	 board is dual x8 die or not, otherwise it may get the wrong
+	 size of the memory space.
+
+config ASPEED_BYPASS_SELFTEST
+	depends on ASPEED_RAM
+	depends on ASPEED_AST2600
+	bool "Bypass self test during initialization"
+	help
+	  Say Y here to bypass DRAM self test to speed up the boot time.
+
+config ASPEED_ECC
+	bool "ASPEED SDRAM ECC"
+	depends on ASPEED_RAM
+	depends on ASPEED_AST2600
 	help
-		Say Y if dual X8 DDR4 die is used on the board.  The aspeed ddr

sdram

drivers/ram/aspeed/Kconfig +0 -1
-		controller needs to know if the memory chip mounted on the board

is dual

drivers/ram/aspeed/Kconfig +22 -37
-		 x8 die or not.  Or it may get the wrong size of the memory space.
+	  Enable SDRAM ECC function. This configures the SDRAM controller to
+	  perform error detection and correction, sacrificing 1/9th of the
+	  installed RAM to do so.
 
-if ASPEED_AST2600
+
+config ASPEED_ECC_SIZE
+	int "ECC size: 0=driver auto-caluated"
+	depends on ASPEED_ECC
+	default 0
+	help
+	  SDRAM size with the error correcting code enabled. The unit is
+	  in Megabytes.  Noted that only the 8/9 of the configured size
+	  can be used by the system.  The remaining 1/9 will be used by
+	  the ECC engine.  If the size is set to 0, the sdram driver will
+	  calculate the SDRAM size and set the whole range be ECC enabled.
 
 choice
-	prompt "DDR4 target date rate"
+	prompt "AST2600 DDR4 target date rate"
 	default ASPEED_DDR4_1600
+	depends on ASPEED_RAM
+	depends on ASPEED_AST2600
 
 config ASPEED_DDR4_400
-	bool "DDR4 targets at 400Mbps"
-	depends on DM && OF_CONTROL && ARCH_ASPEED
+	bool "400Mbps"
 	help
 	  select DDR4 target data rate at 400M
 
 config ASPEED_DDR4_800
-	bool "DDR4 targets at 800Mbps"
-	depends on DM && OF_CONTROL && ARCH_ASPEED
+	bool "800Mbps"
 	help
 	  select DDR4 target data rate at 800M
 
 config ASPEED_DDR4_1333
-	bool "DDR4 targets at 1333Mbps"
-	depends on DM && OF_CONTROL && ARCH_ASPEED
+	bool "1333Mbps"
 	help
 	  select DDR4 target data rate at 1333M
 
 config ASPEED_DDR4_1600
-	bool "DDR4 targets at 1600Mbps"
-	depends on DM && OF_CONTROL && ARCH_ASPEED
+	bool "1600Mbps"
 	help
 	  select DDR4 target data rate at 1600M  endchoice
 
-config ASPEED_BYPASS_SELFTEST
-	bool "bypass self test during DRAM initialization"
-	help
-	  Say Y here to bypass DRAM self test to speed up the boot time
-
-config ASPEED_ECC
-	bool "aspeed SDRAM error correcting code"
-	depends on DM && OF_CONTROL && ARCH_ASPEED
-	help
-	  enable SDRAM ECC function
-
-if ASPEED_ECC
-config ASPEED_ECC_SIZE
-	int "ECC size: 0=driver auto-caluated"
-	depends on ASPEED_ECC
-	default 0
-	help
-	  SDRAM size with the error correcting code enabled. The unit is
-	  in Megabytes.  Noted that only the 8/9 of the configured size
-	  can be used by the system.  The remaining 1/9 will be used by
-	  the ECC engine.  If the size is set to 0, the sdram driver will
-	  calculate the SDRAM size and set the whole range be ECC enabled.
-endif # end of ASPEED_ECC
-endif # end of ASPEED_AST2600
-endif # end of RAM || SPL_RAM
+endif # End of ASPEED_RAM
--
Quoted 1 line

2.34.1

#2 lore raw
In reply to Joel Stanley
Quoted 10 lines · Joel Stanley

Ensure the ASPEED related options are grouped together under the RAM option when enabling support.

This also makes some minor grammar corrections and renames options so they present cleanly in menuconfig.

There should be no functional change to the configuration or binary.

Applied to u-boot/next, thanks!

Signature · 1 line
Tom