brcmfmac: Replace zero-length arrays with flexible-array members
PATCH 1/1 brcmfmac: Replace zero-length arrays with flexible-array members
There is a regular need in the kernel to provide a way to declare having a dynamically sized set of trailing elements in a structure. Kernel code should always use “flexible array members”[1] for these cases. The older style of one-element or zero-length arrays should no longer be used[2].
[1] https://en.wikipedia.org/wiki/Flexible_array_member
[2] https://www.kernel.org/doc/html/v5.16/process/deprecated.html#zero-length-and-one-element-arrays
--- drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwil_types.h | 2 +- drivers/net/wireless/broadcom/brcm80211/brcmfmac/xtlv.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwil_types.h +1 -1
@@ -1068,7 +1068,7 @@ struct brcmf_mkeep_alive_pkt_le {__le32 period_msec;__le16 len_bytes;u8 keep_alive_id; - u8 data[0]; + u8 data[]; } __packed;#endif /* FWIL_TYPES_H_ */
drivers/net/wireless/broadcom/brcm80211/brcmfmac/xtlv.h +1 -1
@@ -15,7 +15,7 @@struct brcmf_xtlv {u16 id;u16 len; -u8 data[0 ]; +u8 data[]; };enum brcmf_xtlv_option {
Signature · 1 line
2.27.0
Quoted 11 lines · Gustavo A. R. Silva
There is a regular need in the kernel to provide a way to declare having a dynamically sized set of trailing elements in a structure. Kernel code should always use “flexible array members”[1] for these cases. The older style of one-element or zero-length arrays should no longer be used[2].
[1] https://en.wikipedia.org/wiki/Flexible_array_member
[2] https://www.kernel.org/doc/html/v5.16/process/deprecated.html#zero-length-and-one-element-arrays
Signature · 1 line
Kees Cook
Quoted 6 lines · Gustavo A. R. Silva
There is a regular need in the kernel to provide a way to declare having a dynamically sized set of trailing elements in a structure. Kernel code should always use “flexible array members”[1] for these cases. The older style of one-element or zero-length arrays should no longer be used[2].
Quoted 6 lines
[1] https://en.wikipedia.org/wiki/Flexible_array_member
[2] https://www.kernel.org/doc/html/v5.16/process/deprecated.html#zero-length-and-one-element-arraysSigned-off-by Gustavo A. R. Silva <[email protected]>Reviewed-by Kees Cook <[email protected]>
Patch applied to wireless-next.git, thanks.
d8b1f4193e09 brcmfmac: Replace zero-length arrays with flexible-array members
Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/patch/20220216194935.GA904103@embeddedor/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches