arm64: dts: rockchip: Correct clock-output-names for rk817
Subsystems (2)
PATCH 1/1 arm64: dts: rockchip: Correct clock-output-names for rk817
From: Chris Morgan <[email protected]>
According to the datasheet for the rk817 there is only a single output clock for the PMIC. I don't believe this is causing any harm though and testing this change doesn't appear to have any noticeable effects.
--- arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts +1 -1
@@ -296,7 +296,7 @@ rk817: pmic@20 { reg = <0x20>; interrupt-parent = <&gpio0>; interrupts = <RK_PB2 IRQ_TYPE_LEVEL_LOW>; - clock-output-names = "rk808-clkout1", "xin32k"; + clock-output-names = "rk808-clkout1"; clock-names = "mclk"; clocks = <&cru SCLK_I2S1_OUT>; pinctrl-names = "default";
Signature · 7 lines
2.25.1 _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
Heiko Stübner
maintainerHi,
Am Mittwoch, 16. Februar 2022, 17:58:37 CET schrieb Chris Morgan:
Quoted 5 lines
From: Chris Morgan <[email protected]>
According to the datasheet for the rk817 there is only a single output clock for the PMIC. I don't believe this is causing any harm though and testing this change doesn't appear to have any noticeable effects.
hmm, looking at the go2's schematics, I'd disagree:
- yes, the rk817 has only one clock output
- but no, it is used for the clkout_32k signal, which gets piped back into the SoC. As that clock dynamically appears at some unspecified point when the rk817 probes, the clock controller expects it to be named xin32k to bind into its clock-tree.
The driver (drivers/clk/clk-rk808.c) really puts that rk817-clk32k at position 2 but I'm not sure if that simply papers over some implementation
Heiko
Quoted 19 lines
Signed-off-by Chris Morgan <[email protected]>--- arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts +1
-1@@ -296,7 +296,7 @@ rk817: pmic@20 { reg = <0x20>; interrupt-parent = <&gpio0>; interrupts = <RK_PB2 IRQ_TYPE_LEVEL_LOW>; - clock-output-names = "rk808-clkout1", "xin32k"; + clock-output-names = "rk808-clkout1"; clock-names = "mclk"; clocks = <&cru SCLK_I2S1_OUT>; pinctrl-names = "default";
Quoted 11 lines · Heiko Stübner
Hi,
Am Mittwoch, 16. Februar 2022, 17:58:37 CET schrieb Chris Morgan:
Quoted 5 lines
From: Chris Morgan <[email protected]>
According to the datasheet for the rk817 there is only a single output clock for the PMIC. I don't believe this is causing any harm though and testing this change doesn't appear to have any noticeable effects.
hmm, looking at the go2's schematics, I'd disagree:
Quoted 8 lines
- yes, the rk817 has only one clock output
- but no, it is used for theclkout_32ksignal, which gets piped back into the SoC. As that clock dynamically appears at some unspecified point when the rk817 probes, the clock controller expects it to be named xin32k to bind into its clock-tree.The driver (
drivers/clk/clk-rk808.c) really puts that rk817-clk32k at position 2 but I'm not sure if that simply papers over some implementation
Indeed it appears to be a hangover from RK808 where CLK32KOUT1 is always-on and CLK32KOUT2 is the switchable one. It's even more obvious on RK805 which still shares the original control register layout.
Robin.
Quoted 32 lines
Heiko
Quoted 11 lines
Signed-off-by Chris Morgan <[email protected]>--- arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts +0
-0arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts rk817: pmic@20 { · line 302
Quoted 8 lines
arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts +1
-1@@ -296,7 +296,7 @@ rk817: pmic@20 { reg = <0x20>; interrupt-parent = <&gpio0>; interrupts = <RK_PB2 IRQ_TYPE_LEVEL_LOW>; - clock-output-names = "rk808-clkout1", "xin32k"; + clock-output-names = "rk808-clkout1"; clock-names = "mclk"; clocks = <&cru SCLK_I2S1_OUT>; pinctrl-names = "default";_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
Quoted 18 lines · Robin Murphy
Quoted 17 lines · Heiko Stübner
Hi,
Am Mittwoch, 16. Februar 2022, 17:58:37 CET schrieb Chris Morgan:
Quoted 5 lines
From: Chris Morgan <[email protected]>
According to the datasheet for the rk817 there is only a single output clock for the PMIC. I don't believe this is causing any harm though and testing this change doesn't appear to have any noticeable effects.
hmm, looking at the go2's schematics, I'd disagree:
- yes, the rk817 has only one clock output
- but no, it is used for theclkout_32ksignal, which gets piped back into the SoC. As that clock dynamically appears at some unspecified point when the rk817 probes, the clock controller expects it to be named xin32k to bind into its clock-tree.
Quoted 8 lines
Quoted 2 lines
The driver (
drivers/clk/clk-rk808.c) really puts that rk817-clk32k at position 2 but I'm not sure if that simply papers over some implementationIndeed it appears to be a hangover from RK808 where CLK32KOUT1 is always-on and CLK32KOUT2 is the switchable one. It's even more obvious on RK805 which still shares the original control register layout.
Robin.
Okay, so I'm thinking for now we cancel this patch, note in the yaml updates patch series that this issue is present, update the driver, and then notify the board dts maintainers to switch over and test. Does that sound good?
Thank you.
Quoted 33 lines
Quoted 33 lines
Heiko
Quoted 11 lines
Signed-off-by Chris Morgan <[email protected]>--- arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts +0
-0arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts rk817: pmic@20 { · line 302
Quoted 8 lines
arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts +1
-1@@ -296,7 +296,7 @@ rk817: pmic@20 { reg = <0x20>; interrupt-parent = <&gpio0>; interrupts = <RK_PB2 IRQ_TYPE_LEVEL_LOW>; - clock-output-names = "rk808-clkout1", "xin32k"; + clock-output-names = "rk808-clkout1"; clock-names = "mclk"; clocks = <&cru SCLK_I2S1_OUT>; pinctrl-names = "default";_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip