gstreamer1.0: update licences of all modules
PATCH 1/1 gstreamer1.0: update licences of all modules
Since all gstreamer modules uses LGPLv2.1 with exceptions for some plugins in bad and ugly modules that has GPLv2+.
For the GPLv2+ this patch set the licence only for each plugin that is affected by this licence. The commercial LICENSE_FLAGS is enabled if any of the previous plugins is builded.
--- .../gstreamer/gst-devtools_1.20.0.bb | 2 +- .../gstreamer/gstreamer1.0-libav_1.20.0.bb | 2 +- .../gstreamer/gstreamer1.0-omx_1.20.0.bb | 2 +- .../gstreamer/gstreamer1.0-plugins-bad_1.20.0.bb | 7 ++++++- .../gstreamer/gstreamer1.0-plugins-base_1.20.0.bb | 2 +- .../gstreamer/gstreamer1.0-plugins-good_1.20.0.bb | 2 +- .../gstreamer/gstreamer1.0-plugins-ugly_1.20.0.bb | 10 ++++++++-- .../gstreamer/gstreamer1.0-python_1.20.0.bb | 2 +- .../gstreamer/gstreamer1.0-rtsp-server_1.20.0.bb | 2 +- .../gstreamer/gstreamer1.0-vaapi_1.20.0.bb | 2 +- .../gstreamer/gstreamer1.0_1.20.0.bb | 2 +- 11 files changed, 23 insertions(+), 12 deletions(-)
meta/recipes-multimedia/gstreamer/gst-devtools_1.20.0.bb +1 -1
@@ -3,7 +3,7 @@ DESCRIPTION = "A Tool to test GStreamer components" HOMEPAGE = "https://gstreamer.freedesktop.org/documentation/gst-devtools/index.html" SECTION = "multimedia" -LICENSE = "LGPLv2.1" +LICENSE = "LGPL-2.1-or-later" LIC_FILES_CHKSUM = "file://validate/COPYING;md5=a6f89e2100d9b6cdffcea4f398e37343" #S = "${WORKDIR}/gst-devtools-${PV}"
meta/recipes-multimedia/gstreamer/gstreamer1.0-libav_1.20.0.bb +1 -1
@@ -6,7 +6,7 @@ SECTION = "multimedia" # ffmpeg has comercial license flags so add it as we need ffmpeg as a dependency LICENSE_FLAGS = "commercial" -LICENSE = "LGPLv2+" +LICENSE = "LGPL-2.1-or-later" LIC_FILES_CHKSUM = "file://COPYING;md5=69333daa044cb77e486cc36129f7a770 \ file://ext/libav/gstav.h;beginline=1;endline=18;md5=a752c35267d8276fd9ca3db6994fca9c \ "
meta/recipes-multimedia/gstreamer/gstreamer1.0-omx_1.20.0.bb +1 -1
@@ -3,7 +3,7 @@ DESCRIPTION = "Wraps available OpenMAX IL components and makes them available as HOMEPAGE = "http://gstreamer.freedesktop.org/" SECTION = "multimedia" -LICENSE = "LGPLv2.1" +LICENSE = "LGPL-2.1-or-later" LICENSE_FLAGS = "commercial" LIC_FILES_CHKSUM = "file://COPYING;md5=4fbd65380cdd255951079008b364516c \ file://omx/gstomx.h;beginline=1;endline=21;md5=5c8e1fca32704488e76d2ba9ddfa935f"
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.20.0.bb +6 -1
@@ -15,7 +15,7 @@ SRC_URI[sha256sum] = "015b8d4d9a395ebf444d40876867a2034dd3304b3ad48bc3a0dd0c1ee7 S = "${WORKDIR}/gst-plugins-bad-${PV}" -LICENSE = "GPLv2+ & LGPLv2+ & LGPLv2.1+" +LICENSE = "LGPL-2.1-or-later & GPL-2.0-or-later" LIC_FILES_CHKSUM = "file://COPYING;md5=4fbd65380cdd255951079008b364516c" DEPENDS += "gstreamer1.0-plugins-base"
@@ -98,6 +98,11 @@ PACKAGECONFIG[faad] = "-Dfaad=enabled,-Dfaad=disabled,faad2" PACKAGECONFIG[resindvd] = "-Dresindvd=enabled,-Dresindvd=disabled,libdvdread libdvdnav" PACKAGECONFIG[x265] = "-Dx265=enabled,-Dx265=disabled,x265" +LICENSE_FLAGS = "${@bb.utils.contains("PACKAGECONFIG", "gpl", "commercial", "", d)}" +LICENSE:${PN}-faad = "GPL-2.0-or-later" +LICENSE:${PN}-resindvd = "GPL-2.0-or-later" +LICENSE:${PN}-x265 = "GPL-2.0-or-later" + EXTRA_OEMESON += " \ -Ddoc=disabled \ -Daes=enabled \
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base_1.20.0.bb +1 -1
@@ -3,7 +3,7 @@ require gstreamer1.0-plugins-common.inc DESCRIPTION = "'Base' GStreamer plugins and helper libraries" HOMEPAGE = "https://gstreamer.freedesktop.org/" BUGTRACKER = "https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/issues" -LICENSE = "LGPLv2+" +LICENSE = "LGPL-2.1-or-later" LIC_FILES_CHKSUM = "file://COPYING;md5=69333daa044cb77e486cc36129f7a770" SRC_URI = "https://gstreamer.freedesktop.org/src/gst-plugins-base/gst-plugins-base-${PV}.tar.xz \
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.20.0.bb +1 -1
@@ -12,7 +12,7 @@ SRC_URI[sha256sum] = "2d119c15ab8c9e79f8cd3c6bf582ff7a050b28ccae52ab4865e1a14649 S = "${WORKDIR}/gst-plugins-good-${PV}" -LICENSE = "GPLv2+ & LGPLv2.1+" +LICENSE = "LGPL-2.1-or-later" LIC_FILES_CHKSUM = "file://COPYING;md5=a6f89e2100d9b6cdffcea4f398e37343 \ file://gst/replaygain/rganalysis.c;beginline=1;endline=23;md5=b60ebefd5b2f5a8e0cab6bfee391a5fe"
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-ugly_1.20.0.bb +8 -2
@@ -7,8 +7,7 @@ BUGTRACKER = "https://gitlab.freedesktop.org/gstreamer/gst-plugins-ugly/-/issues LIC_FILES_CHKSUM = "file://COPYING;md5=a6f89e2100d9b6cdffcea4f398e37343 \ file://tests/check/elements/xingmux.c;beginline=1;endline=21;md5=4c771b8af188724855cb99cadd390068" -LICENSE = "GPLv2+ & LGPLv2.1+ & LGPLv2+" -LICENSE_FLAGS = "commercial" +LICENSE = "LGPL-2.1-or-later & GPL-2.0-or-later" SRC_URI = " \ https://gstreamer.freedesktop.org/src/gst-plugins-ugly/gst-plugins-ugly-${PV}.tar.xz \
@@ -37,6 +36,13 @@ PACKAGECONFIG[dvdread] = "-Ddvdread=enabled,-Ddvdread=disabled,libdvdread" PACKAGECONFIG[mpeg2dec] = "-Dmpeg2dec=enabled,-Dmpeg2dec=disabled,mpeg2dec" PACKAGECONFIG[x264] = "-Dx264=enabled,-Dx264=disabled,x264" +LICENSE_FLAGS = "${@bb.utils.contains("PACKAGECONFIG", "gpl", "commercial", "", d)}" +LICENSE:${PN}-cdio = "GPL-2.0-or-later" +LICENSE:${PN}-a52dec = "GPL-2.0-or-later" +LICENSE:${PN}-dvdread = "GPL-2.0-or-later" +LICENSE:${PN}-mpeg2dec = "GPL-2.0-or-later" +LICENSE:${PN}-x264 = "GPL-2.0-or-later" + EXTRA_OEMESON += " \ -Ddoc=disabled \ -Dsidplay=disabled \
meta/recipes-multimedia/gstreamer/gstreamer1.0-python_1.20.0.bb +1 -1
@@ -4,7 +4,7 @@ provided by python-gi) " HOMEPAGE = "http://cgit.freedesktop.org/gstreamer/gst-python/" SECTION = "multimedia" -LICENSE = "LGPLv2.1" +LICENSE = "LGPL-2.1-or-later" LIC_FILES_CHKSUM = "file://COPYING;md5=c34deae4e395ca07e725ab0076a5f740" SRC_URI = "https://gstreamer.freedesktop.org/src/${PNREAL}/${PNREAL}-${PV}.tar.xz"
meta/recipes-multimedia/gstreamer/gstreamer1.0-rtsp-server_1.20.0.bb +1 -1
@@ -1,7 +1,7 @@ SUMMARY = "A library on top of GStreamer for building an RTSP server" HOMEPAGE = "http://cgit.freedesktop.org/gstreamer/gst-rtsp-server/" SECTION = "multimedia" -LICENSE = "LGPLv2" +LICENSE = "LGPL-2.1-or-later" LIC_FILES_CHKSUM = "file://COPYING;md5=69333daa044cb77e486cc36129f7a770" DEPENDS = "gstreamer1.0 gstreamer1.0-plugins-base"
meta/recipes-multimedia/gstreamer/gstreamer1.0-vaapi_1.20.0.bb +1 -1
@@ -6,7 +6,7 @@ based plugins for GStreamer and helper libraries: `vaapidecode', \ REALPN = "gstreamer-vaapi" -LICENSE = "LGPLv2.1+" +LICENSE = "LGPL-2.1-or-later" LIC_FILES_CHKSUM = "file://COPYING.LIB;md5=4fbd65380cdd255951079008b364516c" SRC_URI = "https://gstreamer.freedesktop.org/src/${REALPN}/${REALPN}-${PV}.tar.xz"
meta/recipes-multimedia/gstreamer/gstreamer1.0_1.20.0.bb +1 -1
@@ -4,7 +4,7 @@ It supports a wide range of formats including mp3, ogg, avi, mpeg and quicktime. HOMEPAGE = "http://gstreamer.freedesktop.org/" BUGTRACKER = "https://bugzilla.gnome.org/enter_bug.cgi?product=Gstreamer" SECTION = "multimedia" -LICENSE = "LGPLv2+" +LICENSE = "LGPL-2.1-or-later" DEPENDS = "glib-2.0 glib-2.0-native libxml2 bison-native flex-native"
Signature · 1 line
2.35.1
Quoted 29 lines
-----Original Message-----
From: Jose Quaresma <[email protected]>
Sent: den 17 februari 2022 00:28
To: [email protected]
Cc: Peter Kjellerstedt <[email protected]>; Jose Quaresma <[email protected]>
Subject: [PATCH] gstreamer1.0: update licences of all modulesSince all gstreamer modules uses LGPLv2.1 with exceptions for some plugins in bad and ugly modules that has GPLv2+.
For the GPLv2+ this patch set the licence only for each plugin that is affected by this licence. The commercial
LICENSE_FLAGSis enabled if any of the previous plugins is builded.Signed-off-by Jose Quaresma <[email protected]>Cc Peter Kjellerstedt <[email protected]>--- .../gstreamer/gst-devtools_1.20.0.bb | 2 +- .../gstreamer/gstreamer1.0-libav_1.20.0.bb | 2 +- .../gstreamer/gstreamer1.0-omx_1.20.0.bb | 2 +- .../gstreamer/gstreamer1.0-plugins-bad_1.20.0.bb | 7 ++++++- .../gstreamer/gstreamer1.0-plugins-base_1.20.0.bb | 2 +- .../gstreamer/gstreamer1.0-plugins-good_1.20.0.bb | 2 +- .../gstreamer/gstreamer1.0-plugins-ugly_1.20.0.bb | 10 ++++++++-- .../gstreamer/gstreamer1.0-python_1.20.0.bb | 2 +- .../gstreamer/gstreamer1.0-rtsp-server_1.20.0.bb | 2 +- .../gstreamer/gstreamer1.0-vaapi_1.20.0.bb | 2 +- .../gstreamer/gstreamer1.0_1.20.0.bb | 2 +- 11 files changed, 23 insertions(+), 12 deletions(-)
[cut]
Quoted 15 lines
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.20.0.bb +0
-0@@ -15,7 +15,7 @@ SRC_URI[sha256sum] ="
015b8d4d9a395ebf444d40876867a2034dd3304b3ad48bc3a0dd0c1ee7S = "${WORKDIR}/gst-plugins-bad-${PV}"
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.20.0.bb +1
-1-LICENSE = "GPLv2+ & LGPLv2+ & LGPLv2.1+" +LICENSE = "LGPL-2.1-or-later & GPL-2.0-or-later" LIC_FILES_CHKSUM = "file://COPYING;md5=4fbd65380cdd255951079008b364516c" DEPENDS += "gstreamer1.0-plugins-base"
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.20.0.bb PACKAGECONFIG[faad] = "-Dfaad=enabled,-Dfaad=disabled,faad2" · line 101
Quoted 4 lines
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.20.0.bb +1
-0@@ -98,6 +98,11 @@ PACKAGECONFIG[faad] = "-Dfaad=enabled,-Dfaad=disabled,faad2" PACKAGECONFIG[resindvd] = "-Dresindvd=enabled,- Dresindvd=disabled,libdvdread libdvdnav" PACKAGECONFIG[x265] = "-Dx265=enabled,-Dx265=disabled,x265" +LICENSE_FLAGS = "${@bb.utils.contains("PACKAGECONFIG", "gpl", "commercial", "", d)}"
There shouldn't be any commercial limitations in these plugins. If there were, then they would be in -ugly instead.
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.20.0.bb PACKAGECONFIG[faad] = "-Dfaad=enabled,-Dfaad=disabled,faad2" · line 104
Quoted 3 lines
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.20.0.bb +3
-0+LICENSE:${PN}-faad = "GPL-2.0-or-later" +LICENSE:${PN}-resindvd = "GPL-2.0-or-later" +LICENSE:${PN}-x265 = "GPL-2.0-or-later"
This is unfortunately not enough. It is actually more the opposite of what is needed. You need to set the license for all the other plugins that are only affected by LGPL-2.1-or-later since the default for a package is ${LICENSE} if no ${LICENSE:<package>} is defined.
It is likely that you can do something creative in split_gstreamer10_packages() and set the default license there for the plugin packages to "LGPL-2.1-or-later" and then the overrides above would be enough. You probably want to do something like this to avoid having to update the lists of plugin packages every time the recipes are updated to new versions as plugins have a tendency to come and go.
Quoted 4 lines
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.20.0.bb +1
-0+ EXTRA_OEMESON += " \ -Ddoc=disabled \ -Daes=enabled \
[cut]
Quoted 16 lines
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-ugly_1.20.0.bb +0
-0@@ -7,8 +7,7 @@ BUGTRACKER = "https://gitlab.freedesktop.org/gstreamer/gst-plugins-ugly/-/issues LIC_FILES_CHKSUM = "file://COPYING;md5=a6f89e2100d9b6cdffcea4f398e37343 \file://tests/check/elements/xingmux.c;beginline=1;endline=21;md5=4c771b8af188724855cb99cadd390068"
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-ugly_1.20.0.bb +1
-2-LICENSE = "GPLv2+ & LGPLv2.1+ & LGPLv2+" -LICENSE_FLAGS = "commercial" +LICENSE = "LGPL-2.1-or-later & GPL-2.0-or-later" SRC_URI = " \ https://gstreamer.freedesktop.org/src/gst-plugins-ugly/gst-plugins-ugly-${PV}.tar.xz \
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-ugly_1.20.0.bb PACKAGECONFIG[dvdread] = "-Ddvdread=enabled,-Ddvdread=disabled,libdvdread" · line 39
Quoted 4 lines
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-ugly_1.20.0.bb +1
-0@@ -37,6 +36,13 @@ PACKAGECONFIG[dvdread] = "-Ddvdread=enabled,-Ddvdread=disabled,libdvdread" PACKAGECONFIG[mpeg2dec] = "-Dmpeg2dec=enabled,-Dmpeg2dec=disabled,mpeg2dec" PACKAGECONFIG[x264] = "-Dx264=enabled,-Dx264=disabled,x264" +LICENSE_FLAGS = "${@bb.utils.contains("PACKAGECONFIG", "gpl", "commercial", "", d)}"
I do not think making this conditional is correct. AFAIK the commercial flag is used in this recipe due to, e.g., patent limitations and not necessarily the actual code and its license. It affects all plugins in -ugly (it is the reason they are there in the first place and not in, e.g., -good or -bad).
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-ugly_1.20.0.bb PACKAGECONFIG[dvdread] = "-Ddvdread=enabled,-Ddvdread=disabled,libdvdread" · line 44
Quoted 5 lines
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-ugly_1.20.0.bb +5
-0+LICENSE:${PN}-cdio = "GPL-2.0-or-later" +LICENSE:${PN}-a52dec = "GPL-2.0-or-later" +LICENSE:${PN}-dvdread = "GPL-2.0-or-later" +LICENSE:${PN}-mpeg2dec = "GPL-2.0-or-later" +LICENSE:${PN}-x264 = "GPL-2.0-or-later"
The same applies here as in -bad.
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-ugly_1.20.0.bb PACKAGECONFIG[dvdread] = "-Ddvdread=enabled,-Ddvdread=disabled,libdvdread" · line 48
Quoted 4 lines
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-ugly_1.20.0.bb +1
-0+ EXTRA_OEMESON += " \ -Ddoc=disabled \ -Dsidplay=disabled \
//Peter
Hi Peter,
It's not as simple as I was thinking, I'll need more time.
Jose
Peter Kjellerstedt <[email protected]> escreveu no dia quinta, 17/02/2022 à(s) 14:34:
Quoted 140 lines
Quoted 5 lines
-----Original Message-----
From: Jose Quaresma <[email protected]>
Sent: den 17 februari 2022 00:28
To: [email protected]
Cc: Peter Kjellerstedt <[email protected]>; Jose Quaresma <Quoted 24 lines
Subject: [PATCH] gstreamer1.0: update licences of all modules
Since all gstreamer modules uses LGPLv2.1 with exceptions for some plugins in bad and ugly modules that has GPLv2+.
For the GPLv2+ this patch set the licence only for each plugin that is affected by this licence. The commercial
LICENSE_FLAGSis enabled if any of the previous plugins is builded.Signed-off-by Jose Quaresma <[email protected]>Cc Peter Kjellerstedt <[email protected]>--- .../gstreamer/gst-devtools_1.20.0.bb | 2 +- .../gstreamer/gstreamer1.0-libav_1.20.0.bb | 2 +- .../gstreamer/gstreamer1.0-omx_1.20.0.bb | 2 +- .../gstreamer/gstreamer1.0-plugins-bad_1.20.0.bb | 7 ++++++- .../gstreamer/gstreamer1.0-plugins-base_1.20.0.bb | 2 +- .../gstreamer/gstreamer1.0-plugins-good_1.20.0.bb | 2 +- .../gstreamer/gstreamer1.0-plugins-ugly_1.20.0.bb | 10 ++++++++-- .../gstreamer/gstreamer1.0-python_1.20.0.bb | 2 +- .../gstreamer/gstreamer1.0-rtsp-server_1.20.0.bb | 2 +- .../gstreamer/gstreamer1.0-vaapi_1.20.0.bb | 2 +- .../gstreamer/gstreamer1.0_1.20.0.bb | 2 +- 11 files changed, 23 insertions(+), 12 deletions(-)[cut]
Review
Quoted 1 line
(quoted diff) +0
-0gstreamer1.0-plugins-bad_1.20.0.bb b/meta/recipes-multimedia/gstreamer/ gstreamer1.0-plugins-bad_1.20.0.bb
Quoted 2 lines
index
915d4ec744..22288373ac100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.20.0.bb
Quoted 1 line
+++ b/meta/recipes-multimedia/gstreamer/
gstreamer1.0-plugins-bad_1.20.0.bb
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.20.0.bb PACKAGECONFIG[faad] =
Quoted 11 lines
(quoted diff) +0
-0@@ -15,7 +15,7 @@ SRC_URI[sha256sum] ="
015b8d4d9a395ebf444d40876867a2034dd3304b3ad48bc3a0dd0c1ee7S = "${WORKDIR}/gst-plugins-bad-${PV}"
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.20.0.bb +1
-1-LICENSE = "GPLv2+ & LGPLv2+ & LGPLv2.1+" +LICENSE = "LGPL-2.1-or-later & GPL-2.0-or-later" LIC_FILES_CHKSUM = "file://COPYING;md5=4fbd65380cdd255951079008b364516c" DEPENDS += "gstreamer1.0-plugins-base"@@ -98,6 +98,11 @@ PACKAGECONFIG[faad] ="-Dfaad=enabled,-Dfaad=disabled,faad2"
Review PACKAGECONFIG[faad] = · line 98
Quoted 1 line
(quoted diff) +0
-0PACKAGECONFIG[resindvd] = "-Dresindvd=enabled,-Dresindvd=disabled,libdvdread libdvdnav"
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.20.0.bb PACKAGECONFIG[faad] = "-Dfaad=enabled,-Dfaad=disabled,faad2"
Quoted 3 lines
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.20.0.bb +1
-0PACKAGECONFIG[x265] = "-Dx265=enabled,-Dx265=disabled,x265" +LICENSE_FLAGS = "${@bb.utils.contains("PACKAGECONFIG", "gpl","commercial", "", d)}"
There shouldn't be any commercial limitations in these plugins. If there were, then they would be in -ugly instead.
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.20.0.bb PACKAGECONFIG[faad] = "-Dfaad=enabled,-Dfaad=disabled,faad2" · line 104
Quoted 3 lines
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.20.0.bb +3
-0+LICENSE:${PN}-faad = "GPL-2.0-or-later" +LICENSE:${PN}-resindvd = "GPL-2.0-or-later" +LICENSE:${PN}-x265 = "GPL-2.0-or-later"This is unfortunately not enough. It is actually more the opposite of what is needed. You need to set the license for all the other plugins that are only affected by LGPL-2.1-or-later since the default for a package is ${LICENSE} if no ${LICENSE:<package>} is defined.
It is likely that you can do something creative in
split_gstreamer10_packages()and set the default license there for the plugin packages to "LGPL-2.1-or-later" and then the overrides above would be enough. You probably want to do something like this to avoid having to update the lists of plugin packages every time the recipes are updated to new versions as plugins have a tendency to come and go.Quoted 4 lines
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.20.0.bb +1
-0+ EXTRA_OEMESON += " \ -Ddoc=disabled \ -Daes=enabled \[cut]
Review
Quoted 1 line
(quoted diff) +0
-0gstreamer1.0-plugins-ugly_1.20.0.bb b/meta/recipes-multimedia/gstreamer/ gstreamer1.0-plugins-ugly_1.20.0.bb
Quoted 2 lines
index 8128104319..6442fd4504 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-ugly_1.20.0.bb
Quoted 1 line
+++ b/meta/recipes-multimedia/gstreamer/
gstreamer1.0-plugins-ugly_1.20.0.bb
Review BUGTRACKER = "
Quoted 1 line
(quoted diff) +0
-0@@ -7,8 +7,7 @@ BUGTRACKER = "https://gitlab.freedesktop.org/gstreamer/gst-plugins-ugly/-/issues
Review BUGTRACKER = " · line 7
Quoted 1 line
(quoted diff) +0
-0LIC_FILES_CHKSUM = "file://COPYING;md5=a6f89e2100d9b6cdffcea4f398e37343\
Quoted 2 lines
file://tests/check/elements/xingmux.c;beginline=1;endline=21;md5=4c771b8af188724855cb99cadd390068"
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-ugly_1.20.0.bb BUGTRACKER = "https://gitlab.freedesktop.org/gstreamer/gst-plugins-ugly/-/issues · line 12
Quoted 7 lines
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-ugly_1.20.0.bb +1
-2-LICENSE = "GPLv2+ & LGPLv2.1+ & LGPLv2+" -LICENSE_FLAGS = "commercial" +LICENSE = "LGPL-2.1-or-later & GPL-2.0-or-later" SRC_URI = " \https://gstreamer.freedesktop.org/src/gst-plugins-ugly/gst-plugins-ugly-${PV}.tar.xz
\Review PACKAGECONFIG[dvdread] =
Quoted 1 line
(quoted diff) +0
-0@@ -37,6 +36,13 @@ PACKAGECONFIG[dvdread] ="-Ddvdread=enabled,-Ddvdread=disabled,libdvdread"
Review PACKAGECONFIG[dvdread] = · line 36
Quoted 1 line
(quoted diff) +0
-0PACKAGECONFIG[mpeg2dec] ="-Dmpeg2dec=enabled,-Dmpeg2dec=disabled,mpeg2dec"
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-ugly_1.20.0.bb PACKAGECONFIG[dvdread] = "-Ddvdread=enabled,-Ddvdread=disabled,libdvdread"
Quoted 3 lines
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-ugly_1.20.0.bb +1
-0PACKAGECONFIG[x264] = "-Dx264=enabled,-Dx264=disabled,x264" +LICENSE_FLAGS = "${@bb.utils.contains("PACKAGECONFIG", "gpl","commercial", "", d)}"
I do not think making this conditional is correct. AFAIK the commercial flag is used in this recipe due to, e.g., patent limitations and not necessarily the actual code and its license. It affects all plugins in -ugly (it is the reason they are there in the first place and not in, e.g., -good or -bad).
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-ugly_1.20.0.bb PACKAGECONFIG[dvdread] = "-Ddvdread=enabled,-Ddvdread=disabled,libdvdread" · line 44
Quoted 5 lines
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-ugly_1.20.0.bb +5
-0+LICENSE:${PN}-cdio = "GPL-2.0-or-later" +LICENSE:${PN}-a52dec = "GPL-2.0-or-later" +LICENSE:${PN}-dvdread = "GPL-2.0-or-later" +LICENSE:${PN}-mpeg2dec = "GPL-2.0-or-later" +LICENSE:${PN}-x264 = "GPL-2.0-or-later"The same applies here as in -bad.
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-ugly_1.20.0.bb PACKAGECONFIG[dvdread] = "-Ddvdread=enabled,-Ddvdread=disabled,libdvdread" · line 48
Quoted 4 lines
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-ugly_1.20.0.bb +1
-0+ EXTRA_OEMESON += " \ -Ddoc=disabled \ -Dsidplay=disabled \//Peter
Signature · 3 lines
Best regards, José Quaresma
Quoted 1 line · Jose Quaresma
It's not as simple as I was thinking, I'll need more time.
Perhaps split the patch so the main change to LICENSE can be resolved, then the remaining later patches focus on the harder bit?
Cheers,
Richard
Richard Purdie <[email protected]> escreveu no dia quinta, 17/02/2022 à(s) 23:50:
Quoted 7 lines · Jose Quaresma
Quoted 1 line
It's not as simple as I was thinking, I'll need more time.
Perhaps split the patch so the main change to LICENSE can be resolved, then the
remaining later patches focus on the harder bit?
I sent a v2 with that.
Jose
Quoted 5 lines
Cheers,
Richard
Signature · 3 lines
Best regards, José Quaresma