Skip to contentSkip to conversation

IB/cma: Allow XRG INI QPs to set their local ACK timeout

PATCH Applied Håkon Bugge 4 participants 5 messages Feb 9, 2022 – Feb 17, 2022 InfiniBand

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 IB/cma: Allow XRG INI QPs to set their local ACK timeout

XRC INI QPs should be able to adjust their local ACK timeout.

Fixes 2c1619edef61 ("IB/cma: Define option to set ack timeout and pack tos_set")

---

v1 -> v2:
* Removed WARN_ON as suggested by Leon

---
 drivers/infiniband/core/cma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/infiniband/core/cma.c +1 -1
index 0f5f0d7..7adacd1 100644
@@ -2811,7 +2811,7 @@ int rdma_set_ack_timeout(struct rdma_cm_id *id, u8 timeout)
 {
 	struct rdma_id_private *id_priv;
 
-	if (id->qp_type != IB_QPT_RC)
+	if (id->qp_type != IB_QPT_RC && id->qp_type != IB_QPT_XRC_INI)
 		return -EINVAL;
 
 	id_priv = container_of(id, struct rdma_id_private, id);
Signature · 1 line
1.8.3.1
#2 lore raw
Quoted 11 lines · Leon Romanovsky
Quoted 6 lines · Håkon Bugge

XRC INI QPs should be able to adjust their local ACK timeout.

Fixes 2c1619edef61 ("IB/cma: Define option to set ack timeout and pack tos_set")
Quoted 5 lines
Quoted 2 lines

---

Thanks,

Thanks Leon. I just saw that we need a s/XRG/XRC/ in $Subject. Shall I send a v3?

Thxs, Håkon

#3 lore raw
Quoted 13 lines · Haakon Bugge
Quoted 13 lines · Leon Romanovsky
Quoted 7 lines · Håkon Bugge

XRC INI QPs should be able to adjust their local ACK timeout.

Fixes 2c1619edef61 ("IB/cma: Define option to set ack timeout and pack tos_set")
Quoted 4 lines
Quoted 2 lines

Thanks,

Thanks Leon. I just saw that we need a s/XRG/XRC/ in $Subject. Shall I send a v3?

I will fix it

Jason

maintainer Applied
#4 lore raw
In reply to Håkon Bugge
Quoted 6 lines · Håkon Bugge

XRC INI QPs should be able to adjust their local ACK timeout.

Fixes 2c1619edef61 ("IB/cma: Define option to set ack timeout and pack tos_set")
Quoted 7 lines

---

v1 -> v2:
* Removed WARN_ON as suggested by Leon

---
 drivers/infiniband/core/cma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied to for-next, thanks

Jason