Skip to contentSkip to conversation

clk: Mark a couple things const

PATCH Applied Stephen Boyd 1 participant 5 messages Feb 17, 2022 – Feb 26, 2022 Common clk

lore
Share & tools
lore

Stephen Boyd

author maintainer
#0 lore raw

cover clk: Mark a couple things const

Some spring cleaning.

Stephen Boyd (2):
clk: Mark 'all_lists' as const
clk: Mark clk_core_evict_parent_cache_subtree() 'target' const

 drivers/clk/clk.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

base-commit: fa62806ece26d6a7e40e785e5297ecccfffd29a3

Signature · 2 lines
https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/
https://git.kernel.org/pub/scm/linux/kernel/git/sboyd/spmi.git
author maintainer
#1 lore raw

PATCH 1/2 clk: Mark 'all_lists' as const

This list array doesn't change at runtime. Mark it const to move to RO memory.

Signed-off-by Stephen Boyd <[email protected]>
---
 drivers/clk/clk.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/clk/clk.c +2 -2
index 8de6a22498e7..16384e9437f5 100644
@@ -37,7 +37,7 @@ static HLIST_HEAD(clk_root_list);
 static HLIST_HEAD(clk_orphan_list);
 static LIST_HEAD(clk_notifier_list);
 
-static struct hlist_head *all_lists[] = {
+static const struct hlist_head *all_lists[] = {
 	&clk_root_list,
 	&clk_orphan_list,
 	NULL,

@@ -4095,7 +4095,7 @@ static void clk_core_evict_parent_cache_subtree(struct clk_core *root,
 /* Remove this clk from all parent caches */
 static void clk_core_evict_parent_cache(struct clk_core *core)
 {
-	struct hlist_head **lists;
+	const struct hlist_head **lists;
 	struct clk_core *root;
 
 	lockdep_assert_held(&prepare_lock);
Signature · 2 lines
https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/
https://git.kernel.org/pub/scm/linux/kernel/git/sboyd/spmi.git
author maintainer Applied
#2 lore raw

Re: [PATCH 1/2] clk: Mark 'all_lists' as const

Quoting Stephen Boyd (2022-02-17 14:05:53)

Quoted 5 lines

This list array doesn't change at runtime. Mark it const to move to RO memory.

Signed-off-by Stephen Boyd <[email protected]>

---

Applied to clk-next

author maintainer
#3 lore raw

PATCH 2/2 clk: Mark clk_core_evict_parent_cache_subtree() 'target' const

In reply to Stephen Boyd

Clarify that the 'target' clk isn't being modified, instead it's being searched for. Mark it const so the function can't modify it.

Signed-off-by Stephen Boyd <[email protected]>
---
 drivers/clk/clk.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/clk.c +1 -1
index 16384e9437f5..d15997ea3930 100644
@@ -4079,7 +4079,7 @@ static const struct clk_ops clk_nodrv_ops = {
 };
 
 static void clk_core_evict_parent_cache_subtree(struct clk_core *root,
-						struct clk_core *target)
+						const struct clk_core *target)
 {
 	int i;
 	struct clk_core *child;
Signature · 2 lines
https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/
https://git.kernel.org/pub/scm/linux/kernel/git/sboyd/spmi.git
author maintainer Applied
#4 lore raw

Re: [PATCH 2/2] clk: Mark clk_core_evict_parent_cache_subtree() 'target' const

Quoting Stephen Boyd (2022-02-17 14:05:54)

Quoted 5 lines

Clarify that the 'target' clk isn't being modified, instead it's being searched for. Mark it const so the function can't modify it.

Signed-off-by Stephen Boyd <[email protected]>

---

Applied to clk-next