net: dsa: OF-ware slave_mii_bus
Subsystems (3)
PATCH v2 1/1 net: dsa: OF-ware slave_mii_bus
If found, register the DSA internally allocated slave_mii_bus with an OF "mdio" child object. It can save some drivers from creating their custom internal MDIO bus.
Signed-off-by Luiz Angelo Daros de Luca <[email protected]>
--- net/dsa/dsa2.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
net/dsa/dsa2.c +6 -1
@@ -13,6 +13,7 @@#include <linux/slab.h> #include <linux/rtnetlink.h> #include <linux/of.h> +#include <linux/of_mdio.h> #include <linux/of_net.h> #include <net/devlink.h> #include <net/sch_generic.h>
@@ -869,6 +870,7 @@ static int dsa_switch_setup_tag_protocol(struct dsa_switch *ds)static int dsa_switch_setup (struct dsa_switch *ds) {struct dsa_devlink_priv *dl_priv; +struct device_node *dn;struct dsa_port *dp;int err;
@@ -924,7 +926,10 @@ static int dsa_switch_setup(struct dsa_switch *ds)dsa_slave_mii_bus_init (ds); - err =mdiobus_register (ds->slave_mii_bus); + dn =of_get_child_by_name (ds->dev->of_node,"mdio" ); + + err =of_mdiobus_register (ds->slave_mii_bus, dn); +of_node_put (dn);if (err <0 ) goto free_slave_mii_bus; }
Signature · 1 line
2.35.1
Andrew Lunn
maintainernet/dsa/dsa2.c static int dsa_switch_setup(struct dsa_switch *ds) · line 932
Quoted 13 lines · Luiz Angelo Daros de Luca
If found, register the DSA internally allocated
slave_mii_buswith an OF "mdio" child object. It can save some drivers from creating their custom internal MDIO bus.net/dsa/dsa2.c +4
-1@@ -924,7 +926,10 @@ static int dsa_switch_setup(struct dsa_switch *ds)dsa_slave_mii_bus_init (ds); - err =mdiobus_register (ds->slave_mii_bus); + dn =of_get_child_by_name (ds->dev->of_node,"mdio" ); + + err =of_mdiobus_register (ds->slave_mii_bus, dn); +of_node_put (dn);
This makes sense, but please update the binding document to include this:
Documentation/devicetree/bindings/net/dsa/dsa.yaml
Andrew