netfilter: nf_tables: fix memory leak during stateful obj update
Subsystems (2)
Florian Westphal
maintainerPATCH 1/1 netfilter: nf_tables: fix memory leak during stateful obj update
stateful objects can be updated from the control plane. The transaction logic allocates a temporary object for this purpose.
This object has to be released via nft_obj_destroy, not kfree, since the ->init function was called and it can have side effects beyond memory allocation.
Fixes d62d0ba97b58 ("netfilter: nf_tables: Introduce stateful object update operation")
Cc Fernando Fernandez Mancera <[email protected]>
Signed-off-by Florian Westphal <[email protected]>
--- net/netfilter/nf_tables_api.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
net/netfilter/nf_tables_api.c +2 -2
@@ -8185,7 +8185,7 @@ static void nft_obj_commit_update(struct nft_trans *trans)if (obj->ops->update) obj->ops->update (obj, newobj); -kfree (newobj); +nft_obj_destroy (&trans->ctx, newobj); }static void nft_commit_release (struct nft_trans *trans)
@@ -8976,7 +8976,7 @@ static int __nf_tables_abort(struct net *net, enum nfnl_abort_action action)break ;case NFT_MSG_NEWOBJ :if (nft_trans_obj_update (trans)) { -kfree (nft_trans_obj_newobj (trans)); +nft_obj_destroy (&trans->ctx,nft_trans_obj_newobj (trans));nft_trans_destroy (trans); }else { trans->ctx.table->use--;
Signature · 1 line
2.34.1