Skip to contentSkip to conversation

mtd: rawnand: omap2: Actually prevent invalid configuration and build error

PATCH Applied Roger Quadros 2 participants 2 messages Feb 19, 2022 – Feb 25, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mtd: rawnand: omap2: Actually prevent invalid configuration and build error

The root of the problem is that we are selecting symbols that have dependencies. This can cause random configurations that can fail. The cleanest solution is to avoid using select.

This driver uses interfaces from the OMAP_GPMC driver so we have to depend on it instead.

Fixes 4cd335dae3cf ("mtd: rawnand: omap2: Prevent invalid configuration and build error")
---
 drivers/mtd/nand/raw/Kconfig | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/mtd/nand/raw/Kconfig +1 -2
index 36e697456ec4..9b078e78f3fa 100644
@@ -42,8 +42,7 @@ config MTD_NAND_OMAP2
 	tristate "OMAP2, OMAP3, OMAP4 and Keystone NAND controller"
 	depends on ARCH_OMAP2PLUS || ARCH_KEYSTONE || ARCH_K3 || COMPILE_TEST
 	depends on HAS_IOMEM
-	select MEMORY
-	select OMAP_GPMC
+	depends on OMAP_GPMC
 	help
 	  Support for NAND flash on Texas Instruments OMAP2, OMAP3, OMAP4
 	  and Keystone platforms.
Signature · 6 lines
2.17.1


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
maintainer Applied
#1 lore raw
Quoted 9 lines · Roger Quadros

The root of the problem is that we are selecting symbols that have dependencies. This can cause random configurations that can fail. The cleanest solution is to avoid using select.

This driver uses interfaces from the OMAP_GPMC driver so we have to depend on it instead.

Fixes 4cd335dae3cf ("mtd: rawnand: omap2: Prevent invalid configuration and build error")

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/fixes, thanks.

Miquel