mm/hwpoison: Add in-use hugepage hwpoison filter judgement
Subsystems (2)
PATCH v4 2/2 mm/hwpoison: Add in-use hugepage hwpoison filter judgement
After successfully obtaining the reference count of the huge page, it is still necessary to call hwpoison_filter() to make a filter judgement, otherwise the filter hugepage will be unmaped and the related process may be killed.
Signed-off-by luofei <[email protected]>
--- mm/memory-failure.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
mm/memory-failure.c +11 -0
@@ -1548,6 +1548,17 @@ static int memory_failure_hugetlb(unsigned long pfn, int flags)lock_page (head); page_flags = head->flags; +if (hwpoison_filter (p)) { +if (TestClearPageHWPoison (head)) +num_poisoned_pages_dec (); +put_page (p); +if (flags &MF_MCE_HANDLE ) + res = -EHWPOISON ; +else + res =0 ; + goto out; + } +/* * TODO: hwpoison for pud-sized hugetlb doesn't work right now, so * simply disable it. In order to make it work properly, we need
Signature · 1 line
2.27.0
Quoted 5 lines · luofei
After successfully obtaining the reference count of the huge page, it is still necessary to call
hwpoison_filter()to make a filter judgement, otherwise the filter hugepage will be unmaped and the related process may be killed.
LGTM. Thanks.
Reviewed-by Miaohe Lin <[email protected]>
BTW: It seems there is also another missing call to hwpoison_filter() when we encounter free_buddy_page in memory_failure(). But I'am not sure.
Quoted 28 lines
Signed-off-by luofei <[email protected]>--- mm/memory-failure.c | 11 +++++++++++ 1 file changed, 11 insertions(+)mm/memory-failure.c +11
-0@@ -1548,6 +1548,17 @@ static int memory_failure_hugetlb(unsigned long pfn, int flags)lock_page (head); page_flags = head->flags; +if (hwpoison_filter (p)) { +if (TestClearPageHWPoison (head)) +num_poisoned_pages_dec (); +put_page (p); +if (flags &MF_MCE_HANDLE ) + res = -EHWPOISON ; +else + res =0 ; + goto out; + } +/* * TODO: hwpoison for pud-sized hugetlb doesn't work right now, so * simply disable it. In order to make it work properly, we need