Skip to contentSkip to conversation

ACPI: Fix LAPIC_ADDR_OVR address print

PATCH Superseded Vasant Hegde 2 participants 4 messages Feb 21, 2022 – Mar 17, 2022 ACPI

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ACPI: Fix LAPIC_ADDR_OVR address print

Without fix:

  [    0.005429] ACPI: LAPIC_ADDR_OVR (address[(____ptrval____)])

With fix:

  [    0.005429] ACPI: LAPIC_ADDR_OVR (address[0x800fee00000])
---
 drivers/acpi/tables.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/acpi/tables.c +2 -2
index 0741a4933f62..550e9512534c 100644
@@ -151,8 +151,8 @@ void acpi_table_print_madt_entry(struct acpi_subtable_header *header)
 		{
 			struct acpi_madt_local_apic_override *p =
 			    (struct acpi_madt_local_apic_override *)header;
-			pr_info("LAPIC_ADDR_OVR (address[%p])\n",
-				(void *)(unsigned long)p->address);
+			pr_info("LAPIC_ADDR_OVR (address[0x%llx])\n",
+				p->address);
 		}
 		break;
 
Signature · 1 line
2.27.0
#1 lore raw
Quoted 8 lines · Vasant Hegde

Without fix:

  [    0.005429] ACPI: LAPIC_ADDR_OVR (address[(____ptrval____)])

With fix:

  [    0.005429] ACPI: LAPIC_ADDR_OVR (address[0x800fee00000])

The meaning of this sign-off is unclear.

If this a co-developer sign-off, please use a Co-developed-by tag to clarify that.

Quoted 23 lines
---
 drivers/acpi/tables.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/acpi/tables.c +2 -3
index 0741a4933f62..550e9512534c 100644
@@ -151,8 +151,8 @@ void acpi_table_print_madt_entry(struct acpi_subtable_header *header)
                {
                        struct acpi_madt_local_apic_override *p =
                            (struct acpi_madt_local_apic_override *)header;
-                       pr_info("LAPIC_ADDR_OVR (address[%p])\n",
-                               (void *)(unsigned long)p->address);
+                       pr_info("LAPIC_ADDR_OVR (address[0x%llx])\n",
+                               p->address);
                }
                break;
 
--

2.27.0

#2 lore raw

Rafael,

Quoted 8 lines · Rafael J. Wysocki
Quoted 7 lines · Vasant Hegde

Without fix:

  [    0.005429] ACPI: LAPIC_ADDR_OVR (address[(____ptrval____)])

With fix:

  [    0.005429] ACPI: LAPIC_ADDR_OVR (address[0x800fee00000])
Quoted 6 lines
Quoted 1 line

The meaning of this sign-off is unclear.

If this a co-developer sign-off, please use a Co-developed-by tag to clarify that.

Sorry for that. I missed to add Co-Developed-by tag. Can you please add below line before merging -OR- do you want me to resend the patch?

-Vasant

#3 lore raw

Rafael,

Quoted 14 lines · Vasant Hegde

Rafael,

Quoted 10 lines · Rafael J. Wysocki
Quoted 8 lines · Vasant Hegde

Without fix:

  [    0.005429] ACPI: LAPIC_ADDR_OVR (address[(____ptrval____)])

With fix:

  [    0.005429] ACPI: LAPIC_ADDR_OVR (address[0x800fee00000])
Quoted 7 lines
Quoted 4 lines

The meaning of this sign-off is unclear.

If this a co-developer sign-off, please use a Co-developed-by tag to clarify that.

Sorry for that. I missed to add Co-Developed-by tag. Can you please add below line before merging -OR- do you want me to resend the patch?

I have sent v2 with updated co-developer tag.

Thanks
-Vasant