staging: qlge: add unregister_netdev in qlge_probe
Subsystems (3)
PATCH v3 1/1 staging: qlge: add unregister_netdev in qlge_probe
unregister_netdev need to be called when register_netdev succeeds qlge_health_create_reporters fails.
Fixes d8827ae8e22b ("staging: qlge: deal with the case that devlink_health_reporter_create fails")
Signed-off-by Hangyu Hua <[email protected]>
---
v3: add a Fixed tag
v2: use goto to fix this bug
drivers/staging/qlge/qlge_main.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-)
drivers/staging/qlge/qlge_main.c +7 -4
@@ -4605,14 +4605,12 @@ static int qlge_probe(struct pci_dev *pdev, err =register_netdev (ndev);if (err) {dev_err (&pdev->dev,"net device registration failed.\n" ); -qlge_release_all (pdev); -pci_disable_device (pdev); - goto netdev_free; + goto cleanup_pdev; } err =qlge_health_create_reporters (qdev);if (err) - goto netdev_free; + goto unregister_netdev;/* Start up the timer to trigger EEH if * the bus goes dead
@@ -4626,6 +4624,11 @@ static int qlge_probe(struct pci_dev *pdev,devlink_register (devlink);return 0 ; +unregister_netdev: +unregister_netdev (ndev); +cleanup_pdev: +qlge_release_all (pdev); +pci_disable_device (pdev); netdev_free:free_netdev (ndev); devlink_free:
Signature · 1 line
2.25.1