Skip to contentSkip to conversation

Makefile: unexport 'DEVICE_TREE' environment variable

PATCH Applied Peter Korsgaard 2 participants 2 messages Feb 23, 2022 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Makefile: unexport 'DEVICE_TREE' environment variable

U-Boot looks for the environment variable DEVICE_TREE and uses its value if set instead of the CONFIG_DEFAULT_DEVICE_TREE configuration option since v2021.01, more specifically commit c0f1ebe9c1b9745e (binman: Allow selecting default FIT configuration) - So unexport it like we do for other "troublesome" environment variables to ensure consistent behaviour.

---
 Makefile | 1 +
 1 file changed, 1 insertion(+)
Makefile +1 -0
index d92438166f..0ed93e600d 100644
@@ -426,6 +426,7 @@ unexport O
 unexport GCC_COLORS
 unexport PLATFORM
 unexport OS
+unexport DEVICE_TREE
 
 GNU_HOST_NAME := $(shell support/gnuconfig/config.guess)
 
Signature · 6 lines
2.30.2

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

Peter, All,

On 2022-02-23 13:41 +0100, Peter Korsgaard spake thusly:

Quoted 8 lines

U-Boot looks for the environment variable DEVICE_TREE and uses its value if set instead of the CONFIG_DEFAULT_DEVICE_TREE configuration option since v2021.01, more specifically commit c0f1ebe9c1b9745e (binman: Allow selecting default FIT configuration) - So unexport it like we do for other "troublesome" environment variables to ensure consistent behaviour.

Applied to master, thanks.

Regards,
Yann E. MORIN.

Quoted 23 lines
---
 Makefile | 1 +
 1 file changed, 1 insertion(+)
Makefile +1 -0
index d92438166f..0ed93e600d 100644
@@ -426,6 +426,7 @@ unexport O
 unexport GCC_COLORS
 unexport PLATFORM
 unexport OS
+unexport DEVICE_TREE
 
 GNU_HOST_NAME := $(shell support/gnuconfig/config.guess)
 
Signature · 6 lines
2.30.2

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Signature · 10 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot