clk: lan966x: Depend on CONFIG_IOMEM
Subsystems (2)
PATCH 1/1 clk: lan966x: Depend on CONFIG_IOMEM
The lan966x clk driver depends on IOMEM functions, in particular devm_platform_ioremap_resource(), but doesn't state a formal dependency on it in Kconfig.
Add such a dependency, which prevents this driver from being enabled on UML configurations without IOMEM.
This fixes the following build failure:
/usr/bin/ld: drivers/clk/clk-lan966x.o: in function `lan966x_clk_probe':
clk-lan966x.c:(.text+0x294): undefined reference to devm_platform_ioremap_resource' /usr/bin/ld: clk-lan966x.c:(.text+0x3aa): undefined reference to devm_ioremap_resource'
collect2: error: ld returned 1 exit status
--- drivers/clk/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/clk/Kconfig +1 -0
@@ -231,6 +231,7 @@ config COMMON_CLK_GEMINI config COMMON_CLK_LAN966X bool "Generic Clock Controller driver for LAN966X SoC" + depends on IOMEM help This driver provides support for Generic Clock Controller(GCK) on LAN966X SoC. GCK generates and supplies clock to various peripherals
Signature · 1 line
2.35.1.473.g83b2b277ed-goog
Quoted 25 lines · David Gow
The lan966x clk driver depends on IOMEM functions, in particular
devm_platform_ioremap_resource(), but doesn't state a formal dependency on it inKconfig.Add such a dependency, which prevents this driver from being enabled on UML configurations without IOMEM.
This fixes the following build failure:
/usr/bin/ld:drivers/clk/clk-lan966x.o: in function `lan966x_clk_probe':
clk-lan966x.c:(.text+0x294): undefined reference todevm_platform_ioremap_resource' /usr/bin/ld: clk-lan966x.c:(.text+0x3aa): undefined reference todevm_ioremap_resource'
collect2: error: ld returned 1 exit statusSigned-off-by David Gow <[email protected]>--- drivers/clk/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/clk/Kconfig +0
-0
drivers/clk/Kconfig config COMMON_CLK_GEMINI · line 237
Quoted 7 lines
drivers/clk/Kconfig +1
-0@@ -231,6 +231,7 @@ config COMMON_CLK_GEMINI config COMMON_CLK_LAN966X bool "Generic Clock Controller driver for LAN966X SoC" + depends on IOMEM help This driver provides support for Generic Clock Controller(GCK) on LAN966X SoC. GCK generates and supplies clock to various peripherals
Signature · 7 lines
Anton R. Ivanov https://www.kot-begemot.co.uk/ _______________________________________________ linux-um mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-um
Stephen Boyd
maintainerQuoting David Gow (2022-02-23 19:59:02)
Quoted 24 lines
The lan966x clk driver depends on IOMEM functions, in particular
devm_platform_ioremap_resource(), but doesn't state a formal dependency on it inKconfig.Add such a dependency, which prevents this driver from being enabled on UML configurations without IOMEM.
This fixes the following build failure:
/usr/bin/ld:drivers/clk/clk-lan966x.o: in function `lan966x_clk_probe':
clk-lan966x.c:(.text+0x294): undefined reference todevm_platform_ioremap_resource' /usr/bin/ld: clk-lan966x.c:(.text+0x3aa): undefined reference todevm_ioremap_resource'
collect2: error: ld returned 1 exit statusSigned-off-by David Gow <[email protected]>--- drivers/clk/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/clk/Kconfig +0
-0
drivers/clk/Kconfig config COMMON_CLK_GEMINI · line 234
Quoted 4 lines
drivers/clk/Kconfig +1
-0@@ -231,6 +231,7 @@ config COMMON_CLK_GEMINI config COMMON_CLK_LAN966X bool "Generic Clock Controller driver for LAN966X SoC" + depends on IOMEM
What is CONFIG_IOMEM? This is superseded by
https://lore.kernel.org/r/[email protected]
drivers/clk/Kconfig config COMMON_CLK_GEMINI · line 237
Quoted 3 lines
drivers/clk/Kconfig +0
-0help This driver provides support for Generic Clock Controller(GCK) on LAN966X SoC. GCK generates and supplies clock to various peripherals
_______________________________________________
linux-um mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-um
Quoted 27 lines · Stephen Boyd
Quoting David Gow (2022-02-23 19:59:02)
Quoted 25 lines
The lan966x clk driver depends on IOMEM functions, in particular
devm_platform_ioremap_resource(), but doesn't state a formal dependency on it inKconfig.Add such a dependency, which prevents this driver from being enabled on UML configurations without IOMEM.
This fixes the following build failure:
/usr/bin/ld:drivers/clk/clk-lan966x.o: in function `lan966x_clk_probe':
clk-lan966x.c:(.text+0x294): undefined reference todevm_platform_ioremap_resource' /usr/bin/ld: clk-lan966x.c:(.text+0x3aa): undefined reference todevm_ioremap_resource'
collect2: error: ld returned 1 exit statusSigned-off-by David Gow <[email protected]>--- drivers/clk/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/clk/Kconfig +0
-0@@ -231,6 +231,7 @@ config COMMON_CLK_GEMINI
Quoted 7 lines
drivers/clk/Kconfig config COMMON_CLK_GEMINI · line 234
Quoted 3 lines
drivers/clk/Kconfig +1
-0config COMMON_CLK_LAN966X bool "Generic Clock Controller driver for LAN966X SoC" + depends on IOMEMWhat is
CONFIG_IOMEM? This is superseded by
https://lore.kernel.org/r/[email protected]
Whoops, thanks! If I had a nickel every time I forgot the "HAS" in "CONFIG_HAS_IOMEM"...
This patch indeed is no-longer needed in clk-fixes, so let's abandon it here.
Cheers,
-- David
Quoted 3 lines
Quoted 3 lines
drivers/clk/Kconfig +0
-0help This driver provides support for Generic Clock Controller(GCK) on LAN966X SoC. GCK generates and supplies clock to various peripherals