Skip to contentSkip to conversation

USB: serial: simple: add Nokia phone driver

PATCH Superseded Johan Hovold 3 participants 4 messages Feb 24, 2022 – Feb 27, 2022

Subsystems (3)
Stable branch USB USB serial

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Johan Hovold

author maintainer
#0 lore raw

PATCH 1/1 USB: serial: simple: add Nokia phone driver

Add a new "simple" driver for certain Nokia phones, including Nokia 130 (RM-1035) which exposes two serial ports in "charging only" mode.

Reported-by Felix Becker <[email protected]>
Link https://lore.kernel.org/r/[email protected] open here
Cc [email protected]
Signed-off-by Johan Hovold <[email protected]>
---
 drivers/usb/serial/Kconfig             | 1 +
 drivers/usb/serial/usb-serial-simple.c | 7 +++++++
 2 files changed, 8 insertions(+)
drivers/usb/serial/Kconfig +1 -0
index de5c01257060..ef8d1c73c754 100644
@@ -66,6 +66,7 @@ config USB_SERIAL_SIMPLE
 		- Libtransistor USB console
 		- a number of Motorola phones
 		- Motorola Tetra devices
+		- Nokia mobile phones
 		- Novatel Wireless GPS receivers
 		- Siemens USB/MPI adapter.
 		- ViVOtech ViVOpay USB device.
drivers/usb/serial/usb-serial-simple.c +7 -0
index bd23a7cb1be2..c95dfe4a6f0f 100644
@@ -91,6 +91,11 @@ DEVICE(moto_modem, MOTO_IDS);
 	{ USB_DEVICE(0x0cad, 0x9016) }	/* TPG2200 */
 DEVICE(motorola_tetra, MOTOROLA_TETRA_IDS);
 
+/* Nokia mobile phone driver */
+#define NOKIA_IDS()			\
+	{ USB_DEVICE(0x0421, 0x069a) }	/* Nokia 130 (RM-1035) */
+DEVICE_N(nokia, NOKIA_IDS, 2);
+
 /* Novatel Wireless GPS driver */
 #define NOVATEL_IDS()			\
 	{ USB_DEVICE(0x09d7, 0x0100) }	/* NovAtel FlexPack GPS */

@@ -123,6 +128,7 @@ static struct usb_serial_driver * const serial_drivers[] = {
 	&vivopay_device,
 	&moto_modem_device,
 	&motorola_tetra_device,
+	&nokia_device,
 	&novatel_gps_device,
 	&hp4x_device,
 	&suunto_device,

@@ -140,6 +146,7 @@ static const struct usb_device_id id_table[] = {
 	VIVOPAY_IDS(),
 	MOTO_IDS(),
 	MOTOROLA_TETRA_IDS(),
+	NOKIA_IDS(),
 	NOVATEL_IDS(),
 	HP4X_IDS(),
 	SUUNTO_IDS(),
Signature · 1 line
2.34.1
#2 lore raw
In reply to Johan Hovold

Dear Johan,
dear people.

I see that this includes my email address publicly in a non-obfuscated form, and this is also available freely on the web at
https://lore.kernel.org/r/[email protected].

I do not want to have my Email address publicly available (e.g. against automated email address harvesting).

According to the GPDR, I want that you remove my email address from the patch before it is published somewhere on the web or/and in downloadable source code (if already done, I wish that it get's removed from everything published), and that you remove it from publicly accessible email list archives.

Please confirm back to me when you have done that, or please refer to me whom I should contact to get my email address removed.

Regards!

On Thu, 24 Feb 2022 14:31:09 +0100, Johan Hovold <[email protected]> wrote about "[PATCH] USB: serial: simple: add Nokia phone driver":

Quoted 56 lines

Add a new "simple" driver for certain Nokia phones, including Nokia 130 (RM-1035) which exposes two serial ports in "charging only" mode.

Reported-by Felix Becker <[email protected]>
Link https://lore.kernel.org/r/[email protected] open here
Cc [email protected]
Signed-off-by Johan Hovold <[email protected]>
---
 drivers/usb/serial/Kconfig             | 1 +
 drivers/usb/serial/usb-serial-simple.c | 7 +++++++
 2 files changed, 8 insertions(+)
drivers/usb/serial/Kconfig +1 -0
index de5c01257060..ef8d1c73c754 100644
@@ -66,6 +66,7 @@ config USB_SERIAL_SIMPLE
 		- Libtransistor USB console
 		- a number of Motorola phones
 		- Motorola Tetra devices
+		- Nokia mobile phones
 		- Novatel Wireless GPS receivers
 		- Siemens USB/MPI adapter.
 		- ViVOtech ViVOpay USB device.
(quoted diff) +0 -0

b/drivers/usb/serial/usb-serial-simple.c index bd23a7cb1be2..c95dfe4a6f0f 100644 --- a/drivers/usb/serial/usb-serial-simple.c +++ b/drivers/usb/serial/usb-serial-simple.c @@ -91,6 +91,11 @@ DEVICE(moto_modem, MOTO_IDS); { USB_DEVICE(0x0cad, 0x9016) } /* TPG2200 */ DEVICE(motorola_tetra, MOTOROLA_TETRA_IDS);

drivers/usb/serial/usb-serial-simple.c +3 -0
+/* Nokia mobile phone driver */
+#define NOKIA_IDS()			\
+	{ USB_DEVICE(0x0421, 0x069a) }	/* Nokia 130 (RM-1035)

*/ +DEVICE_N(nokia, NOKIA_IDS, 2);

drivers/usb/serial/usb-serial-simple.c +1 -0
+
 /* Novatel Wireless GPS driver */
 #define NOVATEL_IDS()			\
 	{ USB_DEVICE(0x09d7, 0x0100) }	/* NovAtel FlexPack

GPS */ @@ -123,6 +128,7 @@ static struct usb_serial_driver * const serial_drivers[] = { &vivopay_device,

drivers/usb/serial/usb-serial-simple.c +2 -0
 	&moto_modem_device,
 	&motorola_tetra_device,
+	&nokia_device,
 	&novatel_gps_device,
 	&hp4x_device,
 	&suunto_device,

@@ -140,6 +146,7 @@ static const struct usb_device_id id_table[] = {
 	VIVOPAY_IDS(),
 	MOTO_IDS(),
 	MOTOROLA_TETRA_IDS(),
+	NOKIA_IDS(),
 	NOVATEL_IDS(),
 	HP4X_IDS(),
 	SUUNTO_IDS(),
Signature · 1 line
Machen ist wie wollen, nur krasser.
maintainer
#3 lore raw
Quoted 10 lines · Felix Becker

Dear Johan,
dear people.

I see that this includes my email address publicly in a non-obfuscated form, and this is also available freely on the web at
https://lore.kernel.org/r/[email protected].

I do not want to have my Email address publicly available (e.g. against automated email address harvesting).

Quoted 8 lines

According to the GPDR, I want that you remove my email address from the patch before it is published somewhere on the web or/and in downloadable source code (if already done, I wish that it get's removed from everything published), and that you remove it from publicly accessible email list archives.

Please confirm back to me when you have done that, or please refer to me whom I should contact to get my email address removed.

When sending a message to a public mailing list, the GPDR does not come into play, sorry. There's nothing we can do here.

thanks,

greg k-h