Skip to contentSkip to conversation

remove extra blank line at eof

PATCH In review Stephen Hemminger 2 participants 5 messages Feb 25, 2022 – Feb 27, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 remove extra blank line at eof

These source files all had unnecessary blank line at end of file.

---
 drivers/common/iavf/iavf_adminq.c     | 1 -
 drivers/common/mlx5/mlx5_common_log.h | 1 -
 drivers/net/cxgbe/smt.h               | 1 -
 drivers/net/dpaa2/mc/dpni.c           | 1 -
 drivers/net/hinic/hinic_pmd_flow.c    | 1 -
 drivers/net/iavf/iavf_generic_flow.c  | 1 -
 drivers/net/ionic/ionic_ethdev.h      | 1 -
 drivers/net/ionic/ionic_mac_api.c     | 1 -
 drivers/net/mlx5/linux/meson.build    | 1 -
 drivers/net/mlx5/mlx5_flow_dv.c       | 1 -
 drivers/net/mlx5/mlx5_rx.c            | 1 -
 drivers/net/netvsc/meson.build        | 1 -
 drivers/net/nfp/nfp_rxtx.h            | 1 -
 drivers/net/ngbe/ngbe_ptypes.c        | 1 -
 drivers/net/octeontx_ep/meson.build   | 1 -
 drivers/net/octeontx_ep/otx2_ep_vf.h  | 1 -
 drivers/net/txgbe/txgbe_flow.c        | 1 -
 drivers/net/txgbe/txgbe_ptypes.c      | 1 -
 drivers/net/txgbe/txgbe_rxtx.c        | 1 -
 drivers/regex/cn9k/meson.build        | 1 -
 lib/ethdev/ethdev_driver.c            | 1 -
 lib/ethdev/ethdev_private.c           | 1 -
 22 files changed, 22 deletions(-)
drivers/common/iavf/iavf_adminq.c +0 -1
index 9c36e8908e59..8b305c0fe3eb 100644
@@ -963,4 +963,3 @@ enum iavf_status iavf_clean_arq_element(struct iavf_hw *hw,
 
 	return ret_code;
 }
-
drivers/common/mlx5/mlx5_common_log.h +0 -1
index 26b13fedaf2e..cabae3866b58 100644
@@ -18,4 +18,3 @@ extern int mlx5_common_logtype;
 		PMD_DRV_LOG_CPAREN)
 
 #endif /* RTE_PMD_MLX5_COMMON_LOG_H_ */
-
drivers/net/cxgbe/smt.h +0 -1
index e6e8aea964e1..a70e3a208575 100644
@@ -42,4 +42,3 @@ struct smt_entry *cxgbe_smt_alloc_switching(struct rte_eth_dev *dev, u8 *smac);
 void cxgbe_smt_release(struct smt_entry *e);
 
 #endif  /* __CXGBE_SMT_H_ */
-
drivers/net/dpaa2/mc/dpni.c +0 -1
index 7a2bc15eb4da..c5cc9302f987 100644
@@ -3118,4 +3118,3 @@ int dpni_set_port_cfg(struct fsl_mc_io *mc_io, uint32_t cmd_flags,
 	/* send command to MC */
 	return mc_send_command(mc_io, &cmd);
 }
-
drivers/net/hinic/hinic_pmd_flow.c +0 -1
index 2cf24ebcf64e..358b372e07e8 100644
@@ -3311,4 +3311,3 @@ const struct rte_flow_ops hinic_flow_ops = {
 	.destroy = hinic_flow_destroy,
 	.flush = hinic_flow_flush,
 };
-
drivers/net/iavf/iavf_generic_flow.c +0 -1
index 2befa125ac90..d1abcbd54266 100644
@@ -2334,4 +2334,3 @@ iavf_flow_query(struct rte_eth_dev *dev,
 	}
 	return ret;
 }
-
drivers/net/ionic/ionic_ethdev.h +0 -1
index 652f28c97d57..9304e170dec3 100644
@@ -23,4 +23,3 @@
 int ionic_dev_link_update(struct rte_eth_dev *eth_dev, int wait_to_complete);
 
 #endif /* _IONIC_ETHDEV_H_ */
-
drivers/net/ionic/ionic_mac_api.c +0 -1
index c0ea042bc5d0..411d84b57806 100644
@@ -60,4 +60,3 @@ ionic_set_mac_type(struct ionic_hw *hw)
 
 	return err;
 }
-
drivers/net/mlx5/linux/meson.build +0 -1
index 553024135601..e541d25c183d 100644
@@ -11,4 +11,3 @@ sources += files(
         'mlx5_vlan_os.c',
         'mlx5_flow_os.c',
 )
-
drivers/net/mlx5/mlx5_flow_dv.c +0 -1
index ef9c66eddf06..b430754ea918 100644
@@ -18284,4 +18284,3 @@ const struct mlx5_flow_driver_ops mlx5_flow_dv_drv_ops = {
 };
 
 #endif /* HAVE_IBV_FLOW_DV_SUPPORT */
-
drivers/net/mlx5/mlx5_rx.c +0 -1
index 11ea935d72f0..e5eea0ad949e 100644
@@ -1187,4 +1187,3 @@ mlx5_check_vec_rx_support(struct rte_eth_dev *dev __rte_unused)
 {
 	return -ENOTSUP;
 }
-
drivers/net/netvsc/meson.build +0 -1
index 399400dd0114..bb6225d05a10 100644
@@ -15,4 +15,3 @@ sources = files(
         'hn_rxtx.c',
         'hn_vf.c',
 )
-
drivers/net/nfp/nfp_rxtx.h +0 -1
index 1a813ded1539..dec1857da384 100644
@@ -299,4 +299,3 @@ uint16_t nfp_net_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,
  * indent-tabs-mode: t
  * End:
  */
-
drivers/net/ngbe/ngbe_ptypes.c +0 -1
index d6d82105c975..33f20e924720 100644
@@ -297,4 +297,3 @@ u8 ngbe_encode_ptype(u32 ptype)
 
 	return ptid;
 }
-
drivers/net/octeontx_ep/meson.build +0 -1
index b15646b82a47..957e8fc48a29 100644
@@ -8,4 +8,3 @@ sources = files(
         'otx_ep_vf.c',
         'otx2_ep_vf.c',
 )
-
drivers/net/octeontx_ep/otx2_ep_vf.h +0 -1
index dc720368abf1..757eeae9f007 100644
@@ -139,4 +139,3 @@ struct otx2_ep_instr_64B {
 };
 
 #endif /*_OTX2_EP_VF_H_ */
-
drivers/net/txgbe/txgbe_flow.c +0 -1
index 6d7fd1842843..d0093c0163d2 100644
@@ -3150,4 +3150,3 @@ const struct rte_flow_ops txgbe_flow_ops = {
 	.destroy = txgbe_flow_destroy,
 	.flush = txgbe_flow_flush,
 };
-
drivers/net/txgbe/txgbe_ptypes.c +0 -1
index 0ed757d820e2..e1299d736372 100644
@@ -672,4 +672,3 @@ txgbe_ptype_table_tn[TXGBE_PTID_MAX] __rte_cache_aligned = {
 		RTE_PTYPE_TUNNEL_VXLAN | RTE_PTYPE_INNER_L2_ETHER |
 		RTE_PTYPE_INNER_L3_IPV4_EXT | RTE_PTYPE_INNER_L4_UDP,
 };
-
drivers/net/txgbe/txgbe_rxtx.c +0 -1
index 35b77cb271ba..ac1bba08a337 100644
@@ -5108,4 +5108,3 @@ txgbe_config_rss_filter(struct rte_eth_dev *dev,
 
 	return 0;
 }
-
drivers/regex/cn9k/meson.build +0 -1
index bb0504fba12c..06c906710c7e 100644
@@ -22,4 +22,3 @@ sources = files(
 
 deps += ['bus_pci', 'regexdev']
 deps += ['common_cnxk', 'mempool_cnxk']
-
lib/ethdev/ethdev_driver.c +0 -1
index 7184e0a6579a..a285f213f0a8 100644
@@ -767,4 +767,3 @@ rte_eth_switch_domain_free(uint16_t domain_id)
 
 	return 0;
 }
-
lib/ethdev/ethdev_private.c +0 -1
index 84dc0b320ed0..48090c879af3 100644
@@ -432,4 +432,3 @@ eth_dev_tx_queue_config(struct rte_eth_dev *dev, uint16_t nb_queues)
 	dev->data->nb_tx_queues = nb_queues;
 	return 0;
 }
-
Signature · 1 line
2.34.1
#1 lore raw

PATCH 2/2 examples: add missing newline at eof

The text file did not end with newline.

---
 examples/flow_classify/ipv4_rules_file.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
examples/flow_classify/ipv4_rules_file.txt +1 -1
index dfa0631fcc09..cd5215736aaf 100644
@@ -11,4 +11,4 @@
 6.7.8.9/16 192.168.0.36/16 10 : 0xffff 11 : 0xffff 6/0xfe 7
 6.7.8.9/8 192.168.0.36/8 10 : 0xffff 11 : 0xffff 6/0xfe 8
 #error rules
-#9.8.7.6/8 192.168.0.36/8 10 : 0xffff 11 : 0xffff 6/0xfe 9
\ No newline at end of file
+#9.8.7.6/8 192.168.0.36/8 10 : 0xffff 11 : 0xffff 6/0xfe 9
Signature · 1 line
2.34.1
#2 lore raw

Re: [PATCH 2/2] examples: add missing newline at eof

25/02/2022 18:47, Stephen Hemminger:

Quoted 3 lines

The text file did not end with newline.

Series applied, thanks for the cleanup.

Could we add a check in checkpatch to avoid it in future?

#3 lore raw

Re: [PATCH 2/2] examples: add missing newline at eof

Quoted 10 lines · On Sun, 27 Feb 2022 21:27:40 +0100 Thomas Monjalon <[email protected]> wrote:

25/02/2022 18:47, Stephen Hemminger:

Quoted 3 lines

The text file did not end with newline.

Series applied, thanks for the cleanup.

Could we add a check in checkpatch to avoid it in future?

The only tool I saw to find these was
pcregrep -LMr '\n\Z'

But probably possible with a complex python one-liner...

#4 lore raw

Re: [PATCH 2/2] examples: add missing newline at eof

27/02/2022 22:32, Stephen Hemminger:

Quoted 8 lines
Quoted 5 lines · On Sun, 27 Feb 2022 21:27:40 +0100 Thomas Monjalon <[email protected]> wrote:

25/02/2022 18:47, Stephen Hemminger:

Quoted 3 lines

The text file did not end with newline.

Quoted 8 lines
Quoted 3 lines

Series applied, thanks for the cleanup.

Could we add a check in checkpatch to avoid it in future?

The only tool I saw to find these was
pcregrep -LMr '\n\Z'

But probably possible with a complex python one-liner...

It can be done with diff:
diff /dev/null $file | tail -1 | grep '^\\ No newline'