KVM: arm64: Enable Cortex-A510 erratum 2077057 by default
PATCH 1/1 KVM: arm64: Enable Cortex-A510 erratum 2077057 by default
The recently added configuration option for Cortex A510 erratum 2077057 does not have a "default y" unlike other errata fixes. This appears to simply be an oversight since the help text suggests enabling the option if unsure and there's nothing in the commit log to suggest it is intentional.
--- arch/arm64/Kconfig | 1 + 1 file changed, 1 insertion(+)
arch/arm64/Kconfig +1 -0
@@ -685,6 +685,7 @@ config ARM64_ERRATUM_2051678 config ARM64_ERRATUM_2077057 bool "Cortex-A510: 2077057: workaround software-step corrupting SPSR_EL2" + default y help This option adds the workaround for ARM Cortex-A510 erratum 2077057. Affected Cortex-A510 may corrupt SPSR_EL2 when the a step exception is
Signature · 6 lines
2.30.2 _______________________________________________ kvmarm mailing list [email protected] https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
Quoted 7 lines · Mark Brown
The recently added configuration option for Cortex A510 erratum 2077057 does not have a "default y" unlike other errata fixes. This appears to simply be an oversight since the help text suggests enabling the option if unsure and there's nothing in the commit log to suggest it is intentional.
Fixes 1dd498e5e26ad ("KVM: arm64: Workaround Cortex-A510's single-step and PAC trap errata")Signed-off-by Mark Brown <[email protected]>
The fixed commit went in through Marc's KVM tree, so this patch can go in via the same route. I don't think it's critical for 5.17 (unless there are pending fixes from Marc already; I don't have any for arm64).
_______________________________________________
kvmarm mailing list
[email protected]
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
Marc Zyngier
maintainerQuoted 7 lines · Catalin Marinas
Quoted 5 lines · Mark Brown
The recently added configuration option for Cortex A510 erratum 2077057 does not have a "default y" unlike other errata fixes. This appears to simply be an oversight since the help text suggests enabling the option if unsure and there's nothing in the commit log to suggest it is intentional.
Quoted 6 lines
Quoted 2 lines
Fixes 1dd498e5e26ad ("KVM: arm64: Workaround Cortex-A510's single-step and PAC trap errata")Signed-off-by Mark Brown <[email protected]>The fixed commit went in through Marc's KVM tree, so this patch can go in via the same route. I don't think it's critical for 5.17 (unless there are pending fixes from Marc already; I don't have any for arm64).
I don't have anything at the moment, so unless something really urgent crops up next week, I'll punt that to 5.18.
Thanks,
M.
Signature · 5 lines
Without deviation from the norm, progress is not possible. _______________________________________________ kvmarm mailing list [email protected] https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
Quoted 4 lines · Mark Brown
The recently added configuration option for Cortex A510 erratum 2077057 does not have a "default y" unlike other errata fixes. This appears to simply be an oversight since the help text suggests enabling the option if unsure and there's nothing in the commit log to suggest it is intentional.
Applied to next, thanks!
[1/1] KVM: arm64: Enable Cortex-A510 erratum 2077057 by default
commit: 4c11113c1a3d10f5b617e5d2b9acd8d1d715450f
Cheers,
M.
Signature · 7 lines
Without deviation from the norm, progress is not possible. _______________________________________________ kvmarm mailing list [email protected] https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
Quoted 7 lines · Mark Brown
The recently added configuration option for Cortex A510 erratum 2077057 does not have a "default y" unlike other errata fixes. This appears to simply be an oversight since the help text suggests enabling the option if unsure and there's nothing in the commit log to suggest it is intentional.
Fixes 1dd498e5e26ad ("KVM: arm64: Workaround Cortex-A510's single-step and PAC trap errata")Signed-off-by Mark Brown <[email protected]>
I don't think Will picked this up, so:
_______________________________________________
kvmarm mailing list
[email protected]
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
Catalin Marinas
maintainerQuoted 6 lines · Catalin Marinas
Quoted 5 lines · Mark Brown
The recently added configuration option for Cortex A510 erratum 2077057 does not have a "default y" unlike other errata fixes. This appears to simply be an oversight since the help text suggests enabling the option if unsure and there's nothing in the commit log to suggest it is intentional.
Quoted 6 lines
Quoted 2 lines
Fixes 1dd498e5e26ad ("KVM: arm64: Workaround Cortex-A510's single-step and PAC trap errata")Signed-off-by Mark Brown <[email protected]>I don't think Will picked this up, so:
Reviewed-by Catalin Marinas <[email protected]>
Ah, I should call it a day. I already acked this patch and Marc queued it.
Signature · 5 lines
Catalin _______________________________________________ kvmarm mailing list [email protected] https://lists.cs.columbia.edu/mailman/listinfo/kvmarm