Skip to contentSkip to conversation

clk: Consolidate some clock functions

PATCH Applied Sean Anderson 1 participant 2 messages Feb 27, 2022 – Mar 30, 2022 Common clk

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 clk: Consolidate some clock functions

These functions are exactly the same as their "nodev" varients, except they accept a device and not an ofnode. Rewrite them to just call the other function.

---

 drivers/clk/clk-uclass.c | 22 ++--------------------
 1 file changed, 2 insertions(+), 20 deletions(-)
drivers/clk/clk-uclass.c +2 -20
index c20c928bf1..4ab876517a 100644
@@ -138,14 +138,7 @@ static int clk_get_by_indexed_prop(struct udevice *dev, const char *prop_name,
 
 int clk_get_by_index(struct udevice *dev, int index, struct clk *clk)
 {
-	struct ofnode_phandle_args args;
-	int ret;
-
-	ret = dev_read_phandle_with_args(dev, "clocks", "#clock-cells", 0,
-					 index, &args);
-
-	return clk_get_by_index_tail(ret, dev_ofnode(dev), &args, "clocks",
-				     index, clk);
+	return clk_get_by_index_nodev(dev_ofnode(dev), index, clk);
 }
 
 int clk_get_by_index_nodev(ofnode node, int index, struct clk *clk)
@@ -400,18 +393,7 @@ int clk_set_defaults(struct udevice *dev, enum clk_defaults_stage stage)
 
 int clk_get_by_name(struct udevice *dev, const char *name, struct clk *clk)
 {
-	int index;
-
-	debug("%s(dev=%p, name=%s, clk=%p)\n", __func__, dev, name, clk);
-	clk->dev = NULL;
-
-	index = dev_read_stringlist_search(dev, "clock-names", name);
-	if (index < 0) {
-		debug("fdt_stringlist_search() failed: %d\n", index);
-		return index;
-	}
-
-	return clk_get_by_index(dev, index, clk);
+	return clk_get_by_name_nodev(dev_ofnode(dev), name, clk);
 }
 #endif /* OF_REAL */
 
Signature · 1 line
2.34.1
author Applied
#1 lore raw
Quoted 5 lines · Sean Anderson

These functions are exactly the same as their "nodev" varients, except they accept a device and not an ofnode. Rewrite them to just call the other function.

Applied, thanks!

[1/1] clk: Consolidate some clock functions

      commit: e7075ff7b3dce82e4fd6246b87f3c44fabf6323b

Best regards,

Signature · 1 line
Sean Anderson <[email protected]>