Skip to contentSkip to conversation

Add kernel-shark plug and libtraceevent plugin

PATCH Superseded Hongzhan Chen 2 participants 14 messages Feb 28, 2022 – Mar 1, 2022 Kbuild

v1 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

cover Add kernel-shark plug and libtraceevent plugin

1. Add kernel-shark plugin to visualize OOB state of xenomai realtime thread.
2. Add libtraceevent plugin to parse xenomai_schedparams correctly
3. build: Add c++ build support to build kernel-shark plugin
4. Add --with-kernelshark option to build plugins in userland.

Hongzhan Chen (4):
build: Add c++ build support
Kernel-shark: Add xenomai_cobalt_switch_events plugin for kernel-shark Add --with-kernelshark option
libtraceevent: Add Add xenomai_schedparams plugin for libtraceevent

 Makefile.am                                   |   6 +
 configure.ac                                  |  29 +++
 kernel-shark/Makefile.am                      |   8 +
 .../kernelshark/CobaltSwitchEvents.cpp        | 156 ++++++++++++++
 kernel-shark/kernelshark/Makefile.am          |  18 ++
 kernel-shark/kernelshark/README               |  75 +++++++
 .../xenomai_cobalt_switch_events.c            | 174 +++++++++++++++
 .../xenomai_cobalt_switch_events.h            |  58 +++++
 kernel-shark/libtraceevent/Makefile.am        |  10 +
 kernel-shark/libtraceevent/README             |  30 +++
 .../plugin_xenomai_schedparams.c              | 201 ++++++++++++++++++
 11 files changed, 765 insertions(+)
 create mode 100644 kernel-shark/Makefile.am
 create mode 100644 kernel-shark/kernelshark/CobaltSwitchEvents.cpp
 create mode 100644 kernel-shark/kernelshark/Makefile.am
 create mode 100644 kernel-shark/kernelshark/README
 create mode 100644 kernel-shark/kernelshark/xenomai_cobalt_switch_events.c
 create mode 100644 kernel-shark/kernelshark/xenomai_cobalt_switch_events.h
 create mode 100644 kernel-shark/libtraceevent/Makefile.am
 create mode 100644 kernel-shark/libtraceevent/README
 create mode 100644 kernel-shark/libtraceevent/plugin_xenomai_schedparams.c
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/4 build: Add c++ build support

Add c++ build support or use specific c++ compiler

---
 configure.ac | 12 ++++++++++++
 1 file changed, 12 insertions(+)
configure.ac +12 -0
index 0389cf008..16cffd8f8 100644
@@ -79,6 +79,18 @@ AC_ARG_WITH(cc,
     ])
 AC_PROG_CC
 
+AC_ARG_WITH(cxx,
+    AS_HELP_STRING([--with-cxx=compiler],[use specific C++ compiler]),
+    [
+	case "$withval" in
+	"" | y | ye | yes | n | no)
+	    AC_MSG_ERROR([You must supply an argument to --with-cxx])
+	  ;;
+	esac
+	CXX="$withval"
+    ])
+AC_PROG_CXX
+
 # Do not let autoconf set the default value of CFLAGS
 if $XENO_EMPTY_CFLAGS; then
 	CFLAGS=""
Signature · 1 line
2.17.1
#2 lore raw

Re: [PATCH 1/4] build: Add c++ build support

Quoted 20 lines · Hongzhan Chen

Add c++ build support or use specific c++ compiler

---
 configure.ac | 12 ++++++++++++
 1 file changed, 12 insertions(+)
configure.ac +5 -0
index 0389cf008..16cffd8f8 100644
@@ -79,6 +79,18 @@ AC_ARG_WITH(cc,
     ])
 AC_PROG_CC
 
+AC_ARG_WITH(cxx,
+    AS_HELP_STRING([--with-cxx=compiler],[use specific C++ compiler]),
+    [
+	case "$withval" in
+	"" | y | ye | yes | n | no)

configure.ac AC_ARG_WITH(cc, · line 96

Quoted 10 lines
configure.ac +7 -0
+	    AC_MSG_ERROR([You must supply an argument to --with-cxx])
+	  ;;
+	esac
+	CXX="$withval"
+    ])
+AC_PROG_CXX
+
 # Do not let autoconf set the default value of CFLAGS
 if $XENO_EMPTY_CFLAGS; then
 	CFLAGS=""

Will that make a C++ compiler mandatory for the build? Or only when pulling in KernelShark support?

Jan

Signature · 2 lines
Siemens AG, Technology
Competence Center Embedded Linux
#3 lore raw

RE: [PATCH 1/4] build: Add c++ build support

Quoted 31 lines

-----Original Message-----
From: Jan Kiszka <[email protected]>
Sent: Tuesday, March 1, 2022 3:31 PM
To: Chen, Hongzhan <[email protected]>; [email protected]
Subject: Re: [PATCH 1/4] build: Add c++ build support

Quoted 24 lines · Hongzhan Chen

Add c++ build support or use specific c++ compiler

---
 configure.ac | 12 ++++++++++++
 1 file changed, 12 insertions(+)
configure.ac +9 -0
index 0389cf008..16cffd8f8 100644
@@ -79,6 +79,18 @@ AC_ARG_WITH(cc,
     ])
 AC_PROG_CC
 
+AC_ARG_WITH(cxx,
+    AS_HELP_STRING([--with-cxx=compiler],[use specific C++ compiler]),
+    [
+	case "$withval" in
+	"" | y | ye | yes | n | no)
+	    AC_MSG_ERROR([You must supply an argument to --with-cxx])
+	  ;;
+	esac
+	CXX="$withval"
Quoted 8 lines

configure.ac AC_ARG_WITH(cc, · line 96

Quoted 6 lines
configure.ac +3 -0
+    ])
+AC_PROG_CXX
+
 # Do not let autoconf set the default value of CFLAGS
 if $XENO_EMPTY_CFLAGS; then
 	CFLAGS=""

Will that make a C++ compiler mandatory for the build? Or only when

No. According to description of sector 6.2 of [1], libtool tries to automatically infer what tag to use from the compiler command being used to compile or link. CC is the default tag. In our case, only kernelshark would use CXX.

[1]: https://www.gnu.org/software/libtool/manual/libtool.html#C_002b_002b-libraries

Regards

Hongzhan Chen

Quoted 8 lines

pulling in KernelShark support?

Jan

Signature · 2 lines
Siemens AG, Technology
Competence Center Embedded Linux
#4 lore raw

Re: [PATCH 1/4] build: Add c++ build support

Quoted 40 lines · Hongzhan
Quoted 31 lines

-----Original Message-----
From: Jan Kiszka <[email protected]>
Sent: Tuesday, March 1, 2022 3:31 PM
To: Chen, Hongzhan <[email protected]>; [email protected]
Subject: Re: [PATCH 1/4] build: Add c++ build support

Quoted 24 lines · Hongzhan Chen

Add c++ build support or use specific c++ compiler

---
 configure.ac | 12 ++++++++++++
 1 file changed, 12 insertions(+)
configure.ac +9 -0
index 0389cf008..16cffd8f8 100644
@@ -79,6 +79,18 @@ AC_ARG_WITH(cc,
     ])
 AC_PROG_CC
 
+AC_ARG_WITH(cxx,
+    AS_HELP_STRING([--with-cxx=compiler],[use specific C++ compiler]),
+    [
+	case "$withval" in
+	"" | y | ye | yes | n | no)
+	    AC_MSG_ERROR([You must supply an argument to --with-cxx])
+	  ;;
+	esac
+	CXX="$withval"
Quoted 8 lines

configure.ac AC_ARG_WITH(cc, · line 96

Quoted 6 lines
configure.ac +3 -0
+    ])
+AC_PROG_CXX
+
 # Do not let autoconf set the default value of CFLAGS
 if $XENO_EMPTY_CFLAGS; then
 	CFLAGS=""

Will that make a C++ compiler mandatory for the build? Or only when

Quoted 6 lines

No. According to description of sector 6.2 of [1], libtool tries to automatically infer what tag to use from the compiler command being used to compile or link. CC is the default tag. In our case, only kernelshark would use CXX.

[1]: https://www.gnu.org/software/libtool/manual/libtool.html#C_002b_002b-libraries

Perfect, thanks for clarifying!

Jan

Signature · 2 lines
Siemens AG, Technology
Competence Center Embedded Linux
#5 lore raw

PATCH 2/4 Kernel-shark: Add xenomai_cobalt_switch_events plugin for kernel-shark

In reply to Hongzhan Chen

For Xenomai-cobalt enabled system, cobalt_switch_context means that there is schedule and context switch in companion core(realtime core), which we may need to do special treatment and take correct action as main kernel sched_switch to visualize out-of-band state of realtime tasks running in cobalt core. To achive our target, we implement following:

1. store corresponding cobalt_switch_context events into container data.
2. modify pid stored in entry to be equal to next_pid to show correct color in cpu bar when cobalt_switch_context event happen.
3. show blue hollow box to mark out-of-band state according to cobalt_switch_context events.
4. clickable cobalt_switch_context plugin shapes.

---
 kernel-shark/Makefile.am                      |   6 +
 .../kernelshark/CobaltSwitchEvents.cpp        | 156 ++++++++++++++++
 kernel-shark/kernelshark/Makefile.am          |  18 ++
 kernel-shark/kernelshark/README               |  75 ++++++++
 .../xenomai_cobalt_switch_events.c            | 174 ++++++++++++++++++
 .../xenomai_cobalt_switch_events.h            |  58 ++++++
 6 files changed, 487 insertions(+)
 create mode 100644 kernel-shark/Makefile.am
 create mode 100644 kernel-shark/kernelshark/CobaltSwitchEvents.cpp
 create mode 100644 kernel-shark/kernelshark/Makefile.am
 create mode 100644 kernel-shark/kernelshark/README
 create mode 100644 kernel-shark/kernelshark/xenomai_cobalt_switch_events.c
 create mode 100644 kernel-shark/kernelshark/xenomai_cobalt_switch_events.h
kernel-shark/Makefile.am new file +6 -0
new file mode 100644
index 000000000..8bdf1f906
@@ -0,0 +1,6 @@
+
+SUBDIRS =		\
+	kernelshark
+
+DIST_SUBDIRS = 		\
+	kernelshark
kernel-shark/kernelshark/CobaltSwitchEvents.cpp new file +156 -0

156 lines not on this page · raw message

kernel-shark/kernelshark/Makefile.am new file +18 -0
new file mode 100644
index 000000000..17c4ff217
@@ -0,0 +1,18 @@
+
+lib_LTLIBRARIES = libplugin_xenomai_cobalt_switch_events.la
+
+KS_INCLUDS         ?= /usr/local/include/kernelshark
+TRACECMD_INCLUDS   ?= /usr/local/include/trace-cmd
+TRACEFS_INCLUDS    ?= /usr/local/include/tracefs
+TRACEEVENR_INCLUDS ?= /usr/local/include/traceevent
+
+libplugin_xenomai_cobalt_switch_events_la_SOURCES =	\
+	CobaltSwitchEvents.cpp			\
+	xenomai_cobalt_switch_events.c		\
+	xenomai_cobalt_switch_events.h
+
+libplugin_xenomai_cobalt_switch_events_la_CPPFLAGS =	\
+	-I$(KS_INCLUDS)					\
+	-I$(TRACECMD_INCLUDS)				\
+	-I$(TRACEFS_INCLUDS)				\
+	-I$(TRACEEVENR_INCLUDS)
kernel-shark/kernelshark/README new file +75 -0

75 lines not on this page · raw message

kernel-shark/kernelshark/xenomai_cobalt_switch_events.c new file +174 -0

174 lines not on this page · raw message

kernel-shark/kernelshark/xenomai_cobalt_switch_events.h new file +58 -0

58 lines not on this page · raw message

Signature · 1 line
2.17.1
#6 lore raw

Re: [PATCH 2/4] Kernel-shark: Add xenomai_cobalt_switch_events plugin for kernel-shark

Quoted 32 lines · Hongzhan Chen

For Xenomai-cobalt enabled system, cobalt_switch_context means that there is schedule and context switch in companion core(realtime core), which we may need to do special treatment and take correct action as main kernel sched_switch to visualize out-of-band state of realtime tasks running in cobalt core. To achive our target, we implement following:

1. store corresponding cobalt_switch_context events into container data.
2. modify pid stored in entry to be equal to next_pid to show correct color in cpu bar when cobalt_switch_context event happen.
3. show blue hollow box to mark out-of-band state according to cobalt_switch_context events.
4. clickable cobalt_switch_context plugin shapes.

---
 kernel-shark/Makefile.am                      |   6 +
 .../kernelshark/CobaltSwitchEvents.cpp        | 156 ++++++++++++++++
 kernel-shark/kernelshark/Makefile.am          |  18 ++
 kernel-shark/kernelshark/README               |  75 ++++++++
 .../xenomai_cobalt_switch_events.c            | 174 ++++++++++++++++++
 .../xenomai_cobalt_switch_events.h            |  58 ++++++
 6 files changed, 487 insertions(+)
 create mode 100644 kernel-shark/Makefile.am
 create mode 100644 kernel-shark/kernelshark/CobaltSwitchEvents.cpp
 create mode 100644 kernel-shark/kernelshark/Makefile.am
 create mode 100644 kernel-shark/kernelshark/README
 create mode 100644 kernel-shark/kernelshark/xenomai_cobalt_switch_events.c
 create mode 100644 kernel-shark/kernelshark/xenomai_cobalt_switch_events.h

...

Quoted 6 lines
kernel-shark/kernelshark/README new file +0 -0
new file mode 100644
index 000000000..41a26a39a

kernel-shark/kernelshark/README line 10

Quoted 10 lines
kernel-shark/kernelshark/README new file +10 -0
@@ -0,0 +1,75 @@
+
+What is it?
+=============
+
+  It is Xenomai plugin for kernel-shark to visualize out-of-band state
+  of realtime thread running in companion core with making use of
+  cobalt_switch_context events in trace log.
+
+  For more introductions about kernel-shark , please refer to [1].
+

I think it's "KernelShark". Please check and then use that spelling consistently if I'm right.

Jan

Signature · 2 lines
Siemens AG, Technology
Competence Center Embedded Linux
#7 lore raw

RE: [PATCH 2/4] Kernel-shark: Add xenomai_cobalt_switch_events plugin for kernel-shark

Quoted 55 lines

-----Original Message-----
From: Jan Kiszka <[email protected]>
Sent: Tuesday, March 1, 2022 3:40 PM
To: Chen, Hongzhan <[email protected]>; [email protected]
Subject: Re: [PATCH 2/4] Kernel-shark: Add xenomai_cobalt_switch_events plugin for kernel-shark

Quoted 32 lines · Hongzhan Chen

For Xenomai-cobalt enabled system, cobalt_switch_context means that there is schedule and context switch in companion core(realtime core), which we may need to do special treatment and take correct action as main kernel sched_switch to visualize out-of-band state of realtime tasks running in cobalt core. To achive our target, we implement following:

1. store corresponding cobalt_switch_context events into container data.
2. modify pid stored in entry to be equal to next_pid to show correct color in cpu bar when cobalt_switch_context event happen.
3. show blue hollow box to mark out-of-band state according to cobalt_switch_context events.
4. clickable cobalt_switch_context plugin shapes.

---
 kernel-shark/Makefile.am                      |   6 +
 .../kernelshark/CobaltSwitchEvents.cpp        | 156 ++++++++++++++++
 kernel-shark/kernelshark/Makefile.am          |  18 ++
 kernel-shark/kernelshark/README               |  75 ++++++++
 .../xenomai_cobalt_switch_events.c            | 174 ++++++++++++++++++
 .../xenomai_cobalt_switch_events.h            |  58 ++++++
 6 files changed, 487 insertions(+)
 create mode 100644 kernel-shark/Makefile.am
 create mode 100644 kernel-shark/kernelshark/CobaltSwitchEvents.cpp
 create mode 100644 kernel-shark/kernelshark/Makefile.am
 create mode 100644 kernel-shark/kernelshark/README
 create mode 100644 kernel-shark/kernelshark/xenomai_cobalt_switch_events.c
 create mode 100644 kernel-shark/kernelshark/xenomai_cobalt_switch_events.h

...

Quoted 11 lines
kernel-shark/kernelshark/README new file +5 -0
new file mode 100644
index 000000000..41a26a39a
@@ -0,0 +1,75 @@
+
+What is it?
+=============
+
+  It is Xenomai plugin for kernel-shark to visualize out-of-band state
Quoted 8 lines

kernel-shark/kernelshark/README line 10

Quoted 5 lines
kernel-shark/kernelshark/README new file +5 -0
+  of realtime thread running in companion core with making use of
+  cobalt_switch_context events in trace log.
+
+  For more introductions about kernel-shark , please refer to [1].
+

I think it's "KernelShark". Please check and then use that spelling consistently if I'm right.

Actually, in kernelshark project , they are mixing using them.

For example, like following commit message. There are lots of commit messages include such name kernel-shark. Or their repo name https://git.kernel.org/pub/scm/utils/trace-cmd/kernel-shark.git

commit 59b5763c7c52b703e3b8e05be801f7c85365c9d3

Author: Yordan Karadzhov (VMware) <[email protected]>
Date:   Wed Jan 19 14:02:28 2022 +0200

kernel-shark: Add KsPluginsGUI.hpp/.cpp

Here we will place all GUI-related APIs that will be exposed to the external plugins. For the moment we add only two such APIs that will allow the plugins to manipulate the markers.

Regards

Hongzhan Chen

Quoted 6 lines

Jan

Signature · 2 lines
Siemens AG, Technology
Competence Center Embedded Linux
#8 lore raw

Re: [PATCH 2/4] Kernel-shark: Add xenomai_cobalt_switch_events plugin for kernel-shark

Quoted 73 lines · Hongzhan
Quoted 55 lines

-----Original Message-----
From: Jan Kiszka <[email protected]>
Sent: Tuesday, March 1, 2022 3:40 PM
To: Chen, Hongzhan <[email protected]>; [email protected]
Subject: Re: [PATCH 2/4] Kernel-shark: Add xenomai_cobalt_switch_events plugin for kernel-shark

Quoted 32 lines · Hongzhan Chen

For Xenomai-cobalt enabled system, cobalt_switch_context means that there is schedule and context switch in companion core(realtime core), which we may need to do special treatment and take correct action as main kernel sched_switch to visualize out-of-band state of realtime tasks running in cobalt core. To achive our target, we implement following:

1. store corresponding cobalt_switch_context events into container data.
2. modify pid stored in entry to be equal to next_pid to show correct color in cpu bar when cobalt_switch_context event happen.
3. show blue hollow box to mark out-of-band state according to cobalt_switch_context events.
4. clickable cobalt_switch_context plugin shapes.

---
 kernel-shark/Makefile.am                      |   6 +
 .../kernelshark/CobaltSwitchEvents.cpp        | 156 ++++++++++++++++
 kernel-shark/kernelshark/Makefile.am          |  18 ++
 kernel-shark/kernelshark/README               |  75 ++++++++
 .../xenomai_cobalt_switch_events.c            | 174 ++++++++++++++++++
 .../xenomai_cobalt_switch_events.h            |  58 ++++++
 6 files changed, 487 insertions(+)
 create mode 100644 kernel-shark/Makefile.am
 create mode 100644 kernel-shark/kernelshark/CobaltSwitchEvents.cpp
 create mode 100644 kernel-shark/kernelshark/Makefile.am
 create mode 100644 kernel-shark/kernelshark/README
 create mode 100644 kernel-shark/kernelshark/xenomai_cobalt_switch_events.c
 create mode 100644 kernel-shark/kernelshark/xenomai_cobalt_switch_events.h

...

Quoted 11 lines
kernel-shark/kernelshark/README new file +5 -0
new file mode 100644
index 000000000..41a26a39a
@@ -0,0 +1,75 @@
+
+What is it?
+=============
+
+  It is Xenomai plugin for kernel-shark to visualize out-of-band state
Quoted 8 lines

kernel-shark/kernelshark/README line 10

Quoted 5 lines
kernel-shark/kernelshark/README new file +5 -0
+  of realtime thread running in companion core with making use of
+  cobalt_switch_context events in trace log.
+
+  For more introductions about kernel-shark , please refer to [1].
+

I think it's "KernelShark". Please check and then use that spelling consistently if I'm right.

Actually, in kernelshark project , they are mixing using them.

For example, like following commit message. There are lots of commit messages include such name kernel-shark. Or their repo name https://git.kernel.org/pub/scm/utils/trace-cmd/kernel-shark.git

commit 59b5763c7c52b703e3b8e05be801f7c85365c9d3

Author: Yordan Karadzhov (VMware) <[email protected]>
Date:   Wed Jan 19 14:02:28 2022 +0200
Quoted 8 lines

kernel-shark: Add KsPluginsGUI.hpp/.cpp

Here we will place all GUI-related APIs that will be exposed to the external plugins. For the moment we add only two such APIs that will allow the plugins to manipulate the markers.

Right, but website and README use "KernelShark". Maybe ask for clarification.

Jan

Signature · 2 lines
Siemens AG, Technology
Competence Center Embedded Linux
#9 lore raw

PATCH 3/4 Add --with-kernelshark option

In reply to Hongzhan Chen

option to build kernelshark related plugins

---
 Makefile.am  |  6 ++++++
 configure.ac | 16 ++++++++++++++++
 2 files changed, 22 insertions(+)
Makefile.am +6 -0
index 604644277..9563f33ca 100644
@@ -18,6 +18,11 @@ SUBDIRS += 		\
 	testsuite
 endif
 
+if BUILD_KERNELSHARK
+SUBDIRS +=		\
+	kernel-shark
+endif
+
 EXTRA_DIST = kernel debian
 
 DIST_SUBDIRS =		\
@@ -26,6 +31,7 @@ DIST_SUBDIRS =		\
 	doc		\
 	include		\
 	lib 		\
+	kernel-shark	\
 	scripts		\
 	testsuite	\
 	utils
configure.ac +16 -0
index 16cffd8f8..b2e233494 100644
@@ -826,6 +826,20 @@ AC_ARG_WITH(demodir,
     ], [XENO_DEMO_DIR=$demodir])
 AC_MSG_RESULT($XENO_DEMO_DIR)
 
+xeno_build_kernelshark=false
+AC_MSG_CHECKING(build kernel-shark plugins)
+AC_ARG_WITH(kernelshark,
+    AS_HELP_STRING([--with-kernelshark],[build kernelshark related plugins]),
+    [
+	case "$withval" in
+	"" | y | ye | yes) xeno_build_kernelshark=true;;
+	n | no) xeno_build_kernelshark=false;;
+	esac
+    ], [xeno_build_kernelshark=false])
+AC_MSG_RESULT($xeno_build_kernelshark)
+
+AM_CONDITIONAL([BUILD_KERNELSHARK], [test x$xeno_build_kernelshark = xtrue])
+
 AC_MSG_CHECKING([for test source generation])
 AC_RUN_IFELSE([AC_LANG_PROGRAM([[ ]], [[ ]])],
     [AC_MSG_RESULT(ok)], [AC_MSG_RESULT(failed)], [AC_MSG_RESULT(untestable)])
@@ -943,6 +957,8 @@ AC_CONFIG_FILES([ \
 	scripts/Makefile \
 	scripts/xeno-config:scripts/xeno-config-$rtcore_type.in \
 	scripts/xeno \
+	kernel-shark/Makefile \
+	kernel-shark/kernelshark/Makefile \
 	lib/Makefile \
 	lib/boilerplate/Makefile \
 	lib/boilerplate/init/Makefile \
Signature · 1 line
2.17.1
#10 lore raw

PATCH 4/4 libtraceevent: Add Add xenomai_schedparams plugin for libtraceevent

In reply to Hongzhan Chen

For cobalt thread, there is special struct param_ex data stored in data record, we need to parse and print its content out correctly to hint user when using libtraceevent.

---
 configure.ac                                  |   1 +
 kernel-shark/Makefile.am                      |   6 +-
 kernel-shark/libtraceevent/Makefile.am        |  10 +
 kernel-shark/libtraceevent/README             |  30 +++
 .../plugin_xenomai_schedparams.c              | 201 ++++++++++++++++++
 5 files changed, 246 insertions(+), 2 deletions(-)
 create mode 100644 kernel-shark/libtraceevent/Makefile.am
 create mode 100644 kernel-shark/libtraceevent/README
 create mode 100644 kernel-shark/libtraceevent/plugin_xenomai_schedparams.c
configure.ac +1 -0
index b2e233494..1dc8e4cff 100644
@@ -959,6 +959,7 @@ AC_CONFIG_FILES([ \
 	scripts/xeno \
 	kernel-shark/Makefile \
 	kernel-shark/kernelshark/Makefile \
+	kernel-shark/libtraceevent/Makefile \
 	lib/Makefile \
 	lib/boilerplate/Makefile \
 	lib/boilerplate/init/Makefile \
kernel-shark/Makefile.am +4 -2
index 8bdf1f906..35ebe3954 100644
@@ -1,6 +1,8 @@
 
 SUBDIRS =		\
-	kernelshark
+	kernelshark	\
+	libtraceevent
 
 DIST_SUBDIRS = 		\
-	kernelshark
+	kernelshark	\
+	libtraceevent
kernel-shark/libtraceevent/Makefile.am new file +10 -0
new file mode 100644
index 000000000..e6ae6f319
@@ -0,0 +1,10 @@
+
+lib_LTLIBRARIES = libplugin_xenomai_schedparams.la
+
+TRACEEVENR_INCLUDS ?= /usr/local/include/traceevent
+
+libplugin_xenomai_schedparams_la_SOURCES =	\
+	plugin_xenomai_schedparams.c
+
+libplugin_xenomai_schedparams_la_CPPFLAGS =	\
+	-I$(TRACEEVENR_INCLUDS)
kernel-shark/libtraceevent/README new file +30 -0
new file mode 100644
index 000000000..8a55749fa
@@ -0,0 +1,30 @@
+
+What is it?
+=============
+
+  It is Xenomai plugin on libtracevent to parse struct param_ex
+  out correctly for trace log.
+
+How to compile?
+================================
+
+Preparation:
+
+  - GIT clone:
+
+      https://git.kernel.org/pub/scm/libs/libtrace/libtraceevent.git
+
+  - build and install libtraceevent:
+
+      make;
+      sudo make install
+
+How to use built lib?
+===============================
+
+  Please copy built libplugin_xenomai_schedparams.so to 
+  /usr/local/lib/traceevent/plugins/ or 
+  /usr/local/lib64/traceevent/plugins/ depending your system.
+  When libtracevent and its plugins is installed correctly, the plugins
+  would be loaded automatically by other module such as libtracecmd after
+  kernel-shark run.
kernel-shark/libtraceevent/plugin_xenomai_schedparams.c new file +201 -0

201 lines not on this page · raw message

Signature · 1 line
2.17.1
#11 lore raw

Re: [PATCH 4/4] libtraceevent: Add Add xenomai_schedparams plugin for libtraceevent

Quoted 4 lines · Hongzhan Chen

For cobalt thread, there is special struct param_ex data stored in data record, we need to parse and print its content out correctly to hint user when using libtraceevent.

While libtraceevent can be used along with KernelShark, it's not bound to it. You can also perfectly use it with pure command line tooling (trace-cmd). That would make it interesting for your UI-free demo images (xenomai-images). So I would recommand controlling its build independently of KernelShark.

Quoted 4 lines
---
 configure.ac                                  |   1 +
 kernel-shark/Makefile.am                      |   6 +-

Maybe call the top-level directory "tracing" instead.

Jan

Signature · 2 lines
Siemens AG, Technology
Competence Center Embedded Linux
#12 lore raw

RE: [PATCH 4/4] libtraceevent: Add Add xenomai_schedparams plugin for libtraceevent

Quoted 20 lines

-----Original Message-----
From: Jan Kiszka <[email protected]>
Sent: Tuesday, March 1, 2022 3:41 PM
To: Chen, Hongzhan <[email protected]>; [email protected]
Subject: Re: [PATCH 4/4] libtraceevent: Add Add xenomai_schedparams plugin for libtraceevent

Quoted 4 lines · Hongzhan Chen

For cobalt thread, there is special struct param_ex data stored in data record, we need to parse and print its content out correctly to hint user when using libtraceevent.

While libtraceevent can be used along with KernelShark, it's not bound to it. You can also perfectly use it with pure command line tooling (trace-cmd). That would make it interesting for your UI-free demo images (xenomai-images). So I would recommand controlling its build independently of KernelShark.

Quoted 6 lines
Quoted 4 lines
---
 configure.ac                                  |   1 +
 kernel-shark/Makefile.am                      |   6 +-

Maybe call the top-level directory "tracing" instead.

It was supposed that the building of all plugins is controlled by one option --with-kernelshark in my case. As you suggested ,does that means we need to add one more option like --with-libtraceevent to build libtraceevent standalone independent from building kernelshark plugin. Or we replace --with-kernelshark with- -with-tracing to build all plugins under tracing folder with sole option?

Regards

Hongzhan Chen

Quoted 7 lines

Jan

Signature · 2 lines
Siemens AG, Technology
Competence Center Embedded Linux
#13 lore raw

Re: [PATCH 4/4] libtraceevent: Add Add xenomai_schedparams plugin for libtraceevent

Quoted 20 lines · Hongzhan
Quoted 20 lines

-----Original Message-----
From: Jan Kiszka <[email protected]>
Sent: Tuesday, March 1, 2022 3:41 PM
To: Chen, Hongzhan <[email protected]>; [email protected]
Subject: Re: [PATCH 4/4] libtraceevent: Add Add xenomai_schedparams plugin for libtraceevent

Quoted 4 lines · Hongzhan Chen

For cobalt thread, there is special struct param_ex data stored in data record, we need to parse and print its content out correctly to hint user when using libtraceevent.

While libtraceevent can be used along with KernelShark, it's not bound to it. You can also perfectly use it with pure command line tooling (trace-cmd). That would make it interesting for your UI-free demo images (xenomai-images). So I would recommand controlling its build independently of KernelShark.

Quoted 9 lines
Quoted 6 lines
Quoted 4 lines
---
 configure.ac                                  |   1 +
 kernel-shark/Makefile.am                      |   6 +-

Maybe call the top-level directory "tracing" instead.

It was supposed that the building of all plugins is controlled by one option --with-kernelshark in my case. As you suggested ,does that means we need to add one more option like --with-libtraceevent to build libtraceevent standalone independent from building kernelshark plugin. Or we replace --with-kernelshark with- -with-tracing to build all plugins under tracing folder with sole option?

Yes, --with-libtraceevent, and then maybe make --with-kernelshark imply the former if it depends on it technically.

Jan

Signature · 2 lines
Siemens AG, Technology
Competence Center Embedded Linux