Add watchdog support for MT8186 SoC
v2 cover Add watchdog support for MT8186 SoC
resend v2:
1. Fix topic to V2.
v2:
1. Squash [1] into [2] in v1.
2. Add tags of acked-by and reviewed-by.
[1]: [3/4] dt-bindings: reset: mt8186: add DSI reset bit for MMSYS [2]: [2/4] dt-bindings: reset: mt8186: add toprgu reset-controller header file
v1:
1. Add mt8186-resets.h to define definition of reset bits.
2. Add wdt compatible for MT8186.
Rex-BC Chen (1):
dt-bindings: watchdog: Add compatible for MediaTek MT8186
Runyang Chen (2):
dt-bindings: reset: mt8186: add reset-controller header file
watchdog: mediatek: mt8186: add wdt support
.../devicetree/bindings/watchdog/mtk-wdt.txt | 1 + drivers/watchdog/mtk_wdt.c | 6 ++++ include/dt-bindings/reset/mt8186-resets.h | 36 +++++++++++++++++++ 3 files changed, 43 insertions(+) create mode 100644 include/dt-bindings/reset/mt8186-resets.h
Signature · 1 line
2.18.0
PATCH RESEND v2 1/3 dt-bindings: watchdog: Add compatible for MediaTek MT8186
Add dt-binding documentation of watchdog for MediaTek MT8186 SoC.
--- Documentation/devicetree/bindings/watchdog/mtk-wdt.txt | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/watchdog/mtk-wdt.txt +1 -0
@@ -15,6 +15,7 @@ Required properties: "mediatek,mt7629-wdt", "mediatek,mt6589-wdt": for MT7629 "mediatek,mt7986-wdt", "mediatek,mt6589-wdt": for MT7986 "mediatek,mt8183-wdt": for MT8183 + "mediatek,mt8186-wdt", "mediatek,mt6589-wdt": for MT8186 "mediatek,mt8516-wdt", "mediatek,mt6589-wdt": for MT8516 "mediatek,mt8192-wdt": for MT8192 "mediatek,mt8195-wdt", "mediatek,mt6589-wdt": for MT8195
Signature · 1 line
2.18.0
PATCH RESEND v2 2/3 dt-bindings: reset: mt8186: add reset-controller header file
In reply to Rex-BC ChenFrom: Runyang Chen <[email protected]>
- Add toprgu reset-controller header file for MT8186.
- Add DSI software reset bit which is controlled in MMSYS for MT8186.
--- include/dt-bindings/reset/mt8186-resets.h | 36 +++++++++++++++++++++++ 1 file changed, 36 insertions(+) create mode 100644 include/dt-bindings/reset/mt8186-resets.h
include/dt-bindings/reset/mt8186-resets.h new file +36 -0
@@ -0,0 +1,36 @@ +/* SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause) */ +/* +* Copyright (c) 2022 MediaTek Inc. +* Author: Runyang Chen <[email protected]> +*/ + +#ifndef _DT_BINDINGS_RESET_CONTROLLER_MT8186 +#define _DT_BINDINGS_RESET_CONTROLLER_MT8186 + +#define MT8186_TOPRGU_INFRA_SW_RST 0 +#define MT8186_TOPRGU_MM_SW_RST 1 +#define MT8186_TOPRGU_MFG_SW_RST 2 +#define MT8186_TOPRGU_VENC_SW_RST 3 +#define MT8186_TOPRGU_VDEC_SW_RST 4 +#define MT8186_TOPRGU_IMG_SW_RST 5 +#define MT8186_TOPRGU_DDR_SW_RST 6 +#define MT8186_TOPRGU_INFRA_AO_SW_RST 8 +#define MT8186_TOPRGU_CONNSYS_SW_RST 9 +#define MT8186_TOPRGU_APMIXED_SW_RST 10 +#define MT8186_TOPRGU_PWRAP_SW_RST 11 +#define MT8186_TOPRGU_CONN_MCU_SW_RST 12 +#define MT8186_TOPRGU_IPNNA_SW_RST 13 +#define MT8186_TOPRGU_WPE_SW_RST 14 +#define MT8186_TOPRGU_ADSP_SW_RST 15 +#define MT8186_TOPRGU_AUDIO_SW_RST 17 +#define MT8186_TOPRGU_CAM_MAIN_SW_RST 18 +#define MT8186_TOPRGU_CAM_RAWA_SW_RST 19 +#define MT8186_TOPRGU_CAM_RAWB_SW_RST 20 +#define MT8186_TOPRGU_IPE_SW_RST 21 +#define MT8186_TOPRGU_IMG2_SW_RST 22 +#define MT8186_TOPRGU_SW_RST_NUM 23 + +/* MMSYS resets */ +#define MT8186_MMSYS_SW0_RST_B_DISP_DSI0 19 + +#endif /* _DT_BINDINGS_RESET_CONTROLLER_MT8186 */
Signature · 1 line
2.18.0
PATCH RESEND v2 3/3 watchdog: mediatek: mt8186: add wdt support
In reply to Rex-BC ChenFrom: Runyang Chen <[email protected]>
Support MT8186 watchdog device.
--- drivers/watchdog/mtk_wdt.c | 6 ++++++ 1 file changed, 6 insertions(+)
drivers/watchdog/mtk_wdt.c +6 -0
@@ -11,6 +11,7 @@#include <dt-bindings/reset/mt2712-resets.h> #include <dt-bindings/reset/mt8183-resets.h> +#include <dt-bindings/reset/mt8186-resets.h> #include <dt-bindings/reset/mt8192-resets.h> #include <dt-bindings/reset/mt8195-resets.h> #include <linux/delay.h>
@@ -80,6 +81,10 @@ static const struct mtk_wdt_data mt8183_data = { .toprgu_sw_rst_num = MT8183_TOPRGU_SW_RST_NUM, }; +static const struct mtk_wdt_data mt8186_data = { + .toprgu_sw_rst_num =MT8186_TOPRGU_SW_RST_NUM , +}; +static const struct mtk_wdt_data mt8192_data = { .toprgu_sw_rst_num =MT8192_TOPRGU_SW_RST_NUM , };
@@ -419,6 +424,7 @@ static const struct of_device_id mtk_wdt_dt_ids[] = { { .compatible = "mediatek,mt2712-wdt", .data = &mt2712_data }, { .compatible = "mediatek,mt6589-wdt" }, { .compatible = "mediatek,mt8183-wdt", .data = &mt8183_data }, + { .compatible = "mediatek,mt8186-wdt", .data = &mt8186_data }, { .compatible = "mediatek,mt8192-wdt", .data = &mt8192_data }, { .compatible = "mediatek,mt8195-wdt", .data = &mt8195_data }, {/* sentinel */ }
Signature · 1 line
2.18.0
Quoted 22 lines · Rex-BC Chen
resend v2:
1. Fix topic to V2.v2:
1. Squash [1] into [2] in v1.
2. Add tags of acked-by and reviewed-by.[1]: [3/4] dt-bindings: reset: mt8186: add DSI reset bit for MMSYS [2]: [2/4] dt-bindings: reset: mt8186: add toprgu reset-controller header file
v1:
1. Addmt8186-resets.hto define definition of reset bits.
2. Add wdt compatible for MT8186.Rex-BC Chen (1):
dt-bindings: watchdog: Add compatible for MediaTek MT8186Runyang Chen (2):
dt-bindings: reset: mt8186: add reset-controller header file
watchdog: mediatek: mt8186: add wdt support
Quoted 7 lines
.../devicetree/bindings/watchdog/mtk-wdt.txt | 1 + drivers/watchdog/mtk_wdt.c | 6 ++++ include/dt-bindings/reset/mt8186-resets.h | 36 +++++++++++++++++++ 3 files changed, 43 insertions(+) create mode 100644 include/dt-bindings/reset/mt8186-resets.h
Hello Guenter,
All patches are reviewed-by and acked-by.
Do you have any suggestion for this series?
Thanks!
BRs,
Rex
Quoted 33 lines · Rex-BC Chen
Quoted 22 lines · Rex-BC Chen
resend v2:
1. Fix topic to V2.v2:
1. Squash [1] into [2] in v1.
2. Add tags of acked-by and reviewed-by.[1]: [3/4] dt-bindings: reset: mt8186: add DSI reset bit for MMSYS [2]: [2/4] dt-bindings: reset: mt8186: add toprgu reset-controller header file
v1:
1. Addmt8186-resets.hto define definition of reset bits.
2. Add wdt compatible for MT8186.Rex-BC Chen (1):
dt-bindings: watchdog: Add compatible for MediaTek MT8186Runyang Chen (2):
dt-bindings: reset: mt8186: add reset-controller header file
watchdog: mediatek: mt8186: add wdt supportQuoted 7 lines
.../devicetree/bindings/watchdog/mtk-wdt.txt | 1 + drivers/watchdog/mtk_wdt.c | 6 ++++ include/dt-bindings/reset/mt8186-resets.h | 36 +++++++++++++++++++ 3 files changed, 43 insertions(+) create mode 100644 include/dt-bindings/reset/mt8186-resets.hHello Guenter,
Quoted 8 lines
All patches are reviewed-by and acked-by.
Do you have any suggestion for this series?Thanks!
BRs,
Rex
Hello Guenter,
I am sorry that I did not notice this series is in watchdog-next. Thanks for accepting this series!
BRs,
Rex