Skip to contentSkip to conversation

media: camss: Replace hard coded value with parameter

PATCH In review Souptick Joarder 2 participants 2 messages Mar 1, 2022

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 media: camss: Replace hard coded value with parameter

From: "Souptick Joarder (HPE)" <[email protected]>

Kernel test robot reported below warning -> drivers/media/platform/qcom/camss/camss-csid-gen2.c:407:3:
warning: Value stored to 'val' is never read [clang-analyzer-deadcode.DeadStores]

Replace hard coded value with val.

---
 drivers/media/platform/qcom/camss/camss-csid-gen2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/platform/qcom/camss/camss-csid-gen2.c +1 -1
index abbfbf448893..2031bde13a93 100644
@@ -405,7 +405,7 @@ static void csid_configure_stream(struct csid_device *csid, u8 enable)
 		writel_relaxed(val, csid->base + CSID_RDI_FRM_DROP_PERIOD(0));
 
 		val = 0;
-		writel_relaxed(0, csid->base + CSID_RDI_FRM_DROP_PATTERN(0));
+		writel_relaxed(val, csid->base + CSID_RDI_FRM_DROP_PATTERN(0));
 
 		val = 1;
 		writel_relaxed(val, csid->base + CSID_RDI_IRQ_SUBSAMPLE_PERIOD(0));
Signature · 1 line
2.25.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 30 lines · Souptick Joarder

From: "Souptick Joarder (HPE)" <[email protected]>

Kernel test robot reported below warning -> drivers/media/platform/qcom/camss/camss-csid-gen2.c:407:3:
warning: Value stored to 'val' is never read [clang-analyzer-deadcode.DeadStores]

Replace hard coded value with val.

---
 drivers/media/platform/qcom/camss/camss-csid-gen2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/platform/qcom/camss/camss-csid-gen2.c +1 -2
index abbfbf448893..2031bde13a93 100644
@@ -405,7 +405,7 @@ static void csid_configure_stream(struct csid_device *csid, u8 enable)
                writel_relaxed(val, csid->base + CSID_RDI_FRM_DROP_PERIOD(0));
 
                val = 0;
-               writel_relaxed(0, csid->base + CSID_RDI_FRM_DROP_PATTERN(0));
+               writel_relaxed(val, csid->base + CSID_RDI_FRM_DROP_PATTERN(0));
 
                val = 1;
                writel_relaxed(val, csid->base + CSID_RDI_IRQ_SUBSAMPLE_PERIOD(0));
--
Quoted 2 lines

2.25.1