Skip to contentSkip to conversation

power: supply: da9150-fg: Remove unnecessary print function dev_err()

PATCH In review Yang Li 3 participants 3 messages Mar 1, 2022 – Mar 4, 2022

Subsystems (2)
lore
Share & tools
lore

Yang Li

author
#0 lore raw

PATCH 1/1 power: supply: da9150-fg: Remove unnecessary print function dev_err()

The print function dev_err() is redundant because platform_get_irq_byname() already prints an error.

Eliminate the follow coccicheck warning:
./drivers/power/supply/da9150-fg.c:524:2-9: line 524 is redundant because platform_get_irq() already prints an error

---
 drivers/power/supply/da9150-fg.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/power/supply/da9150-fg.c +1 -3
index e63fa62d1943..8c5e2c49d6c1 100644
@@ -520,10 +520,8 @@ static int da9150_fg_probe(struct platform_device *pdev)
 
 	/* Register IRQ */
 	irq = platform_get_irq_byname(pdev, "FG");
-	if (irq < 0) {
-		dev_err(dev, "Failed to get IRQ FG: %d\n", irq);
+	if (irq < 0)
 		return irq;
-	}
 
 	ret = devm_request_threaded_irq(dev, irq, NULL, da9150_fg_irq,
 					IRQF_ONESHOT, "FG", fg);
Signature · 1 line
2.20.1.7.g153144c
#2 lore raw
In reply to Yang Li

Hi,

Quoted 10 lines · Yang Li

The print function dev_err() is redundant because platform_get_irq_byname() already prints an error.

Eliminate the follow coccicheck warning:
./drivers/power/supply/da9150-fg.c:524:2-9: line 524 is redundant because platform_get_irq() already prints an error

---

Thanks, queued.

-- Sebastian

Quoted 22 lines
 drivers/power/supply/da9150-fg.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/power/supply/da9150-fg.c +1 -3
index e63fa62d1943..8c5e2c49d6c1 100644
@@ -520,10 +520,8 @@ static int da9150_fg_probe(struct platform_device *pdev)
 
 	/* Register IRQ */
 	irq = platform_get_irq_byname(pdev, "FG");
-	if (irq < 0) {
-		dev_err(dev, "Failed to get IRQ FG: %d\n", irq);
+	if (irq < 0)
 		return irq;
-	}
 
 	ret = devm_request_threaded_irq(dev, irq, NULL, da9150_fg_irq,
 					IRQF_ONESHOT, "FG", fg);
Signature · 1 line
2.20.1.7.g153144c