app/testpmd: register metadata dynfield on modify field
PATCH 1/1 app/testpmd: register metadata dynfield on modify field
This patch adds implicit registration of metadata dynamic field and flag whenever a modify_field action with META as source and/or destination field is used.
--- app/test-pmd/cmdline_flow.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)
app/test-pmd/cmdline_flow.c +9 -2
@@ -8347,6 +8347,7 @@ parse_vc_modify_field_id(struct context *ctx, const struct token *token, {struct rte_flow_action_modify_field *action_modify_field;unsigned int i; +int ret; (void )token; (void )buf;
@@ -8362,9 +8363,15 @@ parse_vc_modify_field_id(struct context *ctx, const struct token *token,if (!ctx->object)return len; action_modify_field = ctx->object; -if (ctx->curr ==ACTION_MODIFY_FIELD_DST_TYPE_VALUE ) +if (ctx->curr ==ACTION_MODIFY_FIELD_DST_TYPE_VALUE ) { action_modify_field->dst.field = (enum rte_flow_field_id )i; -else +if (action_modify_field->dst.field ==RTE_FLOW_FIELD_META ) { + ret =rte_flow_dynf_metadata_register (); +if (ret <0 ) +return -1 ; + } + + }else action_modify_field->src.field = (enum rte_flow_field_id )i;return len; }
Signature · 1 line
2.25.1
Quoted 1 line · Dariusz Sosnowski
This patch adds implicit registration of metadata dynamic field and flag
Hi Dariusz,
metaday dynamic field is explicitly registered when testpmd command used to enable tx metadata, or rte flow rule created with "set_meta" action.
Can you please document more when this implicit enablement is required? And why that case doesn't cover above explicit enable cases?
Quoted 3 lines
whenever a
modify_fieldaction with META as source and/or destination field is used.
According below code it is only registered in the DST_TYPE block, not is 'else' (which seems src) leg, is this OK?
Quoted 36 lines
Signed-off-by Dariusz Sosnowski <[email protected]>Reviewed-by Viacheslav Ovsiienko <[email protected]>--- app/test-pmd/cmdline_flow.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)app/test-pmd/cmdline_flow.c +9
-2@@ -8347,6 +8347,7 @@ parse_vc_modify_field_id(struct context *ctx, const struct token *token, {struct rte_flow_action_modify_field *action_modify_field;unsigned int i; +int ret; (void )token; (void )buf;@@ -8362,9 +8363,15 @@ parse_vc_modify_field_id(struct context *ctx, const struct token *token,if (!ctx->object)return len; action_modify_field = ctx->object; -if (ctx->curr ==ACTION_MODIFY_FIELD_DST_TYPE_VALUE ) +if (ctx->curr ==ACTION_MODIFY_FIELD_DST_TYPE_VALUE ) { action_modify_field->dst.field = (enum rte_flow_field_id )i; -else +if (action_modify_field->dst.field ==RTE_FLOW_FIELD_META ) { + ret =rte_flow_dynf_metadata_register (); +if (ret <0 ) +return -1 ; + } + + }else action_modify_field->src.field = (enum rte_flow_field_id )i;return len; }
Hi Ferruh,
Quoted 17 lines
-----Original Message-----
From: Ferruh Yigit <[email protected]>
Sent: Thursday, March 3, 2022 13:21
To: Dariusz Sosnowski <[email protected]>; Ori Kam <[email protected]>; Xiaoyun Li <[email protected]>; Aman Singh <[email protected]>; Yuying Zhang <[email protected]>
Cc: [email protected]; Slava Ovsiienko <[email protected]>
Subject: Re: [PATCH] app/testpmd: register metadata dynfield on modify fieldExternal email: Use caution opening links or attachments
Quoted 2 lines · Dariusz Sosnowski
This patch adds implicit registration of metadata dynamic field and flag
Quoted 7 lines
Hi Dariusz,
metaday dynamic field is explicitly registered when testpmd command used to enable tx metadata, or rte flow rule created with "
set_meta" action.Can you please document more when this implicit enablement is required? And why that case doesn't cover above explicit enable cases?
Before this patch, when a user inserted a flow rule with MODIFY_FIELD action, which modified packet metadata, the metadata dynamic field was not registered, as opposed to what happened with SET_META action. Goal of this patch is to make the behavior consistent between these two actions.
Maybe using "implicit" in the commit message was misleading here.
What do you think about rewording the commit message to something like the one below?
"This patch adds registration of metadata dynamic field and flag whenever a MODIFY_FIELD action with META as source and/or destination field is used. It makes the behavior consistent with SET_META action, where metadata dynamic field and flag is registered on flow rule creation."
Quoted 24 lines
Quoted 3 lines
whenever a
modify_fieldaction with META as source and/or destination field is used.According below code it is only registered in the
DST_TYPEblock, not is 'else' (which seems src) leg, is this OK?app/test-pmd/cmdline_flow.c parse_vc_modify_field_id(struct context *ctx,
Quoted 11 lines
Signed-off-by Dariusz Sosnowski <[email protected]>Reviewed-by Viacheslav Ovsiienko <[email protected]>--- app/test-pmd/cmdline_flow.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)app/test-pmd/cmdline_flow.c +0
-0@@ -8347,6 +8347,7 @@ parse_vc_modify_field_id(struct context *ctx,const struct token *token,
Quoted 5 lines
app/test-pmd/cmdline_flow.c +1
-0{struct rte_flow_action_modify_field *action_modify_field;unsigned int i; +int ret;
Quoted 21 lines
app/test-pmd/cmdline_flow.c parse_vc_modify_field_id(struct context *ctx,
Quoted 3 lines
app/test-pmd/cmdline_flow.c +0
-0(void )token; (void )buf;@@ -8362,9 +8363,15 @@ parse_vc_modify_field_id(struct context *ctx,const struct token *token,
Quoted 17 lines
app/test-pmd/cmdline_flow.c +8
-2if (!ctx->object)return len; action_modify_field = ctx->object; -if (ctx->curr ==ACTION_MODIFY_FIELD_DST_TYPE_VALUE ) +if (ctx->curr ==ACTION_MODIFY_FIELD_DST_TYPE_VALUE ) { action_modify_field->dst.field = (enum rte_flow_field_id )i; -else +if (action_modify_field->dst.field ==RTE_FLOW_FIELD_META ) { + ret =rte_flow_dynf_metadata_register (); +if (ret <0 ) +return -1 ; + } + + }else action_modify_field->src.field = (enum rte_flow_field_id )i;return len; }
No, I should add registering for source field as well.
Best regards,
Dariusz Sosnowski
09/03/2022 12:50, Dariusz Sosnowski:
Quoted 10 lines
From: Ferruh Yigit <[email protected]>
Quoted 9 lines · Dariusz Sosnowski
Quoted 2 lines
This patch adds implicit registration of metadata dynamic field and flag
Hi Dariusz,
metaday dynamic field is explicitly registered when testpmd command used to enable tx metadata, or rte flow rule created with "
set_meta" action.
Quoted 7 lines
Quoted 2 lines
Can you please document more when this implicit enablement is required? And why that case doesn't cover above explicit enable cases?
Before this patch, when a user inserted a flow rule with
MODIFY_FIELDaction, which modified packet metadata, the metadata dynamic field was not registered, as opposed to what happened withSET_METAaction. Goal of this patch is to make the behavior consistent between these two actions.
I think consistency should be ensured by the PMD.
Why not registering the field in the PMD?