Skip to contentSkip to conversation

ima: remove redundant initialization of pointer 'file'.

PATCH In review Colin Ian King 2 participants 2 messages Mar 1, 2022 – Apr 5, 2022

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ima: remove redundant initialization of pointer 'file'.

The pointer 'file' is being initialized with a value that is never read, it is being re-assigned the same value later on closer to where it is being first used. The initialization is redundant and can be removed.

Cleans up clang scan build warning:
security/integrity/ima/ima_main.c:434:15: warning: Value stored to 'file' during its initialization is never read [deadcode.DeadStores]

---
 security/integrity/ima/ima_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
security/integrity/ima/ima_main.c +1 -1
index c6412dec3810..41b91a0bc8dc 100644
@@ -431,7 +431,7 @@ int ima_file_mmap(struct file *file, unsigned long prot)
 int ima_file_mprotect(struct vm_area_struct *vma, unsigned long prot)
 {
 	struct ima_template_desc *template = NULL;
-	struct file *file = vma->vm_file;
+	struct file *file;
 	char filename[NAME_MAX];
 	char *pathbuf = NULL;
 	const char *pathname = NULL;
Signature · 1 line
2.34.1
maintainer
#1 lore raw
Quoted 9 lines · Colin Ian King

The pointer 'file' is being initialized with a value that is never read, it is being re-assigned the same value later on closer to where it is being first used. The initialization is redundant and can be removed.

Cleans up clang scan build warning:
security/integrity/ima/ima_main.c:434:15: warning: Value stored to 'file' during its initialization is never read [deadcode.DeadStores]

thanks,

Mimi