Skip to contentSkip to conversation

compressdev: fix size of socket ID in device data struct

PATCH Applied Raja Zidane 2 participants 2 messages Mar 1, 2022 – Mar 4, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 compressdev: fix size of socket ID in device data struct

Socket ID is used and interpreted as integer, one of the possible values for socket id is -1 (SOCKET_ID_ANY).
here socket_id is defined as unsigned 8 bit integer, so when putting -1, it is interpreted as 255, which causes allocation errors when trying to allocate from socket_id (255).

change socket_id from unsigned 8 bit integer to integer.

Fixes ed7dd94f7f66 ("compressdev: add basic device management")
---
 lib/compressdev/rte_compressdev_internal.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/compressdev/rte_compressdev_internal.h +1 -1
index 888c8f5c5c..25d8afbfb9 100644
@@ -98,7 +98,7 @@ struct rte_compressdev {
 struct rte_compressdev_data {
 	uint8_t dev_id;
 	/**< Compress device identifier */
-	uint8_t socket_id;
+	int socket_id;
 	/**< Socket identifier where memory is allocated */
 	char name[RTE_COMPRESSDEV_NAME_MAX_LEN];
 	/**< Unique identifier name */
Signature · 1 line
2.21.0
Applied
#1 lore raw
Quoted 6 lines

Socket ID is used and interpreted as integer, one of the possible values for socket id is -1 (SOCKET_ID_ANY).
here socket_id is defined as unsigned 8 bit integer, so when putting -1, it is interpreted as 255, which causes allocation errors when trying to allocate from socket_id (255).

Quoted 8 lines

change socket_id from unsigned 8 bit integer to integer.

Fixes ed7dd94f7f66 ("compressdev: add basic device management")

Applied to dpdk-next-crypto

Thanks.