mm/damon/sysfs: Fix out-of-bound array access for wmark_metric_strs[]
Subsystems (2)
SeongJae Park
maintainerPATCH 1/1 mm/damon/sysfs: Fix out-of-bound array access for wmark_metric_strs[]
Commit 7a8630be880e ("mm/damon/sysfs: support DAMOS watermarks") on -mm tree which introduced by a patch[1] titled mm-damon-sysfs-support-damos-watermarks.patch allows out-of-bound access to damon_sysfs_wmark_metric_strs[] array due to wrong bound check. This commit fixes the wrong bound check. The issue has found by Coverity report for linux-next.
[1] https://www.ozlabs.org/~akpm/mmotm/broken-out/mm-damon-sysfs-support-damos-watermarks.patch
Addresses-Coverity: ("Out-of-bounds read")
Fixes 7a8630be880e ("mm/damon/sysfs: support DAMOS watermarks")
Signed-off-by SeongJae Park <[email protected]>
--- mm/damon/sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
mm/damon/sysfs.c +1 -1
@@ -266,7 +266,7 @@ static ssize_t metric_store(struct kobject *kobj, struct kobj_attribute *attr, struct damon_sysfs_watermarks, kobj);enum damos_wmark_metric metric; -for (metric =0 ; metric <=NR_DAMOS_WMARK_METRICS ; metric++) { +for (metric =0 ; metric <NR_DAMOS_WMARK_METRICS ; metric++) {if (sysfs_streq (buf, damon_sysfs_wmark_metric_strs[metric])) { watermarks->metric = metric;return count;
Signature · 1 line
2.17.1