Skip to contentSkip to conversation

dt-bindings: clock: renesas: Make example 'clocks' parsable

PATCH Applied Rob Herring 3 participants 7 messages Mar 1, 2022 – Mar 25, 2022

Subsystems (3)
Device tree bindings Common clk Renesas clock drivers
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: clock: renesas: Make example 'clocks' parsable

'clocks' in the example is not parsable with the 0 phandle value because the number of #clock-cells is unknown in the previous entry. Solve this by adding the clock provider node. Only 'cpg_clocks' is needed as the examples are built with fixups which can be used to identify phandles.

This is in preparation to support schema validation on .dtb files.

Signed-off-by Rob Herring <[email protected]>
---
 .../bindings/clock/renesas,cpg-div6-clock.yaml       | 12 ++++++++++++
 1 file changed, 12 insertions(+)
Documentation/devicetree/bindings/clock/renesas,cpg-div6-clock.yaml +12 -0
index c55a7c494e01..2197c952e21d 100644
@@ -51,6 +51,18 @@ additionalProperties: false
 examples:
   - |
     #include <dt-bindings/clock/r8a73a4-clock.h>
+
+    cpg_clocks: cpg_clocks@e6150000 {
+            compatible = "renesas,r8a73a4-cpg-clocks";
+            reg = <0xe6150000 0x10000>;
+            clocks = <&extal1_clk>, <&extal2_clk>;
+            #clock-cells = <1>;
+            clock-output-names = "main", "pll0", "pll1", "pll2",
+                                  "pll2s", "pll2h", "z", "z2",
+                                  "i", "m3", "b", "m1", "m2",
+                                  "zx", "zs", "hp";
+    };
+
     sdhi2_clk: sdhi2_clk@e615007c {
             compatible = "renesas,r8a73a4-div6-clock", "renesas,cpg-div6-clock";
             reg = <0xe615007c 4>;
Signature · 1 line
2.32.0
Reviewed-by Acked-by on v1 1/1
#1 lore raw

Hi Rob,

Quoted 9 lines · Rob Herring

'clocks' in the example is not parsable with the 0 phandle value because the number of #clock-cells is unknown in the previous entry. Solve this by adding the clock provider node. Only 'cpg_clocks' is needed as the examples are built with fixups which can be used to identify phandles.

This is in preparation to support schema validation on .dtb files.

Signed-off-by Rob Herring <[email protected]>

Thanks for your patch!

Reviewed-by Geert Uytterhoeven <[email protected]>

Do you want me to queue this in renesas-clk-for-v5.19, or do you want to take it yourself, together with the validation patches? Please let me know.

In the latter case:

Acked-by Geert Uytterhoeven <[email protected]>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

author maintainer
#2 lore raw
Quoted 14 lines · Geert Uytterhoeven

Hi Rob,

Quoted 9 lines · Rob Herring

'clocks' in the example is not parsable with the 0 phandle value because the number of #clock-cells is unknown in the previous entry. Solve this by adding the clock provider node. Only 'cpg_clocks' is needed as the examples are built with fixups which can be used to identify phandles.

This is in preparation to support schema validation on .dtb files.

Signed-off-by Rob Herring <[email protected]>
Quoted 7 lines

Thanks for your patch!

Reviewed-by Geert Uytterhoeven <[email protected]>

Do you want me to queue this in renesas-clk-for-v5.19, or do you want to take it yourself, together with the validation patches? Please let me know.

You can take it.

Rob

#3 lore raw

Hi Rob,

Quoted 14 lines · Rob Herring
Quoted 13 lines · Geert Uytterhoeven
Quoted 9 lines · Rob Herring

'clocks' in the example is not parsable with the 0 phandle value because the number of #clock-cells is unknown in the previous entry. Solve this by adding the clock provider node. Only 'cpg_clocks' is needed as the examples are built with fixups which can be used to identify phandles.

This is in preparation to support schema validation on .dtb files.

Signed-off-by Rob Herring <[email protected]>

Thanks for your patch!

Quoted 7 lines
Quoted 5 lines
Reviewed-by Geert Uytterhoeven <[email protected]>

Do you want me to queue this in renesas-clk-for-v5.19, or do you want to take it yourself, together with the validation patches? Please let me know.

You can take it.

Thanks, queuing in renesas-clk-for-v5.19.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

author maintainer
#4 lore raw
Quoted 20 lines · Geert Uytterhoeven

Hi Rob,

Quoted 16 lines · Rob Herring
Quoted 15 lines · Geert Uytterhoeven
Quoted 9 lines · Rob Herring

'clocks' in the example is not parsable with the 0 phandle value because the number of #clock-cells is unknown in the previous entry. Solve this by adding the clock provider node. Only 'cpg_clocks' is needed as the examples are built with fixups which can be used to identify phandles.

This is in preparation to support schema validation on .dtb files.

Signed-off-by Rob Herring <[email protected]>

Thanks for your patch!

Reviewed-by Geert Uytterhoeven <[email protected]>
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

Do you want me to queue this in renesas-clk-for-v5.19, or do you want to take it yourself, together with the validation patches? Please let me know.

You can take it.

Thanks, queuing in renesas-clk-for-v5.19.

This needs to go in 5.18, not 5.19.

Rob

Acked-by
#5 lore raw

Hi Rob,

Quoted 22 lines · Rob Herring
Quoted 21 lines · Geert Uytterhoeven
Quoted 20 lines · Rob Herring
Quoted 18 lines · Geert Uytterhoeven
Quoted 9 lines · Rob Herring

'clocks' in the example is not parsable with the 0 phandle value because the number of #clock-cells is unknown in the previous entry. Solve this by adding the clock provider node. Only 'cpg_clocks' is needed as the examples are built with fixups which can be used to identify phandles.

This is in preparation to support schema validation on .dtb files.

Signed-off-by Rob Herring <[email protected]>

Thanks for your patch!

Reviewed-by Geert Uytterhoeven <[email protected]>

Do you want me to queue this in renesas-clk-for-v5.19, or do you want to take it yourself, together with the validation patches? Please let me know.

Quoted 5 lines
Quoted 3 lines
Quoted 1 line

You can take it.

Thanks, queuing in renesas-clk-for-v5.19.

This needs to go in 5.18, not 5.19.

Mike/Stephen: can you please take this directly?
Thanks!

Acked-by Geert Uytterhoeven <[email protected]>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

maintainer Applied
#6 lore raw
In reply to Rob Herring

Quoting Rob Herring (2022-03-01 11:03:59)

Quoted 10 lines

'clocks' in the example is not parsable with the 0 phandle value because the number of #clock-cells is unknown in the previous entry. Solve this by adding the clock provider node. Only 'cpg_clocks' is needed as the examples are built with fixups which can be used to identify phandles.

This is in preparation to support schema validation on .dtb files.

Signed-off-by Rob Herring <[email protected]>

---

Applied to clk-next