Skip to contentSkip to conversation

misc: bcm-vk: Remove viper from device id table

PATCH In review Desmond Yan 2 participants 2 messages Mar 2, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 misc: bcm-vk: Remove viper from device id table

As bcm_vk driver is not the production driver for viper, remove its pci device id from table.

---
Changes since v1:
- remove Kconfig option and simply remove viper pci id completely
---
drivers/misc/bcm-vk/bcm_vk_dev.c | 1 -

 1 file changed, 1 deletion(-)
drivers/misc/bcm-vk/bcm_vk_dev.c +0 -1
index ad639ee85b2a..a16b99bdaa13 100644
@@ -1633,7 +1633,6 @@ static void bcm_vk_shutdown(struct pci_dev *pdev)
 
 static const struct pci_device_id bcm_vk_ids[] = {
 	{ PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, PCI_DEVICE_ID_VALKYRIE), },
-	{ PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, PCI_DEVICE_ID_VIPER), },
 	{ }
 };
 MODULE_DEVICE_TABLE(pci, bcm_vk_ids);
Signature · 1 line
2.17.1
maintainer Acked-by on v2 1/1
#1 lore raw

Looks fine - Viper not officially supported by this driver.

Quoted 4 lines · Desmond Yan

As bcm_vk driver is not the production driver for viper, remove its pci device id from table.

Quoted 19 lines

---
Changes since v1:
- remove Kconfig option and simply remove viper pci id completely
---
drivers/misc/bcm-vk/bcm_vk_dev.c | 1 -

  1 file changed, 1 deletion(-)
drivers/misc/bcm-vk/bcm_vk_dev.c +0 -1
index ad639ee85b2a..a16b99bdaa13 100644
@@ -1633,7 +1633,6 @@ static void bcm_vk_shutdown(struct pci_dev *pdev)
 
  static const struct pci_device_id bcm_vk_ids[] = {
  	{ PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, PCI_DEVICE_ID_VALKYRIE), },
-	{ PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, PCI_DEVICE_ID_VIPER), },
  	{ }
  };
  MODULE_DEVICE_TABLE(pci, bcm_vk_ids);