Skip to contentSkip to conversation

drm/amdgpu: clean up some inconsistent indenting

PATCH In review Yang Li 2 participants 2 messages Mar 3, 2022

Subsystems (2)
lore
Share & tools
lore

Yang Li

author
#0 lore raw

PATCH 1/1 drm/amdgpu: clean up some inconsistent indenting

Eliminate the follow smatch warning:
drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c:413 amdgpu_get_xgmi_hive()
warn: inconsistent indenting

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c +8 -8
index 91817a31f3e1..4ff6e06babca 100644
@@ -410,14 +410,14 @@ struct amdgpu_hive_info *amdgpu_get_xgmi_hive(struct amdgpu_device *adev)
 	 */
 	if (adev->reset_domain->type != XGMI_HIVE) {
 		hive->reset_domain = amdgpu_reset_create_reset_domain(XGMI_HIVE, "amdgpu-reset-hive");
-			if (!hive->reset_domain) {
-				dev_err(adev->dev, "XGMI: failed initializing reset domain for xgmi hive\n");
-				ret = -ENOMEM;
-				kobject_put(&hive->kobj);
-				kfree(hive);
-				hive = NULL;
-				goto pro_end;
-			}
+		if (!hive->reset_domain) {
+			dev_err(adev->dev, "XGMI: failed initializing reset domain for xgmi hive\n");
+			ret = -ENOMEM;
+			kobject_put(&hive->kobj);
+			kfree(hive);
+			hive = NULL;
+			goto pro_end;
+		}
 	} else {
 		amdgpu_reset_get_reset_domain(adev->reset_domain);
 		hive->reset_domain = adev->reset_domain;
Signature · 1 line
2.20.1.7.g153144c
maintainer Reviewed-by on v1 1/1
#1 lore raw

Am 03.03.22 um 02:52 schrieb Yang Li:

Quoted 6 lines

Eliminate the follow smatch warning:
drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c:413 amdgpu_get_xgmi_hive()
warn: inconsistent indenting

Quoted 31 lines
---
  drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 16 ++++++++--------
  1 file changed, 8 insertions(+), 8 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c +8 -8
index 91817a31f3e1..4ff6e06babca 100644
@@ -410,14 +410,14 @@ struct amdgpu_hive_info *amdgpu_get_xgmi_hive(struct amdgpu_device *adev)
  	 */
  	if (adev->reset_domain->type != XGMI_HIVE) {
  		hive->reset_domain = amdgpu_reset_create_reset_domain(XGMI_HIVE, "amdgpu-reset-hive");
-			if (!hive->reset_domain) {
-				dev_err(adev->dev, "XGMI: failed initializing reset domain for xgmi hive\n");
-				ret = -ENOMEM;
-				kobject_put(&hive->kobj);
-				kfree(hive);
-				hive = NULL;
-				goto pro_end;
-			}
+		if (!hive->reset_domain) {
+			dev_err(adev->dev, "XGMI: failed initializing reset domain for xgmi hive\n");
+			ret = -ENOMEM;
+			kobject_put(&hive->kobj);
+			kfree(hive);
+			hive = NULL;
+			goto pro_end;
+		}
  	} else {
  		amdgpu_reset_get_reset_domain(adev->reset_domain);
  		hive->reset_domain = adev->reset_domain;