Skip to contentSkip to conversation

drm/fsl-dcu: Remove unnecessary print function dev_err()

PATCH In review Yang Li 2 participants 2 messages Mar 3, 2022 – Mar 4, 2022

Subsystems (3)
lore
Share & tools
lore

Yang Li

author
#0 lore raw

PATCH 1/1 drm/fsl-dcu: Remove unnecessary print function dev_err()

The print function dev_err() is redundant because platform_get_irq() already prints an error.

Eliminate the follow coccicheck warning:
./drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c:277:2-9: line 277 is redundant because platform_get_irq() already prints an error

---
 drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c +1 -3
index 7a503bf08d0f..20895ea79739 100644
@@ -273,10 +273,8 @@ static int fsl_dcu_drm_probe(struct platform_device *pdev)
 	}
 
 	fsl_dev->irq = platform_get_irq(pdev, 0);
-	if (fsl_dev->irq < 0) {
-		dev_err(dev, "failed to get irq\n");
+	if (fsl_dev->irq < 0)
 		return fsl_dev->irq;
-	}
 
 	fsl_dev->regmap = devm_regmap_init_mmio(dev, base,
 			&fsl_dcu_regmap_config);
Signature · 1 line
2.20.1.7.g153144c
maintainer Acked-by on v1 1/1
#1 lore raw

Best Regards,
Alison Wang

-----Original Message-----
From: Yang Li <[email protected]>
Sent: 2022年3月3日 10:30
To: Alison Wang <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; Yang Li <[email protected]>; Abaci Robot <[email protected]>
Subject: [EXT] [PATCH -next] drm/fsl-dcu: Remove unnecessary print function dev_err()

Caution: EXT Email

The print function dev_err() is redundant because platform_get_irq() already prints an error.

Eliminate the follow coccicheck warning:
./drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c:277:2-9: line 277 is redundant because platform_get_irq() already prints an error

---
 drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c +1 -3
index 7a503bf08d0f..20895ea79739 100644
@@ -273,10 +273,8 @@ static int fsl_dcu_drm_probe(struct platform_device *pdev)
        }
 
        fsl_dev->irq = platform_get_irq(pdev, 0);
-       if (fsl_dev->irq < 0) {
-               dev_err(dev, "failed to get irq\n");
+       if (fsl_dev->irq < 0)
                return fsl_dev->irq;
-       }
 
        fsl_dev->regmap = devm_regmap_init_mmio(dev, base,
                        &fsl_dcu_regmap_config);

--[Alison Wang] r
2.20.1.7.g153144c