pinctrl: berlin: fix error return code of berlin_pinctrl_build_state()
Subsystems (2)
PATCH 1/1 pinctrl: berlin: fix error return code of berlin_pinctrl_build_state()
When krealloc() fails and pctrl->functions is NULL, no error return code of berlin_pinctrl_build_state() is assigned. To fix this bug, ret is assigned with -ENOMEM when pctrl->functions is NULL.
Signed-off-by Meng Tang <[email protected]>
--- drivers/pinctrl/berlin/berlin.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/pinctrl/berlin/berlin.c +2 -0
@@ -233,6 +233,8 @@ static int berlin_pinctrl_build_state(struct platform_device *pdev) pctrl->functions =krealloc (pctrl->functions, pctrl->nfunctions *sizeof (*pctrl->functions),GFP_KERNEL ); +if (!pctrl->functions) +return -ENOMEM ;/* map functions to theirs groups */ for (i =0 ; i < pctrl->desc->ngroups; i++) {
Signature · 1 line
2.20.1
Quoted 6 lines · Meng Tang
When
krealloc()fails andpctrl->functionsis NULL, no error return code ofberlin_pinctrl_build_state()is assigned. To fix this bug, ret is assigned with-ENOMEMwhenpctrl->functionsis NULL.Signed-off-by Meng Tang <[email protected]>
Patch applied!
Yours,
Linus Walleij