Skip to contentSkip to conversation

clk: imx: remove redundant re-assignment of pll->base

PATCH Applied Colin Ian King 2 participants 2 messages Mar 3, 2022 – Mar 9, 2022

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 clk: imx: remove redundant re-assignment of pll->base

There are two identical assignments of pll->base to the same value, the second assignment is redundant and can be removed.

Cleans up cppcheck warning:
drivers/clk/imx/clk-sscg-pll.c:528:12: style: Variable 'pll->base' is reassigned a value before the old one has been used. [redundantAssignment]

---
 drivers/clk/imx/clk-sscg-pll.c | 1 -
 1 file changed, 1 deletion(-)
drivers/clk/imx/clk-sscg-pll.c +0 -1
index 9d6cdff0537f..81f304fae908 100644
@@ -525,7 +525,6 @@ struct clk_hw *imx_clk_hw_sscg_pll(const char *name,
 	init.parent_names = parent_names;
 	init.num_parents = num_parents;
 
-	pll->base = base;
 	pll->hw.init = &init;
 
 	hw = &pll->hw;
Signature · 1 line
2.34.1
maintainer Applied
#1 lore raw

Quoting Colin Ian King (2022-03-03 01:05:08)

Quoted 9 lines

There are two identical assignments of pll->base to the same value, the second assignment is redundant and can be removed.

Cleans up cppcheck warning:
drivers/clk/imx/clk-sscg-pll.c:528:12: style: Variable 'pll->base' is reassigned a value before the old one has been used. [redundantAssignment]

---

Applied to clk-next