Skip to contentSkip to conversation

net/mlx5: fix Rx queue private pointers array checking

PATCH In review Bing Zhao 2 participants 2 messages Mar 3, 2022 – Mar 7, 2022 Network drivers

lore
Share & tools
lore

Bing Zhao

author
#0 lore raw

PATCH 1/1 net/mlx5: fix Rx queue private pointers array checking

None Rx queue configured in a DPDK application should be supported. In this mode, the NIC can be used to generate packets without receiving any ingress traffic.

In the current implementation, once there is no Rx queue specified, the array to store the queues' pointers is NULL after allocation. Then the checking of the array allocation prevents the application from starting up.

By adding another condition checking of the Rx queue number, the application with none Rx queue can start up successfully.

Fixes 4cda06c3c35e ("net/mlx5: split Rx queue into shareable and private")
---
 drivers/net/mlx5/mlx5_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/mlx5/mlx5_ethdev.c +1 -1
index de0ba2b1ff..05c919ed39 100644
@@ -111,7 +111,7 @@ mlx5_dev_configure(struct rte_eth_dev *dev)
 				       MLX5_MEM_RTE | MLX5_MEM_ZERO,
 				       sizeof(void *) * rxqs_n, 0,
 				       SOCKET_ID_ANY);
-	if (priv->rxq_privs == NULL) {
+	if (rxqs_n && priv->rxq_privs == NULL) {
 		DRV_LOG(ERR, "port %u cannot allocate rxq private data",
 			dev->data->port_id);
 		rte_errno = ENOMEM;
Signature · 1 line
2.25.1
#1 lore raw

Hi,

Quoted 21 lines

-----Original Message-----
From: Bing Zhao <[email protected]>
Sent: Thursday, March 3, 2022 5:27 PM
To: Slava Ovsiienko <[email protected]>; Matan Azrad <[email protected]>
Cc: [email protected]; Raslan Darawsheh <[email protected]>; Xueming(Steven) Li <[email protected]>; [email protected]
Subject: [PATCH] net/mlx5: fix Rx queue private pointers array checking

None Rx queue configured in a DPDK application should be supported. In this mode, the NIC can be used to generate packets without receiving any ingress traffic.

In the current implementation, once there is no Rx queue specified, the array to store the queues' pointers is NULL after allocation. Then the checking of the array allocation prevents the application from starting up.

By adding another condition checking of the Rx queue number, the application with none Rx queue can start up successfully.

Quoted 6 lines
Fixes 4cda06c3c35e ("net/mlx5: split Rx queue into shareable and private")

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh