i2c: i801: Drop two outdated comments
PATCH 1/1 i2c: i801: Drop two outdated comments
* Timeouts are reported even in interrupt mode since commit b3b8df97723d ("i2c: i801: Use wait_event_timeout to wait for interrupts") so drop the comment which claims this only happens in polled mode.
* xact does not include the PEC bit, as the driver does not support software PEC.
---
Please correct me if I'm wrong.
drivers/i2c/busses/i2c-i801.c | 5 ----- 1 file changed, 5 deletions(-)
drivers/i2c/busses/i2c-i801.c +0 -5
@@ -364,9 +364,6 @@ static int i801_check_post(struct i801_p/* * If the SMBus is still busy, we give up -* Note: This timeout condition only happens when using polling -* transactions. For interrupt operation, NAK/timeout is indicated by -* DEV_ERR. */ if (unlikely (status <0 )) {dev_err (&priv->pci_dev->dev,"Transaction timeout\n" );
@@ -475,8 +472,6 @@ static int i801_transaction(struct i801_return i801_check_post (priv, result ? priv->status : -ETIMEDOUT ); } -/* the current contents of SMBHSTCNT can be overwritten, since PEC, -* SMBSCMD are passed in xact */ outb_p (xact |SMBHSTCNT_START ,SMBHSTCNT (priv)); status =i801_wait_intr (priv);
Signature · 2 lines
Jean Delvare SUSE L3 Support
Quoted 7 lines · Jean Delvare
* Timeouts are reported even in interrupt mode since commit
b3b8df97723d("i2c: i801: Usewait_event_timeoutto wait for interrupts") so drop the comment which claims this only happens in polled mode.
* xact does not include the PEC bit, as the driver does not support software PEC.
Quoted 7 lines
Signed-off-by Jean Delvare <[email protected]>---
Please correct me if I'm wrong.drivers/i2c/busses/i2c-i801.c | 5 ----- 1 file changed, 5 deletions(-)
Wolfram Sang
AppliedQuoted 8 lines · Jean Delvare
* Timeouts are reported even in interrupt mode since commit
b3b8df97723d("i2c: i801: Usewait_event_timeoutto wait for interrupts") so drop the comment which claims this only happens in polled mode.
* xact does not include the PEC bit, as the driver does not support software PEC.Signed-off-by Jean Delvare <[email protected]>
Applied to for-next, thanks!