cxl/list: tidy the error path in add_cxl_decoder()
[email protected]
maintainerPATCH 1/1 cxl/list: tidy the error path in add_cxl_decoder()
From: Alison Schofield <[email protected]>
Static analysis reported this NULL pointer dereference during cleanup on error in add_cxl_decoder().
Fixes 46564977afb7 ("cxl/list: Add decoder support")
Signed-off-by Alison Schofield <[email protected]>
--- cxl/lib/libcxl.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
cxl/lib/libcxl.c +5 -3
@@ -919,11 +919,11 @@ static void *add_cxl_decoder(void *parent, int id, const char *cxldecoder_base) decoder->dev_path =strdup (cxldecoder_base);if (!decoder->dev_path) - goto err; + goto err_decoder; decoder->dev_buf =calloc (1 ,strlen (cxldecoder_base) +50 );if (!decoder->dev_buf) - goto err; + goto err_decoder; decoder->buf_len =strlen (cxldecoder_base) +50 ;sprintf (path,"%s/start" , cxldecoder_base);
@@ -1024,10 +1024,12 @@ static void *add_cxl_decoder(void *parent, int id, const char *cxldecoder_base)list_add (&port->decoders, &decoder->list);return decoder; -err: + +err_decoder:free (decoder->dev_path);free (decoder->dev_buf);free (decoder); +err:free (path);return NULL ; }
base-commit: 3b5fb8b6428dfaab39bab58d67412427f514c1f4
Signature · 1 line
2.31.1