Skip to contentSkip to conversation

ptp: ocp: correct label for error path

PATCH RESEND Superseded Jonathan Lemon 2 participants 2 messages Mar 4, 2022 – Mar 5, 2022

Subsystems (4)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 ptp: ocp: correct label for error path

When devlink_register() was removed from the error path, the
corresponding label was not updated. Rename the label for
readability puposes, no functional change.

---
 drivers/ptp/ptp_ocp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/ptp/ptp_ocp.c +2 -2
index 608d1a0eb141..cfe744b80407 100644
@@ -2600,7 +2600,7 @@ ptp_ocp_probe(struct pci_dev *pdev, const struct pci_device_id *id)
 	err = pci_enable_device(pdev);
 	if (err) {
 		dev_err(&pdev->dev, "pci_enable_device\n");
-		gto out_unregister;
+		goto out_free;
 	}
 
 	bp = devlink_priv(devlink);
@@ -2646,7 +2646,7 @@ ptp_ocp_probe(struct pci_dev *pdev, const struct pci_device_id *id)
 	pci_set_drvdata(pdev, NULL);
 out_disable:
 	pci_disable_device(pdev);
-out_unregister:
+out_free:
 	devlink_free(devlink);
 	return err;
 }
Signature · 1 line
2.31.1
maintainer
#1 lore raw

drivers/ptp/ptp_ocp.c ptp_ocp_probe(struct pci_dev *pdev, const struct pci_device_id *id) · line 2603

Quoted 1 line · On Thu, 3 Mar 2022 21:46:29 -0800 Jonathan Lemon wrote:
drivers/ptp/ptp_ocp.c +0 -1
-		gto out_unregister;

The git send-email deities are not on your side, it seems. Something ate an 'o' there.

Quoted 1 line
drivers/ptp/ptp_ocp.c +1 -0
+		goto out_free;