Skip to contentSkip to conversation

Input: synaptics: change initialization error into warning

PATCH New David Heidelberg 1 participant 1 message Mar 4, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Input: synaptics: change initialization error into warning

Since touchpad work on Dell XPS 9360 as expected while using Synopsys DesignWare driver, let's assume
warning about not loading driver can be lowered from error to warning.

Lower in some cases useless errors like these to warnings:
psmouse serio1: synaptics: Unable to query device: -5

---
 drivers/input/mouse/synaptics.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/input/mouse/synaptics.c +3 -3
index ffad142801b3..ffb13055c7dc 100644
@@ -1668,7 +1668,7 @@ static int __synaptics_init(struct psmouse *psmouse, bool absolute_mode)
 
 	error = synaptics_query_hardware(psmouse, &info);
 	if (error) {
-		psmouse_err(psmouse, "Unable to query device: %d\n", error);
+		psmouse_warn(psmouse, "Unable to query device: %d\n", error);
 		return error;
 	}
 
@@ -1824,7 +1824,7 @@ int synaptics_init_smbus(struct psmouse *psmouse)
 
 	error = synaptics_query_hardware(psmouse, &info);
 	if (error) {
-		psmouse_err(psmouse, "Unable to query device: %d\n", error);
+		psmouse_warn(psmouse, "Unable to query device: %d\n", error);
 		return error;
 	}
 
@@ -1864,7 +1864,7 @@ int synaptics_init(struct psmouse *psmouse)
 
 	error = synaptics_query_hardware(psmouse, &info);
 	if (error) {
-		psmouse_err(psmouse, "Unable to query device: %d\n", error);
+		psmouse_warn(psmouse, "Unable to query device: %d\n", error);
 		return error;
 	}
 
Signature · 1 line
2.34.1