5.10.104-rc1 review
Greg Kroah-Hartman
maintainercover 5.10.104-rc1 review
This is the start of the stable review cycle for the 5.10.104 release. There are 105 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Wed, 09 Mar 2022 09:16:25 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.104-rc1.gz
or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
and the diffstat can be found below.
thanks,
greg k-h
-------------
Pseudo-Shortlog of commits:
Greg Kroah-Hartman <[email protected]>
Linux 5.10.104-rc1
Jiri Bohac <[email protected]>
Revert "xfrm: xfrm_state_mtu should return at least 1280 for ipv6"
Filipe Manana <[email protected]>
btrfs: add missing run of delayed items after unlink during log replay
Sidong Yang <[email protected]>
btrfs: qgroup: fix deadlock between rescan worker and remove qgroup
Filipe Manana <[email protected]>
btrfs: fix lost prealloc extents beyond eof after full fsync
Randy Dunlap <[email protected]>
tracing: Fix return value of __setup handlers
Steven Rostedt (Google) <[email protected]>
tracing/histogram: Fix sorting on old "cpu" value
William Mahon <[email protected]>
HID: add mapping for KEY_ALL_APPLICATIONS
William Mahon <[email protected]>
HID: add mapping for KEY_DICTATE
David Gow <[email protected]>
Input: samsung-keypad - properly state IOMEM dependency
Hans de Goede <[email protected]>
Input: elan_i2c - fix regulator enable count imbalance after suspend/resume
Hans de Goede <[email protected]>
Input: elan_i2c - move regulator_[en|dis]able() out of elan_[en|dis]able_power()
Vladimir Oltean <[email protected]>
net: dcb: disable softirqs in dcbnl_flush_dev()
Qiang Yu <[email protected]>
drm/amdgpu: fix suspend/resume hang regression
Jiasheng Jiang <[email protected]>
nl80211: Handle nla_memdup failures in handle_nan_filter
Mateusz Palczewski <[email protected]>
iavf: Refactor iavf state machine tracking
Jia-Ju Bai <[email protected]>
net: chelsio: cxgb3: check the return value of pci_find_capability()
Sukadev Bhattiprolu <[email protected]>
ibmvnic: complete init_done on transport events
Sukadev Bhattiprolu <[email protected]>
ibmvnic: define flush_reset_queue helper
Thierry Reding <[email protected]>
ARM: tegra: Move panels to AUX bus
Jiasheng Jiang <[email protected]>
soc: fsl: qe: Check of ioremap return value
Christophe JAILLET <[email protected]>
soc: fsl: guts: Add a missing memory allocation failure check
Christophe JAILLET <[email protected]>
soc: fsl: guts: Revert commit 3c0d64e867ed
Anthoine Bourgeois <[email protected]>
ARM: dts: Use 32KiHz oscillator on devkit8000
Anthoine Bourgeois <[email protected]>
ARM: dts: switch timer config to common devkit8000 devicetree
Heiko Carstens <[email protected]>
s390/extable: fix exception table sorting
Hugh Dickins <[email protected]>
memfd: fix F_SEAL_WRITE after shmem huge page allocated
Sukadev Bhattiprolu <[email protected]>
ibmvnic: free reset-work-item when flushing
Sasha Neftin <[email protected]>
igc: igc_write_phy_reg_gpy: drop premature return
Samuel Holland <[email protected]>
pinctrl: sunxi: Use unique lockdep classes for IRQs
Amit Cohen <[email protected]>
selftests: mlxsw: tc_police_scale: Make test more robust
Randy Dunlap <[email protected]>
ARM: 9182/1: mmu: fix returns from early_param() and __setup() functions
Russell King (Oracle) <[email protected]>
ARM: Fix kgdb breakpoint for Thumb2
Corinna Vinschen <[email protected]>
igc: igc_read_phy_reg_gpy: drop premature return
Brian Norris <[email protected]>
arm64: dts: rockchip: Switch RK3399-Gru DP to SPDIF output
Vincent Mailhol <[email protected]>
can: gs_usb: change active_channels's type from atomic_t to u8
Fabio Estevam <[email protected]>
ASoC: cs4265: Fix the duplicated control name
Alyssa Ross <[email protected]>
firmware: arm_scmi: Remove space in MODULE_ALIAS name
Jann Horn <[email protected]>
efivars: Respect "block" flag in efivar_entry_set_safe()
Maciej Fijalkowski <[email protected]>
ixgbe: xsk: change !netif_carrier_ok() handling in ixgbe_xmit_zc()
Zheyu Ma <[email protected]>
net: arcnet: com20020: Fix null-ptr-deref in com20020pci_probe()
Sukadev Bhattiprolu <[email protected]>
ibmvnic: register netdev after init of adapter
Randy Dunlap <[email protected]>
net: sxgbe: fix return value of __setup handler
Slawomir Laba <[email protected]>
iavf: Fix missing check for running netdev
Johannes Berg <[email protected]>
mac80211: treat some SAE auth steps as final
Randy Dunlap <[email protected]>
net: stmmac: fix return value of __setup handler
Nicolas Escande <[email protected]>
mac80211: fix forwarded mesh frames AC & queue selection
Valentin Schneider <[email protected]>
ia64: ensure proper NUMA distance and possible map initialization
Dietmar Eggemann <[email protected]>
sched/topology: Fix sched_domain_topology_level alloc in sched_init_numa()
Valentin Schneider <[email protected]>
sched/topology: Make sched_init_numa() use a set for the deduplicating sort
Jacob Keller <[email protected]>
ice: fix concurrent reset and removal of VFs
Brett Creeley <[email protected]>
ice: Fix race conditions between virtchnl handling and VF ndo ops
Frederic Weisbecker <[email protected]>
rcu/nocb: Fix missed nocb_timer requeue
D. Wythe <[email protected]>
net/smc: fix unexpected SMC_CLC_DECL_ERR_REGRMB error cause by server
D. Wythe <[email protected]>
net/smc: fix unexpected SMC_CLC_DECL_ERR_REGRMB error generated by client
D. Wythe <[email protected]>
net/smc: fix connection leak
Vladimir Oltean <[email protected]>
net: dcb: flush lingering app table entries for unregistered devices
[email protected] <[email protected]>
net: ipv6: ensure we call ipv6_mc_down() at most once
Sven Eckelmann <[email protected]>
batman-adv: Don't expect inter-netns unique iflink indices
Sven Eckelmann <[email protected]>
batman-adv: Request iflink once in batadv_get_real_netdevice
Sven Eckelmann <[email protected]>
batman-adv: Request iflink once in batadv-on-batadv check
Florian Westphal <[email protected]>
netfilter: nf_queue: handle socket prefetch
Florian Westphal <[email protected]>
netfilter: nf_queue: fix possible use-after-free
Florian Westphal <[email protected]>
netfilter: nf_queue: don't assume sk is full socket
lena wang <[email protected]>
net: fix up skbs delta_truesize in UDP GRO frag_list
Sasha Neftin <[email protected]>
e1000e: Correct NVM checksum verification flow
Leon Romanovsky <[email protected]>
xfrm: enforce validity of offload input flags
Antony Antony <[email protected]>
xfrm: fix the if_id check in changelink
Eric Dumazet <[email protected]>
bpf, sockmap: Do not ignore orig_len parameter
Eric Dumazet <[email protected]>
netfilter: fix use-after-free in __nf_register_net_hook()
Jiri Bohac <[email protected]>
xfrm: fix MTU regression
Daniel Borkmann <[email protected]>
mm: Consider __GFP_NOWARN flag for oversized kvmalloc() calls
Dave Jiang <[email protected]>
ntb: intel: fix port config status offset for SPR
Nicolas Cavallari <[email protected]>
thermal: core: Fix TZ_GET_TRIP NULL pointer dereference
Marek Marczykowski-Górecki <[email protected]>
xen/netfront: destroy queues before real_num_tx_queues is zeroed
Ville Syrjälä <[email protected]>
drm/i915: s/JSP2/ICP2/ PCH
Lennert Buytenhek <[email protected]>
iommu/amd: Recover from event log overflow
Marek Vasut <[email protected]>
ASoC: ops: Shift tested values in snd_soc_put_volsw() by +min
Alexandre Ghiti <[email protected]>
riscv: Fix config KASAN && DEBUG_VIRTUAL
Alexandre Ghiti <[email protected]>
riscv: Fix config KASAN && SPARSEMEM && !SPARSE_VMEMMAP
Sunil V L <[email protected]>
riscv/efi_stub: Fix get_boot_hartid_from_fdt() return value
Zhen Ni <[email protected]>
ALSA: intel_hdmi: Fix reference to PCM buffer address
Steven Rostedt <[email protected]>
tracing: Add ustring operation to filtering string pointers
Qiang Yu <[email protected]>
drm/amdgpu: check vm ready by amdgpu_vm->evicting flag
Sergey Shtylyov <[email protected]>
ata: pata_hpt37x: fix PCI clock detection
Valentin Caron <[email protected]>
serial: stm32: prevent TDR register overwrite when sending x_char
Steven Rostedt <[email protected]>
tracing: Add test for user space strings when filtering on string pointers
Christophe Vu-Brugier <[email protected]>
exfat: fix i_blocks for files truncated over 4 GiB
Christophe Vu-Brugier <[email protected]>
exfat: reuse exfat_inode_info variable instead of calling EXFAT_I()
Hangyu Hua <[email protected]>
usb: gadget: clear related members when goto fail
Hangyu Hua <[email protected]>
usb: gadget: don't release an existing dev->buf
Daniele Palmas <[email protected]>
net: usb: cdc_mbim: avoid altsetting toggling for Telit FN990
Wolfram Sang <[email protected]>
i2c: qup: allow COMPILE_TEST
Wolfram Sang <[email protected]>
i2c: cadence: allow COMPILE_TEST
Yongzhi Liu <[email protected]>
dmaengine: shdma: Fix runtime PM imbalance on error
Sherry Yang <[email protected]>
selftests/seccomp: Fix seccomp failure by adding missing headers
Ronnie Sahlberg <[email protected]>
cifs: fix double free race when mount fails in cifs_get_root()
Hangyu Hua <[email protected]>
tipc: fix a bit overflow in tipc_crypto_key_rcv()
Marc Zyngier <[email protected]>
KVM: arm64: vgic: Read HW interrupt pending state from the HW
José Expósito <[email protected]>
Input: clear BTN_RIGHT/MIDDLE on buttonpads
Oliver Barta <[email protected]>
regulator: core: fix false positive in regulator_late_cleanup()
Kai Vehmanen <[email protected]>
ASoC: rt5682: do not block workqueue if card is unbound
Kai Vehmanen <[email protected]>
ASoC: rt5668: do not block workqueue if card is unbound
Eric Anholt <[email protected]>
i2c: bcm2835: Avoid clock stretching timeouts
JaeMan Park <[email protected]>
mac80211_hwsim: initialize ieee80211_tx_info at hw_scan_work
Benjamin Beichler <[email protected]>
mac80211_hwsim: report NOACK frames in tx_status
-------------
Diffstat:
Documentation/trace/events.rst | 19 ++++ Makefile | 4 +- arch/arm/boot/dts/omap3-devkit8000-common.dtsi | 18 ++++ arch/arm/boot/dts/omap3-devkit8000.dts | 33 ------- arch/arm/boot/dts/tegra124-nyan-big.dts | 15 +-- arch/arm/boot/dts/tegra124-nyan-blaze.dts | 15 +-- arch/arm/boot/dts/tegra124-venice2.dts | 14 +-- arch/arm/kernel/kgdb.c | 36 +++++-- arch/arm/mm/mmu.c | 2 + arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi | 17 +++- arch/arm64/kvm/vgic/vgic-mmio.c | 2 + arch/ia64/kernel/acpi.c | 7 +- arch/riscv/mm/Makefile | 3 + arch/riscv/mm/kasan_init.c | 3 +- arch/s390/include/asm/extable.h | 9 +- drivers/ata/pata_hpt37x.c | 4 +- drivers/clocksource/timer-ti-dm-systimer.c | 3 +- drivers/dma/sh/shdma-base.c | 4 +- drivers/firmware/arm_scmi/driver.c | 2 +- drivers/firmware/efi/libstub/riscv-stub.c | 17 ++-- drivers/firmware/efi/vars.c | 5 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 10 +- drivers/gpu/drm/i915/intel_pch.c | 2 +- drivers/gpu/drm/i915/intel_pch.h | 2 +- drivers/hid/hid-debug.c | 5 +- drivers/hid/hid-input.c | 3 + drivers/i2c/busses/Kconfig | 4 +- drivers/i2c/busses/i2c-bcm2835.c | 11 +++ drivers/input/input.c | 6 ++ drivers/input/keyboard/Kconfig | 2 +- drivers/input/mouse/elan_i2c_core.c | 64 +++++------- drivers/iommu/amd/amd_iommu.h | 1 + drivers/iommu/amd/amd_iommu_types.h | 1 + drivers/iommu/amd/init.c | 10 ++ drivers/iommu/amd/iommu.c | 10 +- drivers/net/arcnet/com20020-pci.c | 3 + drivers/net/can/usb/gs_usb.c | 10 +- drivers/net/ethernet/chelsio/cxgb3/t3_hw.c | 2 + drivers/net/ethernet/ibm/ibmvnic.c | 39 ++++++-- drivers/net/ethernet/intel/e1000e/ich8lan.c | 4 +- drivers/net/ethernet/intel/iavf/iavf.h | 10 ++ drivers/net/ethernet/intel/iavf/iavf_main.c | 44 +++++---- drivers/net/ethernet/intel/iavf/iavf_virtchnl.c | 2 +- drivers/net/ethernet/intel/ice/ice_main.c | 2 + drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c | 58 +++++++++-- drivers/net/ethernet/intel/ice/ice_virtchnl_pf.h | 5 + drivers/net/ethernet/intel/igc/igc_phy.c | 4 - drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c | 6 +- drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c | 6 +- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 6 +- drivers/net/usb/cdc_mbim.c | 5 + drivers/net/wireless/mac80211_hwsim.c | 13 +++ drivers/net/xen-netfront.c | 39 +++++--- drivers/ntb/hw/intel/ntb_hw_gen4.c | 17 +++- drivers/ntb/hw/intel/ntb_hw_gen4.h | 16 +++ drivers/pinctrl/sunxi/pinctrl-sunxi.c | 9 ++ drivers/regulator/core.c | 13 +-- drivers/soc/fsl/guts.c | 14 ++- drivers/soc/fsl/qe/qe_io.c | 2 + drivers/thermal/thermal_netlink.c | 5 +- drivers/tty/serial/stm32-usart.c | 12 +++ drivers/usb/gadget/legacy/inode.c | 10 +- fs/btrfs/qgroup.c | 9 +- fs/btrfs/tree-log.c | 61 +++++++++--- fs/cifs/cifsfs.c | 1 + fs/exfat/file.c | 18 ++-- fs/exfat/inode.c | 13 ++- fs/exfat/namei.c | 6 +- fs/exfat/super.c | 10 +- include/linux/topology.h | 1 + include/net/netfilter/nf_queue.h | 2 +- include/net/xfrm.h | 1 - include/uapi/linux/input-event-codes.h | 4 +- include/uapi/linux/xfrm.h | 6 ++ kernel/rcu/tree_plugin.h | 7 +- kernel/sched/topology.c | 99 +++++++++---------- kernel/trace/trace.c | 4 +- kernel/trace/trace_events_filter.c | 107 +++++++++++++++++++-- kernel/trace/trace_events_hist.c | 6 +- kernel/trace/trace_kprobe.c | 2 +- mm/memfd.c | 40 +++++--- mm/util.c | 4 +- net/batman-adv/hard-interface.c | 29 ++++-- net/core/skbuff.c | 2 +- net/core/skmsg.c | 2 +- net/dcb/dcbnl.c | 44 +++++++++ net/ipv4/esp4.c | 2 +- net/ipv6/addrconf.c | 8 +- net/ipv6/esp6.c | 2 +- net/ipv6/ip6_output.c | 11 ++- net/mac80211/ieee80211_i.h | 2 +- net/mac80211/mlme.c | 16 ++- net/mac80211/rx.c | 4 +- net/netfilter/core.c | 5 +- net/netfilter/nf_queue.c | 36 ++++++- net/netfilter/nfnetlink_queue.c | 12 ++- net/smc/af_smc.c | 10 +- net/smc/smc_core.c | 5 +- net/tipc/crypto.c | 2 +- net/wireless/nl80211.c | 12 +++ net/xfrm/xfrm_device.c | 6 +- net/xfrm/xfrm_interface.c | 2 +- net/xfrm/xfrm_state.c | 14 +-- sound/soc/codecs/cs4265.c | 3 +- sound/soc/codecs/rt5668.c | 12 ++- sound/soc/codecs/rt5682.c | 12 ++- sound/soc/soc-ops.c | 4 +- sound/x86/intel_hdmi_audio.c | 2 +- .../selftests/drivers/net/mlxsw/tc_police_scale.sh | 3 +- tools/testing/selftests/seccomp/Makefile | 2 +- 110 files changed, 960 insertions(+), 424 deletions(-)
Greg Kroah-Hartman
maintainerPATCH 1/105 mac80211_hwsim: report NOACK frames in tx_status
From: Benjamin Beichler <[email protected]>
[ Upstream commit 42a79960ffa50bfe9e0bf5d6280be89bf563a5dd ]
Add IEEE80211_TX_STAT_NOACK_TRANSMITTED to tx_status flags to have proper statistics for non-acked frames.
--- drivers/net/wireless/mac80211_hwsim.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/net/wireless/mac80211_hwsim.c +4 -0
@@ -3567,6 +3567,10 @@ static int hwsim_tx_info_frame_received_nl(struct sk_buff *skb_2, } txi->flags |=IEEE80211_TX_STAT_ACK ; } + +if (hwsim_flags &HWSIM_TX_CTL_NO_ACK ) + txi->flags |=IEEE80211_TX_STAT_NOACK_TRANSMITTED ; +ieee80211_tx_status_irqsafe (data2->hw, skb);return 0 ; out:
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 2/105 mac80211_hwsim: initialize ieee80211_tx_info at hw_scan_work
In reply to Greg Kroah-HartmanFrom: JaeMan Park <[email protected]>
[ Upstream commit cacfddf82baf1470e5741edeecb187260868f195 ]
In mac80211_hwsim, the probe_req frame is created and sent while scanning. It is sent with ieee80211_tx_info which is not initialized. Uninitialized ieee80211_tx_info can cause problems when using mac80211_hwsim with wmediumd. wmediumd checks the tx_rates field of ieee80211_tx_info and doesn't relay probe_req frame to other clients even if it is a broadcasting message.
Call ieee80211_tx_prepare_skb() to initialize ieee80211_tx_info for the probe_req that is created by hw_scan_work in mac80211_hwsim.
--- drivers/net/wireless/mac80211_hwsim.c | 9 +++++++++ 1 file changed, 9 insertions(+)
drivers/net/wireless/mac80211_hwsim.c +9 -0
@@ -2264,6 +2264,15 @@ static void hw_scan_work(struct work_struct *work)if (req->ie_len)skb_put_data (probe, req->ie, req->ie_len); +if (!ieee80211_tx_prepare_skb (hwsim->hw, + hwsim->hw_scan_vif, + probe, + hwsim->tmp_chan->band, +NULL )) { +kfree_skb (probe); +continue ; + } +local_bh_disable ();mac80211_hwsim_tx_frame (hwsim->hw, probe, hwsim->tmp_chan);
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 3/105 i2c: bcm2835: Avoid clock stretching timeouts
In reply to Greg Kroah-HartmanFrom: Eric Anholt <[email protected]>
[ Upstream commit 9495b9b31abe525ebd93da58de2c88b9f66d3a0e ]
The CLKT register contains at poweron 0x40, which at our typical 100kHz bus rate means .64ms. But there is no specified limit to how long devices should be able to stretch the clocks, so just disable the timeout. We still have a timeout wrapping the entire transfer.
--- drivers/i2c/busses/i2c-bcm2835.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
drivers/i2c/busses/i2c-bcm2835.c +11 -0
@@ -23,6 +23,11 @@#define BCM2835_I2C_FIFO 0x10#define BCM2835_I2C_DIV 0x14#define BCM2835_I2C_DEL 0x18 +/* +* 16-bit field for the number of SCL cycles to wait after rising SCL +* before deciding the slave is not responding. 0 disables the +* timeout detection. +*/ #define BCM2835_I2C_CLKT 0x1c#define BCM2835_I2C_C_READ BIT(0)
@@ -477,6 +482,12 @@ static int bcm2835_i2c_probe(struct platform_device *pdev) adap->dev.of_node = pdev->dev.of_node; adap->quirks =of_device_get_match_data (&pdev->dev); +/* +* Disable the hardware clock stretching timeout. SMBUS +* specifies a limit for how long the device can stretch the +* clock, but core I2C doesn't. +*/ +bcm2835_i2c_writel (i2c_dev,BCM2835_I2C_CLKT ,0 );bcm2835_i2c_writel (i2c_dev,BCM2835_I2C_C ,0 ); ret =i2c_add_adapter (adap);
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 4/105 ASoC: rt5668: do not block workqueue if card is unbound
In reply to Greg Kroah-HartmanFrom: Kai Vehmanen <[email protected]>
[ Upstream commit a6d78661dc903d90a327892bbc34268f3a5f4b9c ]
The current rt5668_jack_detect_handler() assumes the component and card will always show up and implements an infinite usleep loop waiting for them to show up.
This does not hold true if a codec interrupt (or other event) occurs when the card is unbound. The codec driver's remove or shutdown functions cannot cancel the workqueue due to the wait loop. As a result, code can either end up blocking the workqueue, or hit a kernel oops when the card is freed.
Fix the issue by rescheduling the jack detect handler in case the card is not ready. In case card never shows up, the shutdown/remove/suspend calls can now cancel the detect task.
--- sound/soc/codecs/rt5668.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-)
sound/soc/codecs/rt5668.c +7 -5
@@ -1022,11 +1022,13 @@ static void rt5668_jack_detect_handler(struct work_struct *work) container_of(work, struct rt5668_priv, jack_detect_work.work);int val, btn_type; -while (!rt5668->component) -usleep_range (10000 ,15000 ); - -while (!rt5668->component->card->instantiated) -usleep_range (10000 ,15000 ); +if (!rt5668->component || !rt5668->component->card || + !rt5668->component->card->instantiated) { +/* card not yet ready, try later */ +mod_delayed_work (system_power_efficient_wq, + &rt5668->jack_detect_work,msecs_to_jiffies (15 )); +return ; + }mutex_lock (&rt5668->calibrate_mutex);
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 5/105 ASoC: rt5682: do not block workqueue if card is unbound
In reply to Greg Kroah-HartmanFrom: Kai Vehmanen <[email protected]>
[ Upstream commit 4c33de0673ced9c7c37b3bbd9bfe0fda72340b2a ]
The current rt5682_jack_detect_handler() assumes the component and card will always show up and implements an infinite usleep loop waiting for them to show up.
This does not hold true if a codec interrupt (or other event) occurs when the card is unbound. The codec driver's remove or shutdown functions cannot cancel the workqueue due to the wait loop. As a result, code can either end up blocking the workqueue, or hit a kernel oops when the card is freed.
Fix the issue by rescheduling the jack detect handler in case the card is not ready. In case card never shows up, the shutdown/remove/suspend calls can now cancel the detect task.
--- sound/soc/codecs/rt5682.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-)
sound/soc/codecs/rt5682.c +7 -5
@@ -1081,11 +1081,13 @@ void rt5682_jack_detect_handler(struct work_struct *work) container_of(work, struct rt5682_priv, jack_detect_work.work);int val, btn_type; -while (!rt5682->component) -usleep_range (10000 ,15000 ); - -while (!rt5682->component->card->instantiated) -usleep_range (10000 ,15000 ); +if (!rt5682->component || !rt5682->component->card || + !rt5682->component->card->instantiated) { +/* card not yet ready, try later */ +mod_delayed_work (system_power_efficient_wq, + &rt5682->jack_detect_work,msecs_to_jiffies (15 )); +return ; + }mutex_lock (&rt5682->calibrate_mutex);
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 6/105 regulator: core: fix false positive in regulator_late_cleanup()
In reply to Greg Kroah-HartmanFrom: Oliver Barta <[email protected]>
[ Upstream commit 4e2a354e3775870ca823f1fb29bbbffbe11059a6 ]
The check done by regulator_late_cleanup() to detect whether a regulator is on was inconsistent with the check done by _regulator_is_enabled(). While _regulator_is_enabled() takes the enable GPIO into account, regulator_late_cleanup() was not doing that.
This resulted in a false positive, e.g. when a GPIO-controlled fixed regulator was used, which was not enabled at boot time, e.g.
reg_disp_1v2: reg_disp_1v2 {
compatible = "regulator-fixed";
regulator-name = "display_1v2";
regulator-min-microvolt = <1200000>;
regulator-max-microvolt = <1200000>;
gpio = <&tlmm 148 0>;
enable-active-high;
};Such regulator doesn't have an is_enabled() operation. Nevertheless it's state can be determined based on the enable GPIO. The check in regulator_late_cleanup() wrongly assumed that the regulator is on and tried to disable it.
--- drivers/regulator/core.c | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-)
drivers/regulator/core.c +3 -10
@@ -5862,9 +5862,8 @@ core_initcall(regulator_init);static int regulator_late_cleanup (struct device *dev,void *data) {struct regulator_dev *rdev =dev_to_rdev (dev); -const struct regulator_ops *ops = rdev->desc->ops;struct regulation_constraints *c = rdev->constraints; -int enabled, ret; +int ret;if (c && c->always_on)return 0 ;
@@ -5877,14 +5876,8 @@ static int regulator_late_cleanup(struct device *dev, void *data)if (rdev->use_count) goto unlock; -/* If we can't read the status assume it's always on. */ -if (ops->is_enabled) - enabled = ops->is_enabled (rdev); -else - enabled =1 ; - -/* But if reading the status failed, assume that it's off. */ -if (enabled <=0 ) +/* If reading the status failed, assume that it's off. */ +if (_regulator_is_enabled (rdev) <=0 ) goto unlock;if (have_full_constraints ()) {
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 7/105 Input: clear BTN_RIGHT/MIDDLE on buttonpads
In reply to Greg Kroah-HartmanFrom: José Expósito <[email protected]>
[ Upstream commit 37ef4c19b4c659926ce65a7ac709ceaefb211c40 ]
Buttonpads are expected to map the INPUT_PROP_BUTTONPAD property bit and the BTN_LEFT key bit.
As explained in the specification, where a device has a button type value of 0 (click-pad) or 1 (pressure-pad) there should not be discrete buttons:
https://docs.microsoft.com/en-us/windows-hardware/design/component-guidelines/touchpad-windows-precision-touchpad-collection#device-capabilities-feature-report
However, some drivers map the BTN_RIGHT and/or BTN_MIDDLE key bits even though the device is a buttonpad and therefore does not have those buttons.
This behavior has forced userspace applications like libinput to implement different workarounds and quirks to detect buttonpads and offer to the user the right set of features and configuration options. For more information:
https://gitlab.freedesktop.org/libinput/libinput/-/merge_requests/726
In order to avoid this issue clear the BTN_RIGHT and BTN_MIDDLE key bits when the input device is register if the INPUT_PROP_BUTTONPAD property bit is set.
Notice that this change will not affect udev because it does not check for buttons. See systemd/src/udev/udev-builtin-input_id.c.
List of known affected hardware:
- Chuwi AeroBook Plus
- Chuwi Gemibook
- Framework Laptop
- GPD Win Max
- Huawei MateBook 2020
- Prestigio Smartbook 141 C2
- Purism Librem 14v1
- StarLite Mk II - AMI firmware - StarLite Mk II - Coreboot firmware - StarLite Mk III - AMI firmware - StarLite Mk III - Coreboot firmware
- StarLabTop Mk IV - AMI firmware
- StarLabTop Mk IV - Coreboot firmware
- StarBook Mk V
--- drivers/input/input.c | 6 ++++++ 1 file changed, 6 insertions(+)
drivers/input/input.c +6 -0
@@ -2179,6 +2179,12 @@ int input_register_device(struct input_dev *dev)/* KEY_RESERVED is not supposed to be transmitted to userspace. */ __clear_bit (KEY_RESERVED , dev->keybit); +/* Buttonpads should not map BTN_RIGHT and/or BTN_MIDDLE. */ +if (test_bit (INPUT_PROP_BUTTONPAD , dev->propbit)) { +__clear_bit (BTN_RIGHT , dev->keybit); +__clear_bit (BTN_MIDDLE , dev->keybit); + } +/* Make sure that bitmasks not mentioned in dev->evbit are clean. */ input_cleanse_bitmasks (dev);
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 8/105 KVM: arm64: vgic: Read HW interrupt pending state from the HW
In reply to Greg Kroah-HartmanFrom: Marc Zyngier <[email protected]>
[ Upstream commit 5bfa685e62e9ba93c303a9a8db646c7228b9b570 ]
It appears that a read access to GIC[DR]_I[CS]PENDRn doesn't always result in the pending interrupts being accurately reported if they are mapped to a HW interrupt. This is particularily visible when acking the timer interrupt and reading the GICR_ISPENDR1 register immediately after, for example (the interrupt appears as not-pending while it really is...).
This is because a HW interrupt has its 'active and pending state' kept in the *physical* distributor, and not in the virtual one, as mandated by the spec (this is what allows the direct deactivation). The virtual distributor only caries the pending and active *states* (note the plural, as these are two independent and non-overlapping states).
Fix it by reading the HW state back, either from the timer itself or from the distributor if necessary.
--- arch/arm64/kvm/vgic/vgic-mmio.c | 2 ++ 1 file changed, 2 insertions(+)
arch/arm64/kvm/vgic/vgic-mmio.c +2 -0
@@ -248,6 +248,8 @@ unsigned long vgic_mmio_read_pending(struct kvm_vcpu *vcpu,IRQCHIP_STATE_PENDING , &val);WARN_RATELIMIT (err,"IRQ %d" , irq->host_irq); + }else if (vgic_irq_is_mapped_level (irq)) { + val =vgic_get_phys_line_level (irq); }else { val =irq_is_pending (irq); }
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 9/105 tipc: fix a bit overflow in tipc_crypto_key_rcv()
In reply to Greg Kroah-HartmanFrom: Hangyu Hua <[email protected]>
[ Upstream commit 143de8d97d79316590475dc2a84513c63c863ddf ]
msg_data_sz return a 32bit value, but size is 16bit. This may lead to a bit overflow.
--- net/tipc/crypto.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/tipc/crypto.c +1 -1
@@ -2280,7 +2280,7 @@ static bool tipc_crypto_key_rcv(struct tipc_crypto *rx, struct tipc_msg *hdr)struct tipc_crypto *tx =tipc_net (rx->net)->crypto_tx;struct tipc_aead_key *skey =NULL ;u16 key_gen =msg_key_gen (hdr); -u16 size =msg_data_sz (hdr); +u32 size =msg_data_sz (hdr);u8 *data =msg_data (hdr);unsigned int keylen;
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 10/105 cifs: fix double free race when mount fails in cifs_get_root()
In reply to Greg Kroah-HartmanFrom: Ronnie Sahlberg <[email protected]>
[ Upstream commit 3d6cc9898efdfb062efb74dc18cfc700e082f5d5 ]
When cifs_get_root() fails during cifs_smb3_do_mount() we call deactivate_locked_super() which eventually will call delayed_free() which will free the context.
In this situation we should not proceed to enter the out: section in cifs_smb3_do_mount() and free the same resources a second time.
[Thu Feb 10 12:59:06 2022] BUG: KASAN: use-after-free in rcu_cblist_dequeue+0x32/0x60 [Thu Feb 10 12:59:06 2022] Read of size 8 at addr ffff888364f4d110 by task swapper/1/0
[Thu Feb 10 12:59:06 2022] CPU: 1 PID: 0 Comm: swapper/1 Tainted: G OE 5.17.0-rc3+ #4 [Thu Feb 10 12:59:06 2022] Hardware name: Microsoft Corporation Virtual Machine/Virtual Machine, BIOS Hyper-V UEFI Release v4.0 12/17/2019 [Thu Feb 10 12:59:06 2022] Call Trace: [Thu Feb 10 12:59:06 2022] <IRQ> [Thu Feb 10 12:59:06 2022] dump_stack_lvl+0x5d/0x78 [Thu Feb 10 12:59:06 2022] print_address_description.constprop.0+0x24/0x150 [Thu Feb 10 12:59:06 2022] ? rcu_cblist_dequeue+0x32/0x60 [Thu Feb 10 12:59:06 2022] kasan_report.cold+0x7d/0x117 [Thu Feb 10 12:59:06 2022] ? rcu_cblist_dequeue+0x32/0x60 [Thu Feb 10 12:59:06 2022] __asan_load8+0x86/0xa0 [Thu Feb 10 12:59:06 2022] rcu_cblist_dequeue+0x32/0x60 [Thu Feb 10 12:59:06 2022] rcu_core+0x547/0xca0 [Thu Feb 10 12:59:06 2022] ? call_rcu+0x3c0/0x3c0 [Thu Feb 10 12:59:06 2022] ? __this_cpu_preempt_check+0x13/0x20 [Thu Feb 10 12:59:06 2022] ? lock_is_held_type+0xea/0x140 [Thu Feb 10 12:59:06 2022] rcu_core_si+0xe/0x10 [Thu Feb 10 12:59:06 2022] __do_softirq+0x1d4/0x67b [Thu Feb 10 12:59:06 2022] __irq_exit_rcu+0x100/0x150 [Thu Feb 10 12:59:06 2022] irq_exit_rcu+0xe/0x30 [Thu Feb 10 12:59:06 2022] sysvec_hyperv_stimer0+0x9d/0xc0 ... [Thu Feb 10 12:59:07 2022] Freed by task 58179: [Thu Feb 10 12:59:07 2022] kasan_save_stack+0x26/0x50 [Thu Feb 10 12:59:07 2022] kasan_set_track+0x25/0x30 [Thu Feb 10 12:59:07 2022] kasan_set_free_info+0x24/0x40 [Thu Feb 10 12:59:07 2022] ____kasan_slab_free+0x137/0x170 [Thu Feb 10 12:59:07 2022] __kasan_slab_free+0x12/0x20 [Thu Feb 10 12:59:07 2022] slab_free_freelist_hook+0xb3/0x1d0 [Thu Feb 10 12:59:07 2022] kfree+0xcd/0x520 [Thu Feb 10 12:59:07 2022] cifs_smb3_do_mount+0x149/0xbe0 [cifs] [Thu Feb 10 12:59:07 2022] smb3_get_tree+0x1a0/0x2e0 [cifs] [Thu Feb 10 12:59:07 2022] vfs_get_tree+0x52/0x140 [Thu Feb 10 12:59:07 2022] path_mount+0x635/0x10c0 [Thu Feb 10 12:59:07 2022] __x64_sys_mount+0x1bf/0x210 [Thu Feb 10 12:59:07 2022] do_syscall_64+0x5c/0xc0 [Thu Feb 10 12:59:07 2022] entry_SYSCALL_64_after_hwframe+0x44/0xae
[Thu Feb 10 12:59:07 2022] Last potentially related work creation: [Thu Feb 10 12:59:07 2022] kasan_save_stack+0x26/0x50 [Thu Feb 10 12:59:07 2022] __kasan_record_aux_stack+0xb6/0xc0 [Thu Feb 10 12:59:07 2022] kasan_record_aux_stack_noalloc+0xb/0x10 [Thu Feb 10 12:59:07 2022] call_rcu+0x76/0x3c0 [Thu Feb 10 12:59:07 2022] cifs_umount+0xce/0xe0 [cifs] [Thu Feb 10 12:59:07 2022] cifs_kill_sb+0xc8/0xe0 [cifs] [Thu Feb 10 12:59:07 2022] deactivate_locked_super+0x5d/0xd0 [Thu Feb 10 12:59:07 2022] cifs_smb3_do_mount+0xab9/0xbe0 [cifs] [Thu Feb 10 12:59:07 2022] smb3_get_tree+0x1a0/0x2e0 [cifs] [Thu Feb 10 12:59:07 2022] vfs_get_tree+0x52/0x140 [Thu Feb 10 12:59:07 2022] path_mount+0x635/0x10c0 [Thu Feb 10 12:59:07 2022] __x64_sys_mount+0x1bf/0x210 [Thu Feb 10 12:59:07 2022] do_syscall_64+0x5c/0xc0 [Thu Feb 10 12:59:07 2022] entry_SYSCALL_64_after_hwframe+0x44/0xae
--- fs/cifs/cifsfs.c | 1 + 1 file changed, 1 insertion(+)
fs/cifs/cifsfs.c +1 -0
@@ -864,6 +864,7 @@ cifs_smb3_do_mount(struct file_system_type *fs_type, out_super:deactivate_locked_super (sb); +return root; out:cifs_cleanup_volume_info (volume_info);return root;
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 11/105 selftests/seccomp: Fix seccomp failure by adding missing headers
In reply to Greg Kroah-HartmanFrom: Sherry Yang <[email protected]>
[ Upstream commit 21bffcb76ee2fbafc7d5946cef10abc9df5cfff7 ]
seccomp_bpf failed on tests 47 global.user_notification_filter_empty and 48 global.user_notification_filter_empty_threaded when it's tested on updated kernel but with old kernel headers. Because old kernel headers don't have definition of macro __NR_clone3 which is required for these two tests. Since under selftests/, we can install headers once for all tests (the default INSTALL_HDR_PATH is usr/include), fix it by adding usr/include to the list of directories to be searched. Use "-isystem" to indicate it's a system directory as the real kernel headers directories are.
--- tools/testing/selftests/seccomp/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/seccomp/Makefile +1 -1
@@ -1,5 +1,5 @@ # SPDX-License-Identifier: GPL-2.0 -CFLAGS += -Wl,-no-as-needed -Wall +CFLAGS += -Wl,-no-as-needed -Wall -isystem ../../../../usr/include/ LDFLAGS += -lpthread TEST_GEN_PROGS := seccomp_bpf seccomp_benchmark
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 12/105 dmaengine: shdma: Fix runtime PM imbalance on error
In reply to Greg Kroah-HartmanFrom: Yongzhi Liu <[email protected]>
[ Upstream commit 455896c53d5b803733ddd84e1bf8a430644439b6 ]
pm_runtime_get_() increments the runtime PM usage counter even when it returns an error code, thus a matching decrement is needed on the error handling path to keep the counter balanced.
--- drivers/dma/sh/shdma-base.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/dma/sh/shdma-base.c +3 -1
@@ -115,8 +115,10 @@ static dma_cookie_t shdma_tx_submit(struct dma_async_tx_descriptor *tx) ret =pm_runtime_get (schan->dev);spin_unlock_irq (&schan->chan_lock); -if (ret <0 ) +if (ret <0 ) {dev_err (schan->dev,"%s(): GET = %d\n" , __func__, ret); +pm_runtime_put (schan->dev); + }pm_runtime_barrier (schan->dev);
Signature · 1 line
2.34.1
Re: [PATCH 5.10 012/105] dmaengine: shdma: Fix runtime PM imbalance on error
Hi!
Quoted 7 lines
From: Yongzhi Liu <[email protected]>
[ Upstream commit
455896c53d5b803733ddd84e1bf8a430644439b6]
pm_runtime_get_()increments the runtime PM usage counter even when it returns an error code, thus a matching decrement is needed on the error handling path to keep the counter balanced.
This patch will break things.
Notice that -ret is ignored (checked 4.4 and 5.10), so we don't actually abort/return error; we just printk. We'll do two pm_runtime_put's after the "fix".
Please drop from -stable.
It was discussed during AUTOSEL review:
Date: Fri, 25 Feb 2022 14:25:10 +0800 (GMT+08:00)
From: 刘永志 <[email protected]>
To: pavel machek <[email protected]>
Cc: sasha levin <[email protected]>, [email protected],
Subject: Re: [PATCH AUTOSEL 5.16 24/30] dmaengine: shdma: Fix runtime PM
imbalance on error
Best regards,
Pavel
Quoted 17 lines
+++
b/drivers/dma/sh/shdma-base.cdrivers/dma/sh/shdma-base.c +3
-1@@ -115,8 +115,10 @@ static dma_cookie_t shdma_tx_submit(struct dma_async_tx_descriptor *tx) ret =pm_runtime_get (schan->dev);spin_unlock_irq (&schan->chan_lock); -if (ret <0 ) +if (ret <0 ) {dev_err (schan->dev,"%s(): GET = %d\n" , __func__, ret); +pm_runtime_put (schan->dev); + }pm_runtime_barrier (schan->dev);Signature · 1 line
2.34.1
Signature · 2 lines
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Greg Kroah-Hartman
maintainerRe: [PATCH 5.10 012/105] dmaengine: shdma: Fix runtime PM imbalance on error
Quoted 18 lines · Pavel Machek
Hi!
Quoted 7 lines
From: Yongzhi Liu <[email protected]>
[ Upstream commit
455896c53d5b803733ddd84e1bf8a430644439b6]
pm_runtime_get_()increments the runtime PM usage counter even when it returns an error code, thus a matching decrement is needed on the error handling path to keep the counter balanced.This patch will break things.
Notice that -ret is ignored (checked 4.4 and 5.10), so we don't actually abort/return error; we just printk. We'll do two pm_runtime_put's after the "fix".
Please drop from -stable.
Quoted 8 lines
It was discussed during AUTOSEL review:
Date: Fri, 25 Feb 2022 14:25:10 +0800 (GMT+08:00)
From: 刘永志 <[email protected]>
To: pavel machek <[email protected]>
Cc: sasha levin <[email protected]>, [email protected],
Subject: Re: [PATCH AUTOSEL 5.16 24/30] dmaengine: shdma: Fix runtime PM
imbalance on error
So 5.15 and 5.16 is ok, but older is not?
thanks,
greg k-h
Re: [PATCH 5.10 012/105] dmaengine: shdma: Fix runtime PM imbalance on error
Quoted 21 lines · Greg Kroah-Hartman
Quoted 20 lines · Pavel Machek
Hi!
Quoted 7 lines
From: Yongzhi Liu <[email protected]>
[ Upstream commit
455896c53d5b803733ddd84e1bf8a430644439b6]
pm_runtime_get_()increments the runtime PM usage counter even when it returns an error code, thus a matching decrement is needed on the error handling path to keep the counter balanced.This patch will break things.
Notice that -ret is ignored (checked 4.4 and 5.10), so we don't actually abort/return error; we just printk. We'll do two pm_runtime_put's after the "fix".
Please drop from -stable.
It was discussed during AUTOSEL review:
Quoted 8 lines
Quoted 6 lines
Date: Fri, 25 Feb 2022 14:25:10 +0800 (GMT+08:00)
From: 刘永志 <[email protected]>
To: pavel machek <[email protected]>
Cc: sasha levin <[email protected]>, [email protected],
Subject: Re: [PATCH AUTOSEL 5.16 24/30] dmaengine: shdma: Fix runtime PM
imbalance on errorSo 5.15 and 5.16 is ok, but older is not?
I believe commit is wrong for mainline and all stable releases, and author seems to agree. Drop from everywhere.
(And sorry for confusion, I concentrate on 5.10/4.19; that's why mail was ambiguous).
Best regards,
Pavel
Signature · 2 lines
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Greg Kroah-Hartman
maintainerRe: [PATCH 5.10 012/105] dmaengine: shdma: Fix runtime PM imbalance on error
Quoted 29 lines · Pavel Machek
Quoted 28 lines · Greg Kroah-Hartman
Quoted 26 lines · Pavel Machek
Hi!
Quoted 7 lines
From: Yongzhi Liu <[email protected]>
[ Upstream commit
455896c53d5b803733ddd84e1bf8a430644439b6]
pm_runtime_get_()increments the runtime PM usage counter even when it returns an error code, thus a matching decrement is needed on the error handling path to keep the counter balanced.This patch will break things.
Notice that -ret is ignored (checked 4.4 and 5.10), so we don't actually abort/return error; we just printk. We'll do two pm_runtime_put's after the "fix".
Please drop from -stable.
It was discussed during AUTOSEL review:
Date: Fri, 25 Feb 2022 14:25:10 +0800 (GMT+08:00)
From: 刘永志 <[email protected]>
To: pavel machek <[email protected]>
Cc: sasha levin <[email protected]>, [email protected],
Subject: Re: [PATCH AUTOSEL 5.16 24/30] dmaengine: shdma: Fix runtime PM
imbalance on error
Quoted 4 lines
Quoted 1 line
So 5.15 and 5.16 is ok, but older is not?
I believe commit is wrong for mainline and all stable releases, and author seems to agree. Drop from everywhere.
Is it reverted in Linus's tree yet?
thanks,
greg k-h
Re: [PATCH 5.10 012/105] dmaengine: shdma: Fix runtime PM imbalance on error
Quoted 30 lines · Greg Kroah-Hartman
Quoted 29 lines · Pavel Machek
Quoted 28 lines · Greg Kroah-Hartman
Quoted 26 lines · Pavel Machek
Hi!
Quoted 7 lines
From: Yongzhi Liu <[email protected]>
[ Upstream commit
455896c53d5b803733ddd84e1bf8a430644439b6]
pm_runtime_get_()increments the runtime PM usage counter even when it returns an error code, thus a matching decrement is needed on the error handling path to keep the counter balanced.This patch will break things.
Notice that -ret is ignored (checked 4.4 and 5.10), so we don't actually abort/return error; we just printk. We'll do two pm_runtime_put's after the "fix".
Please drop from -stable.
It was discussed during AUTOSEL review:
Date: Fri, 25 Feb 2022 14:25:10 +0800 (GMT+08:00)
From: 刘永志 <[email protected]>
To: pavel machek <[email protected]>
Cc: sasha levin <[email protected]>, [email protected],
Subject: Re: [PATCH AUTOSEL 5.16 24/30] dmaengine: shdma: Fix runtime PM
imbalance on error
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
So 5.15 and 5.16 is ok, but older is not?
I believe commit is wrong for mainline and all stable releases, and author seems to agree. Drop from everywhere.
Is it reverted in Linus's tree yet?
It will take you a minute to check.
Take a look at the patch. There's no return in error path, thus doing runtime_put is clearly bogus. Should take you less than minute to verify.
Please drop the patch.
Pavel
Signature · 2 lines
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Greg Kroah-Hartman
maintainerRe: [PATCH 5.10 012/105] dmaengine: shdma: Fix runtime PM imbalance on error
Quoted 38 lines · Pavel Machek
Quoted 30 lines · Greg Kroah-Hartman
Quoted 29 lines · Pavel Machek
Quoted 28 lines · Greg Kroah-Hartman
Quoted 26 lines · Pavel Machek
Hi!
Quoted 7 lines
From: Yongzhi Liu <[email protected]>
[ Upstream commit
455896c53d5b803733ddd84e1bf8a430644439b6]
pm_runtime_get_()increments the runtime PM usage counter even when it returns an error code, thus a matching decrement is needed on the error handling path to keep the counter balanced.This patch will break things.
Notice that -ret is ignored (checked 4.4 and 5.10), so we don't actually abort/return error; we just printk. We'll do two pm_runtime_put's after the "fix".
Please drop from -stable.
It was discussed during AUTOSEL review:
Date: Fri, 25 Feb 2022 14:25:10 +0800 (GMT+08:00)
From: 刘永志 <[email protected]>
To: pavel machek <[email protected]>
Cc: sasha levin <[email protected]>, [email protected],
Subject: Re: [PATCH AUTOSEL 5.16 24/30] dmaengine: shdma: Fix runtime PM
imbalance on errorQuoted 6 lines
Quoted 4 lines
Quoted 1 line
So 5.15 and 5.16 is ok, but older is not?
I believe commit is wrong for mainline and all stable releases, and author seems to agree. Drop from everywhere.
Is it reverted in Linus's tree yet?
Quoted 7 lines
It will take you a minute to check.
Take a look at the patch. There's no return in error path, thus doing
runtime_putis clearly bogus. Should take you less than minute to verify.Please drop the patch.
I want to have it reverted in Linus's tree as well, otherwise that's a regression that people will hit.
thanks,
greg k-h
Re: [PATCH 5.10 012/105] dmaengine: shdma: Fix runtime PM imbalance on error
Quoted 41 lines · Greg Kroah-Hartman
Quoted 40 lines · Pavel Machek
Quoted 30 lines · Greg Kroah-Hartman
Quoted 29 lines · Pavel Machek
Quoted 28 lines · Greg Kroah-Hartman
Quoted 26 lines · Pavel Machek
Hi!
Quoted 7 lines
From: Yongzhi Liu <[email protected]>
[ Upstream commit
455896c53d5b803733ddd84e1bf8a430644439b6]
pm_runtime_get_()increments the runtime PM usage counter even when it returns an error code, thus a matching decrement is needed on the error handling path to keep the counter balanced.This patch will break things.
Notice that -ret is ignored (checked 4.4 and 5.10), so we don't actually abort/return error; we just printk. We'll do two pm_runtime_put's after the "fix".
Please drop from -stable.
It was discussed during AUTOSEL review:
Date: Fri, 25 Feb 2022 14:25:10 +0800 (GMT+08:00)
From: 刘永志 <[email protected]>
To: pavel machek <[email protected]>
Cc: sasha levin <[email protected]>, [email protected],
Subject: Re: [PATCH AUTOSEL 5.16 24/30] dmaengine: shdma: Fix runtime PM
imbalance on errorQuoted 6 lines
Quoted 4 lines
Quoted 1 line
So 5.15 and 5.16 is ok, but older is not?
I believe commit is wrong for mainline and all stable releases, and author seems to agree. Drop from everywhere.
Is it reverted in Linus's tree yet?
It will take you a minute to check.
Quoted 8 lines
Quoted 5 lines
Take a look at the patch. There's no return in error path, thus doing
runtime_putis clearly bogus. Should take you less than minute to verify.Please drop the patch.
I want to have it reverted in Linus's tree as well, otherwise that's a regression that people will hit.
I have reverted now, it will be in -next tomorrow and in mainline during upcoming merge window
Signature · 1 line
~Vinod
Greg Kroah-Hartman
maintainerRe: [PATCH 5.10 012/105] dmaengine: shdma: Fix runtime PM imbalance on error
Quoted 46 lines · Vinod Koul
Quoted 45 lines · Greg Kroah-Hartman
Quoted 44 lines · Pavel Machek
Quoted 30 lines · Greg Kroah-Hartman
Quoted 29 lines · Pavel Machek
Quoted 28 lines · Greg Kroah-Hartman
Quoted 26 lines · Pavel Machek
Hi!
Quoted 7 lines
From: Yongzhi Liu <[email protected]>
[ Upstream commit
455896c53d5b803733ddd84e1bf8a430644439b6]
pm_runtime_get_()increments the runtime PM usage counter even when it returns an error code, thus a matching decrement is needed on the error handling path to keep the counter balanced.This patch will break things.
Notice that -ret is ignored (checked 4.4 and 5.10), so we don't actually abort/return error; we just printk. We'll do two pm_runtime_put's after the "fix".
Please drop from -stable.
It was discussed during AUTOSEL review:
Date: Fri, 25 Feb 2022 14:25:10 +0800 (GMT+08:00)
From: 刘永志 <[email protected]>
To: pavel machek <[email protected]>
Cc: sasha levin <[email protected]>, [email protected],
Subject: Re: [PATCH AUTOSEL 5.16 24/30] dmaengine: shdma: Fix runtime PM
imbalance on errorQuoted 6 lines
Quoted 4 lines
Quoted 1 line
So 5.15 and 5.16 is ok, but older is not?
I believe commit is wrong for mainline and all stable releases, and author seems to agree. Drop from everywhere.
Is it reverted in Linus's tree yet?
It will take you a minute to check.
Take a look at the patch. There's no return in error path, thus doing
runtime_putis clearly bogus. Should take you less than minute to verify.
Quoted 7 lines
Quoted 4 lines
Quoted 1 line
Please drop the patch.
I want to have it reverted in Linus's tree as well, otherwise that's a regression that people will hit.
I have reverted now, it will be in -next tomorrow and in mainline during upcoming merge window
Thanks, now queued up.
greg k-h
Greg Kroah-Hartman
maintainerPATCH 13/105 i2c: cadence: allow COMPILE_TEST
In reply to Greg Kroah-HartmanFrom: Wolfram Sang <[email protected]>
[ Upstream commit 0b0dcb3882c8f08bdeafa03adb4487e104d26050 ]
Driver builds fine with COMPILE_TEST. Enable it for wider test coverage and easier maintenance.
--- drivers/i2c/busses/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/i2c/busses/Kconfig +1 -1
@@ -488,7 +488,7 @@ config I2C_BRCMSTB config I2C_CADENCE tristate "Cadence I2C Controller" - depends on ARCH_ZYNQ || ARM64 || XTENSA + depends on ARCH_ZYNQ || ARM64 || XTENSA || COMPILE_TEST help Say yes here to select Cadence I2C Host Controller. This controller is e.g. used by Xilinx Zynq.
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 14/105 i2c: qup: allow COMPILE_TEST
In reply to Greg Kroah-HartmanFrom: Wolfram Sang <[email protected]>
[ Upstream commit 5de717974005fcad2502281e9f82e139ca91f4bb ]
Driver builds fine with COMPILE_TEST. Enable it for wider test coverage and easier maintenance.
--- drivers/i2c/busses/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/i2c/busses/Kconfig +1 -1
@@ -926,7 +926,7 @@ config I2C_QCOM_GENI config I2C_QUP tristate "Qualcomm QUP based I2C controller" - depends on ARCH_QCOM + depends on ARCH_QCOM || COMPILE_TEST help If you say yes to this option, support will be included for the built-in I2C interface on the Qualcomm SoCs.
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 15/105 net: usb: cdc_mbim: avoid altsetting toggling for Telit FN990
In reply to Greg Kroah-HartmanFrom: Daniele Palmas <[email protected]>
[ Upstream commit 21e8a96377e6b6debae42164605bf9dcbe5720c5 ]
Add quirk CDC_MBIM_FLAG_AVOID_ALTSETTING_TOGGLE for Telit FN990 0x1071 composition in order to avoid bind error.
--- drivers/net/usb/cdc_mbim.c | 5 +++++ 1 file changed, 5 insertions(+)
drivers/net/usb/cdc_mbim.c +5 -0
@@ -658,6 +658,11 @@ static const struct usb_device_id mbim_devs[] = { .driver_info = (unsigned long)&cdc_mbim_info_avoid_altsetting_toggle, }, +/* Telit FN990 */ + { USB_DEVICE_AND_INTERFACE_INFO(0x1bc7, 0x1071, USB_CLASS_COMM, USB_CDC_SUBCLASS_MBIM, USB_CDC_PROTO_NONE), + .driver_info = (unsigned long )&cdc_mbim_info_avoid_altsetting_toggle, + }, + /* default entry */ { USB_INTERFACE_INFO(USB_CLASS_COMM, USB_CDC_SUBCLASS_MBIM, USB_CDC_PROTO_NONE), .driver_info = (unsigned long)&cdc_mbim_info_zlp,
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 16/105 usb: gadget: dont release an existing dev->buf
In reply to Greg Kroah-HartmanFrom: Hangyu Hua <[email protected]>
commit 89f3594d0de58e8a57d92d497dea9fee3d4b9cda upstream.
dev->buf does not need to be released if it already exists before executing dev_config.
--- drivers/usb/gadget/legacy/inode.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/usb/gadget/legacy/inode.c +2 -1
@@ -1828,8 +1828,9 @@ dev_config (struct file *fd, const charspin_lock_irq (&dev->lock); value = -EINVAL ;if (dev->buf) { +spin_unlock_irq (&dev->lock);kfree (kbuf); - goto fail; +return value; } dev->buf = kbuf;
Greg Kroah-Hartman
maintainerPATCH 17/105 usb: gadget: clear related members when goto fail
In reply to Greg Kroah-HartmanFrom: Hangyu Hua <[email protected]>
commit 501e38a5531efbd77d5c73c0ba838a889bfc1d74 upstream.
dev->config and dev->hs_config and dev->dev need to be cleaned if dev_config fails to avoid UAF.
--- drivers/usb/gadget/legacy/inode.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/usb/gadget/legacy/inode.c +5 -2
@@ -1877,8 +1877,8 @@ dev_config (struct file *fd, const char value =usb_gadget_probe_driver (&gadgetfs_driver);if (value !=0 ) { -kfree (dev->buf); - dev->buf =NULL ; +spin_lock_irq (&dev->lock); + goto fail; }else {/* at this point "good" hardware has for the first time * let the USB the host see us. alternatively, if users
@@ -1895,6 +1895,9 @@ dev_config (struct file *fd, const charreturn value; fail: + dev->config =NULL ; + dev->hs_config =NULL ; + dev->dev =NULL ;spin_unlock_irq (&dev->lock);pr_debug ("%s: %s fail %zd, %p\n" , shortname, __func__, value, dev);kfree (dev->buf);
Greg Kroah-Hartman
maintainerPATCH 18/105 exfat: reuse exfat_inode_info variable instead of calling EXFAT_I()
In reply to Greg Kroah-HartmanFrom: Christophe Vu-Brugier <[email protected]>
[ Upstream commit 7dee6f57d7f22a89dd214518c778aec448270d4c ]
Also add a local "struct exfat_inode_info *ei" variable to exfat_truncate() to simplify the code.
--- fs/exfat/file.c | 14 +++++++------- fs/exfat/inode.c | 9 ++++----- fs/exfat/namei.c | 6 +++--- fs/exfat/super.c | 6 +++--- 4 files changed, 17 insertions(+), 18 deletions(-)
fs/exfat/file.c +7 -7
@@ -109,8 +109,7 @@ int __exfat_truncate(struct inode *inode, loff_t new_size)exfat_set_volume_dirty (sb); num_clusters_new =EXFAT_B_TO_CLU_ROUND_UP (i_size_read (inode), sbi); - num_clusters_phys = -EXFAT_B_TO_CLU_ROUND_UP (EXFAT_I (inode)->i_size_ondisk, sbi); + num_clusters_phys =EXFAT_B_TO_CLU_ROUND_UP (ei->i_size_ondisk, sbi);exfat_chain_set (&clu, ei->start_clu, num_clusters_phys, ei->flags);
@@ -227,12 +226,13 @@ void exfat_truncate(struct inode *inode, loff_t size) {struct super_block *sb = inode->i_sb;struct exfat_sb_info *sbi =EXFAT_SB (sb); +struct exfat_inode_info *ei =EXFAT_I (inode);unsigned int blocksize =i_blocksize (inode);loff_t aligned_size;int err;mutex_lock (&sbi->s_lock); -if (EXFAT_I (inode)->start_clu ==0 ) { +if (ei->start_clu ==0 ) {/* * Empty start_clu != ~0 (not allocated) */
@@ -259,11 +259,11 @@ void exfat_truncate(struct inode *inode, loff_t size) aligned_size++; } -if (EXFAT_I (inode)->i_size_ondisk >i_size_read (inode)) -EXFAT_I (inode)->i_size_ondisk = aligned_size; +if (ei->i_size_ondisk >i_size_read (inode)) + ei->i_size_ondisk = aligned_size; -if (EXFAT_I (inode)->i_size_aligned >i_size_read (inode)) -EXFAT_I (inode)->i_size_aligned = aligned_size; +if (ei->i_size_aligned >i_size_read (inode)) + ei->i_size_aligned = aligned_size;mutex_unlock (&sbi->s_lock); }
fs/exfat/inode.c +4 -5
@@ -114,10 +114,9 @@ static int exfat_map_cluster(struct inode *inode, unsigned int clu_offset,unsigned int local_clu_offset = clu_offset;unsigned int num_to_be_allocated =0 , num_clusters =0 ; -if (EXFAT_I (inode)->i_size_ondisk >0 ) +if (ei->i_size_ondisk >0 ) num_clusters = -EXFAT_B_TO_CLU_ROUND_UP (EXFAT_I (inode)->i_size_ondisk, - sbi); +EXFAT_B_TO_CLU_ROUND_UP (ei->i_size_ondisk, sbi);if (clu_offset >= num_clusters) num_to_be_allocated = clu_offset - num_clusters +1 ;
@@ -415,10 +414,10 @@ static int exfat_write_end(struct file *file, struct address_space *mapping, err =generic_write_end (file, mapping, pos, len, copied, pagep, fsdata); -if (EXFAT_I (inode)->i_size_aligned <i_size_read (inode)) { +if (ei->i_size_aligned <i_size_read (inode)) {exfat_fs_error (inode->i_sb,"invalid size(size(%llu) > aligned(%llu)\n" , -i_size_read (inode),EXFAT_I (inode)->i_size_aligned); +i_size_read (inode), ei->i_size_aligned);return -EIO ; }
fs/exfat/namei.c +3 -3
@@ -395,9 +395,9 @@ static int exfat_find_empty_entry(struct inode *inode,/* directory inode should be updated in here */ i_size_write (inode, size); -EXFAT_I (inode)->i_size_ondisk += sbi->cluster_size; -EXFAT_I (inode)->i_size_aligned += sbi->cluster_size; -EXFAT_I (inode)->flags = p_dir->flags; + ei->i_size_ondisk += sbi->cluster_size; + ei->i_size_aligned += sbi->cluster_size; + ei->flags = p_dir->flags; inode->i_blocks +=1 << sbi->sect_per_clus_bits; }
fs/exfat/super.c +3 -3
@@ -366,9 +366,9 @@ static int exfat_read_root(struct inode *inode) inode->i_blocks = ((i_size_read (inode) + (sbi->cluster_size -1 )) & ~(sbi->cluster_size -1 )) >> inode->i_blkbits; -EXFAT_I (inode)->i_pos = ((loff_t )sbi->root_dir <<32 ) |0xffffffff ; -EXFAT_I (inode)->i_size_aligned =i_size_read (inode); -EXFAT_I (inode)->i_size_ondisk =i_size_read (inode); + ei->i_pos = ((loff_t )sbi->root_dir <<32 ) |0xffffffff ; + ei->i_size_aligned =i_size_read (inode); + ei->i_size_ondisk =i_size_read (inode);exfat_save_attr (inode,ATTR_SUBDIR ); inode->i_mtime = inode->i_atime = inode->i_ctime = ei->i_crtime =
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 19/105 exfat: fix i_blocks for files truncated over 4 GiB
In reply to Greg Kroah-HartmanFrom: Christophe Vu-Brugier <[email protected]>
[ Upstream commit 92fba084b79e6bc7b12fc118209f1922c1a2df56 ]
In exfat_truncate(), the computation of inode->i_blocks is wrong if the file is larger than 4 GiB because a 32-bit variable is used as a mask. This is fixed and simplified by using round_up().
Also fix the same buggy computation in exfat_read_root() and another (correct) one in exfat_fill_inode(). The latter was fixed another way last month but can be simplified by using round_up() as well. See:
commit 0c336d6e33f4 ("exfat: fix incorrect loading of i_blocks for
large files")
--- fs/exfat/file.c | 4 ++-- fs/exfat/inode.c | 4 ++-- fs/exfat/super.c | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-)
fs/exfat/file.c +2 -2
@@ -250,8 +250,8 @@ void exfat_truncate(struct inode *inode, loff_t size)else mark_inode_dirty (inode); - inode->i_blocks = ((i_size_read (inode) + (sbi->cluster_size -1 )) & - ~(sbi->cluster_size -1 )) >> inode->i_blkbits; + inode->i_blocks =round_up (i_size_read (inode), sbi->cluster_size) >> + inode->i_blkbits; write_size: aligned_size =i_size_read (inode);if (aligned_size & (blocksize -1 )) {
fs/exfat/inode.c +2 -2
@@ -600,8 +600,8 @@ static int exfat_fill_inode(struct inode *inode, struct exfat_dir_entry *info)exfat_save_attr (inode, info->attr); - inode->i_blocks = ((i_size_read (inode) + (sbi->cluster_size -1 )) & - ~((loff_t )sbi->cluster_size -1 )) >> inode->i_blkbits; + inode->i_blocks =round_up (i_size_read (inode), sbi->cluster_size) >> + inode->i_blkbits; inode->i_mtime = info->mtime; inode->i_ctime = info->mtime; ei->i_crtime = info->crtime;
fs/exfat/super.c +2 -2
@@ -364,8 +364,8 @@ static int exfat_read_root(struct inode *inode) inode->i_op = &exfat_dir_inode_operations; inode->i_fop = &exfat_dir_operations; - inode->i_blocks = ((i_size_read (inode) + (sbi->cluster_size -1 )) - & ~(sbi->cluster_size -1 )) >> inode->i_blkbits; + inode->i_blocks =round_up (i_size_read (inode), sbi->cluster_size) >> + inode->i_blkbits; ei->i_pos = ((loff_t )sbi->root_dir <<32 ) |0xffffffff ; ei->i_size_aligned =i_size_read (inode); ei->i_size_ondisk =i_size_read (inode);
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 20/105 tracing: Add test for user space strings when filtering on string pointers
In reply to Greg Kroah-HartmanFrom: Steven Rostedt <[email protected]>
[ Upstream commit 77360f9bbc7e5e2ab7a2c8b4c0244fbbfcfc6f62 ]
Pingfan reported that the following causes a fault:
echo "filename ~ \"cpu\"" > events/syscalls/sys_enter_openat/filter echo 1 > events/syscalls/sys_enter_at/enable
The reason is that trace event filter treats the user space pointer defined by "filename" as a normal pointer to compare against the "cpu" string. The following bug happened:
kvm-03-guest16 login: [72198.026181] BUG: unable to handle page fault for address: 00007fffaae8ef60 #PF: supervisor read access in kernel mode
#PF: error_code(0x0001) - permissions violation
PGD 80000001008b7067 P4D 80000001008b7067 PUD 2393f1067 PMD 2393ec067 PTE 8000000108f47867
Oops: 0001 [#1] PREEMPT SMP PTI
CPU: 1 PID: 1 Comm: systemd Kdump: loaded Not tainted 5.14.0-32.el9.x86_64 #1
Hardware name: Red Hat KVM, BIOS 0.5.1 01/01/2011
RIP: 0010:strlen+0x0/0x20
Code: 48 89 f9 74 09 48 83 c1 01 80 39 00 75 f7 31 d2 44 0f b6 04 16 44 88 04 11
48 83 c2 01 45 84 c0 75 ee c3 0f 1f 80 00 00 00 00 <80> 3f 00 74 10 48 89 f8
48 83 c0 01 80 38 00 75 f7 48 29 f8 c3 31
RSP: 0018:ffffb5b900013e48 EFLAGS: 00010246
RAX: 0000000000000018 RBX: ffff8fc1c49ede00 RCX: 0000000000000000
RDX: 0000000000000020 RSI: ffff8fc1c02d601c RDI: 00007fffaae8ef60
RBP: 00007fffaae8ef60 R08: 0005034f4ddb8ea4 R09: 0000000000000000
R10: ffff8fc1c02d601c R11: 0000000000000000 R12: ffff8fc1c8a6e380
R13: 0000000000000000 R14: ffff8fc1c02d6010 R15: ffff8fc1c00453c0
FS: 00007fa86123db40(0000) GS:ffff8fc2ffd00000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007fffaae8ef60 CR3: 0000000102880001 CR4: 00000000007706e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
PKRU: 55555554
Call Trace:
filter_pred_pchar+0x18/0x40
filter_match_preds+0x31/0x70
ftrace_syscall_enter+0x27a/0x2c0
syscall_trace_enter.constprop.0+0x1aa/0x1d0
do_syscall_64+0x16/0x90
entry_SYSCALL_64_after_hwframe+0x44/0xae
RIP: 0033:0x7fa861d88664The above happened because the kernel tried to access user space directly and triggered a "supervisor read access in kernel mode" fault. Worse yet, the memory could not even be loaded yet, and a SEGFAULT could happen as well. This could be true for kernel space accessing as well.
To be even more robust, test both kernel and user space strings. If the string fails to read, then simply have the filter fail.
Note, TASK_SIZE is used to determine if the pointer is user or kernel space and the appropriate strncpy_from_kernel/user_nofault() function is used to copy the memory. For some architectures, the compare to TASK_SIZE may always pick user space or kernel space. If it gets it wrong, the only thing is that the filter will fail to match. In the future, this needs to be fixed to have the event denote which should be used. But failing a filter is much better than panicing the machine, and that can be solved later.
--- Documentation/trace/events.rst | 10 +++++ kernel/trace/trace_events_filter.c | 66 ++++++++++++++++++++++++++++-- 2 files changed, 73 insertions(+), 3 deletions(-)
Documentation/trace/events.rst +10 -0
@@ -230,6 +230,16 @@ Currently the caret ('^') for an error always appears at the beginning of the filter string; the error message should still be useful though even without more accurate position info. +5.2.1 Filter limitations +------------------------ + +If a filter is placed on a string pointer ``(char *)`` that does not point +to a string on the ring buffer, but instead points to kernel or user space +memory, then, for safety reasons, at most 1024 bytes of the content is +copied onto a temporary buffer to do the compare. If the copy of the memory +faults (the pointer points to memory that should not be accessed), then the +string compare will be treated as not matching. + 5.3 Clearing filters --------------------
kernel/trace/trace_events_filter.c +63 -3
99 lines not on this page · raw message
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 21/105 serial: stm32: prevent TDR register overwrite when sending x_char
In reply to Greg Kroah-HartmanFrom: Valentin Caron <[email protected]>
[ Upstream commit d3d079bde07e1b7deaeb57506dc0b86010121d17 ]
When sending x_char in stm32_usart_transmit_chars(), driver can overwrite the value of TDR register by the value of x_char. If this happens, the previous value that was present in TDR register will not be sent through uart.
This code checks if the previous value in TDR register is sent before writing the x_char value into register.
--- drivers/tty/serial/stm32-usart.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)
drivers/tty/serial/stm32-usart.c +12 -0
@@ -420,10 +420,22 @@ static void stm32_usart_transmit_chars(struct uart_port *port)struct stm32_port *stm32_port =to_stm32_port (port);const struct stm32_usart_offsets *ofs = &stm32_port->info->ofs;struct circ_buf *xmit = &port->state->xmit; +u32 isr; +int ret;if (port->x_char) {if (stm32_port->tx_dma_busy)stm32_usart_clr_bits (port, ofs->cr3,USART_CR3_DMAT ); + +/* Check that TDR is empty before filling FIFO */ + ret = +readl_relaxed_poll_timeout_atomic (port->membase + ofs->isr, + isr, + (isr &USART_SR_TXE ), +10 ,1000 ); +if (ret) +dev_warn (port->dev,"1 character may be erased\n" ); +writel_relaxed (port->x_char, port->membase + ofs->tdr); port->x_char =0 ; port->icount.tx++;
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 22/105 ata: pata_hpt37x: fix PCI clock detection
In reply to Greg Kroah-HartmanFrom: Sergey Shtylyov <[email protected]>
[ Upstream commit 5f6b0f2d037c8864f20ff15311c695f65eb09db5 ]
The f_CNT register (at the PCI config. address 0x78) is 16-bit, not 8-bit! The bug was there from the very start... :-(
--- drivers/ata/pata_hpt37x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/ata/pata_hpt37x.c +2 -2
@@ -962,14 +962,14 @@ static int hpt37x_init_one(struct pci_dev *dev, const struct pci_device_id *id)if ((freq >>12 ) !=0xABCDE ) {int i; -u8 sr; +u16 sr;u32 total =0 ;pr_warn ("BIOS has not set timing clocks\n" );/* This is the process the HPT371 BIOS is reported to use */ for (i =0 ; i <128 ; i++) { -pci_read_config_byte (dev,0x78 , &sr); +pci_read_config_word (dev,0x78 , &sr); total += sr &0x1FF ;udelay (15 ); }
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 23/105 drm/amdgpu: check vm ready by amdgpu_vm->evicting flag
In reply to Greg Kroah-HartmanFrom: Qiang Yu <[email protected]>
[ Upstream commit c1a66c3bc425ff93774fb2f6eefa67b83170dd7e ]
Workstation application ANSA/META v21.1.4 get this error dmesg when running CI test suite provided by ANSA/META:
[drm:amdgpu_gem_va_ioctl [amdgpu]] *ERROR* Couldn't update BO_VA (-16)
This is caused by:
1. create a 256MB buffer in invisible VRAM
2. CPU map the buffer and access it causes vm_fault and try to move it to visible VRAM
3. force visible VRAM space and traverse all VRAM bos to check if evicting this bo is valuable
4. when checking a VM bo (in invisible VRAM), amdgpu_vm_evictable() will set amdgpu_vm->evicting, but latter due to not in visible VRAM, won't really evict it so not add it to amdgpu_vm->evicted
5. before next CS to clear the amdgpu_vm->evicting, user VM ops ioctl will pass amdgpu_vm_ready() (check amdgpu_vm->evicted) but fail in amdgpu_vm_bo_update_mapping() (check amdgpu_vm->evicting) and get this error log
This error won't affect functionality as next CS will finish the waiting VM ops. But we'd better clear the error log by checking the amdgpu_vm->evicting flag in amdgpu_vm_ready() to stop calling amdgpu_vm_bo_update_mapping() later.
Another reason is amdgpu_vm->evicted list holds all BOs (both user buffer and page table), but only page table BOs' eviction prevent VM ops. amdgpu_vm->evicting flag is set only for page table BOs, so we should use evicting flag instead of evicted list in amdgpu_vm_ready().
The side effect of this change is: previously blocked VM op (user buffer in "evicted" list but no page table in it) gets done immediately.
v2: update commit comments.
--- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c +7 -2
@@ -715,11 +715,16 @@ int amdgpu_vm_validate_pt_bos(struct amdgpu_device *adev, struct amdgpu_vm *vm,* Check if all VM PDs/PTs are ready for updates * * Returns: -* True if eviction list is empty. +* True if VM is not evicting. */ bool amdgpu_vm_ready (struct amdgpu_vm *vm) { -return list_empty (&vm->evicted); +bool ret; + +amdgpu_vm_eviction_lock (vm); + ret = !vm->evicting; +amdgpu_vm_eviction_unlock (vm); +return ret; }/**
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 24/105 tracing: Add ustring operation to filtering string pointers
In reply to Greg Kroah-HartmanFrom: Steven Rostedt <[email protected]>
[ Upstream commit f37c3bbc635994eda203a6da4ba0f9d05165a8d6 ]
Since referencing user space pointers is special, if the user wants to filter on a field that is a pointer to user space, then they need to specify it.
Add a ".ustring" attribute to the field name for filters to state that the field is pointing to user space such that the kernel can take the appropriate action to read that pointer.
--- Documentation/trace/events.rst | 9 ++++ kernel/trace/trace_events_filter.c | 81 +++++++++++++++++++++--------- 2 files changed, 66 insertions(+), 24 deletions(-)
Documentation/trace/events.rst +9 -0
@@ -198,6 +198,15 @@ The glob (~) accepts a wild card character (\*,?) and character classes prev_comm ~ "*sh*" prev_comm ~ "ba*sh" +If the field is a pointer that points into user space (for example +"filename" from sys_enter_openat), then you have to append ".ustring" to the +field name:: + + filename.ustring ~ "password" + +As the kernel will have to know how to retrieve the memory that the pointer +is at from user space. + 5.2 Setting filters -------------------
kernel/trace/trace_events_filter.c +57 -24
129 lines not on this page · raw message
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 25/105 ALSA: intel_hdmi: Fix reference to PCM buffer address
In reply to Greg Kroah-HartmanFrom: Zhen Ni <[email protected]>
commit 0aa6b294b312d9710804679abd2c0c8ca52cc2bc upstream.
PCM buffers might be allocated dynamically when the buffer preallocation failed or a larger buffer is requested, and it's not guaranteed that substream->dma_buffer points to the actually used buffer. The driver needs to refer to substream->runtime->dma_addr instead for the buffer address.
--- sound/x86/intel_hdmi_audio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/x86/intel_hdmi_audio.c +1 -1
@@ -1276,7 +1276,7 @@ static int had_pcm_mmap(struct snd_pcm_s { vma->vm_page_prot =pgprot_noncached (vma->vm_page_prot);return remap_pfn_range (vma, vma->vm_start, - substream->dma_buffer.addr >>PAGE_SHIFT , + substream->runtime->dma_addr >>PAGE_SHIFT , vma->vm_end - vma->vm_start, vma->vm_page_prot); }
Greg Kroah-Hartman
maintainerPATCH 26/105 riscv/efi_stub: Fix get_boot_hartid_from_fdt() return value
In reply to Greg Kroah-HartmanFrom: Sunil V L <[email protected]>
commit dcf0c838854c86e1f41fb1934aea906845d69782 upstream.
The get_boot_hartid_from_fdt() function currently returns U32_MAX for failure case which is not correct because U32_MAX is a valid hartid value. This patch fixes the issue by returning error code.
--- drivers/firmware/efi/libstub/riscv-stub.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-)
drivers/firmware/efi/libstub/riscv-stub.c +10 -7
@@ -25,7 +25,7 @@ typedef void __noreturn (*jump_kernel_func)(unsigned int, unsigned long);static u32 hartid; -static u32 get_boot_hartid_from_fdt (void ) +static int get_boot_hartid_from_fdt (void ) {const void *fdt;int chosen_node, len;
@@ -33,23 +33,26 @@ static u32 get_boot_hartid_from_fdt(void) fdt =get_efi_config_table (DEVICE_TREE_GUID );if (!fdt) -return U32_MAX ; +return -EINVAL ; chosen_node =fdt_path_offset (fdt,"/chosen" );if (chosen_node <0 ) -return U32_MAX ; +return -EINVAL ; prop =fdt_getprop ((void *)fdt, chosen_node,"boot-hartid" , &len);if (!prop || len !=sizeof (u32)) -return U32_MAX ; +return -EINVAL ; -return fdt32_to_cpu (*prop); + hartid =fdt32_to_cpu (*prop); +return 0 ; }efi_status_t check_platform_features (void ) { - hartid =get_boot_hartid_from_fdt (); -if (hartid ==U32_MAX ) { +int ret; + + ret =get_boot_hartid_from_fdt (); +if (ret) {efi_err ("/chosen/boot-hartid missing or invalid!\n" );return EFI_UNSUPPORTED ; }
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 27/105 riscv: Fix config KASAN && SPARSEMEM && !SPARSE_VMEMMAP
In reply to Greg Kroah-HartmanFrom: Alexandre Ghiti <[email protected]>
commit a3d328037846d013bb4c7f3777241e190e4c75e1 upstream.
In order to get the pfn of a struct page* when sparsemem is enabled without vmemmap, the mem_section structures need to be initialized which happens in sparse_init.
But kasan_early_init calls pfn_to_page way before sparse_init is called, which then tries to dereference a null mem_section pointer.
Fix this by removing the usage of this function in kasan_early_init.
--- arch/riscv/mm/kasan_init.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
arch/riscv/mm/kasan_init.c +1 -2
@@ -21,8 +21,7 @@ asmlinkage void __init kasan_early_init(for (i =0 ; i <PTRS_PER_PTE ; ++i)set_pte (kasan_early_shadow_pte + i, -mk_pte (virt_to_page (kasan_early_shadow_page), -PAGE_KERNEL )); +pfn_pte (virt_to_pfn (kasan_early_shadow_page),PAGE_KERNEL ));for (i =0 ; i <PTRS_PER_PMD ; ++i) set_pmd(kasan_early_shadow_pmd + i,
Greg Kroah-Hartman
maintainerPATCH 28/105 riscv: Fix config KASAN && DEBUG_VIRTUAL
In reply to Greg Kroah-HartmanFrom: Alexandre Ghiti <[email protected]>
commit c648c4bb7d02ceb53ee40172fdc4433b37cee9c6 upstream.
__virt_to_phys function is called very early in the boot process (ie kasan_early_init) so it should not be instrumented by KASAN otherwise it bugs.
Fix this by declaring phys_addr.c as non-kasan instrumentable.
--- arch/riscv/mm/Makefile | 3 +++ 1 file changed, 3 insertions(+)
arch/riscv/mm/Makefile +3 -0
@@ -24,6 +24,9 @@ obj-$(CONFIG_KASAN) += kasan_init.o ifdef CONFIG_KASAN KASAN_SANITIZE_kasan_init.o := n KASAN_SANITIZE_init.o := n +ifdef CONFIG_DEBUG_VIRTUAL +KASAN_SANITIZE_physaddr.o := n +endif endif obj-$(CONFIG_DEBUG_VIRTUAL) += physaddr.o
Greg Kroah-Hartman
maintainerPATCH 29/105 ASoC: ops: Shift tested values in snd_soc_put_volsw() by +min
In reply to Greg Kroah-HartmanFrom: Marek Vasut <[email protected]>
commit 9bdd10d57a8807dba0003af0325191f3cec0f11c upstream.
While the $val/$val2 values passed in from userspace are always >= 0 integers, the limits of the control can be signed integers and the $min can be non-zero and less than zero. To correctly validate $val/$val2 against platform_max, add the $min offset to val first.
--- sound/soc/soc-ops.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
sound/soc/soc-ops.c +2 -2
@@ -317,7 +317,7 @@ int snd_soc_put_volsw(struct snd_kcontro mask =BIT (sign_bit +1 ) -1 ; val = ucontrol->value.integer.value[0 ]; -if (mc->platform_max && val > mc->platform_max) +if (mc->platform_max && ((int )val + min) > mc->platform_max)return -EINVAL ;if (val > max - min)return -EINVAL ;
@@ -330,7 +330,7 @@ int snd_soc_put_volsw(struct snd_kcontro val = val << shift;if (snd_soc_volsw_is_stereo (mc)) { val2 = ucontrol->value.integer.value[1 ]; -if (mc->platform_max && val2 > mc->platform_max) +if (mc->platform_max && ((int )val2 + min) > mc->platform_max)return -EINVAL ;if (val2 > max - min)return -EINVAL ;
Greg Kroah-Hartman
maintainerPATCH 30/105 iommu/amd: Recover from event log overflow
In reply to Greg Kroah-HartmanFrom: Lennert Buytenhek <[email protected]>
commit 5ce97f4ec5e0f8726a5dda1710727b1ee9badcac upstream.
The AMD IOMMU logs I/O page faults and such to a ring buffer in system memory, and this ring buffer can overflow. The AMD IOMMU spec has the following to say about the interrupt status bit that signals this overflow condition:
EventOverflow: Event log overflow. RW1C. Reset 0b. 1 = IOMMU event log overflow has occurred. This bit is set when a new event is to be written to the event log and there is no usable entry in the event log, causing the new event information to be discarded. An interrupt is generated when EventOverflow = 1b and MMIO Offset 0018h[EventIntEn] = 1b. No new event log entries are written while this bit is set. Software Note: To resume logging, clear EventOverflow (W1C), and write a 1 to MMIO Offset 0018h[EventLogEn].
The AMD IOMMU driver doesn't currently implement this recovery sequence, meaning that if a ring buffer overflow occurs, logging of EVT/PPR/GA events will cease entirely.
This patch implements the spec-mandated reset sequence, with the minor tweak that the hardware seems to want to have a 0 written to MMIO Offset 0018h[EventLogEn] first, before writing an 1 into this field, or the IOMMU won't actually resume logging events.
--- drivers/iommu/amd/amd_iommu.h | 1 + drivers/iommu/amd/amd_iommu_types.h | 1 + drivers/iommu/amd/init.c | 10 ++++++++++ drivers/iommu/amd/iommu.c | 10 ++++++++-- 4 files changed, 20 insertions(+), 2 deletions(-)
drivers/iommu/amd/amd_iommu.h +1 -0
@@ -17,6 +17,7 @@ extern int amd_iommu_init_passthrough(voextern irqreturn_t amd_iommu_int_thread (int irq,void *data);extern irqreturn_t amd_iommu_int_handler (int irq,void *data);extern void amd_iommu_apply_erratum_63 (u16 devid); +extern void amd_iommu_restart_event_logging (struct amd_iommu *iommu);extern void amd_iommu_reset_cmd_buffer (struct amd_iommu *iommu);extern int amd_iommu_init_devices (void );extern void amd_iommu_uninit_devices (void );
drivers/iommu/amd/amd_iommu_types.h +1 -0
@@ -109,6 +109,7 @@#define PASID_MASK 0x0000ffff/* MMIO status bits */ +#define MMIO_STATUS_EVT_OVERFLOW_INT_MASK (1 << 0)#define MMIO_STATUS_EVT_INT_MASK (1 << 1)#define MMIO_STATUS_COM_WAIT_INT_MASK (1 << 2)#define MMIO_STATUS_PPR_INT_MASK (1 << 6)
drivers/iommu/amd/init.c +10 -0
@@ -657,6 +657,16 @@ static int __init alloc_command_buffer(s }/* +* This function restarts event logging in case the IOMMU experienced +* an event log buffer overflow. +*/ +void amd_iommu_restart_event_logging (struct amd_iommu *iommu) +{ +iommu_feature_disable (iommu,CONTROL_EVT_LOG_EN ); +iommu_feature_enable (iommu,CONTROL_EVT_LOG_EN ); +} + +/* * This function resets the command buffer if the IOMMU stopped fetching * commands from it. */
drivers/iommu/amd/iommu.c +8 -2
@@ -813,7 +813,8 @@ amd_iommu_set_pci_msi_domain(struct devi#endif /* !CONFIG_IRQ_REMAP */ #define AMD_IOMMU_INT_MASK \ - (MMIO_STATUS_EVT_INT_MASK | \ + (MMIO_STATUS_EVT_OVERFLOW_INT_MASK | \ + MMIO_STATUS_EVT_INT_MASK | \ MMIO_STATUS_PPR_INT_MASK | \ MMIO_STATUS_GALOG_INT_MASK)
@@ -823,7 +824,7 @@ irqreturn_t amd_iommu_int_thread(int irqu32 status =readl (iommu->mmio_base +MMIO_STATUS_OFFSET );while (status &AMD_IOMMU_INT_MASK ) { -/* Enable EVT and PPR and GA interrupts again */ +/* Enable interrupt sources again */ writel (AMD_IOMMU_INT_MASK , iommu->mmio_base +MMIO_STATUS_OFFSET );
@@ -844,6 +845,11 @@ irqreturn_t amd_iommu_int_thread(int irq }#endif +if (status &MMIO_STATUS_EVT_OVERFLOW_INT_MASK ) { +pr_info_ratelimited ("IOMMU event log overflow\n" ); +amd_iommu_restart_event_logging (iommu); + } +/* * Hardware bug: ERBT1312 * When re-enabling interrupt (by writing 1
Greg Kroah-Hartman
maintainerPATCH 31/105 drm/i915: s/JSP2/ICP2/ PCH
In reply to Greg Kroah-HartmanFrom: Ville Syrjälä <[email protected]>
commit 08783aa7693f55619859f4f63f384abf17cb58c5 upstream.
This JSP2 PCH actually seems to be some special Apple specific ICP variant rather than a JSP. Make it so. Or at least all the references to it seem to be some Apple ICL machines. Didn't manage to find these PCI IDs in any public chipset docs unfortunately.
The only thing we're losing here with this JSP->ICP change is Wa_14011294188, but based on the HSD that isn't actually needed on any ICP based design (including JSP), only TGP based stuff (including MCC) really need it. The documented w/a just never made that distinction because Windows didn't want to differentiate between JSP and MCC (not sure how they handle hpd/ddc/etc. then though...).
--- drivers/gpu/drm/i915/intel_pch.c | 2 +- drivers/gpu/drm/i915/intel_pch.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/intel_pch.c +1 -1
@@ -110,6 +110,7 @@ intel_pch_type(const struct drm_i915_pri/* Comet Lake V PCH is based on KBP, which is SPT compatible */ return PCH_SPT ;case INTEL_PCH_ICP_DEVICE_ID_TYPE : +case INTEL_PCH_ICP2_DEVICE_ID_TYPE :drm_dbg_kms (&dev_priv->drm,"Found Ice Lake PCH\n" );drm_WARN_ON (&dev_priv->drm, !IS_ICELAKE (dev_priv));return PCH_ICP ;
@@ -124,7 +125,6 @@ intel_pch_type(const struct drm_i915_pri !IS_ROCKETLAKE(dev_priv));return PCH_TGP ;case INTEL_PCH_JSP_DEVICE_ID_TYPE : -case INTEL_PCH_JSP2_DEVICE_ID_TYPE :drm_dbg_kms (&dev_priv->drm,"Found Jasper Lake PCH\n" );drm_WARN_ON (&dev_priv->drm, !IS_ELKHARTLAKE (dev_priv));return PCH_JSP ;
drivers/gpu/drm/i915/intel_pch.h +1 -1
@@ -48,11 +48,11 @@ enum intel_pch {#define INTEL_PCH_CMP2_DEVICE_ID_TYPE 0x0680#define INTEL_PCH_CMP_V_DEVICE_ID_TYPE 0xA380#define INTEL_PCH_ICP_DEVICE_ID_TYPE 0x3480 +#define INTEL_PCH_ICP2_DEVICE_ID_TYPE 0x3880#define INTEL_PCH_MCC_DEVICE_ID_TYPE 0x4B00#define INTEL_PCH_TGP_DEVICE_ID_TYPE 0xA080#define INTEL_PCH_TGP2_DEVICE_ID_TYPE 0x4380#define INTEL_PCH_JSP_DEVICE_ID_TYPE 0x4D80 -#define INTEL_PCH_JSP2_DEVICE_ID_TYPE 0x3880#define INTEL_PCH_P2X_DEVICE_ID_TYPE 0x7100#define INTEL_PCH_P3X_DEVICE_ID_TYPE 0x7000#define INTEL_PCH_QEMU_DEVICE_ID_TYPE 0x2900/* qemu q35 has 2918 */
Greg Kroah-Hartman
maintainerPATCH 32/105 xen/netfront: destroy queues before real_num_tx_queues is zeroed
In reply to Greg Kroah-HartmanFrom: Marek Marczykowski-Górecki <[email protected]>
commit dcf4ff7a48e7598e6b10126cc02177abb8ae4f3f upstream.
xennet_destroy_queues() relies on info->netdev->real_num_tx_queues to delete queues. Since d7dac083414eb5bb99a6d2ed53dc2c1b405224e5 ("net-sysfs: update the queue counts in the unregistration path"), unregister_netdev() indirectly sets real_num_tx_queues to 0. Those two facts together means, that xennet_destroy_queues() called from xennet_remove() cannot do its job, because it's called after unregister_netdev(). This results in kfree-ing queues that are still linked in napi, which ultimately crashes:
BUG: kernel NULL pointer dereference, address: 0000000000000000
#PF: supervisor read access in kernel mode
#PF: error_code(0x0000) - not-present page
PGD 0 P4D 0
Oops: 0000 [#1] PREEMPT SMP PTI
CPU: 1 PID: 52 Comm: xenwatch Tainted: G W 5.16.10-1.32.fc32.qubes.x86_64+ #226
RIP: 0010:free_netdev+0xa3/0x1a0
Code: ff 48 89 df e8 2e e9 00 00 48 8b 43 50 48 8b 08 48 8d b8 a0 fe ff ff 48 8d a9 a0 fe ff ff 49 39 c4 75 26 eb 47 e8 ed c1 66 ff <48> 8b 85 60 01 00 00 48 8d 95 60 01 00 00 48 89 ef 48 2d 60 01 00
RSP: 0000:ffffc90000bcfd00 EFLAGS: 00010286
RAX: 0000000000000000 RBX: ffff88800edad000 RCX: 0000000000000000
RDX: 0000000000000001 RSI: ffffc90000bcfc30 RDI: 00000000ffffffff
RBP: fffffffffffffea0 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000001 R12: ffff88800edad050
R13: ffff8880065f8f88 R14: 0000000000000000 R15: ffff8880066c6680
FS: 0000000000000000(0000) GS:ffff8880f3300000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000000000000000 CR3: 00000000e998c006 CR4: 00000000003706e0
Call Trace:
<TASK>
xennet_remove+0x13d/0x300 [xen_netfront]
xenbus_dev_remove+0x6d/0xf0
__device_release_driver+0x17a/0x240
device_release_driver+0x24/0x30
bus_remove_device+0xd8/0x140
device_del+0x18b/0x410
? _raw_spin_unlock+0x16/0x30
? klist_iter_exit+0x14/0x20
? xenbus_dev_request_and_reply+0x80/0x80
device_unregister+0x13/0x60
xenbus_dev_changed+0x18e/0x1f0
xenwatch_thread+0xc0/0x1a0
? do_wait_intr_irq+0xa0/0xa0
kthread+0x16b/0x190
? set_kthread_struct+0x40/0x40
ret_from_fork+0x22/0x30
</TASK>Fix this by calling xennet_destroy_queues() from xennet_uninit(), when real_num_tx_queues is still available. This ensures that queues are destroyed when real_num_tx_queues is set to 0, regardless of how unregister_netdev() was called.
Originally reported at
https://github.com/QubesOS/qubes-issues/issues/7257
--- drivers/net/xen-netfront.c | 39 +++++++++++++++++++++++---------------- 1 file changed, 23 insertions(+), 16 deletions(-)
drivers/net/xen-netfront.c +23 -16
@@ -844,6 +844,28 @@ static int xennet_close(struct net_devicreturn 0 ; } +static void xennet_destroy_queues (struct netfront_info *info) +{ +unsigned int i; + +for (i =0 ; i < info->netdev->real_num_tx_queues; i++) { +struct netfront_queue *queue = &info->queues[i]; + +if (netif_running (info->netdev)) +napi_disable (&queue->napi); +netif_napi_del (&queue->napi); + } + +kfree (info->queues); + info->queues =NULL ; +} + +static void xennet_uninit (struct net_device *dev) +{ +struct netfront_info *np =netdev_priv (dev); +xennet_destroy_queues (np); +} +static void xennet_set_rx_rsp_cons (struct netfront_queue *queue,RING_IDX val) {unsigned long flags;
@@ -1613,6 +1635,7 @@ static int xennet_xdp(struct net_device }static const struct net_device_ops xennet_netdev_ops = { + .ndo_uninit = xennet_uninit, .ndo_open = xennet_open, .ndo_stop = xennet_close, .ndo_start_xmit = xennet_start_xmit,
@@ -2105,22 +2128,6 @@ error:return err; } -static void xennet_destroy_queues (struct netfront_info *info) -{ -unsigned int i; - -for (i =0 ; i < info->netdev->real_num_tx_queues; i++) { -struct netfront_queue *queue = &info->queues[i]; - -if (netif_running (info->netdev)) -napi_disable (&queue->napi); -netif_napi_del (&queue->napi); - } - -kfree (info->queues); - info->queues =NULL ; -} -static int xennet_create_page_pool (struct netfront_queue *queue)
Greg Kroah-Hartman
maintainerPATCH 33/105 thermal: core: Fix TZ_GET_TRIP NULL pointer dereference
In reply to Greg Kroah-HartmanFrom: Nicolas Cavallari <[email protected]>
commit 5838a14832d447990827d85e90afe17e6fb9c175 upstream.
Do not call get_trip_hyst() from thermal_genl_cmd_tz_get_trip() if the thermal zone does not define one.
--- drivers/thermal/thermal_netlink.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/thermal/thermal_netlink.c +3 -2
@@ -418,11 +418,12 @@ static int thermal_genl_cmd_tz_get_trip(for (i =0 ; i < tz->trips; i++) {enum thermal_trip_type type; -int temp, hyst; +int temp, hyst =0 ; tz->ops->get_trip_type (tz, i, &type); tz->ops->get_trip_temp (tz, i, &temp); - tz->ops->get_trip_hyst (tz, i, &hyst); +if (tz->ops->get_trip_hyst) + tz->ops->get_trip_hyst (tz, i, &hyst); if (nla_put_u32(msg, THERMAL_GENL_ATTR_TZ_TRIP_ID, i) || nla_put_u32(msg, THERMAL_GENL_ATTR_TZ_TRIP_TYPE, type) ||
Greg Kroah-Hartman
maintainerPATCH 34/105 ntb: intel: fix port config status offset for SPR
In reply to Greg Kroah-HartmanFrom: Dave Jiang <[email protected]>
commit d5081bf5dcfb1cb83fb538708b0ac07a10a79cc4 upstream.
The field offset for port configuration status on SPR has been changed to bit 14 from ICX where it resides at bit 12. By chance link status detection continued to work on SPR. This is due to bit 12 being a configuration bit which is in sync with the status bit. Fix this by checking for a SPR device and checking correct status bit.
--- drivers/ntb/hw/intel/ntb_hw_gen4.c | 17 ++++++++++++++++- drivers/ntb/hw/intel/ntb_hw_gen4.h | 16 ++++++++++++++++ 2 files changed, 32 insertions(+), 1 deletion(-)
drivers/ntb/hw/intel/ntb_hw_gen4.c +16 -1
@@ -168,6 +168,18 @@ static enum ntb_topo gen4_ppd_topo(strucreturn NTB_TOPO_NONE ; } +static enum ntb_topo spr_ppd_topo (struct intel_ntb_dev *ndev,u32 ppd) +{ +switch (ppd &SPR_PPD_TOPO_MASK ) { +case SPR_PPD_TOPO_B2B_USD : +return NTB_TOPO_B2B_USD ; +case SPR_PPD_TOPO_B2B_DSD : +return NTB_TOPO_B2B_DSD ; + } + +return NTB_TOPO_NONE ; +} +int gen4_init_dev (struct intel_ntb_dev *ndev) {struct pci_dev *pdev = ndev->ntb.pdev;
@@ -181,7 +193,10 @@ int gen4_init_dev(struct intel_ntb_dev * ndev->hwerr_flags |=NTB_HWERR_BAR_ALIGN ; ppd1 =ioread32 (ndev->self_mmio +GEN4_PPD1_OFFSET ); - ndev->ntb.topo =gen4_ppd_topo (ndev, ppd1); +if (pdev_is_ICX (pdev)) + ndev->ntb.topo =gen4_ppd_topo (ndev, ppd1); +else if (pdev_is_SPR (pdev)) + ndev->ntb.topo =spr_ppd_topo (ndev, ppd1);dev_dbg (&pdev->dev,"ppd %#x topo %s\n" , ppd1,ntb_topo_string (ndev->ntb.topo));if (ndev->ntb.topo ==NTB_TOPO_NONE )
drivers/ntb/hw/intel/ntb_hw_gen4.h +16 -0
@@ -46,10 +46,14 @@#define GEN4_PPD_CLEAR_TRN 0x0001#define GEN4_PPD_LINKTRN 0x0008#define GEN4_PPD_CONN_MASK 0x0300 +#define SPR_PPD_CONN_MASK 0x0700#define GEN4_PPD_CONN_B2B 0x0200#define GEN4_PPD_DEV_MASK 0x1000#define GEN4_PPD_DEV_DSD 0x1000#define GEN4_PPD_DEV_USD 0x0000 +#define SPR_PPD_DEV_MASK 0x4000 +#define SPR_PPD_DEV_DSD 0x4000 +#define SPR_PPD_DEV_USD 0x0000#define GEN4_LINK_CTRL_LINK_DISABLE 0x0010#define GEN4_SLOTSTS 0xb05a
@@ -59,6 +63,10 @@#define GEN4_PPD_TOPO_B2B_USD (GEN4_PPD_CONN_B2B | GEN4_PPD_DEV_USD)#define GEN4_PPD_TOPO_B2B_DSD (GEN4_PPD_CONN_B2B | GEN4_PPD_DEV_DSD) +#define SPR_PPD_TOPO_MASK (SPR_PPD_CONN_MASK | SPR_PPD_DEV_MASK) +#define SPR_PPD_TOPO_B2B_USD (GEN4_PPD_CONN_B2B | SPR_PPD_DEV_USD) +#define SPR_PPD_TOPO_B2B_DSD (GEN4_PPD_CONN_B2B | SPR_PPD_DEV_DSD) +#define GEN4_DB_COUNT 32#define GEN4_DB_LINK 32#define GEN4_DB_LINK_BIT BIT_ULL(GEN4_DB_LINK)
@@ -96,5 +104,13 @@ static inline int pdev_is_ICX(struct pcireturn 1 ; return 0; } + +static inline int pdev_is_SPR (struct pci_dev *pdev) +{ +if (pdev_is_gen4 (pdev) && + pdev->revision >PCI_DEVICE_REVISION_ICX_MAX ) +return 1 ; +return 0 ; +}#endif
Greg Kroah-Hartman
maintainerPATCH 35/105 mm: Consider __GFP_NOWARN flag for oversized kvmalloc() calls
In reply to Greg Kroah-HartmanFrom: Daniel Borkmann <[email protected]>
commit 0708a0afe291bdfe1386d74d5ec1f0c27e8b9168 upstream.
syzkaller was recently triggering an oversized kvmalloc() warning via xdp_umem_create().
The triggered warning was added back in 7661809d493b ("mm: don't allow oversized kvmalloc() calls"). The rationale for the warning for huge kvmalloc sizes was as a reaction to a security bug where the size was more than UINT_MAX but not everything was prepared to handle unsigned long sizes.
Anyway, the AF_XDP related call trace from this syzkaller report was:
kvmalloc include/linux/mm.h:806 [inline] kvmalloc_array include/linux/mm.h:824 [inline] kvcalloc include/linux/mm.h:829 [inline] xdp_umem_pin_pages net/xdp/xdp_umem.c:102 [inline] xdp_umem_reg net/xdp/xdp_umem.c:219 [inline] xdp_umem_create+0x6a5/0xf00 net/xdp/xdp_umem.c:252 xsk_setsockopt+0x604/0x790 net/xdp/xsk.c:1068 __sys_setsockopt+0x1fd/0x4e0 net/socket.c:2176 __do_sys_setsockopt net/socket.c:2187 [inline] __se_sys_setsockopt net/socket.c:2184 [inline] __x64_sys_setsockopt+0xb5/0x150 net/socket.c:2184 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x44/0xae
Björn mentioned that requests for >2GB allocation can still be valid:
The structure that is being allocated is the page-pinning accounting. AF_XDP has an internal limit of U32_MAX pages, which is *a lot*, but still fewer than what memcg allows (PAGE_COUNTER_MAX is a LONG_MAX/ PAGE_SIZE on 64 bit systems). [...]
I could just change from U32_MAX to INT_MAX, but as I stated earlier that has a hacky feeling to it. [...] From my perspective, the code isn't broken, with the memcg limits in consideration. [...]
Linus says:
[...] Pretty much every time this has come up, the kernel warning has shown that yes, the code was broken and there really wasn't a reason for doing allocations that big.
Of course, some people would be perfectly fine with the allocation failing, they just don't want the warning. I didn't want __GFP_NOWARN to shut it up originally because I wanted people to see all those cases, but these days I think we can just say "yeah, people can shut it up explicitly by saying 'go ahead and fail this allocation, don't warn about it'".
So enough time has passed that by now I'd certainly be ok with [it].
Thus allow call-sites to silence such userspace triggered splats if the allocation requests have __GFP_NOWARN. For xdp_umem_pin_pages()'s call to kvcalloc() this is already the case, so nothing else needed there.
--- mm/util.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
mm/util.c +3 -1
@@ -582,8 +582,10 @@ void *kvmalloc_node(size_t size, gfp_t freturn ret;/* Don't even allow crazy sizes */ -if (WARN_ON_ONCE (size >INT_MAX )) +if (unlikely (size >INT_MAX )) { +WARN_ON_ONCE (!(flags & __GFP_NOWARN));return NULL ; + }return __vmalloc_node (size,1 , flags, node,__builtin_return_address (0 ));
Greg Kroah-Hartman
maintainerPATCH 36/105 xfrm: fix MTU regression
In reply to Greg Kroah-HartmanFrom: Jiri Bohac <[email protected]>
commit 6596a0229541270fb8d38d989f91b78838e5e9da upstream.
Commit 749439bfac6e1a2932c582e2699f91d329658196 ("ipv6: fix udpv6 sendmsg crash caused by too small MTU") breaks PMTU for xfrm.
A Packet Too Big ICMPv6 message received in response to an ESP packet will prevent all further communication through the tunnel if the reported MTU minus the ESP overhead is smaller than 1280.
E.g. in a case of a tunnel-mode ESP with sha256/aes the overhead is 92 bytes. Receiving a PTB with MTU of 1371 or less will result in all further packets in the tunnel dropped. A ping through the tunnel fails with "ping: sendmsg: Invalid argument".
Apparently the MTU on the xfrm route is smaller than 1280 and fails the check inside ip6_setup_cork() added by 749439bf.
We found this by debugging USGv6/ipv6ready failures. Failing tests are: "Phase-2 Interoperability Test Scenario IPsec" / 5.3.11 and 5.4.11 (Tunnel Mode: Fragmentation).
Commit b515d2637276a3810d6595e10ab02c13bfd0b63a ("xfrm:xfrm_state_mtu should return at least 1280 for ipv6") attempted to fix this but caused another regression in TCP MSS calculations and had to be reverted.
The patch below fixes the situation by dropping the MTU check and instead checking for the underflows described in the 749439bf commit message.
--- net/ipv6/ip6_output.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-)
net/ipv6/ip6_output.c +7 -4
@@ -1432,8 +1432,6 @@ static int ip6_setup_cork(struct sock *sif (np->frag_size) mtu = np->frag_size; } -if (mtu <IPV6_MIN_MTU ) -return -EINVAL ; cork->base.fragsize = mtu; cork->base.gso_size = ipc6->gso_size; cork->base.tx_flags =0 ;
@@ -1495,8 +1493,6 @@ static int __ip6_append_data(struct sock fragheaderlen =sizeof (struct ipv6hdr ) + rt->rt6i_nfheader_len + (opt ? opt->opt_nflen :0 ); - maxfraglen = ((mtu - fragheaderlen) & ~7 ) + fragheaderlen - -sizeof (struct frag_hdr ); headersize =sizeof (struct ipv6hdr ) + (opt ? opt->opt_flen + opt->opt_nflen : 0) +
@@ -1504,6 +1500,13 @@ static int __ip6_append_data(struct sock sizeof(struct frag_hdr) : 0) + rt->rt6i_nfheader_len; +if (mtu < fragheaderlen || + ((mtu - fragheaderlen) & ~7 ) + fragheaderlen <sizeof (struct frag_hdr )) + goto emsgsize; + + maxfraglen = ((mtu - fragheaderlen) & ~7 ) + fragheaderlen - +sizeof (struct frag_hdr ); +/* as per RFC 7112 section 5, the entire IPv6 Header Chain must fit * the first fragment */
Greg Kroah-Hartman
maintainerPATCH 37/105 netfilter: fix use-after-free in __nf_register_net_hook()
In reply to Greg Kroah-HartmanFrom: Eric Dumazet <[email protected]>
commit 56763f12b0f02706576a088e85ef856deacc98a0 upstream.
We must not dereference @new_hooks after nf_hook_mutex has been released, because other threads might have freed our allocated hooks already.
BUG: KASAN: use-after-free in nf_hook_entries_get_hook_ops include/linux/netfilter.h:130 [inline]
BUG: KASAN: use-after-free in hooks_validate net/netfilter/core.c:171 [inline]
BUG: KASAN: use-after-free in __nf_register_net_hook+0x77a/0x820 net/netfilter/core.c:438
Read of size 2 at addr ffff88801c1a8000 by task syz-executor237/4430
CPU: 1 PID: 4430 Comm: syz-executor237 Not tainted 5.17.0-rc5-syzkaller-00306-g2293be58d6a1 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0xcd/0x134 lib/dump_stack.c:106
print_address_description.constprop.0.cold+0x8d/0x336 mm/kasan/report.c:255
__kasan_report mm/kasan/report.c:442 [inline]
kasan_report.cold+0x83/0xdf mm/kasan/report.c:459
nf_hook_entries_get_hook_ops include/linux/netfilter.h:130 [inline]
hooks_validate net/netfilter/core.c:171 [inline]
__nf_register_net_hook+0x77a/0x820 net/netfilter/core.c:438
nf_register_net_hook+0x114/0x170 net/netfilter/core.c:571
nf_register_net_hooks+0x59/0xc0 net/netfilter/core.c:587
nf_synproxy_ipv6_init+0x85/0xe0 net/netfilter/nf_synproxy_core.c:1218
synproxy_tg6_check+0x30d/0x560 net/ipv6/netfilter/ip6t_SYNPROXY.c:81
xt_check_target+0x26c/0x9e0 net/netfilter/x_tables.c:1038
check_target net/ipv6/netfilter/ip6_tables.c:530 [inline]
find_check_entry.constprop.0+0x7f1/0x9e0 net/ipv6/netfilter/ip6_tables.c:573
translate_table+0xc8b/0x1750 net/ipv6/netfilter/ip6_tables.c:735
do_replace net/ipv6/netfilter/ip6_tables.c:1153 [inline]
do_ip6t_set_ctl+0x56e/0xb90 net/ipv6/netfilter/ip6_tables.c:1639
nf_setsockopt+0x83/0xe0 net/netfilter/nf_sockopt.c:101
ipv6_setsockopt+0x122/0x180 net/ipv6/ipv6_sockglue.c:1024
rawv6_setsockopt+0xd3/0x6a0 net/ipv6/raw.c:1084
__sys_setsockopt+0x2db/0x610 net/socket.c:2180
__do_sys_setsockopt net/socket.c:2191 [inline]
__se_sys_setsockopt net/socket.c:2188 [inline]
__x64_sys_setsockopt+0xba/0x150 net/socket.c:2188
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x44/0xae
RIP: 0033:0x7f65a1ace7d9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 71 15 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f65a1a7f308 EFLAGS: 00000246 ORIG_RAX: 0000000000000036
RAX: ffffffffffffffda RBX: 0000000000000006 RCX: 00007f65a1ace7d9
RDX: 0000000000000040 RSI: 0000000000000029 RDI: 0000000000000003
RBP: 00007f65a1b574c8 R08: 0000000000000001 R09: 0000000000000000
R10: 0000000020000000 R11: 0000000000000246 R12: 00007f65a1b55130
R13: 00007f65a1b574c0 R14: 00007f65a1b24090 R15: 0000000000022000
</TASK>
The buggy address belongs to the page:
page:ffffea0000706a00 refcount:0 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x1c1a8
flags: 0xfff00000000000(node=0|zone=1|lastcpupid=0x7ff)
raw: 00fff00000000000 ffffea0001c1b108 ffffea000046dd08 0000000000000000
raw: 0000000000000000 0000000000000000 00000000ffffffff 0000000000000000
page dumped because: kasan: bad access detected
page_owner tracks the page as freed
page last allocated via order 2, migratetype Unmovable, gfp_mask 0x52dc0(GFP_KERNEL|__GFP_NOWARN|__GFP_NORETRY|__GFP_COMP|__GFP_ZERO), pid 4430, ts 1061781545818, free_ts 1061791488993
prep_new_page mm/page_alloc.c:2434 [inline]
get_page_from_freelist+0xa72/0x2f50 mm/page_alloc.c:4165
__alloc_pages+0x1b2/0x500 mm/page_alloc.c:5389
__alloc_pages_node include/linux/gfp.h:572 [inline]
alloc_pages_node include/linux/gfp.h:595 [inline]
kmalloc_large_node+0x62/0x130 mm/slub.c:4438
__kmalloc_node+0x35a/0x4a0 mm/slub.c:4454
kmalloc_node include/linux/slab.h:604 [inline]
kvmalloc_node+0x97/0x100 mm/util.c:580
kvmalloc include/linux/slab.h:731 [inline]
kvzalloc include/linux/slab.h:739 [inline]
allocate_hook_entries_size net/netfilter/core.c:61 [inline]
nf_hook_entries_grow+0x140/0x780 net/netfilter/core.c:128
__nf_register_net_hook+0x144/0x820 net/netfilter/core.c:429
nf_register_net_hook+0x114/0x170 net/netfilter/core.c:571
nf_register_net_hooks+0x59/0xc0 net/netfilter/core.c:587
nf_synproxy_ipv6_init+0x85/0xe0 net/netfilter/nf_synproxy_core.c:1218
synproxy_tg6_check+0x30d/0x560 net/ipv6/netfilter/ip6t_SYNPROXY.c:81
xt_check_target+0x26c/0x9e0 net/netfilter/x_tables.c:1038
check_target net/ipv6/netfilter/ip6_tables.c:530 [inline]
find_check_entry.constprop.0+0x7f1/0x9e0 net/ipv6/netfilter/ip6_tables.c:573
translate_table+0xc8b/0x1750 net/ipv6/netfilter/ip6_tables.c:735
do_replace net/ipv6/netfilter/ip6_tables.c:1153 [inline]
do_ip6t_set_ctl+0x56e/0xb90 net/ipv6/netfilter/ip6_tables.c:1639
nf_setsockopt+0x83/0xe0 net/netfilter/nf_sockopt.c:101
page last free stack trace:
reset_page_owner include/linux/page_owner.h:24 [inline]
free_pages_prepare mm/page_alloc.c:1352 [inline]
free_pcp_prepare+0x374/0x870 mm/page_alloc.c:1404
free_unref_page_prepare mm/page_alloc.c:3325 [inline]
free_unref_page+0x19/0x690 mm/page_alloc.c:3404
kvfree+0x42/0x50 mm/util.c:613
rcu_do_batch kernel/rcu/tree.c:2527 [inline]
rcu_core+0x7b1/0x1820 kernel/rcu/tree.c:2778
__do_softirq+0x29b/0x9c2 kernel/softirq.c:558
Memory state around the buggy address:
ffff88801c1a7f00: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
ffff88801c1a7f80: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
>ffff88801c1a8000: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
^
ffff88801c1a8080: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
ffff88801c1a8100: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff--- net/netfilter/core.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
net/netfilter/core.c +3 -2
@@ -406,14 +406,15 @@ static int __nf_register_net_hook(struct p =nf_entry_dereference (*pp); new_hooks =nf_hook_entries_grow (p, reg); -if (!IS_ERR (new_hooks)) +if (!IS_ERR (new_hooks)) { +hooks_validate (new_hooks);rcu_assign_pointer (*pp, new_hooks); + }mutex_unlock (&nf_hook_mutex);if (IS_ERR (new_hooks))return PTR_ERR (new_hooks); -hooks_validate (new_hooks);#ifdef CONFIG_NETFILTER_INGRESS if (nf_ingress_hook (reg, pf))net_inc_ingress_queue ();
Greg Kroah-Hartman
maintainerPATCH 38/105 bpf, sockmap: Do not ignore orig_len parameter
In reply to Greg Kroah-HartmanFrom: Eric Dumazet <[email protected]>
commit 60ce37b03917e593d8e5d8bcc7ec820773daf81d upstream.
Currently, sk_psock_verdict_recv() returns skb->len
This is problematic because tcp_read_sock() might have passed orig_len < skb->len, due to the presence of TCP urgent data.
This causes an infinite loop from tcp_read_sock()
Followup patch will make tcp_read_sock() more robust vs bad actors.
--- net/core/skmsg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/core/skmsg.c +1 -1
@@ -943,7 +943,7 @@ static int sk_psock_verdict_recv(read_destruct sk_psock *psock;struct bpf_prog *prog;int ret = __SK_DROP; -int len = skb->len; +int len = orig_len;/* clone here so sk_eat_skb() in tcp_read_sock does not drop our data */ skb =skb_clone (skb,GFP_ATOMIC );
Greg Kroah-Hartman
maintainerPATCH 39/105 xfrm: fix the if_id check in changelink
In reply to Greg Kroah-HartmanFrom: Antony Antony <[email protected]>
commit 6d0d95a1c2b07270870e7be16575c513c29af3f1 upstream.
if_id will be always 0, because it was not yet initialized.
--- net/xfrm/xfrm_interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/xfrm/xfrm_interface.c +1 -1
@@ -679,12 +679,12 @@ static int xfrmi_changelink(struct net_dstruct net *net = xi->net;struct xfrm_if_parms p = {}; +xfrmi_netlink_parms (data, &p);if (!p.if_id) {NL_SET_ERR_MSG (extack,"if_id must be non zero" );return -EINVAL ; } -xfrmi_netlink_parms (data, &p); xi =xfrmi_locate (net, &p);if (!xi) { xi =netdev_priv (dev);
Greg Kroah-Hartman
maintainerPATCH 40/105 xfrm: enforce validity of offload input flags
In reply to Greg Kroah-HartmanFrom: Leon Romanovsky <[email protected]>
commit 7c76ecd9c99b6e9a771d813ab1aa7fa428b3ade1 upstream.
struct xfrm_user_offload has flags variable that received user input, but kernel didn't check if valid bits were provided. It caused a situation where not sanitized input was forwarded directly to the drivers.
For example, XFRM_OFFLOAD_IPV6 define that was exposed, was used by strongswan, but not implemented in the kernel at all.
As a solution, check and sanitize input flags to forward XFRM_OFFLOAD_INBOUND to the drivers.
--- include/uapi/linux/xfrm.h | 6 ++++++ net/xfrm/xfrm_device.c | 6 +++++- 2 files changed, 11 insertions(+), 1 deletion(-)
include/uapi/linux/xfrm.h +6 -0
@@ -506,6 +506,12 @@ struct xfrm_user_offload {int ifindex;__u8 flags; }; +/* This flag was exposed without any kernel code that supporting it. +* Unfortunately, strongswan has the code that uses sets this flag, +* which makes impossible to reuse this bit. +* +* So leave it here to make sure that it won't be reused by mistake. +*/ #define XFRM_OFFLOAD_IPV6 1#define XFRM_OFFLOAD_INBOUND 2
net/xfrm/xfrm_device.c +5 -1
@@ -223,6 +223,9 @@ int xfrm_dev_state_add(struct net *net,if (x->encap || x->tfcpad)return -EINVAL ; +if (xuo->flags & ~(XFRM_OFFLOAD_IPV6 |XFRM_OFFLOAD_INBOUND )) +return -EINVAL ; + dev =dev_get_by_index (net, xuo->ifindex);if (!dev) {if (!(xuo->flags &XFRM_OFFLOAD_INBOUND )) {
@@ -261,7 +264,8 @@ int xfrm_dev_state_add(struct net *net, xso->dev = dev; xso->real_dev = dev; xso->num_exthdrs =1 ; - xso->flags = xuo->flags; +/* Don't forward bit that is not implemented */ + xso->flags = xuo->flags & ~XFRM_OFFLOAD_IPV6 ; err = dev->xfrmdev_ops->xdo_dev_state_add (x);if (err) {
Greg Kroah-Hartman
maintainerPATCH 41/105 e1000e: Correct NVM checksum verification flow
In reply to Greg Kroah-HartmanFrom: Sasha Neftin <[email protected]>
commit ffd24fa2fcc76ecb2e61e7a4ef8588177bcb42a6 upstream.
Update MAC type check e1000_pch_tgp because for e1000_pch_cnp, NVM checksum update is still possible.
Emit a more detailed warning message.
Bugzilla: https://bugzilla.opensuse.org/show_bug.cgi?id=1191663
--- drivers/net/ethernet/intel/e1000e/ich8lan.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ethernet/intel/e1000e/ich8lan.c +2 -2
@@ -4134,9 +4134,9 @@ static s32 e1000_validate_nvm_checksum_ireturn ret_val;if (!(data & valid_csum_mask)) { -e_dbg ("NVM Checksum Invalid\n" ); +e_dbg ("NVM Checksum valid bit not set\n" ); -if (hw->mac.type < e1000_pch_cnp) { +if (hw->mac.type < e1000_pch_tgp) { data |= valid_csum_mask; ret_val =e1000_write_nvm (hw, word,1 , &data);if (ret_val)
Greg Kroah-Hartman
maintainerPATCH 42/105 net: fix up skbs delta_truesize in UDP GRO frag_list
In reply to Greg Kroah-HartmanFrom: lena wang <[email protected]>
commit 224102de2ff105a2c05695e66a08f4b5b6b2d19c upstream.
The truesize for a UDP GRO packet is added by main skb and skbs in main skb's frag_list:skb_gro_receive_list
p->truesize += skb->truesize;
The commit 53475c5dd856 ("net: fix use-after-free when UDP GRO with shared fraglist") introduced a truesize increase for frag_list skbs. When uncloning skb, it will call pskb_expand_head and trusesize for frag_list skbs may increase. This can occur when allocators uses __netdev_alloc_skb and not jump into __alloc_skb. This flow does not use ksize(len) to calculate truesize while pskb_expand_head uses. skb_segment_list
err = skb_unclone(nskb, GFP_ATOMIC);pskb_expand_head
if (!skb->sk || skb->destructor == sock_edemux)
skb->truesize += size - osize;If we uses increased truesize adding as delta_truesize, it will be larger than before and even larger than previous total truesize value if skbs in frag_list are abundant. The main skb truesize will become smaller and even a minus value or a huge value for an unsigned int parameter. Then the following memory check will drop this abnormal skb.
To avoid this error we should use the original truesize to segment the main skb.
--- net/core/skbuff.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/core/skbuff.c +1 -1
@@ -3690,6 +3690,7 @@ struct sk_buff *skb_segment_list(struct list_skb = list_skb->next; err =0 ; + delta_truesize += nskb->truesize;if (skb_shared (nskb)) { tmp =skb_clone (nskb,GFP_ATOMIC );if (tmp) {
@@ -3714,7 +3715,6 @@ struct sk_buff *skb_segment_list(struct tail = nskb; delta_len += nskb->len; - delta_truesize += nskb->truesize;skb_push (nskb, -skb_network_offset (nskb) + offset);
Greg Kroah-Hartman
maintainerPATCH 43/105 netfilter: nf_queue: dont assume sk is full socket
In reply to Greg Kroah-HartmanFrom: Florian Westphal <[email protected]>
commit 747670fd9a2d1b7774030dba65ca022ba442ce71 upstream.
There is no guarantee that state->sk refers to a full socket.
If refcount transitions to 0, sock_put calls sk_free which then ends up with garbage fields.
I'd like to thank Oleksandr Natalenko and Jiri Benc for considerable debug work and pointing out state->sk oddities.
--- net/netfilter/nf_queue.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-)
net/netfilter/nf_queue.c +10 -1
@@ -46,6 +46,15 @@ void nf_unregister_queue_handler(struct }EXPORT_SYMBOL (nf_unregister_queue_handler); +static void nf_queue_sock_put (struct sock *sk) +{ +#ifdef CONFIG_INET +sock_gen_put (sk); +#else +sock_put (sk); +#endif +} +static void nf_queue_entry_release_refs (struct nf_queue_entry *entry) {struct nf_hook_state *state = &entry->state;
@@ -56,7 +65,7 @@ static void nf_queue_entry_release_refs(if (state->out)dev_put (state->out);if (state->sk) -sock_put (state->sk); +nf_queue_sock_put (state->sk);#if IS_ENABLED (CONFIG_BRIDGE_NETFILTER )if (entry->physin)
Greg Kroah-Hartman
maintainerPATCH 44/105 netfilter: nf_queue: fix possible use-after-free
In reply to Greg Kroah-HartmanFrom: Florian Westphal <[email protected]>
commit c3873070247d9e3c7a6b0cf9bf9b45e8018427b1 upstream.
Eric Dumazet says:
The sock_hold() side seems suspect, because there is no guarantee that sk_refcnt is not already 0.
On failure, we cannot queue the packet and need to indicate an error. The packet will be dropped by the caller.
v2: split skb prefetch hunk into separate change
--- include/net/netfilter/nf_queue.h | 2 +- net/netfilter/nf_queue.c | 13 +++++++++---- net/netfilter/nfnetlink_queue.c | 12 +++++++++--- 3 files changed, 19 insertions(+), 8 deletions(-)
include/net/netfilter/nf_queue.h +1 -1
@@ -37,7 +37,7 @@ void nf_register_queue_handler(struct nevoid nf_unregister_queue_handler (struct net *net);void nf_reinject (struct nf_queue_entry *entry,unsigned int verdict); -void nf_queue_entry_get_refs (struct nf_queue_entry *entry); +bool nf_queue_entry_get_refs (struct nf_queue_entry *entry);void nf_queue_entry_free (struct nf_queue_entry *entry);static inline void init_hashrandom (u32 *jhash_initval)
net/netfilter/nf_queue.c +9 -4
@@ -100,16 +100,17 @@ static void __nf_queue_entry_init_physde }/* Bump dev refs so they don't vanish while packet is out */ -void nf_queue_entry_get_refs (struct nf_queue_entry *entry) +bool nf_queue_entry_get_refs (struct nf_queue_entry *entry) {struct nf_hook_state *state = &entry->state; +if (state->sk && !refcount_inc_not_zero (&state->sk->sk_refcnt)) +return false; +if (state->in)dev_hold (state->in);if (state->out)dev_hold (state->out); -if (state->sk) -sock_hold (state->sk);#if IS_ENABLED (CONFIG_BRIDGE_NETFILTER )if (entry->physin)
@@ -117,6 +118,7 @@ void nf_queue_entry_get_refs(struct nf_qif (entry->physout)dev_hold (entry->physout);#endif +return true; }EXPORT_SYMBOL_GPL (nf_queue_entry_get_refs);
@@ -205,7 +207,10 @@ static int __nf_queue(struct sk_buff *sk__nf_queue_entry_init_physdevs (entry); -nf_queue_entry_get_refs (entry); +if (!nf_queue_entry_get_refs (entry)) { +kfree (entry); +return -ENOTCONN ; + }switch (entry->state.pf) {case AF_INET :
net/netfilter/nfnetlink_queue.c +9 -3
@@ -712,9 +712,15 @@ static struct nf_queue_entry * nf_queue_entry_dup(struct nf_queue_entry *e) {struct nf_queue_entry *entry =kmemdup (e, e->size,GFP_ATOMIC ); -if (entry) -nf_queue_entry_get_refs (entry); -return entry; + +if (!entry) +return NULL ; + +if (nf_queue_entry_get_refs (entry)) +return entry; + +kfree (entry); +return NULL ; }#if IS_ENABLED (CONFIG_BRIDGE_NETFILTER )
Greg Kroah-Hartman
maintainerPATCH 45/105 netfilter: nf_queue: handle socket prefetch
In reply to Greg Kroah-HartmanFrom: Florian Westphal <[email protected]>
commit 3b836da4081fa585cf6c392f62557496f2cb0efe upstream.
In case someone combines bpf socket assign and nf_queue, then we will queue an skb who references a struct sock that did not have its reference count incremented.
As we leave rcu protection, there is no guarantee that skb->sk is still valid.
For refcount-less skb->sk case, try to increment the reference count and then override the destructor.
In case of failure we have two choices: orphan the skb and 'delete' preselect or let nf_queue() drop the packet.
Do the latter, it should not happen during normal operation.
--- net/netfilter/nf_queue.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)
net/netfilter/nf_queue.c +12 -0
@@ -189,6 +189,18 @@ static int __nf_queue(struct sk_buff *skbreak ; } +if (skb_sk_is_prefetched (skb)) { +struct sock *sk = skb->sk; + +if (!sk_is_refcounted (sk)) { +if (!refcount_inc_not_zero (&sk->sk_refcnt)) +return -ENOTCONN ; + +/* drop refcount on skb_orphan */ + skb->destructor = sock_edemux; + } + } + entry =kmalloc (sizeof (*entry) + route_key_size,GFP_ATOMIC );if (!entry)return -ENOMEM ;
Greg Kroah-Hartman
maintainerPATCH 46/105 batman-adv: Request iflink once in batadv-on-batadv check
In reply to Greg Kroah-HartmanFrom: Sven Eckelmann <[email protected]>
commit 690bb6fb64f5dc7437317153902573ecad67593d upstream.
There is no need to call dev_get_iflink multiple times for the same net_device in batadv_is_on_batman_iface. And since some of the .ndo_get_iflink callbacks are dynamic (for example via RCUs like in vxcan_get_iflink), it could easily happen that the returned values are not stable. The pre-checks before __dev_get_by_index are then of course bogus.
--- net/batman-adv/hard-interface.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)
net/batman-adv/hard-interface.c +5 -4
@@ -151,22 +151,23 @@ static bool batadv_is_on_batman_iface(costruct net *net =dev_net (net_dev);struct net_device *parent_dev;struct net *parent_net; +int iflink;bool ret;/* check if this is a batman-adv mesh interface */ if (batadv_softif_is_valid (net_dev))return true; + iflink =dev_get_iflink (net_dev); +/* no more parents..stop recursion */ -if (dev_get_iflink (net_dev) ==0 || -dev_get_iflink (net_dev) == net_dev->ifindex) +if (iflink ==0 || iflink == net_dev->ifindex)return false; parent_net =batadv_getlink_net (net_dev, net);/* recurse over the parent device */ - parent_dev =__dev_get_by_index ((struct net *)parent_net, -dev_get_iflink (net_dev)); + parent_dev =__dev_get_by_index ((struct net *)parent_net, iflink);/* if we got a NULL parent_dev there is something broken.. */ if (!parent_dev) {pr_err ("Cannot find parent device\n" );
Greg Kroah-Hartman
maintainerPATCH 47/105 batman-adv: Request iflink once in batadv_get_real_netdevice
In reply to Greg Kroah-HartmanFrom: Sven Eckelmann <[email protected]>
commit 6116ba09423f7d140f0460be6a1644dceaad00da upstream.
There is no need to call dev_get_iflink multiple times for the same net_device in batadv_get_real_netdevice. And since some of the ndo_get_iflink callbacks are dynamic (for example via RCUs like in vxcan_get_iflink), it could easily happen that the returned values are not stable. The pre-checks before __dev_get_by_index are then of course bogus.
--- net/batman-adv/hard-interface.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)
net/batman-adv/hard-interface.c +5 -4
@@ -217,14 +217,16 @@ static struct net_device *batadv_get_reastruct net_device *real_netdev =NULL ;struct net *real_net;struct net *net; -int ifindex; +int iflink;ASSERT_RTNL ();if (!netdev)return NULL ; -if (netdev->ifindex ==dev_get_iflink (netdev)) { + iflink =dev_get_iflink (netdev); + +if (netdev->ifindex == iflink) {dev_hold (netdev);return netdev; }
@@ -234,9 +236,8 @@ static struct net_device *batadv_get_rea goto out; net =dev_net (hard_iface->soft_iface); - ifindex =dev_get_iflink (netdev); real_net =batadv_getlink_net (netdev, net); - real_netdev =dev_get_by_index (real_net, ifindex); + real_netdev =dev_get_by_index (real_net, iflink); out:if (hard_iface)
Greg Kroah-Hartman
maintainerPATCH 48/105 batman-adv: Dont expect inter-netns unique iflink indices
In reply to Greg Kroah-HartmanFrom: Sven Eckelmann <[email protected]>
commit 6c1f41afc1dbe59d9d3c8bb0d80b749c119aa334 upstream.
The ifindex doesn't have to be unique for multiple network namespaces on the same machine.
$ ip netns add test1 $ ip -net test1 link add dummy1 type dummy $ ip netns add test2 $ ip -net test2 link add dummy2 type dummy
$ ip -net test1 link show dev dummy1
6: dummy1: <BROADCAST,NOARP> mtu 1500 qdisc noop state DOWN mode DEFAULT group default qlen 1000
link/ether 96:81:55:1e:dd:85 brd ff:ff:ff:ff:ff:ff
$ ip -net test2 link show dev dummy2
6: dummy2: <BROADCAST,NOARP> mtu 1500 qdisc noop state DOWN mode DEFAULT group default qlen 1000
link/ether 5a:3c:af:35:07:c3 brd ff:ff:ff:ff:ff:ffBut the batman-adv code to walk through the various layers of virtual interfaces uses this assumption because dev_get_iflink handles it internally and doesn't return the actual netns of the iflink. And dev_get_iflink only documents the situation where ifindex == iflink for physical devices.
But only checking for dev->netdev_ops->ndo_get_iflink is also not an option because ipoib_get_iflink implements it even when it sometimes returns an iflink != ifindex and sometimes iflink == ifindex. The caller must therefore make sure itself to check both netns and iflink + ifindex for equality. Only when they are equal, a "physical" interface was detected which should stop the traversal. On the other hand, vxcan_get_iflink can also return 0 in case there was currently no valid peer. In this case, it is still necessary to stop.
--- net/batman-adv/hard-interface.c | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-)
net/batman-adv/hard-interface.c +14 -5
@@ -159,13 +159,15 @@ static bool batadv_is_on_batman_iface(coreturn true; iflink =dev_get_iflink (net_dev); - -/* no more parents..stop recursion */ -if (iflink ==0 || iflink == net_dev->ifindex) +if (iflink ==0 )return false; parent_net =batadv_getlink_net (net_dev, net); +/* iflink to itself, most likely physical device */ +if (net == parent_net && iflink == net_dev->ifindex) +return false; +/* recurse over the parent device */ parent_dev =__dev_get_by_index ((struct net *)parent_net, iflink);/* if we got a NULL parent_dev there is something broken.. */
@@ -225,8 +227,7 @@ static struct net_device *batadv_get_reareturn NULL ; iflink =dev_get_iflink (netdev); - -if (netdev->ifindex == iflink) { +if (iflink ==0 ) {dev_hold (netdev);return netdev; }
@@ -237,6 +238,14 @@ static struct net_device *batadv_get_rea net =dev_net (hard_iface->soft_iface); real_net =batadv_getlink_net (netdev, net); + +/* iflink to itself, most likely physical device */ +if (net == real_net && netdev->ifindex == iflink) { + real_netdev = netdev; +dev_hold (real_netdev); + goto out; + } + real_netdev =dev_get_by_index (real_net, iflink); out:
Greg Kroah-Hartman
maintainerPATCH 49/105 net: ipv6: ensure we call ipv6_mc_down() at most once
In reply to Greg Kroah-HartmanFrom: [email protected] <[email protected]>
commit 9995b408f17ff8c7f11bc725c8aa225ba3a63b1c upstream.
There are two reasons for addrconf_notify() to be called with NETDEV_DOWN:
either the network device is actually going down, or IPv6 was disabled on the interface.
If either of them stays down while the other is toggled, we repeatedly call the code for NETDEV_DOWN, including ipv6_mc_down(), while never calling the corresponding ipv6_mc_up() in between. This will cause a new entry in idev->mc_tomb to be allocated for each multicast group the interface is subscribed to, which in turn leaks one struct ifmcaddr6 per nontrivial multicast group the interface is subscribed to.
The following reproducer will leak at least $n objects:
ip addr add ff2e::4242/32 dev eth0 autojoin sysctl -w net.ipv6.conf.eth0.disable_ipv6=1 for i in $(seq 1 $n); do
ip link set up eth0; ip link set down eth0
done
Joining groups with IPV6_ADD_MEMBERSHIP (unprivileged) or setting the sysctl net.ipv6.conf.eth0.forwarding to 1 (=> subscribing to ff02::2) can also be used to create a nontrivial idev->mc_list, which will the leak objects with the right up-down-sequence.
Based on both sources for NETDEV_DOWN events the interface IPv6 state should be considered:
- not ready if the network interface is not ready OR IPv6 is disabled for it
- ready if the network interface is ready AND IPv6 is enabled for it
The functions ipv6_mc_up() and ipv6_down() should only be run when this state changes.
Implement this by remembering when the IPv6 state is ready, and only run ipv6_mc_down() if it actually changed from ready to not ready.
The other direction (not ready -> ready) already works correctly, as:
- the interface notification triggered codepath for NETDEV_UP / NETDEV_CHANGE returns early if ipv6 is disabled, and
- the disable_ipv6=0 triggered codepath skips fully initializing the interface as long as addrconf_link_ready(dev) returns false
- calling ipv6_mc_up() repeatedly does not leak anything
--- net/ipv6/addrconf.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
net/ipv6/addrconf.c +6 -2
@@ -3712,6 +3712,7 @@ static int addrconf_ifdown(struct net_destruct inet6_dev *idev;struct inet6_ifaddr *ifa, *tmp;bool keep_addr = false; +bool was_ready;int state, i;ASSERT_RTNL ();
@@ -3777,7 +3778,10 @@ restart:addrconf_del_rs_timer (idev); -/* Step 2: clear flags for stateless addrconf */ +/* Step 2: clear flags for stateless addrconf, repeated down +* detection +*/ + was_ready = idev->if_flags &IF_READY ;if (!unregister) idev->if_flags &= ~(IF_RS_SENT |IF_RA_RCVD |IF_READY );
@@ -3851,7 +3855,7 @@ restart:if (unregister) {ipv6_ac_destroy_dev (idev);ipv6_mc_destroy_dev (idev); - }else { + }else if (was_ready) {ipv6_mc_down (idev); }
Greg Kroah-Hartman
maintainerPATCH 50/105 net: dcb: flush lingering app table entries for unregistered devices
In reply to Greg Kroah-HartmanFrom: Vladimir Oltean <[email protected]>
commit 91b0383fef06f20b847fa9e4f0e3054ead0b1a1b upstream.
If I'm not mistaken (and I don't think I am), the way in which the dcbnl_ops work is that drivers call dcb_ieee_setapp() and this populates the application table with dynamically allocated struct dcb_app_type entries that are kept in the module-global dcb_app_list.
However, nobody keeps exact track of these entries, and although dcb_ieee_delapp() is supposed to remove them, nobody does so when the interface goes away (example: driver unbinds from device). So the dcb_app_list will contain lingering entries with an ifindex that no longer matches any device in dcb_app_lookup().
Reclaim the lost memory by listening for the NETDEV_UNREGISTER event and flushing the app table entries of interfaces that are now gone.
In fact something like this used to be done as part of the initial commit (blamed below), but it was done in dcbnl_exit() -> dcb_flushapp(), essentially at module_exit time. That became dead code after commit 7a6b6f515f77 ("DCB: fix kconfig option") which essentially merged "tristate config DCB" and "bool config DCBNL" into a single "bool config DCB", so net/dcb/dcbnl.c could not be built as a module anymore.
Commit 36b9ad8084bd ("net/dcb: make dcbnl.c explicitly non-modular") recognized this and deleted dcbnl_exit() and dcb_flushapp() altogether, leaving us with the version we have today.
Since flushing application table entries can and should be done as soon as the netdevice disappears, fundamentally the commit that is to blame is the one that introduced the design of this API.
--- net/dcb/dcbnl.c | 44 ++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 44 insertions(+)
net/dcb/dcbnl.c +44 -0
@@ -2063,10 +2063,54 @@ u8 dcb_ieee_getapp_default_prio_mask(con }EXPORT_SYMBOL (dcb_ieee_getapp_default_prio_mask); +static void dcbnl_flush_dev (struct net_device *dev) +{ +struct dcb_app_type *itr, *tmp; + +spin_lock (&dcb_lock); + +list_for_each_entry_safe (itr, tmp, &dcb_app_list, list) { +if (itr->ifindex == dev->ifindex) { +list_del (&itr->list); +kfree (itr); + } + } + +spin_unlock (&dcb_lock); +} + +static int dcbnl_netdevice_event (struct notifier_block *nb, +unsigned long event,void *ptr) +{ +struct net_device *dev =netdev_notifier_info_to_dev (ptr); + +switch (event) { +case NETDEV_UNREGISTER : +if (!dev->dcbnl_ops) +return NOTIFY_DONE ; + +dcbnl_flush_dev (dev); + +return NOTIFY_OK ; +default : +return NOTIFY_DONE ; + } +} + +static struct notifier_block dcbnl_nb__read_mostly = { + .notifier_call = dcbnl_netdevice_event, +}; +static int __init dcbnl_init (void ) { +int err; +INIT_LIST_HEAD (&dcb_app_list); + err =register_netdevice_notifier (&dcbnl_nb); +if (err) +return err; +rtnl_register (PF_UNSPEC ,RTM_GETDCB , dcb_doit,NULL ,0 );rtnl_register (PF_UNSPEC ,RTM_SETDCB , dcb_doit,NULL ,0 );
Greg Kroah-Hartman
maintainerPATCH 51/105 net/smc: fix connection leak
In reply to Greg Kroah-HartmanFrom: D. Wythe <[email protected]>
commit 9f1c50cf39167ff71dc5953a3234f3f6eeb8fcb5 upstream.
There's a potential leak issue under following execution sequence :
smc_release smc_connect_work
if (sk->sk_state == SMC_INIT)
send_clc_confirim tcp_abort(); ... sk.sk_state = SMC_ACTIVE
smc_close_activeswitch(sk->sk_state) {
...
case SMC_ACTIVE:
smc_close_final() // then wait peer closed
Unfortunately, tcp_abort() may discard CLC CONFIRM messages that are still in the tcp send buffer, in which case our connection token cannot be delivered to the server side, which means that we cannot get a passive close message at all. Therefore, it is impossible for the to be disconnected at all.
This patch tries a very simple way to avoid this issue, once the state has changed to SMC_ACTIVE after tcp_abort(), we can actively abort the smc connection, considering that the state is SMC_INIT before tcp_abort(), abandoning the complete disconnection process should not cause too much problem.
In fact, this problem may exist as long as the CLC CONFIRM message is not received by the server. Whether a timer should be added after smc_close_final() needs to be discussed in the future. But even so, this patch provides a faster release for connection in above case, it should also be valuable.
--- net/smc/af_smc.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)
net/smc/af_smc.c +8 -2
@@ -180,7 +180,7 @@ static int smc_release(struct socket *so {struct sock *sk = sock->sk;struct smc_sock *smc; -int rc =0 ; +int old_state, rc =0 ;if (!sk) goto out;
@@ -188,8 +188,10 @@ static int smc_release(struct socket *sosock_hold (sk);/* sock_put below */ smc =smc_sk (sk); + old_state = sk->sk_state; +/* cleanup for a dangling non-blocking connect */ -if (smc->connect_nonblock && sk->sk_state ==SMC_INIT ) +if (smc->connect_nonblock && old_state ==SMC_INIT )tcp_abort (smc->clcsock->sk,ECONNABORTED );if (cancel_work_sync (&smc->connect_work))
@@ -203,6 +205,10 @@ static int smc_release(struct socket *soelse lock_sock (sk); +if (old_state ==SMC_INIT && sk->sk_state ==SMC_ACTIVE && + !smc->use_fallback) +smc_close_active_abort (smc); + rc =__smc_release (smc);/* detach socket */
Greg Kroah-Hartman
maintainerPATCH 52/105 net/smc: fix unexpected SMC_CLC_DECL_ERR_REGRMB error generated by client
In reply to Greg Kroah-HartmanFrom: D. Wythe <[email protected]>
commit 0537f0a2151375dcf90c1bbfda6a0aaf57164e89 upstream.
The main reason for this unexpected SMC_CLC_DECL_ERR_REGRMB in client dues to following execution sequence:
Server Conn A: Server Conn B: Client Conn B:
smc_lgr_unregister_conn
smc_lgr_register_conn
smc_clc_send_accept ->
smc_rtoken_add
smcr_buf_unuse
-> Client Conn A:
smc_rtoken_deletesmc_lgr_unregister_conn() makes current link available to assigned to new incoming connection, while smcr_buf_unuse() has not executed yet, which means that smc_rtoken_add may fail because of insufficient rtoken_entry, reversing their execution order will avoid this problem.
--- net/smc/smc_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/smc/smc_core.c +1 -1
@@ -662,8 +662,8 @@ void smc_conn_free(struct smc_connectioncancel_work_sync (&conn->abort_work); }if (!list_empty (&lgr->list)) { -smc_lgr_unregister_conn (conn);smc_buf_unuse (conn, lgr);/* allow buffer reuse */ +smc_lgr_unregister_conn (conn); }if (!lgr->conns_num)
Greg Kroah-Hartman
maintainerPATCH 53/105 net/smc: fix unexpected SMC_CLC_DECL_ERR_REGRMB error cause by server
In reply to Greg Kroah-HartmanFrom: D. Wythe <[email protected]>
commit 4940a1fdf31c39f0806ac831cde333134862030b upstream.
The problem of SMC_CLC_DECL_ERR_REGRMB on the server is very clear. Based on the fact that whether a new SMC connection can be accepted or not depends on not only the limit of conn nums, but also the available entries of rtoken. Since the rtoken release is trigger by peer, while the conn nums is decrease by local, tons of thing can happen in this time difference.
This only thing that needs to be mentioned is that now all connection creations are completely protected by smc_server_lgr_pending lock, it's enough to check only the available entries in rtokens_used_mask.
--- net/smc/smc_core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
net/smc/smc_core.c +2 -1
@@ -1316,7 +1316,8 @@ int smc_conn_create(struct smc_sock *smc (ini->smcd_version ==SMC_V2 || lgr->vlan_id == ini->vlan_id) && (role ==SMC_CLNT || ini->is_smcd || - lgr->conns_num < SMC_RMBS_PER_LGR_MAX)) { + (lgr->conns_num <SMC_RMBS_PER_LGR_MAX && + !bitmap_full(lgr->rtokens_used_mask, SMC_RMBS_PER_LGR_MAX)))) { /* link group found */ ini->first_contact_local = 0; conn->lgr = lgr;
Greg Kroah-Hartman
maintainerPATCH 54/105 rcu/nocb: Fix missed nocb_timer requeue
In reply to Greg Kroah-HartmanFrom: Frederic Weisbecker <[email protected]>
commit b2fcf2102049f6e56981e0ab3d9b633b8e2741da upstream.
This sequence of events can lead to a failure to requeue a CPU's ->nocb_timer:
1. There are no callbacks queued for any CPU covered by CPU 0-2's
->nocb_gp_kthread. Note that ->nocb_gp_kthread is associated with CPU 0.
2. CPU 1 enqueues its first callback with interrupts disabled, and
thus must defer awakening its ->nocb_gp_kthread. It therefore queues its rcu_data structure's ->nocb_timer. At this point, CPU 1's rdp->nocb_defer_wakeup is RCU_NOCB_WAKE.
3. CPU 2, which shares the same ->nocb_gp_kthread, also enqueues a
callback, but with interrupts enabled, allowing it to directly awaken the ->nocb_gp_kthread.
4. The newly awakened ->nocb_gp_kthread associates both CPU 1's
and CPU 2's callbacks with a future grace period and arranges for that grace period to be started.
5. This ->nocb_gp_kthread goes to sleep waiting for the end of this
future grace period.
6. This grace period elapses before the CPU 1's timer fires.
This is normally improbably given that the timer is set for only one jiffy, but timers can be delayed. Besides, it is possible that kernel was built with CONFIG_RCU_STRICT_GRACE_PERIOD=y.
7. The grace period ends, so rcu_gp_kthread awakens the
->nocb_gp_kthread, which in turn awakens both CPU 1's and CPU 2's ->nocb_cb_kthread. Then ->nocb_gb_kthread sleeps waiting for more newly queued callbacks.
8. CPU 1's ->nocb_cb_kthread invokes its callback, then sleeps
waiting for more invocable callbacks.
9. Note that neither kthread updated any ->nocb_timer state,
so CPU 1's ->nocb_defer_wakeup is still set to RCU_NOCB_WAKE.
10. CPU 1 enqueues its second callback, this time with interrupts
enabled so it can wake directly ->nocb_gp_kthread.
It does so with calling wake_nocb_gp() which also cancels the pending timer that got queued in step 2. But that doesn't reset CPU 1's ->nocb_defer_wakeup which is still set to RCU_NOCB_WAKE. So CPU 1's ->nocb_defer_wakeup and its ->nocb_timer are now desynchronized.
11. ->nocb_gp_kthread associates the callback queued in 10 with a new
grace period, arranges for that grace period to start and sleeps waiting for it to complete.
12. The grace period ends, rcu_gp_kthread awakens ->nocb_gp_kthread,
which in turn wakes up CPU 1's ->nocb_cb_kthread which then invokes the callback queued in 10.
13. CPU 1 enqueues its third callback, this time with interrupts
disabled so it must queue a timer for a deferred wakeup. However the value of its ->nocb_defer_wakeup is RCU_NOCB_WAKE which incorrectly indicates that a timer is already queued. Instead, CPU 1's ->nocb_timer was cancelled in 10. CPU 1 therefore fails to queue the ->nocb_timer.
14. CPU 1 has its pending callback and it may go unnoticed until
some other CPU ever wakes up ->nocb_gp_kthread or CPU 1 ever calls an explicit deferred wakeup, for example, during idle entry.
This commit fixes this bug by resetting rdp->nocb_defer_wakeup everytime we delete the ->nocb_timer.
It is quite possible that there is a similar scenario involving ->nocb_bypass_timer and ->nocb_defer_wakeup. However, despite some effort from several people, a failure scenario has not yet been located. However, that by no means guarantees that no such scenario exists. Finding a failure scenario is left as an exercise for the reader, and the "Fixes:" tag below relates to ->nocb_bypass_timer instead of ->nocb_timer.
--- kernel/rcu/tree_plugin.h | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
kernel/rcu/tree_plugin.h +5 -2
@@ -1646,7 +1646,11 @@ static void wake_nocb_gp(struct rcu_datarcu_nocb_unlock_irqrestore (rdp, flags);return ; } -del_timer (&rdp->nocb_timer); + +if (READ_ONCE (rdp->nocb_defer_wakeup) >RCU_NOCB_WAKE_NOT ) { +WRITE_ONCE (rdp->nocb_defer_wakeup,RCU_NOCB_WAKE_NOT ); +del_timer (&rdp->nocb_timer); + }rcu_nocb_unlock_irqrestore (rdp, flags);raw_spin_lock_irqsave (&rdp_gp->nocb_gp_lock, flags);if (force ||READ_ONCE (rdp_gp->nocb_gp_sleep)) {
@@ -2164,7 +2168,6 @@ static void do_nocb_deferred_wakeup_commreturn ; } ndw =READ_ONCE (rdp->nocb_defer_wakeup); -WRITE_ONCE (rdp->nocb_defer_wakeup,RCU_NOCB_WAKE_NOT );wake_nocb_gp (rdp, ndw ==RCU_NOCB_WAKE_FORCE , flags);trace_rcu_nocb_wake (rcu_state.name, rdp->cpu,TPS ("DeferredWake" )); }
Greg Kroah-Hartman
maintainerPATCH 55/105 ice: Fix race conditions between virtchnl handling and VF ndo ops
In reply to Greg Kroah-HartmanFrom: Brett Creeley <[email protected]>
commit e6ba5273d4ede03d075d7a116b8edad1f6115f4d upstream.
The VF can be configured via the PF's ndo ops at the same time the PF is receiving/handling virtchnl messages. This has many issues, with one of them being the ndo op could be actively resetting a VF (i.e. resetting it to the default state and deleting/re-adding the VF's VSI) while a virtchnl message is being handled. The following error was seen because a VF ndo op was used to change a VF's trust setting while the VIRTCHNL_OP_CONFIG_VSI_QUEUES was ongoing:
[35274.192484] ice 0000:88:00.0: Failed to set LAN Tx queue context, error: ICE_ERR_PARAM [35274.193074] ice 0000:88:00.0: VF 0 failed opcode 6, retval: -5 [35274.193640] iavf 0000:88:01.0: PF returned error -5 (IAVF_ERR_PARAM) to our request 6
Fix this by making sure the virtchnl handling and VF ndo ops that trigger VF resets cannot run concurrently. This is done by adding a struct mutex cfg_lock to each VF structure. For VF ndo ops, the mutex will be locked around the critical operations and VFR. Since the ndo ops will trigger a VFR, the virtchnl thread will use mutex_trylock(). This is done because if any other thread (i.e. VF ndo op) has the mutex, then that means the current VF message being handled is no longer valid, so just ignore it.
This issue can be seen using the following commands:
for i in {0..50}; do
rmmod ice
modprobe ice
sleep 1
echo 1 > /sys/class/net/ens785f0/device/sriov_numvfs echo 1 > /sys/class/net/ens785f1/device/sriov_numvfs
ip link set ens785f1 vf 0 trust on
ip link set ens785f0 vf 0 trust on
sleep 2
echo 0 > /sys/class/net/ens785f0/device/sriov_numvfs echo 0 > /sys/class/net/ens785f1/device/sriov_numvfs sleep 1
echo 1 > /sys/class/net/ens785f0/device/sriov_numvfs echo 1 > /sys/class/net/ens785f1/device/sriov_numvfs
ip link set ens785f1 vf 0 trust on
ip link set ens785f0 vf 0 trust on
done
--- drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c | 25 +++++++++++++++++++++++ drivers/net/ethernet/intel/ice/ice_virtchnl_pf.h | 5 ++++ 2 files changed, 30 insertions(+)
drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c +25 -0
@@ -374,6 +374,8 @@ void ice_free_vfs(struct ice_pf *pf)set_bit (ICE_VF_STATE_DIS , pf->vf[i].vf_states);ice_free_vf_res (&pf->vf[i]); } + +mutex_destroy (&pf->vf[i].cfg_lock); }if (ice_sriov_free_msix_res (pf))
@@ -1518,6 +1520,8 @@ static void ice_set_dflt_settings_vfs(stset_bit (ICE_VIRTCHNL_VF_CAP_L2 , &vf->vf_caps); vf->spoofchk = true; vf->num_vf_qs = pf->num_qps_per_vf; + +mutex_init (&vf->cfg_lock); } }
@@ -3345,6 +3349,8 @@ ice_set_vf_port_vlan(struct net_device *return 0 ; } +mutex_lock (&vf->cfg_lock); + vf->port_vlan_info = vlanprio;if (vf->port_vlan_info)
@@ -3354,6 +3360,7 @@ ice_set_vf_port_vlan(struct net_device *dev_info (dev,"Clearing port VLAN on VF %d\n" , vf_id);ice_vc_reset_vf (vf); +mutex_unlock (&vf->cfg_lock);return 0 ; }
@@ -3719,6 +3726,15 @@ error_handler:return ; } +/* VF is being configured in another context that triggers a VFR, so no +* need to process this message +*/ +if (!mutex_trylock (&vf->cfg_lock)) { +dev_info (dev,"VF %u is being configured in another context that will trigger a VFR, so there is no need to handle this message\n" , + vf->vf_id); +return ; + } +switch (v_opcode) {case VIRTCHNL_OP_VERSION : err =ice_vc_get_ver_msg (vf, msg);
@@ -3795,6 +3811,8 @@ error_handler:dev_info (dev,"PF failed to honor VF %d, opcode %d, error %d\n" , vf_id, v_opcode, err); } + +mutex_unlock (&vf->cfg_lock); }/**
@@ -3909,6 +3927,8 @@ int ice_set_vf_mac(struct net_device *nereturn -EINVAL ; } +mutex_lock (&vf->cfg_lock); +/* VF is notified of its new MAC via the PF's response to the * VIRTCHNL_OP_GET_VF_RESOURCES message after the VF has been reset */
@@ -3926,6 +3946,7 @@ int ice_set_vf_mac(struct net_device *ne }ice_vc_reset_vf (vf); +mutex_unlock (&vf->cfg_lock);return 0 ; }
@@ -3955,11 +3976,15 @@ int ice_set_vf_trust(struct net_device *if (trusted == vf->trusted)return 0 ; +mutex_lock (&vf->cfg_lock); + vf->trusted = trusted;ice_vc_reset_vf (vf);dev_info (ice_pf_to_dev (pf),"VF %u is now %strusted\n" , vf_id, trusted ?"" :"un" ); +mutex_unlock (&vf->cfg_lock); +return 0 ; }
drivers/net/ethernet/intel/ice/ice_virtchnl_pf.h +5 -0
@@ -68,6 +68,11 @@ struct ice_mdd_vf_events {struct ice_vf {struct ice_pf *pf; +/* Used during virtchnl message handling and NDO ops against the VF +* that will trigger a VFR +*/ +struct mutex cfg_lock; +u16 vf_id;/* VF ID in the PF space */ u16 lan_vsi_idx;/* index into PF struct */ /* first vector index of this VF in the PF space */
Greg Kroah-Hartman
maintainerPATCH 56/105 ice: fix concurrent reset and removal of VFs
In reply to Greg Kroah-HartmanFrom: Jacob Keller <[email protected]>
commit fadead80fe4c033b5e514fcbadd20b55c4494112 upstream.
Commit c503e63200c6 ("ice: Stop processing VF messages during teardown") introduced a driver state flag, ICE_VF_DEINIT_IN_PROGRESS, which is intended to prevent some issues with concurrently handling messages from VFs while tearing down the VFs.
This change was motivated by crashes caused while tearing down and bringing up VFs in rapid succession.
It turns out that the fix actually introduces issues with the VF driver caused because the PF no longer responds to any messages sent by the VF during its .remove routine. This results in the VF potentially removing its DMA memory before the PF has shut down the device queues.
Additionally, the fix doesn't actually resolve concurrency issues within the ice driver. It is possible for a VF to initiate a reset just prior to the ice driver removing VFs. This can result in the remove task concurrently operating while the VF is being reset. This results in similar memory corruption and panics purportedly fixed by that commit.
Fix this concurrency at its root by protecting both the reset and removal flows using the existing VF cfg_lock. This ensures that we cannot remove the VF while any outstanding critical tasks such as a virtchnl message or a reset are occurring.
This locking change also fixes the root cause originally fixed by commit c503e63200c6 ("ice: Stop processing VF messages during teardown"), so we can simply revert it.
Note that I kept these two changes together because simply reverting the original commit alone would leave the driver vulnerable to worse race conditions.
--- drivers/net/ethernet/intel/ice/ice_main.c | 2 + drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c | 35 ++++++++++++++++------- 2 files changed, 27 insertions(+), 10 deletions(-)
drivers/net/ethernet/intel/ice/ice_main.c +2 -0
@@ -1602,7 +1602,9 @@ static void ice_handle_mdd_event(struct* reset, so print the event prior to reset. */ ice_print_vf_rx_mdd_event (vf); +mutex_lock (&pf->vf[i].cfg_lock);ice_reset_vf (&pf->vf[i], false); +mutex_unlock (&pf->vf[i].cfg_lock); } } }
drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c +25 -10
@@ -360,22 +360,26 @@ void ice_free_vfs(struct ice_pf *pf)else dev_warn (dev,"VFs are assigned - not disabling SR-IOV\n" ); -/* Avoid wait time by stopping all VFs at the same time */ -ice_for_each_vf (pf, i) -ice_dis_vf_qs (&pf->vf[i]); - tmp = pf->num_alloc_vfs; pf->num_qps_per_vf =0 ; pf->num_alloc_vfs =0 ;for (i =0 ; i < tmp; i++) { -if (test_bit (ICE_VF_STATE_INIT , pf->vf[i].vf_states)) { +struct ice_vf *vf = &pf->vf[i]; + +mutex_lock (&vf->cfg_lock); + +ice_dis_vf_qs (vf); + +if (test_bit (ICE_VF_STATE_INIT , vf->vf_states)) {/* disable VF qp mappings and set VF disable state */ -ice_dis_vf_mappings (&pf->vf[i]); -set_bit (ICE_VF_STATE_DIS , pf->vf[i].vf_states); -ice_free_vf_res (&pf->vf[i]); +ice_dis_vf_mappings (vf); +set_bit (ICE_VF_STATE_DIS , vf->vf_states); +ice_free_vf_res (vf); } -mutex_destroy (&pf->vf[i].cfg_lock); +mutex_unlock (&vf->cfg_lock); + +mutex_destroy (&vf->cfg_lock); }if (ice_sriov_free_msix_res (pf))
@@ -1223,9 +1227,13 @@ bool ice_reset_all_vfs(struct ice_pf *pfice_for_each_vf (pf, v) { vf = &pf->vf[v]; +mutex_lock (&vf->cfg_lock); +ice_vf_pre_vsi_rebuild (vf);ice_vf_rebuild_vsi (vf);ice_vf_post_vsi_rebuild (vf); + +mutex_unlock (&vf->cfg_lock); }ice_flush (hw);
@@ -1272,6 +1280,8 @@ bool ice_reset_vf(struct ice_vf *vf, boou32 reg;int i; +lockdep_assert_held (&vf->cfg_lock); + dev =ice_pf_to_dev (pf);if (test_bit (__ICE_VF_RESETS_DISABLED, pf->state)) {
@@ -1725,9 +1735,12 @@ void ice_process_vflr_event(struct ice_p bit_idx = (hw->func_caps.vf_base_id + vf_id) %32 ;/* read GLGEN_VFLRSTAT register to find out the flr VFs */ reg =rd32 (hw,GLGEN_VFLRSTAT (reg_idx)); -if (reg &BIT (bit_idx)) +if (reg &BIT (bit_idx)) {/* GLGEN_VFLRSTAT bit will be cleared in ice_reset_vf */ +mutex_lock (&vf->cfg_lock);ice_reset_vf (vf, true); +mutex_unlock (&vf->cfg_lock); + } } }
@@ -1804,7 +1817,9 @@ ice_vf_lan_overflow_event(struct ice_pfif (!vf)return ; +mutex_lock (&vf->cfg_lock);ice_vc_reset_vf (vf); +mutex_unlock (&vf->cfg_lock); }/**
Greg Kroah-Hartman
maintainerPATCH 57/105 sched/topology: Make sched_init_numa() use a set for the deduplicating sort
In reply to Greg Kroah-HartmanFrom: Valentin Schneider <[email protected]>
commit 620a6dc40754dc218f5b6389b5d335e9a107fd29 upstream.
The deduplicating sort in sched_init_numa() assumes that the first line in the distance table contains all unique values in the entire table. I've been trying to pen what this exactly means for the topology, but it's not straightforward. For instance, topology.c uses this example:
node 0 1 2 3
0: 10 20 20 30
1: 20 10 20 20
2: 20 20 10 20
3: 30 20 20 100 ----- 1
| / | | / | | / |
2 ----- 3
Which works out just fine. However, if we swap nodes 0 and 1:
1 ----- 0
| / | | / | | / |
2 ----- 3
we get this distance table:
node 0 1 2 3
0: 10 20 20 20
1: 20 10 20 30
2: 20 20 10 20
3: 20 30 20 10Which breaks the deduplicating sort (non-representative first line). In this case this would just be a renumbering exercise, but it so happens that we can have a deduplicating sort that goes through the whole table in O(n²) at the extra cost of a temporary memory allocation (i.e. any form of set).
The ACPI spec (SLIT) mentions distances are encoded on 8 bits. Following this, implement the set as a 256-bits bitmap. Should this not be satisfactory (i.e. we want to support 32-bit values), then we'll have to go for some other sparse set implementation.
This has the added benefit of letting us allocate just the right amount of memory for sched_domains_numa_distance[], rather than an arbitrary (nr_node_ids + 1).
Note: DT binding equivalent (distance-map) decodes distances as 32-bit values.
--- include/linux/topology.h | 1 kernel/sched/topology.c | 99 ++++++++++++++++++++++------------------------- 2 files changed, 49 insertions(+), 51 deletions(-)
include/linux/topology.h +1 -0
@@ -48,6 +48,7 @@ int arch_update_cpu_topology(void);/* Conform to ACPI 2.0 SLIT distance definitions */ #define LOCAL_DISTANCE 10#define REMOTE_DISTANCE 20 +#define DISTANCE_BITS 8#ifndef node_distance#define node_distance (from,to) ((from) == (to) ? LOCAL_DISTANCE : REMOTE_DISTANCE)#endif
kernel/sched/topology.c +48 -51
170 lines not on this page · raw message
Greg Kroah-Hartman
maintainerPATCH 58/105 sched/topology: Fix sched_domain_topology_level alloc in sched_init_numa()
In reply to Greg Kroah-HartmanFrom: Dietmar Eggemann <[email protected]>
commit 71e5f6644fb2f3304fcb310145ded234a37e7cc1 upstream.
Commit "sched/topology: Make sched_init_numa() use a set for the deduplicating sort" allocates 'i + nr_levels (level)' instead of 'i + nr_levels + 1' sched_domain_topology_level.
This led to an Oops (on Arm64 juno with CONFIG_SCHED_DEBUG):
sched_init_domains
build_sched_domains()
__free_domain_allocs()
__sdt_free() {
...
for_each_sd_topology(tl)
...
sd = *per_cpu_ptr(sdd->sd, j); <--
...
}--- kernel/sched/topology.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/sched/topology.c +1 -1
@@ -1655,7 +1655,7 @@ void sched_init_numa(void)/* Compute default topology size */ for (i =0 ; sched_domain_topology[i].mask; i++); - tl =kzalloc ((i + nr_levels) * + tl =kzalloc ((i + nr_levels +1 ) *sizeof (struct sched_domain_topology_level ),GFP_KERNEL );if (!tl)return ;
Greg Kroah-Hartman
maintainerPATCH 59/105 ia64: ensure proper NUMA distance and possible map initialization
In reply to Greg Kroah-HartmanFrom: Valentin Schneider <[email protected]>
commit b22a8f7b4bde4e4ab73b64908ffd5d90ecdcdbfd upstream.
John Paul reported a warning about bogus NUMA distance values spurred by commit:
620a6dc40754 ("sched/topology: Make sched_init_numa() use a set for the deduplicating sort")
In this case, the afflicted machine comes up with a reported 256 possible nodes, all of which are 0 distance away from one another. This was previously silently ignored, but is now caught by the aforementioned commit.
The culprit is ia64's node_possible_map which remains unchanged from its initialization value of NODE_MASK_ALL. In John's case, the machine doesn't have any SRAT nor SLIT table, but AIUI the possible map remains untouched regardless of what ACPI tables end up being parsed. Thus, !online && possible nodes remain with a bogus distance of 0 (distances \in [0, 9] are "reserved and have no meaning" as per the ACPI spec).
Follow x86 / drivers/base/arch_numa's example and set the possible map to the parsed map, which in this case seems to be the online map.
--- arch/ia64/kernel/acpi.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
arch/ia64/kernel/acpi.c +5 -2
@@ -446,7 +446,8 @@ void __init acpi_numa_fixup(void)if (srat_num_cpus ==0 ) {node_set_online (0 ); node_cpuid[0 ].phys_id =hard_smp_processor_id (); -return ; +slit_distance (0 ,0 ) =LOCAL_DISTANCE ; + goto out; }/*
@@ -489,7 +490,7 @@ void __init acpi_numa_fixup(void)for (j =0 ; j <MAX_NUMNODES ; j++)slit_distance (i, j) = i == j ?LOCAL_DISTANCE :REMOTE_DISTANCE ; -return ; + goto out; }memset (numa_slit,-1 ,sizeof (numa_slit));
@@ -514,6 +515,8 @@ void __init acpi_numa_fixup(void)printk ("\n" ); }#endif +out: + node_possible_map = node_online_map; }#endif /* CONFIG_ACPI_NUMA */
Greg Kroah-Hartman
maintainerPATCH 60/105 mac80211: fix forwarded mesh frames AC & queue selection
In reply to Greg Kroah-HartmanFrom: Nicolas Escande <[email protected]>
commit 859ae7018316daa4adbc496012dcbbb458d7e510 upstream.
There are two problems with the current code that have been highlighted with the AQL feature that is now enbaled by default.
First problem is in ieee80211_rx_h_mesh_fwding(), ieee80211_select_queue_80211() is used on received packets to choose the sending AC queue of the forwarding packet although this function should only be called on TX packet (it uses ieee80211_tx_info). This ends with forwarded mesh packets been sent on unrelated random AC queue. To fix that, AC queue can directly be infered from skb->priority which has been extracted from QOS info (see ieee80211_parse_qos()).
Second problem is the value of queue_mapping set on forwarded mesh frames via skb_set_queue_mapping() is not the AC of the packet but a hardware queue index. This may or may not work depending on AC to HW queue mapping which is driver specific.
Both of these issues lead to improper AC selection while forwarding mesh packets but more importantly due to improper airtime accounting (which is done on a per STA, per AC basis) caused traffic stall with the introduction of AQL.
--- net/mac80211/rx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
net/mac80211/rx.c +2 -2
@@ -2910,13 +2910,13 @@ ieee80211_rx_h_mesh_fwding(struct ieee80 ether_addr_equal(sdata->vif.addr, hdr->addr3))return RX_CONTINUE ; - ac =ieee80211_select_queue_80211 (sdata, skb, hdr); + ac = ieee802_1d_to_ac[skb->priority]; q = sdata->vif.hw_queue[ac];if (ieee80211_queue_stopped (&local->hw, q)) {IEEE80211_IFSTA_MESH_CTR_INC (ifmsh, dropped_frames_congestion);return RX_DROP_MONITOR ; } -skb_set_queue_mapping (skb, q); +skb_set_queue_mapping (skb, ac);if (!--mesh_hdr->ttl) {if (!is_multicast_ether_addr (hdr->addr1))
Greg Kroah-Hartman
maintainerPATCH 61/105 net: stmmac: fix return value of __setup handler
In reply to Greg Kroah-HartmanFrom: Randy Dunlap <[email protected]>
commit e01b042e580f1fbf4fd8da467442451da00c7a90 upstream.
__setup() handlers should return 1 on success, i.e., the parameter has been handled. A return of 0 causes the "option=value" string to be added to init's environment strings, polluting it.
--- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +3 -3
@@ -5428,7 +5428,7 @@ static int __init stmmac_cmdline_opt(chachar *opt;if (!str || !*str) -return -EINVAL ; +return 1 ;while ((opt =strsep (&str,"," )) !=NULL ) {if (!strncmp (opt,"debug:" ,6 )) {if (kstrtoint (opt +6 ,0 , &debug))
@@ -5459,11 +5459,11 @@ static int __init stmmac_cmdline_opt(cha goto err; } } -return 0 ; +return 1 ; err:pr_err ("%s: ERROR broken module parameter conversion" , __func__); -return -EINVAL ; +return 1 ; }__setup ("stmmaceth=" , stmmac_cmdline_opt);
Greg Kroah-Hartman
maintainerPATCH 62/105 mac80211: treat some SAE auth steps as final
In reply to Greg Kroah-HartmanFrom: Johannes Berg <[email protected]>
commit 94d9864cc86f572f881db9b842a78e9d075493ae upstream.
When we get anti-clogging token required (added by the commit mentioned below), or the other status codes added by the later commit 4e56cde15f7d ("mac80211: Handle special status codes in SAE commit") we currently just pretend (towards the internal state machine of authentication) that we didn't receive anything.
This has the undesirable consequence of retransmitting the prior frame, which is not expected, because the timer is still armed.
If we just disarm the timer at that point, it would result in the undesirable side effect of being in this state indefinitely if userspace crashes, or so.
So to fix this, reset the timer and set a new auth_data->waiting in order to have no more retransmissions, but to have the data destroyed when the timer actually fires, which will only happen if userspace didn't continue (i.e. crashed or abandoned it.)
--- net/mac80211/ieee80211_i.h | 2 +- net/mac80211/mlme.c | 16 ++++++++++++---- 2 files changed, 13 insertions(+), 5 deletions(-)
net/mac80211/ieee80211_i.h +1 -1
@@ -374,7 +374,7 @@ struct ieee80211_mgd_auth_data {u8 key[WLAN_KEY_LEN_WEP104 ];u8 key_len, key_idx; -bool done; +bool done, waiting;bool peer_confirmed;bool timeout_started;
net/mac80211/mlme.c +12 -4
@@ -37,6 +37,7 @@#define IEEE80211_AUTH_TIMEOUT_SAE (HZ * 2)#define IEEE80211_AUTH_MAX_TRIES 3#define IEEE80211_AUTH_WAIT_ASSOC (HZ * 5) +#define IEEE80211_AUTH_WAIT_SAE_RETRY (HZ * 2)#define IEEE80211_ASSOC_TIMEOUT (HZ / 5)#define IEEE80211_ASSOC_TIMEOUT_LONG (HZ / 2)#define IEEE80211_ASSOC_TIMEOUT_SHORT (HZ / 10)
@@ -2999,8 +3000,15 @@ static void ieee80211_rx_mgmt_auth(struc (status_code ==WLAN_STATUS_ANTI_CLOG_REQUIRED || (auth_transaction ==1 && (status_code ==WLAN_STATUS_SAE_HASH_TO_ELEMENT || - status_code == WLAN_STATUS_SAE_PK)))) + status_code == WLAN_STATUS_SAE_PK)))) { + /* waiting for userspace now */ + ifmgd->auth_data->waiting = true; + ifmgd->auth_data->timeout = + jiffies +IEEE80211_AUTH_WAIT_SAE_RETRY ; + ifmgd->auth_data->timeout_started = true; +run_again (sdata, ifmgd->auth_data->timeout);return ; + }sdata_info (sdata,"%pM denied authentication (status %d)\n" , mgmt->sa, status_code);
@@ -4526,10 +4534,10 @@ void ieee80211_sta_work(struct ieee80211if (ifmgd->auth_data && ifmgd->auth_data->timeout_started &&time_after (jiffies, ifmgd->auth_data->timeout)) { -if (ifmgd->auth_data->done) { +if (ifmgd->auth_data->done || ifmgd->auth_data->waiting) {/* -* ok ... we waited for assoc but userspace didn't, -* so let's just kill the auth data +* ok ... we waited for assoc or continuation but +* userspace didn't do it, so kill the auth data */ ieee80211_destroy_auth_data (sdata, false); }else if (ieee80211_auth (sdata)) {
Greg Kroah-Hartman
maintainerPATCH 63/105 iavf: Fix missing check for running netdev
In reply to Greg Kroah-HartmanFrom: Slawomir Laba <[email protected]>
commit d2c0f45fcceb0995f208c441d9c9a453623f9ccf upstream.
The driver was queueing reset_task regardless of the netdev state.
Do not queue the reset task in iavf_change_mtu if netdev is not running.
--- drivers/net/ethernet/intel/iavf/iavf_main.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/net/ethernet/intel/iavf/iavf_main.c +5 -2
@@ -3317,8 +3317,11 @@ static int iavf_change_mtu(struct net_deiavf_notify_client_l2_params (&adapter->vsi); adapter->flags |=IAVF_FLAG_SERVICE_CLIENT_REQUESTED ; } - adapter->flags |=IAVF_FLAG_RESET_NEEDED ; -queue_work (iavf_wq, &adapter->reset_task); + +if (netif_running (netdev)) { + adapter->flags |=IAVF_FLAG_RESET_NEEDED ; +queue_work (iavf_wq, &adapter->reset_task); + }return 0 ; }
Greg Kroah-Hartman
maintainerPATCH 64/105 net: sxgbe: fix return value of __setup handler
In reply to Greg Kroah-HartmanFrom: Randy Dunlap <[email protected]>
commit 50e06ddceeea263f57fe92baa677c638ecd65bb6 upstream.
__setup() handlers should return 1 on success, i.e., the parameter has been handled. A return of 0 causes the "option=value" string to be added to init's environment strings, polluting it.
--- drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c +3 -3
@@ -2282,18 +2282,18 @@ static int __init sxgbe_cmdline_opt(charchar *opt;if (!str || !*str) -return -EINVAL ; +return 1 ;while ((opt =strsep (&str,"," )) !=NULL ) {if (!strncmp (opt,"eee_timer:" ,10 )) {if (kstrtoint (opt +10 ,0 , &eee_timer)) goto err; } } -return 0 ; +return 1 ; err:pr_err ("%s: ERROR broken module parameter conversion\n" , __func__); -return -EINVAL ; +return 1 ; }__setup ("sxgbeeth=" , sxgbe_cmdline_opt);
Greg Kroah-Hartman
maintainerPATCH 65/105 ibmvnic: register netdev after init of adapter
In reply to Greg Kroah-HartmanFrom: Sukadev Bhattiprolu <[email protected]>
commit 570425f8c7c18b14fa8a2a58a0adb431968ad118 upstream.
Finish initializing the adapter before registering netdev so state is consistent.
--- drivers/net/ethernet/ibm/ibmvnic.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)
drivers/net/ethernet/ibm/ibmvnic.c +6 -4
@@ -5383,6 +5383,12 @@ static int ibmvnic_probe(struct vio_dev goto ibmvnic_dev_file_err;netif_carrier_off (netdev); + + adapter->state =VNIC_PROBED ; + + adapter->wait_for_reset = false; + adapter->last_reset_time = jiffies; + rc =register_netdev (netdev);if (rc) {dev_err (&dev->dev,"failed to register netdev rc=%d\n" , rc);
@@ -5390,10 +5396,6 @@ static int ibmvnic_probe(struct vio_dev }dev_info (&dev->dev,"ibmvnic registered\n" ); - adapter->state =VNIC_PROBED ; - - adapter->wait_for_reset = false; - adapter->last_reset_time = jiffies;return 0 ; ibmvnic_register_fail:
Greg Kroah-Hartman
maintainerPATCH 66/105 net: arcnet: com20020: Fix null-ptr-deref in com20020pci_probe()
In reply to Greg Kroah-HartmanFrom: Zheyu Ma <[email protected]>
commit bd6f1fd5d33dfe5d1b4f2502d3694a7cc13f166d upstream.
During driver initialization, the pointer of card info, i.e. the variable 'ci' is required. However, the definition of 'com20020pci_id_table' reveals that this field is empty for some devices, which will cause null pointer dereference when initializing these devices.
The following log reveals it:
[ 3.973806] KASAN: null-ptr-deref in range [0x0000000000000028-0x000000000000002f] [ 3.973819] RIP: 0010:com20020pci_probe+0x18d/0x13e0 [com20020_pci] [ 3.975181] Call Trace: [ 3.976208] local_pci_probe+0x13f/0x210 [ 3.977248] pci_device_probe+0x34c/0x6d0 [ 3.977255] ? pci_uevent+0x470/0x470 [ 3.978265] really_probe+0x24c/0x8d0 [ 3.978273] __driver_probe_device+0x1b3/0x280 [ 3.979288] driver_probe_device+0x50/0x370
Fix this by checking whether the 'ci' is a null pointer first.
--- drivers/net/arcnet/com20020-pci.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/net/arcnet/com20020-pci.c +3 -0
@@ -136,6 +136,9 @@ static int com20020pci_probe(struct pci_return -ENOMEM ; ci = (struct com20020_pci_card_info *)id->driver_data; +if (!ci) +return -EINVAL ; + priv->ci = ci; mm = &ci->misc_map;
Greg Kroah-Hartman
maintainerPATCH 67/105 ixgbe: xsk: change !netif_carrier_ok() handling in ixgbe_xmit_zc()
In reply to Greg Kroah-HartmanFrom: Maciej Fijalkowski <[email protected]>
commit 6c7273a266759d9d36f7c862149f248bcdeddc0f upstream.
Commit c685c69fba71 ("ixgbe: don't do any AF_XDP zero-copy transmit if netif is not OK") addressed the ring transient state when MEM_TYPE_XSK_BUFF_POOL was being configured which in turn caused the interface to through down/up. Maurice reported that when carrier is not ok and xsk_pool is present on ring pair, ksoftirqd will consume 100% CPU cycles due to the constant NAPI rescheduling as ixgbe_poll() states that there is still some work to be done.
To fix this, do not set work_done to false for a !netif_carrier_ok().
--- drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c +4 -2
@@ -391,12 +391,14 @@ static bool ixgbe_xmit_zc(struct ixgbe_ru32 cmd_type;while (budget-- >0 ) { -if (unlikely (!ixgbe_desc_unused (xdp_ring)) || - !netif_carrier_ok (xdp_ring->netdev)) { +if (unlikely (!ixgbe_desc_unused (xdp_ring))) { work_done = false;break ; } +if (!netif_carrier_ok (xdp_ring->netdev)) +break ; +if (!xsk_tx_peek_desc (pool, &desc))break ;
Greg Kroah-Hartman
maintainerPATCH 68/105 efivars: Respect "block" flag in efivar_entry_set_safe()
In reply to Greg Kroah-HartmanFrom: Jann Horn <[email protected]>
commit 258dd902022cb10c83671176688074879517fd21 upstream.
When the "block" flag is false, the old code would sometimes still call check_var_size(), which wrongly tells ->query_variable_store() that it can block.
As far as I can tell, this can't really materialize as a bug at the moment, because ->query_variable_store only does something on X86 with generic EFI, and in that configuration we always take the efivar_entry_set_nonblocking() path.
--- drivers/firmware/efi/vars.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/firmware/efi/vars.c +4 -1
@@ -742,6 +742,7 @@ int efivar_entry_set_safe(efi_char16_t * {const struct efivar_operations *ops;efi_status_t status; +unsigned long varsize;if (!__efivars)return -EINVAL ;
@@ -764,15 +765,17 @@ int efivar_entry_set_safe(efi_char16_t *return efivar_entry_set_nonblocking (name, vendor, attributes, size, data); + varsize = size +ucs2_strsize (name,1024 );if (!block) {if (down_trylock (&efivars_lock))return -EBUSY ; + status =check_var_size_nonblocking (attributes, varsize); }else {if (down_interruptible (&efivars_lock))return -EINTR ; + status =check_var_size (attributes, varsize); } - status =check_var_size (attributes, size +ucs2_strsize (name,1024 ));if (status !=EFI_SUCCESS ) {up (&efivars_lock);return -ENOSPC ;
Greg Kroah-Hartman
maintainerPATCH 69/105 firmware: arm_scmi: Remove space in MODULE_ALIAS name
In reply to Greg Kroah-HartmanFrom: Alyssa Ross <[email protected]>
commit 1ba603f56568c3b4c2542dfba07afa25f21dcff3 upstream.
modprobe can't handle spaces in aliases. Get rid of it to fix the issue.
--- drivers/firmware/arm_scmi/driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/firmware/arm_scmi/driver.c +1 -1
@@ -979,7 +979,7 @@ static void __exit scmi_driver_exit(void }module_exit (scmi_driver_exit); -MODULE_ALIAS ("platform: arm-scmi" ); +MODULE_ALIAS ("platform:arm-scmi" );MODULE_AUTHOR ("Sudeep Holla <[email protected]>" );MODULE_DESCRIPTION ("ARM SCMI protocol driver" );MODULE_LICENSE ("GPL v2" );
Greg Kroah-Hartman
maintainerPATCH 70/105 ASoC: cs4265: Fix the duplicated control name
In reply to Greg Kroah-HartmanFrom: Fabio Estevam <[email protected]>
commit c5487b9cdea5c1ede38a7ec94db0fc59963c8e86 upstream.
Currently, the following error messages are seen during boot:
asoc-simple-card sound: control 2:0:0:SPDIF Switch:0 is already present cs4265 1-004f: ASoC: failed to add widget SPDIF dapm kcontrol SPDIF Switch: -16
Quoting Mark Brown:
"The driver is just plain buggy, it defines both a regular SPIDF Switch control and a SND_SOC_DAPM_SWITCH() called SPDIF both of which will create an identically named control, it can never have loaded without error. One or both of those has to be renamed or they need to be merged into one thing."
Fix the duplicated control name by combining the two SPDIF controls here and move the register bits onto the DAPM widget and have DAPM control them.
--- sound/soc/codecs/cs4265.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
sound/soc/codecs/cs4265.c +1 -2
@@ -150,7 +150,6 @@ static const struct snd_kcontrol_new cs4SOC_SINGLE ("E to F Buffer Disable Switch" ,CS4265_SPDIF_CTL1 ,6 ,1 ,0 ),SOC_ENUM ("C Data Access" , cam_mode_enum), -SOC_SINGLE ("SPDIF Switch" ,CS4265_SPDIF_CTL2 ,5 ,1 ,1 ),SOC_SINGLE ("Validity Bit Control Switch" ,CS4265_SPDIF_CTL2 ,3 ,1 ,0 ), SOC_ENUM("SPDIF Mono/Stereo", spdif_mono_stereo_enum),
@@ -186,7 +185,7 @@ static const struct snd_soc_dapm_widgetSND_SOC_DAPM_SWITCH ("Loopback" ,SND_SOC_NOPM ,0 ,0 , &loopback_ctl), -SND_SOC_DAPM_SWITCH ("SPDIF" ,SND_SOC_NOPM ,0 ,0 , +SND_SOC_DAPM_SWITCH ("SPDIF" ,CS4265_SPDIF_CTL2 ,5 ,1 , &spdif_switch),SND_SOC_DAPM_SWITCH ("DAC" ,CS4265_PWRCTL ,1 ,1 , &dac_switch),
Greg Kroah-Hartman
maintainerPATCH 71/105 can: gs_usb: change active_channelss type from atomic_t to u8
In reply to Greg Kroah-HartmanFrom: Vincent Mailhol <[email protected]>
commit 035b0fcf02707d3c9c2890dc1484b11aa5335eb1 upstream.
The driver uses an atomic_t variable: gs_usb:active_channels to keep track of the number of opened channels in order to only allocate memory for the URBs when this count changes from zero to one.
However, the driver does not decrement the counter when an error occurs in gs_can_open(). This issue is fixed by changing the type from atomic_t to u8 and by simplifying the logic accordingly.
It is safe to use an u8 here because the network stack big kernel lock (a.k.a. rtnl_mutex) is being hold. For details, please refer to [1].
--- drivers/net/can/usb/gs_usb.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/net/can/usb/gs_usb.c +5 -5
@@ -190,8 +190,8 @@ struct gs_can {struct gs_usb {struct gs_can *canch[GS_MAX_INTF ];struct usb_anchor rx_submitted; -atomic_t active_channels;struct usb_device *udev; +u8 active_channels; };/* 'allocate' a tx context.
@@ -588,7 +588,7 @@ static int gs_can_open(struct net_deviceif (rc)return rc; -if (atomic_add_return (1 , &parent->active_channels) ==1 ) { +if (!parent->active_channels) {for (i =0 ; i <GS_MAX_RX_URBS ; i++) {struct urb *urb;u8 *buf;
@@ -689,6 +689,7 @@ static int gs_can_open(struct net_device dev->can.state =CAN_STATE_ERROR_ACTIVE ; + parent->active_channels++;if (!(dev->can.ctrlmode &CAN_CTRLMODE_LISTENONLY ))netif_start_queue (netdev);
@@ -704,7 +705,8 @@ static int gs_can_close(struct net_devicnetif_stop_queue (netdev);/* Stop polling */ -if (atomic_dec_and_test (&parent->active_channels)) + parent->active_channels--; +if (!parent->active_channels)usb_kill_anchored_urbs (&parent->rx_submitted);/* Stop sending URBs */
@@ -983,8 +985,6 @@ static int gs_usb_probe(struct usb_interinit_usb_anchor (&dev->rx_submitted); -atomic_set (&dev->active_channels,0 ); -usb_set_intfdata (intf, dev); dev->udev =interface_to_usbdev (intf);
Greg Kroah-Hartman
maintainerPATCH 72/105 arm64: dts: rockchip: Switch RK3399-Gru DP to SPDIF output
In reply to Greg Kroah-HartmanFrom: Brian Norris <[email protected]>
commit b5fbaf7d779f5f02b7f75b080e7707222573be2a upstream.
Commit b18c6c3c7768 ("ASoC: rockchip: cdn-dp sound output use spdif") switched the platform to SPDIF, but we didn't fix up the device tree.
Drop the pinctrl settings, because the 'spdif_bus' pins are either:
* unused (on kevin, bob), so the settings is ~harmless
* used by a different function (on scarlet), which causes probe failures (!!)
--- arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-)
arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi +12 -5
@@ -281,7 +281,7 @@ sound: sound { compatible = "rockchip,rk3399-gru-sound"; - rockchip,cpu = <&i2s0 &i2s2>; + rockchip,cpu = <&i2s0 &spdif>; }; };
@@ -432,10 +432,6 @@ ap_i2c_audio: &i2c8 { status = "okay"; }; -&i2s2 { - status = "okay"; -}; - &io_domains { status = "okay";
@@ -532,6 +528,17 @@ ap_i2c_audio: &i2c8 { vqmmc-supply = <&ppvar_sd_card_io>; }; +&spdif { + status = "okay"; + + /* + * SPDIF is routed internally to DP; we either don't use these pins, or + * mux them to something else. + */ + /delete-property/ pinctrl-0; + /delete-property/ pinctrl-names; +}; + &spi1 { status = "okay";
Greg Kroah-Hartman
maintainerPATCH 73/105 igc: igc_read_phy_reg_gpy: drop premature return
In reply to Greg Kroah-HartmanFrom: Corinna Vinschen <[email protected]>
commit fda2635466cd26ad237e1bc5d3f6a60f97ad09b6 upstream.
igc_read_phy_reg_gpy checks the return value from igc_read_phy_reg_mdic and if it's not 0, returns immediately. By doing this, it leaves the HW semaphore in the acquired state.
Drop this premature return statement, the function returns after releasing the semaphore immediately anyway.
--- drivers/net/ethernet/intel/igc/igc_phy.c | 2 -- 1 file changed, 2 deletions(-)
drivers/net/ethernet/intel/igc/igc_phy.c +0 -2
@@ -781,8 +781,6 @@ s32 igc_read_phy_reg_gpy(struct igc_hw *if (ret_val)return ret_val; ret_val =igc_read_phy_reg_mdic (hw, offset, data); -if (ret_val) -return ret_val; hw->phy.ops.release (hw); }else { ret_val = igc_read_xmdio_reg(hw, (u16)offset, dev_addr,
Greg Kroah-Hartman
maintainerPATCH 74/105 ARM: Fix kgdb breakpoint for Thumb2
In reply to Greg Kroah-HartmanFrom: Russell King (Oracle) <[email protected]>
commit d920eaa4c4559f59be7b4c2d26fa0a2e1aaa3da9 upstream.
The kgdb code needs to register an undef hook for the Thumb UDF instruction that will fault in order to be functional on Thumb2 platforms.
--- arch/arm/kernel/kgdb.c | 36 ++++++++++++++++++++++++++++-------- 1 file changed, 28 insertions(+), 8 deletions(-)
arch/arm/kernel/kgdb.c +28 -8
@@ -154,22 +154,38 @@ static int kgdb_compiled_brk_fn(struct preturn 0 ; } -static struct undef_hook kgdb_brkpt_hook = { +static struct undef_hook kgdb_brkpt_arm_hook = { .instr_mask =0xffffffff , .instr_val =KGDB_BREAKINST , - .cpsr_mask =MODE_MASK , + .cpsr_mask =PSR_T_BIT |MODE_MASK , .cpsr_val =SVC_MODE , .fn = kgdb_brk_fn }; -static struct undef_hook kgdb_compiled_brkpt_hook = { +static struct undef_hook kgdb_brkpt_thumb_hook = { + .instr_mask =0xffff , + .instr_val =KGDB_BREAKINST &0xffff , + .cpsr_mask =PSR_T_BIT |MODE_MASK , + .cpsr_val =PSR_T_BIT |SVC_MODE , + .fn = kgdb_brk_fn +}; + +static struct undef_hook kgdb_compiled_brkpt_arm_hook = { .instr_mask =0xffffffff , .instr_val =KGDB_COMPILED_BREAK , - .cpsr_mask =MODE_MASK , + .cpsr_mask =PSR_T_BIT |MODE_MASK , .cpsr_val =SVC_MODE , .fn = kgdb_compiled_brk_fn }; +static struct undef_hook kgdb_compiled_brkpt_thumb_hook = { + .instr_mask =0xffff , + .instr_val =KGDB_COMPILED_BREAK &0xffff , + .cpsr_mask =PSR_T_BIT |MODE_MASK , + .cpsr_val =PSR_T_BIT |SVC_MODE , + .fn = kgdb_compiled_brk_fn +}; +static int __kgdb_notify (struct die_args *args,unsigned long cmd) {struct pt_regs *regs = args->regs;
@@ -210,8 +226,10 @@ int kgdb_arch_init(void)if (ret !=0 )return ret; -register_undef_hook (&kgdb_brkpt_hook); -register_undef_hook (&kgdb_compiled_brkpt_hook); +register_undef_hook (&kgdb_brkpt_arm_hook); +register_undef_hook (&kgdb_brkpt_thumb_hook); +register_undef_hook (&kgdb_compiled_brkpt_arm_hook); +register_undef_hook (&kgdb_compiled_brkpt_thumb_hook);return 0 ; }
@@ -224,8 +242,10 @@ int kgdb_arch_init(void)*/ void kgdb_arch_exit (void ) { -unregister_undef_hook (&kgdb_brkpt_hook); -unregister_undef_hook (&kgdb_compiled_brkpt_hook); +unregister_undef_hook (&kgdb_brkpt_arm_hook); +unregister_undef_hook (&kgdb_brkpt_thumb_hook); +unregister_undef_hook (&kgdb_compiled_brkpt_arm_hook); +unregister_undef_hook (&kgdb_compiled_brkpt_thumb_hook);unregister_die_notifier (&kgdb_notifier); }
Greg Kroah-Hartman
maintainerPATCH 75/105 ARM: 9182/1: mmu: fix returns from early_param() and __setup() functions
In reply to Greg Kroah-HartmanFrom: Randy Dunlap <[email protected]>
commit 7b83299e5b9385943a857d59e15cba270df20d7e upstream.
early_param() handlers should return 0 on success. __setup() handlers should return 1 on success, i.e., the parameter has been handled. A return of 0 would cause the "option=value" string to be added to init's environment strings, polluting it.
../arch/arm/mm/mmu.c: In function 'test_early_cachepolicy':../arch/arm/mm/mmu.c:215:1: error: no return statement in function returning non-void [-Werror=return-type] ../arch/arm/mm/mmu.c: In function 'test_noalign_setup':../arch/arm/mm/mmu.c:221:1: error: no return statement in function returning non-void [-Werror=return-type]
--- arch/arm/mm/mmu.c | 2 ++ 1 file changed, 2 insertions(+)
arch/arm/mm/mmu.c +2 -0
@@ -212,12 +212,14 @@ early_param("ecc", early_ecc);static int __init early_cachepolicy (char *p) {pr_warn ("cachepolicy kernel parameter not supported without cp15\n" ); +return 0 ; }early_param ("cachepolicy" , early_cachepolicy);static int __init noalign_setup (char *__unused) {pr_warn ("noalign kernel parameter not supported without cp15\n" ); +return 1 ; }__setup ("noalign" , noalign_setup);
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Greg Kroah-Hartman
maintainerPATCH 76/105 selftests: mlxsw: tc_police_scale: Make test more robust
In reply to Greg Kroah-HartmanFrom: Amit Cohen <[email protected]>
commit dc9752075341e7beb653e37c6f4a3723074dc8bc upstream.
The test adds tc filters and checks how many of them were offloaded by grepping for 'in_hw'.
iproute2 commit f4cd4f127047 ("tc: add skip_hw and skip_sw to control action offload") added offload indication to tc actions, producing the following output:
$ tc filter show dev swp2 ingress
...
filter protocol ipv6 pref 1000 flower chain 0 handle 0x7c0
eth_type ipv6
dst_ip 2001:db8:1::7bf
skip_sw
in_hw in_hw_count 1
action order 1: police 0x7c0 rate 10Mbit burst 100Kb mtu 2Kb action drop overhead 0b
ref 1 bind 1
not_in_hw
used_hw_stats immediateThe current grep expression matches on both 'in_hw' and 'not_in_hw', resulting in incorrect results.
Fix that by using JSON output instead.
--- tools/testing/selftests/drivers/net/mlxsw/tc_police_scale.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
tools/testing/selftests/drivers/net/mlxsw/tc_police_scale.sh +2 -1
@@ -60,7 +60,8 @@ __tc_police_test() tc_police_rules_create $count $should_fail - offload_count=$(tc filter show dev $swp1 ingress | grep in_hw | wc -l) + offload_count=$(tc -j filter show dev $swp1 ingress | + jq "[.[] | select(.options.in_hw == true)] | length") ((offload_count == count)) check_err_fail $should_fail $? "tc police offload count" }
Signature · 1 line
2.35.1
Greg Kroah-Hartman
maintainerPATCH 77/105 pinctrl: sunxi: Use unique lockdep classes for IRQs
In reply to Greg Kroah-HartmanFrom: Samuel Holland <[email protected]>
commit bac129dbc6560dfeb634c03f0c08b78024e71915 upstream.
This driver, like several others, uses a chained IRQ for each GPIO bank, and forwards .irq_set_wake to the GPIO bank's upstream IRQ. As a result, a call to irq_set_irq_wake() needs to lock both the upstream and downstream irq_desc's. Lockdep considers this to be a possible deadlock when the irq_desc's share lockdep classes, which they do by default:
============================================
WARNING: possible recursive locking detected 5.17.0-rc3-00394-gc849047c2473 #1 Not tainted
--------------------------------------------
init/307 is trying to acquire lock:
c2dfe27c (&irq_desc_lock_class){-.-.}-{2:2}, at: __irq_get_desc_lock+0x58/0xa0
but task is already holding lock:
c3c0ac7c (&irq_desc_lock_class){-.-.}-{2:2}, at: __irq_get_desc_lock+0x58/0xa0
other info that might help us debug this:
Possible unsafe locking scenario:
CPU0
---- lock(&irq_desc_lock_class);
lock(&irq_desc_lock_class);
*** DEADLOCK ***
May be due to missing lock nesting notation
4 locks held by init/307:
#0: c1f29f18 (system_transition_mutex){+.+.}-{3:3}, at: __do_sys_reboot+0x90/0x23c #1: c20f7760 (&dev->mutex){....}-{3:3}, at: device_shutdown+0xf4/0x224 #2: c2e804d8 (&dev->mutex){....}-{3:3}, at: device_shutdown+0x104/0x224 #3: c3c0ac7c (&irq_desc_lock_class){-.-.}-{2:2}, at: __irq_get_desc_lock+0x58/0xa0
stack backtrace:
CPU: 0 PID: 307 Comm: init Not tainted 5.17.0-rc3-00394-gc849047c2473 #1
Hardware name: Allwinner sun8i Family
unwind_backtrace from show_stack+0x10/0x14
show_stack from dump_stack_lvl+0x68/0x90
dump_stack_lvl from __lock_acquire+0x1680/0x31a0
__lock_acquire from lock_acquire+0x148/0x3dc
lock_acquire from _raw_spin_lock_irqsave+0x50/0x6c
_raw_spin_lock_irqsave from __irq_get_desc_lock+0x58/0xa0
__irq_get_desc_lock from irq_set_irq_wake+0x2c/0x19c
irq_set_irq_wake from irq_set_irq_wake+0x13c/0x19c
[tail call from sunxi_pinctrl_irq_set_wake]
irq_set_irq_wake from gpio_keys_suspend+0x80/0x1a4
gpio_keys_suspend from gpio_keys_shutdown+0x10/0x2c
gpio_keys_shutdown from device_shutdown+0x180/0x224
device_shutdown from __do_sys_reboot+0x134/0x23c
__do_sys_reboot from ret_fast_syscall+0x0/0x1cHowever, this can never deadlock because the upstream and downstream IRQs are never the same (nor do they even involve the same irqchip).
Silence this erroneous lockdep splat by applying what appears to be the usual fix of moving the GPIO IRQs to separate lockdep classes.
--- drivers/pinctrl/sunxi/pinctrl-sunxi.c | 9 +++++++++ 1 file changed, 9 insertions(+)
drivers/pinctrl/sunxi/pinctrl-sunxi.c +9 -0
@@ -36,6 +36,13 @@#include "../core.h" #include "pinctrl-sunxi.h" +/* +* These lock classes tell lockdep that GPIO IRQs are in a different +* category than their parents, so it won't report false recursion. +*/ +static struct lock_class_key sunxi_pinctrl_irq_lock_class; +static struct lock_class_key sunxi_pinctrl_irq_request_class; +static struct irq_chip sunxi_pinctrl_edge_irq_chip;static struct irq_chip sunxi_pinctrl_level_irq_chip;
@@ -1552,6 +1559,8 @@ int sunxi_pinctrl_init_with_variant(strufor (i =0 ; i < (pctl->desc->irq_banks *IRQ_PER_BANK ); i++) {int irqno =irq_create_mapping (pctl->domain, i); +irq_set_lockdep_class (irqno, &sunxi_pinctrl_irq_lock_class, + &sunxi_pinctrl_irq_request_class);irq_set_chip_and_handler (irqno, &sunxi_pinctrl_edge_irq_chip, handle_edge_irq);irq_set_chip_data (irqno, pctl);
Greg Kroah-Hartman
maintainerPATCH 78/105 igc: igc_write_phy_reg_gpy: drop premature return
In reply to Greg Kroah-HartmanFrom: Sasha Neftin <[email protected]>
commit c4208653a327a09da1e9e7b10299709b6d9b17bf upstream.
Similar to "igc_read_phy_reg_gpy: drop premature return" patch. igc_write_phy_reg_gpy checks the return value from igc_write_phy_reg_mdic and if it's not 0, returns immediately. By doing this, it leaves the HW semaphore in the acquired state.
Drop this premature return statement, the function returns after releasing the semaphore immediately anyway.
--- drivers/net/ethernet/intel/igc/igc_phy.c | 2 -- 1 file changed, 2 deletions(-)
drivers/net/ethernet/intel/igc/igc_phy.c +0 -2
@@ -748,8 +748,6 @@ s32 igc_write_phy_reg_gpy(struct igc_hwif (ret_val)return ret_val; ret_val =igc_write_phy_reg_mdic (hw, offset, data); -if (ret_val) -return ret_val; hw->phy.ops.release (hw); }else { ret_val = igc_write_xmdio_reg(hw, (u16)offset, dev_addr,
Greg Kroah-Hartman
maintainerPATCH 79/105 ibmvnic: free reset-work-item when flushing
In reply to Greg Kroah-HartmanFrom: Sukadev Bhattiprolu <[email protected]>
commit 8d0657f39f487d904fca713e0bc39c2707382553 upstream.
Fix a tiny memory leak when flushing the reset work queue.
--- drivers/net/ethernet/ibm/ibmvnic.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/net/ethernet/ibm/ibmvnic.c +3 -1
@@ -2354,8 +2354,10 @@ static int ibmvnic_reset(struct ibmvnic_* flush reset queue and process this reset */ if (adapter->force_reset_recovery && !list_empty (&adapter->rwi_list)) { -list_for_each_safe (entry, tmp_entry, &adapter->rwi_list) +list_for_each_safe (entry, tmp_entry, &adapter->rwi_list) {list_del (entry); +kfree (list_entry(entry ,struct ibmvnic_rwi ,list )); + } } rwi->reset_reason = reason;list_add_tail (&rwi->list, &adapter->rwi_list);
Greg Kroah-Hartman
maintainerPATCH 80/105 memfd: fix F_SEAL_WRITE after shmem huge page allocated
In reply to Greg Kroah-HartmanFrom: Hugh Dickins <[email protected]>
commit f2b277c4d1c63a85127e8aa2588e9cc3bd21cb99 upstream.
Wangyong reports: after enabling tmpfs filesystem to support transparent hugepage with the following command:
echo always > /sys/kernel/mm/transparent_hugepage/shmem_enabled
the docker program tries to add F_SEAL_WRITE through the following command, but it fails unexpectedly with errno EBUSY:
fcntl(5, F_ADD_SEALS, F_SEAL_WRITE) = -1.
That is because memfd_tag_pins() and memfd_wait_for_pins() were never updated for shmem huge pages: checking page_mapcount() against page_count() is hopeless on THP subpages - they need to check total_mapcount() against page_count() on THP heads only.
Make memfd_tag_pins() (compared > 1) as strict as memfd_wait_for_pins() (compared != 1): either can be justified, but given the non-atomic total_mapcount() calculation, it is better now to be strict. Bear in mind that total_mapcount() itself scans all of the THP subpages, when choosing to take an XA_CHECK_SCHED latency break.
Also fix the unlikely xa_is_value() case in memfd_wait_for_pins(): if a page has been swapped out since memfd_tag_pins(), then its refcount must have fallen, and so it can safely be untagged.
--- mm/memfd.c | 40 ++++++++++++++++++++++++++++------------ 1 file changed, 28 insertions(+), 12 deletions(-)
mm/memfd.c +28 -12
@@ -31,20 +31,28 @@static void memfd_tag_pins (struct xa_state *xas) {struct page *page; -unsigned int tagged =0 ; +int latency =0 ; +int cache_count;lru_add_drain ();xas_lock_irq (xas);xas_for_each (xas, page,ULONG_MAX ) { -if (xa_is_value (page)) -continue ; - page =find_subpage (page, xas->xa_index); -if (page_count (page) -page_mapcount (page) >1 ) + cache_count =1 ; +if (!xa_is_value (page) && +PageTransHuge (page) && !PageHuge (page)) + cache_count =HPAGE_PMD_NR ; + +if (!xa_is_value (page) && +page_count (page) -total_mapcount (page) != cache_count)xas_set_mark (xas,MEMFD_TAG_PINNED ); +if (cache_count !=1 ) +xas_set (xas, page->index + cache_count); -if (++tagged %XA_CHECK_SCHED ) + latency += cache_count; +if (latency <XA_CHECK_SCHED )continue ; + latency =0 ;xas_pause (xas);xas_unlock_irq (xas);
@@ -73,7 +81,8 @@ static int memfd_wait_for_pins(struct ad error =0 ;for (scan =0 ; scan <=LAST_SCAN ; scan++) { -unsigned int tagged =0 ; +int latency =0 ; +int cache_count;if (!xas_marked (&xas,MEMFD_TAG_PINNED ))break ;
@@ -87,10 +96,14 @@ static int memfd_wait_for_pins(struct adxas_lock_irq (&xas);xas_for_each_marked (&xas, page,ULONG_MAX ,MEMFD_TAG_PINNED ) {bool clear = true; -if (xa_is_value (page)) -continue ; - page =find_subpage (page, xas.xa_index); -if (page_count (page) -page_mapcount (page) !=1 ) { + + cache_count =1 ; +if (!xa_is_value (page) && +PageTransHuge (page) && !PageHuge (page)) + cache_count =HPAGE_PMD_NR ; + +if (!xa_is_value (page) && cache_count != +page_count (page) -total_mapcount (page)) {/* * On the last scan, we clean up all those tags * we inserted; but make a note that we still
@@ -103,8 +116,11 @@ static int memfd_wait_for_pins(struct ad }if (clear)xas_clear_mark (&xas,MEMFD_TAG_PINNED ); -if (++tagged %XA_CHECK_SCHED ) + + latency += cache_count; +if (latency <XA_CHECK_SCHED )continue ; + latency =0 ;xas_pause (&xas);xas_unlock_irq (&xas);
Greg Kroah-Hartman
maintainerPATCH 81/105 s390/extable: fix exception table sorting
In reply to Greg Kroah-HartmanFrom: Heiko Carstens <[email protected]>
commit c194dad21025dfd043210912653baab823bdff67 upstream.
s390 has a swap_ex_entry_fixup function, however it is not being used since common code expects a swap_ex_entry_fixup define. If it is not defined the default implementation will be used. So fix this by adding a proper define.
However also the implementation of the function must be fixed, since a NULL value for handler has a special meaning and must not be adjusted.
Luckily all of this doesn't fix a real bug currently: the main extable is correctly sorted during build time, and for runtime sorting there is currently no case where the handler field is not NULL.
--- arch/s390/include/asm/extable.h | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
arch/s390/include/asm/extable.h +7 -2
@@ -69,8 +69,13 @@ static inline void swap_ex_entry_fixup(s { a->fixup = b->fixup + delta; b->fixup = tmp.fixup - delta; - a->handler = b->handler + delta; - b->handler = tmp.handler - delta; + a->handler = b->handler; +if (a->handler) + a->handler += delta; + b->handler = tmp.handler; +if (b->handler) + b->handler -= delta; } +#define swap_ex_entry_fixup swap_ex_entry_fixup#endif
Greg Kroah-Hartman
maintainerPATCH 82/105 ARM: dts: switch timer config to common devkit8000 devicetree
In reply to Greg Kroah-HartmanFrom: Anthoine Bourgeois <[email protected]>
[ Upstream commit 64324ef337d0caa5798fa8fa3f6bbfbd3245868a ]
This patch allow lcd43 and lcd70 flavors to benefit from timer evolution.
--- .../arm/boot/dts/omap3-devkit8000-common.dtsi | 33 +++++++++++++++++++ arch/arm/boot/dts/omap3-devkit8000.dts | 33 ------------------- 2 files changed, 33 insertions(+), 33 deletions(-)
arch/arm/boot/dts/omap3-devkit8000-common.dtsi +33 -0
@@ -158,6 +158,39 @@ status = "disabled"; }; +/* Unusable as clocksource because of unreliable oscillator */ +&counter32k { + status = "disabled"; +}; + +/* Unusable as clockevent because if unreliable oscillator, allow to idle */ +&timer1_target { + /delete-property/ti,no-reset-on-init; + /delete-property/ti,no-idle; + timer@0 { + /delete-property/ti,timer-alwon; + }; +}; + +/* Preferred always-on timer for clocksource */ +&timer12_target { + ti,no-reset-on-init; + ti,no-idle; + timer@0 { + /* Always clocked by secure_32k_fck */ + }; +}; + +/* Preferred timer for clockevent */ +&timer2_target { + ti,no-reset-on-init; + ti,no-idle; + timer@0 { + assigned-clocks = <&gpt2_fck>; + assigned-clock-parents = <&sys_ck>; + }; +}; + &twl_gpio { ti,use-leds; /*
arch/arm/boot/dts/omap3-devkit8000.dts +0 -33
@@ -14,36 +14,3 @@ display2 = &tv0; }; }; - -/* Unusable as clocksource because of unreliable oscillator */ -&counter32k { - status = "disabled"; -}; - -/* Unusable as clockevent because if unreliable oscillator, allow to idle */ -&timer1_target { - /delete-property/ti,no-reset-on-init; - /delete-property/ti,no-idle; - timer@0 { - /delete-property/ti,timer-alwon; - }; -}; - -/* Preferred always-on timer for clocksource */ -&timer12_target { - ti,no-reset-on-init; - ti,no-idle; - timer@0 { - /* Always clocked by secure_32k_fck */ - }; -}; - -/* Preferred timer for clockevent */ -&timer2_target { - ti,no-reset-on-init; - ti,no-idle; - timer@0 { - assigned-clocks = <&gpt2_fck>; - assigned-clock-parents = <&sys_ck>; - }; -};
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 83/105 ARM: dts: Use 32KiHz oscillator on devkit8000
In reply to Greg Kroah-HartmanFrom: Anthoine Bourgeois <[email protected]>
[ Upstream commit 8840f5460a23759403f1f2860429dcbcc2f04a65 ]
Devkit8000 board seems to always used 32k_counter as clocksource. Restore this behavior.
If clocksource is back to 32k_counter, timer12 is now the clockevent source (as before) and timer2 is not longer needed here.
This commit fixes the same issue observed with commit 23885389dbbb ("ARM: dts: Fix timer regression for beagleboard revision c") when sleep is blocked until hitting keys over serial console.
--- arch/arm/boot/dts/omap3-devkit8000-common.dtsi | 17 +---------------- drivers/clocksource/timer-ti-dm-systimer.c | 3 +-- 2 files changed, 2 insertions(+), 18 deletions(-)
arch/arm/boot/dts/omap3-devkit8000-common.dtsi +1 -16
@@ -158,11 +158,6 @@ status = "disabled"; }; -/* Unusable as clocksource because of unreliable oscillator */ -&counter32k { - status = "disabled"; -}; - /* Unusable as clockevent because if unreliable oscillator, allow to idle */ &timer1_target { /delete-property/ti,no-reset-on-init;
@@ -172,7 +167,7 @@ }; }; -/* Preferred always-on timer for clocksource */ +/* Preferred timer for clockevent */ &timer12_target { ti,no-reset-on-init; ti,no-idle;
@@ -181,16 +176,6 @@ }; }; -/* Preferred timer for clockevent */ -&timer2_target { - ti,no-reset-on-init; - ti,no-idle; - timer@0 { - assigned-clocks = <&gpt2_fck>; - assigned-clock-parents = <&sys_ck>; - }; -}; - &twl_gpio { ti,use-leds; /*
drivers/clocksource/timer-ti-dm-systimer.c +1 -2
@@ -241,8 +241,7 @@ static void __init dmtimer_systimer_assign_alwon(void)bool quirk_unreliable_oscillator = false;/* Quirk unreliable 32 KiHz oscillator with incomplete dts */ -if (of_machine_is_compatible ("ti,omap3-beagle-ab4" ) || -of_machine_is_compatible ("timll,omap3-devkit8000" )) { +if (of_machine_is_compatible ("ti,omap3-beagle-ab4" )) { quirk_unreliable_oscillator = true; counter_32k = -ENODEV ; }
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 84/105 soc: fsl: guts: Revert commit 3c0d64e867ed
In reply to Greg Kroah-HartmanFrom: Christophe JAILLET <[email protected]>
[ Upstream commit b113737cf12964a20cc3ba1ddabe6229099661c6 ]
This reverts commit 3c0d64e867ed
("soc: fsl: guts: reuse machine name from device tree").
A following patch will fix the missing memory allocation failure check instead.
--- drivers/soc/fsl/guts.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
drivers/soc/fsl/guts.c +3 -4
@@ -28,7 +28,6 @@ struct fsl_soc_die_attr {static struct guts *guts;static struct soc_device_attribute soc_dev_attr;static struct soc_device *soc_dev; -static struct device_node *root;/* SoC die attribute definition for QorIQ platform */
@@ -138,7 +137,7 @@ static u32 fsl_guts_get_svr(void)static int fsl_guts_probe (struct platform_device *pdev) { -struct device_node *np = pdev->dev.of_node; +struct device_node *root, *np = pdev->dev.of_node;struct device *dev = &pdev->dev;struct resource *res;const struct fsl_soc_die_attr *soc_die;
@@ -161,8 +160,9 @@ static int fsl_guts_probe(struct platform_device *pdev) root =of_find_node_by_path ("/" );if (of_property_read_string (root,"model" , &machine))of_property_read_string_index (root,"compatible" ,0 , &machine); +of_node_put (root);if (machine) - soc_dev_attr.machine = machine; + soc_dev_attr.machine =devm_kstrdup (dev, machine,GFP_KERNEL ); svr =fsl_guts_get_svr (); soc_die =fsl_soc_die_match (svr, fsl_soc_die);
@@ -197,7 +197,6 @@ static int fsl_guts_probe(struct platform_device *pdev)static int fsl_guts_remove (struct platform_device *dev) {soc_device_unregister (soc_dev); -of_node_put (root);return 0 ; }
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 85/105 soc: fsl: guts: Add a missing memory allocation failure check
In reply to Greg Kroah-HartmanFrom: Christophe JAILLET <[email protected]>
[ Upstream commit b9abe942cda43a1d46a0fd96efb54f1aa909f757 ]
If 'devm_kstrdup()' fails, we should return -ENOMEM.
While at it, move the 'of_node_put()' call in the error handling path and after the 'machine' has been copied.
Better safe than sorry.
Depends-on: fddacc7ff4dd ("soc: fsl: guts: Revert commit 3c0d64e867ed")
--- drivers/soc/fsl/guts.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
drivers/soc/fsl/guts.c +7 -2
@@ -160,9 +160,14 @@ static int fsl_guts_probe(struct platform_device *pdev) root =of_find_node_by_path ("/" );if (of_property_read_string (root,"model" , &machine))of_property_read_string_index (root,"compatible" ,0 , &machine); -of_node_put (root); -if (machine) +if (machine) { soc_dev_attr.machine =devm_kstrdup (dev, machine,GFP_KERNEL ); +if (!soc_dev_attr.machine) { +of_node_put (root); +return -ENOMEM ; + } + } +of_node_put (root); svr =fsl_guts_get_svr (); soc_die =fsl_soc_die_match (svr, fsl_soc_die);
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 86/105 soc: fsl: qe: Check of ioremap return value
In reply to Greg Kroah-HartmanFrom: Jiasheng Jiang <[email protected]>
[ Upstream commit a222fd8541394b36b13c89d1698d9530afd59a9c ]
As the possible failure of the ioremap(), the par_io could be NULL. Therefore it should be better to check it and return error in order to guarantee the success of the initiation.
But, I also notice that all the caller like mpc85xx_qe_par_io_init() in arch/powerpc/platforms/85xx/common.c don't check the return value of the par_io_init().
Actually, par_io_init() needs to check to handle the potential error. I will submit another patch to fix that.
Anyway, par_io_init() itsely should be fixed.
--- drivers/soc/fsl/qe/qe_io.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/soc/fsl/qe/qe_io.c +2 -0
@@ -35,6 +35,8 @@ int par_io_init(struct device_node *np)if (ret)return ret; par_io =ioremap (res.start,resource_size (&res)); +if (!par_io) +return -ENOMEM ;if (!of_property_read_u32 (np,"num-ports" , &num_ports)) num_par_io_ports = num_ports;
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 87/105 ARM: tegra: Move panels to AUX bus
In reply to Greg Kroah-HartmanFrom: Thierry Reding <[email protected]>
[ Upstream commit 8d3b01e0d4bb54368d73d0984466d72c2eeeac74 ]
Move the eDP panel on Venice 2 and Nyan boards into the corresponding AUX bus device tree node. This allows us to avoid a nasty circular dependency that would otherwise be created between the DPAUX and panel nodes via the DDC/I2C phandle.
--- arch/arm/boot/dts/tegra124-nyan-big.dts | 15 +++++++++------ arch/arm/boot/dts/tegra124-nyan-blaze.dts | 15 +++++++++------ arch/arm/boot/dts/tegra124-venice2.dts | 14 +++++++------- 3 files changed, 25 insertions(+), 19 deletions(-)
arch/arm/boot/dts/tegra124-nyan-big.dts +9 -6
@@ -13,12 +13,15 @@ "google,nyan-big-rev1", "google,nyan-big-rev0", "google,nyan-big", "google,nyan", "nvidia,tegra124"; - panel: panel { - compatible = "auo,b133xtn01"; - - power-supply = <&vdd_3v3_panel>; - backlight = <&backlight>; - ddc-i2c-bus = <&dpaux>; + host1x@50000000 { + dpaux@545c0000 { + aux-bus { + panel: panel { + compatible = "auo,b133xtn01"; + backlight = <&backlight>; + }; + }; + }; }; mmc@700b0400 { /* SD Card on this bus */
arch/arm/boot/dts/tegra124-nyan-blaze.dts +9 -6
@@ -15,12 +15,15 @@ "google,nyan-blaze-rev0", "google,nyan-blaze", "google,nyan", "nvidia,tegra124"; - panel: panel { - compatible = "samsung,ltn140at29-301"; - - power-supply = <&vdd_3v3_panel>; - backlight = <&backlight>; - ddc-i2c-bus = <&dpaux>; + host1x@50000000 { + dpaux@545c0000 { + aux-bus { + panel: panel { + compatible = "samsung,ltn140at29-301"; + backlight = <&backlight>; + }; + }; + }; }; sound {
arch/arm/boot/dts/tegra124-venice2.dts +7 -7
@@ -48,6 +48,13 @@ dpaux@545c0000 { vdd-supply = <&vdd_3v3_panel>; status = "okay"; + + aux-bus { + panel: panel { + compatible = "lg,lp129qe"; + backlight = <&backlight>; + }; + }; }; };
@@ -1079,13 +1086,6 @@ }; }; - panel: panel { - compatible = "lg,lp129qe"; - power-supply = <&vdd_3v3_panel>; - backlight = <&backlight>; - ddc-i2c-bus = <&dpaux>; - }; - vdd_mux: regulator@0 { compatible = "regulator-fixed"; regulator-name = "+VDD_MUX";
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 88/105 ibmvnic: define flush_reset_queue helper
In reply to Greg Kroah-HartmanFrom: Sukadev Bhattiprolu <[email protected]>
[ Upstream commit 83da53f7e4bd86dca4b2edc1e2bb324fb3c033a1 ]
Define and use a helper to flush the reset queue.
--- drivers/net/ethernet/ibm/ibmvnic.c | 24 ++++++++++++++++-------- 1 file changed, 16 insertions(+), 8 deletions(-)
drivers/net/ethernet/ibm/ibmvnic.c +16 -8
@@ -2304,12 +2304,23 @@ static void __ibmvnic_delayed_reset(struct work_struct *work)__ibmvnic_reset (&adapter->ibmvnic_reset); } +static void flush_reset_queue (struct ibmvnic_adapter *adapter) +{ +struct list_head *entry, *tmp_entry; + +if (!list_empty (&adapter->rwi_list)) { +list_for_each_safe (entry, tmp_entry, &adapter->rwi_list) { +list_del (entry); +kfree (list_entry(entry ,struct ibmvnic_rwi ,list )); + } + } +} +static int ibmvnic_reset (struct ibmvnic_adapter *adapter,enum ibmvnic_reset_reason reason) { -struct list_head *entry, *tmp_entry; -struct ibmvnic_rwi *rwi, *tmp;struct net_device *netdev = adapter->netdev; +struct ibmvnic_rwi *rwi, *tmp;unsigned long flags;int ret;
@@ -2353,12 +2364,9 @@ static int ibmvnic_reset(struct ibmvnic_adapter *adapter,/* if we just received a transport event, * flush reset queue and process this reset */ -if (adapter->force_reset_recovery && !list_empty (&adapter->rwi_list)) { -list_for_each_safe (entry, tmp_entry, &adapter->rwi_list) { -list_del (entry); -kfree (list_entry(entry ,struct ibmvnic_rwi ,list )); - } - } +if (adapter->force_reset_recovery) +flush_reset_queue (adapter); + rwi->reset_reason = reason;list_add_tail (&rwi->list, &adapter->rwi_list);netdev_dbg (adapter->netdev,"Scheduling reset (reason %d)\n" , reason);
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 89/105 ibmvnic: complete init_done on transport events
In reply to Greg Kroah-HartmanFrom: Sukadev Bhattiprolu <[email protected]>
[ Upstream commit 36491f2df9ad2501e5a4ec25d3d95d72bafd2781 ]
If we get a transport event, set the error and mark the init as complete so the attempt to send crq-init or login fail sooner rather than wait for the timeout.
--- drivers/net/ethernet/ibm/ibmvnic.c | 7 +++++++ 1 file changed, 7 insertions(+)
drivers/net/ethernet/ibm/ibmvnic.c +7 -0
@@ -4931,6 +4931,13 @@ static void ibmvnic_handle_crq(union ibmvnic_crq *crq, adapter->fw_done_rc = -EIO ;complete (&adapter->fw_done); } + +/* if we got here during crq-init, retry crq-init */ +if (!completion_done (&adapter->init_done)) { + adapter->init_done_rc = -EAGAIN ; +complete (&adapter->init_done); + } +if (!completion_done (&adapter->stats_done))complete (&adapter->stats_done);if (test_bit (0 , &adapter->resetting))
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 90/105 net: chelsio: cxgb3: check the return value of pci_find_capability()
In reply to Greg Kroah-HartmanFrom: Jia-Ju Bai <[email protected]>
[ Upstream commit 767b9825ed1765894e569a3d698749d40d83762a ]
The function pci_find_capability() in t3_prep_adapter() can fail, so its return value should be checked.
--- drivers/net/ethernet/chelsio/cxgb3/t3_hw.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/net/ethernet/chelsio/cxgb3/t3_hw.c +2 -0
@@ -3678,6 +3678,8 @@ int t3_prep_adapter(struct adapter *adapter, const struct adapter_info *ai, MAC_STATS_ACCUM_SECS : (MAC_STATS_ACCUM_SECS *10 ); adapter->params.pci.vpd_cap_addr =pci_find_capability (adapter->pdev,PCI_CAP_ID_VPD ); +if (!adapter->params.pci.vpd_cap_addr) +return -ENODEV ; ret =get_vpd_params (adapter, &adapter->params.vpd);if (ret <0 )return ret;
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 91/105 iavf: Refactor iavf state machine tracking
In reply to Greg Kroah-HartmanFrom: Mateusz Palczewski <[email protected]>
[ Upstream commit 45eebd62999d37d13568723524b99d828e0ce22c ]
Replace state changes of iavf state machine
with a method that also tracks the previous
state the machine was on.
This change is required for further work with
refactoring init and watchdog state machines.
Tracking of previous state would help us
recover iavf after failure has occurred.
--- drivers/net/ethernet/intel/iavf/iavf.h | 10 +++++ drivers/net/ethernet/intel/iavf/iavf_main.c | 37 ++++++++++--------- .../net/ethernet/intel/iavf/iavf_virtchnl.c | 2 +- 3 files changed, 31 insertions(+), 18 deletions(-)
drivers/net/ethernet/intel/iavf/iavf.h +10 -0
@@ -309,6 +309,7 @@ struct iavf_adapter {struct iavf_hw hw;/* defined in iavf_type.h */ enum iavf_state_t state; +enum iavf_state_t last_state;unsigned long crit_section;struct delayed_work watchdog_task;
@@ -378,6 +379,15 @@ struct iavf_device {extern char iavf_driver_name[];extern struct workqueue_struct *iavf_wq; +static inline void iavf_change_state (struct iavf_adapter *adapter, +enum iavf_state_t state) +{ +if (adapter->state != state) { + adapter->last_state = adapter->state; + adapter->state = state; + } +} +int iavf_up (struct iavf_adapter *adapter);void iavf_down (struct iavf_adapter *adapter);int iavf_process_config (struct iavf_adapter *adapter);
drivers/net/ethernet/intel/iavf/iavf_main.c +20 -17
@@ -963,7 +963,7 @@ static void iavf_configure(struct iavf_adapter *adapter)**/ static void iavf_up_complete (struct iavf_adapter *adapter) { - adapter->state = __IAVF_RUNNING; +iavf_change_state (adapter, __IAVF_RUNNING);clear_bit (__IAVF_VSI_DOWN, adapter->vsi.state);iavf_napi_enable_all (adapter);
@@ -1698,7 +1698,7 @@ static int iavf_startup(struct iavf_adapter *adapter)iavf_shutdown_adminq (hw); goto err; } - adapter->state = __IAVF_INIT_VERSION_CHECK; +iavf_change_state (adapter, __IAVF_INIT_VERSION_CHECK); err:return err; }
@@ -1722,7 +1722,7 @@ static int iavf_init_version_check(struct iavf_adapter *adapter)if (!iavf_asq_done (hw)) {dev_err (&pdev->dev,"Admin queue command never completed\n" );iavf_shutdown_adminq (hw); - adapter->state = __IAVF_STARTUP; +iavf_change_state (adapter, __IAVF_STARTUP); goto err; }
@@ -1745,8 +1745,7 @@ static int iavf_init_version_check(struct iavf_adapter *adapter) err); goto err; } - adapter->state = __IAVF_INIT_GET_RESOURCES; - +iavf_change_state (adapter, __IAVF_INIT_GET_RESOURCES); err:return err; }
@@ -1862,7 +1861,7 @@ static int iavf_init_get_resources(struct iavf_adapter *adapter)if (netdev->features &NETIF_F_GRO )dev_info (&pdev->dev,"GRO is enabled\n" ); - adapter->state = __IAVF_DOWN; +iavf_change_state (adapter, __IAVF_DOWN);set_bit (__IAVF_VSI_DOWN, adapter->vsi.state);rtnl_unlock ();
@@ -1910,7 +1909,7 @@ static void iavf_watchdog_task(struct work_struct *work) goto restart_watchdog;if (adapter->flags &IAVF_FLAG_PF_COMMS_FAILED ) - adapter->state = __IAVF_COMM_FAILED; +iavf_change_state (adapter, __IAVF_COMM_FAILED);switch (adapter->state) {case __IAVF_COMM_FAILED:
@@ -1921,7 +1920,7 @@ static void iavf_watchdog_task(struct work_struct *work)/* A chance for redemption! */ dev_err (&adapter->pdev->dev,"Hardware came out of reset. Attempting reinit.\n" ); - adapter->state = __IAVF_STARTUP; +iavf_change_state (adapter, __IAVF_STARTUP); adapter->flags &= ~IAVF_FLAG_PF_COMMS_FAILED ;queue_delayed_work (iavf_wq, &adapter->init_task,10 ); clear_bit(__IAVF_IN_CRITICAL_TASK,
@@ -1971,9 +1970,10 @@ static void iavf_watchdog_task(struct work_struct *work) goto restart_watchdog; } -/* check for hw reset */ +/* check for hw reset */ reg_val =rd32 (hw,IAVF_VF_ARQLEN1 ) &IAVF_VF_ARQLEN1_ARQENABLE_MASK ;if (!reg_val) { +iavf_change_state (adapter, __IAVF_RESETTING); adapter->flags |=IAVF_FLAG_RESET_PENDING ; adapter->aq_required =0 ; adapter->current_op =VIRTCHNL_OP_UNKNOWN ;
@@ -2053,7 +2053,7 @@ static void iavf_disable_vf(struct iavf_adapter *adapter) adapter->netdev->flags &= ~IFF_UP ;clear_bit (__IAVF_IN_CRITICAL_TASK, &adapter->crit_section); adapter->flags &= ~IAVF_FLAG_RESET_PENDING ; - adapter->state = __IAVF_DOWN; +iavf_change_state (adapter, __IAVF_DOWN);wake_up (&adapter->down_waitqueue);dev_info (&adapter->pdev->dev,"Reset task did not complete, VF disabled\n" ); }
@@ -2165,7 +2165,7 @@ static void iavf_reset_task(struct work_struct *work) }iavf_irq_disable (adapter); - adapter->state = __IAVF_RESETTING; +iavf_change_state (adapter, __IAVF_RESETTING); adapter->flags &= ~IAVF_FLAG_RESET_PENDING ;/* free the Tx/Rx rings and descriptors, might be better to just
@@ -2265,11 +2265,14 @@ static void iavf_reset_task(struct work_struct *work)iavf_configure (adapter); +/* iavf_up_complete() will switch device back +* to __IAVF_RUNNING +*/ iavf_up_complete (adapter);iavf_irq_enable (adapter, true); }else { - adapter->state = __IAVF_DOWN; +iavf_change_state (adapter, __IAVF_DOWN);wake_up (&adapter->down_waitqueue); }clear_bit (__IAVF_IN_CLIENT_TASK, &adapter->crit_section);
@@ -3277,7 +3280,7 @@ static int iavf_close(struct net_device *netdev) adapter->flags |=IAVF_FLAG_CLIENT_NEEDS_CLOSE ;iavf_down (adapter); - adapter->state = __IAVF_DOWN_PENDING; +iavf_change_state (adapter, __IAVF_DOWN_PENDING);iavf_free_traffic_irqs (adapter);clear_bit (__IAVF_IN_CRITICAL_TASK, &adapter->crit_section);
@@ -3661,7 +3664,7 @@ static void iavf_init_task(struct work_struct *work) "Failed to communicate with PF; waiting before retry\n"); adapter->flags |=IAVF_FLAG_PF_COMMS_FAILED ;iavf_shutdown_adminq (hw); - adapter->state = __IAVF_STARTUP; +iavf_change_state (adapter, __IAVF_STARTUP);queue_delayed_work (iavf_wq, &adapter->init_task,HZ *5 ); goto out; }
@@ -3687,7 +3690,7 @@ static void iavf_shutdown(struct pci_dev *pdev)if (iavf_lock_timeout (adapter, __IAVF_IN_CRITICAL_TASK,5000 ))dev_warn (&adapter->pdev->dev,"failed to set __IAVF_IN_CRITICAL_TASK in %s\n" , __FUNCTION__);/* Prevent the watchdog from running. */ - adapter->state = __IAVF_REMOVE; +iavf_change_state (adapter, __IAVF_REMOVE); adapter->aq_required =0 ;clear_bit (__IAVF_IN_CRITICAL_TASK, &adapter->crit_section);
@@ -3760,7 +3763,7 @@ static int iavf_probe(struct pci_dev *pdev, const struct pci_device_id *ent) hw->back = adapter; adapter->msg_enable =BIT (DEFAULT_DEBUG_LEVEL_SHIFT ) -1 ; - adapter->state = __IAVF_STARTUP; +iavf_change_state (adapter, __IAVF_STARTUP);/* Call save state here because it relies on the adapter struct. */ pci_save_state (pdev);
@@ -3928,7 +3931,7 @@ static void iavf_remove(struct pci_dev *pdev)dev_warn (&adapter->pdev->dev,"failed to set __IAVF_IN_CRITICAL_TASK in %s\n" , __FUNCTION__);/* Shut down all the garbage mashers on the detention level */ - adapter->state = __IAVF_REMOVE; +iavf_change_state (adapter, __IAVF_REMOVE); adapter->aq_required =0 ; adapter->flags &= ~IAVF_FLAG_REINIT_ITR_NEEDED ;iavf_free_all_tx_resources (adapter);
drivers/net/ethernet/intel/iavf/iavf_virtchnl.c +1 -1
@@ -1460,7 +1460,7 @@ void iavf_virtchnl_completion(struct iavf_adapter *adapter,iavf_free_all_tx_resources (adapter);iavf_free_all_rx_resources (adapter);if (adapter->state == __IAVF_DOWN_PENDING) { - adapter->state = __IAVF_DOWN; +iavf_change_state (adapter, __IAVF_DOWN);wake_up (&adapter->down_waitqueue); }break ;
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 92/105 nl80211: Handle nla_memdup failures in handle_nan_filter
In reply to Greg Kroah-HartmanFrom: Jiasheng Jiang <[email protected]>
[ Upstream commit 6ad27f522cb3b210476daf63ce6ddb6568c0508b ]
As there's potential for failure of the nla_memdup(), check the return value.
--- net/wireless/nl80211.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)
net/wireless/nl80211.c +12 -0
@@ -12930,6 +12930,9 @@ static int handle_nan_filter(struct nlattr *attr_filter, i =0 ;nla_for_each_nested (attr, attr_filter, rem) { filter[i].filter =nla_memdup (attr,GFP_KERNEL ); +if (!filter[i].filter) + goto err; + filter[i].len =nla_len (attr); i++; }
@@ -12942,6 +12945,15 @@ static int handle_nan_filter(struct nlattr *attr_filter, }return 0 ; + +err: + i =0 ; +nla_for_each_nested (attr, attr_filter, rem) { +kfree (filter[i].filter); + i++; + } +kfree (filter); +return -ENOMEM ; } static int nl80211_nan_add_func(struct sk_buff *skb,
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 93/105 drm/amdgpu: fix suspend/resume hang regression
In reply to Greg Kroah-HartmanFrom: Qiang Yu <[email protected]>
[ Upstream commit f1ef17011c765495c876fa75435e59eecfdc1ee4 ]
Regression has been reported that suspend/resume may hang with the previous vm ready check commit.
So bring back the evicted list check as a temp fix.
--- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c +2 -1
@@ -724,7 +724,8 @@ bool amdgpu_vm_ready(struct amdgpu_vm *vm)amdgpu_vm_eviction_lock (vm); ret = !vm->evicting;amdgpu_vm_eviction_unlock (vm); -return ret; + +return ret &&list_empty (&vm->evicted); }/**
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 94/105 net: dcb: disable softirqs in dcbnl_flush_dev()
In reply to Greg Kroah-HartmanFrom: Vladimir Oltean <[email protected]>
[ Upstream commit 10b6bb62ae1a49ee818fc479cf57b8900176773e ]
Ido Schimmel points out that since commit 52cff74eef5d ("dcbnl : Disable software interrupts before taking dcb_lock"), the DCB API can be called by drivers from softirq context.
One such in-tree example is the chelsio cxgb4 driver:dcb_rpl
-> cxgb4_dcb_handle_fw_update
-> dcb_ieee_setapp
If the firmware for this driver happened to send an event which resulted in a call to dcb_ieee_setapp() at the exact same time as another DCB-enabled interface was unregistering on the same CPU, the softirq would deadlock, because the interrupted process was already holding the dcb_lock in dcbnl_flush_dev().
Fix this unlikely event by using spin_lock_bh() in dcbnl_flush_dev() as in the rest of the dcbnl code.
--- net/dcb/dcbnl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
net/dcb/dcbnl.c +2 -2
@@ -2067,7 +2067,7 @@ static void dcbnl_flush_dev(struct net_device *dev) {struct dcb_app_type *itr, *tmp; -spin_lock (&dcb_lock); +spin_lock_bh (&dcb_lock);list_for_each_entry_safe (itr, tmp, &dcb_app_list, list) {if (itr->ifindex == dev->ifindex) {
@@ -2076,7 +2076,7 @@ static void dcbnl_flush_dev(struct net_device *dev) } } -spin_unlock (&dcb_lock); +spin_unlock_bh (&dcb_lock); } static int dcbnl_netdevice_event(struct notifier_block *nb,
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 95/105 Input: elan_i2c - move regulator_[en|dis]able() out of elan_[en|dis]able_power()
In reply to Greg Kroah-HartmanFrom: Hans de Goede <[email protected]>
commit 81a36d8ce554b82b0a08e2b95d0bd44fcbff339b upstream.
elan_disable_power() is called conditionally on suspend, where as elan_enable_power() is always called on resume. This leads to an imbalance in the regulator's enable count.
Move the regulator_[en|dis]able() calls out of elan_[en|dis]able_power() in preparation of fixing this.
No functional changes intended.
--- drivers/input/mouse/elan_i2c_core.c | 62 ++++++++++++------------------------ 1 file changed, 22 insertions(+), 40 deletions(-)
drivers/input/mouse/elan_i2c_core.c +22 -40
@@ -153,55 +153,21 @@ static int elan_get_fwinfo(u16 ic_type,return 0 ; } -static int elan_enable_power (struct elan_tp_data *data) +static int elan_set_power (struct elan_tp_data *data,bool on) {int repeat =ETP_RETRY_COUNT ;int error; - error =regulator_enable (data->vcc); -if (error) { -dev_err (&data->client->dev, -"failed to enable regulator: %d\n" , error); -return error; - } -do { - error = data->ops->power_control (data->client, true); + error = data->ops->power_control (data->client, on);if (error >=0 )return 0 ;msleep (30 ); }while (--repeat >0 ); -dev_err (&data->client->dev,"failed to enable power: %d\n" , error); -return error; -} - -static int elan_disable_power (struct elan_tp_data *data) -{ -int repeat =ETP_RETRY_COUNT ; -int error; - -do { - error = data->ops->power_control (data->client, false); -if (!error) { - error =regulator_disable (data->vcc); -if (error) { -dev_err (&data->client->dev, -"failed to disable regulator: %d\n" , - error); -/* Attempt to power the chip back up */ - data->ops->power_control (data->client, true); -break ; - } - -return 0 ; - } - -msleep (30 ); - }while (--repeat >0 ); - -dev_err (&data->client->dev,"failed to disable power: %d\n" , error); +dev_err (&data->client->dev,"failed to set power %s: %d\n" , + on ?"on" :"off" , error);return error; }
@@ -1361,9 +1327,19 @@ static int __maybe_unused elan_suspend(s/* Enable wake from IRQ */ data->irq_wake = (enable_irq_wake (client->irq) ==0 ); }else { - ret =elan_disable_power (data); + ret =elan_set_power (data, false); +if (ret) + goto err; + + ret =regulator_disable (data->vcc); +if (ret) { +dev_err (dev,"error %d disabling regulator\n" , ret); +/* Attempt to power the chip back up */ +elan_set_power (data, true); + } } +err:mutex_unlock (&data->sysfs_mutex);return ret; }
@@ -1379,7 +1355,13 @@ static int __maybe_unused elan_resume(st data->irq_wake = false; } - error =elan_enable_power (data); + error =regulator_enable (data->vcc); +if (error) { +dev_err (dev,"error %d enabling regulator\n" , error); + goto err; + } + + error =elan_set_power (data, true);if (error) {dev_err (dev,"power up when resuming failed: %d\n" , error); goto err;
Greg Kroah-Hartman
maintainerPATCH 96/105 Input: elan_i2c - fix regulator enable count imbalance after suspend/resume
In reply to Greg Kroah-HartmanFrom: Hans de Goede <[email protected]>
commit 04b7762e37c95d9b965d16bb0e18dbd1fa2e2861 upstream.
Before these changes elan_suspend() would only disable the regulator when device_may_wakeup() returns false; whereas elan_resume() would unconditionally enable it, leading to an enable count imbalance when device_may_wakeup() returns true.
This triggers the "WARN_ON(regulator->enable_count)" in regulator_put() when the elan_i2c driver gets unbound, this happens e.g. with the hot-plugable dock with Elan I2C touchpad for the Asus TF103C 2-in-1.
Fix this by making the regulator_enable() call also be conditional on device_may_wakeup() returning false.
--- drivers/input/mouse/elan_i2c_core.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/input/mouse/elan_i2c_core.c +7 -7
@@ -1350,17 +1350,17 @@ static int __maybe_unused elan_resume(ststruct elan_tp_data *data =i2c_get_clientdata (client);int error; -if (device_may_wakeup (dev) && data->irq_wake) { +if (!device_may_wakeup (dev)) { + error =regulator_enable (data->vcc); +if (error) { +dev_err (dev,"error %d enabling regulator\n" , error); + goto err; + } + }else if (data->irq_wake) {disable_irq_wake (client->irq); data->irq_wake = false; } - error =regulator_enable (data->vcc); -if (error) { -dev_err (dev,"error %d enabling regulator\n" , error); - goto err; - } - error =elan_set_power (data, true);if (error) {dev_err (dev,"power up when resuming failed: %d\n" , error);
Greg Kroah-Hartman
maintainerPATCH 97/105 Input: samsung-keypad - properly state IOMEM dependency
In reply to Greg Kroah-HartmanFrom: David Gow <[email protected]>
commit ba115adf61b36b8c167126425a62b0efc23f72c0 upstream.
Make the samsung-keypad driver explicitly depend on CONFIG_HAS_IOMEM, as it calls devm_ioremap(). This prevents compile errors in some configs (e.g, allyesconfig/randconfig under UML):
/usr/bin/ld: drivers/input/keyboard/samsung-keypad.o: in function `samsung_keypad_probe':
samsung-keypad.c:(.text+0xc60): undefined reference to `devm_ioremap'
--- drivers/input/keyboard/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/input/keyboard/Kconfig +1 -1
@@ -556,7 +556,7 @@ config KEYBOARD_PMIC8XXX config KEYBOARD_SAMSUNG tristate "Samsung keypad support" - depends on HAVE_CLK + depends on HAS_IOMEM && HAVE_CLK select INPUT_MATRIXKMAP help Say Y here if you want to use the keypad on your Samsung mobile
Greg Kroah-Hartman
maintainerPATCH 98/105 HID: add mapping for KEY_DICTATE
In reply to Greg Kroah-HartmanFrom: William Mahon <[email protected]>
commit bfa26ba343c727e055223be04e08f2ebdd43c293 upstream.
Numerous keyboards are adding dictate keys which allows for text messages to be dictated by a microphone.
This patch adds a new key definition KEY_DICTATE and maps 0x0c/0x0d8 usage code to this new keycode. Additionally hid-debug is adjusted to recognize this new usage code as well.
--- drivers/hid/hid-debug.c | 1 + drivers/hid/hid-input.c | 1 + include/uapi/linux/input-event-codes.h | 1 + 3 files changed, 3 insertions(+)
drivers/hid/hid-debug.c +1 -0
@@ -930,6 +930,7 @@ static const char *keys[KEY_MAX + 1] = { [KEY_SCREENSAVER] = "ScreenSaver", [KEY_VOICECOMMAND] = "VoiceCommand", [KEY_EMOJI_PICKER] = "EmojiPicker", + [KEY_DICTATE] = "Dictate", [KEY_BRIGHTNESS_MIN] = "BrightnessMin", [KEY_BRIGHTNESS_MAX] = "BrightnessMax", [KEY_BRIGHTNESS_AUTO] = "BrightnessAuto",
drivers/hid/hid-input.c +1 -0
@@ -956,6 +956,7 @@ static void hidinput_configure_usage(strcase 0x0cd :map_key_clear (KEY_PLAYPAUSE );break ;case 0x0cf :map_key_clear (KEY_VOICECOMMAND );break ; +case 0x0d8 :map_key_clear (KEY_DICTATE );break ;case 0x0d9 :map_key_clear (KEY_EMOJI_PICKER );break ;case 0x0e0 :map_abs_clear (ABS_VOLUME );break ;
include/uapi/linux/input-event-codes.h +1 -0
@@ -612,6 +612,7 @@#define KEY_ASSISTANT 0x247/* AL Context-aware desktop assistant */ #define KEY_KBD_LAYOUT_NEXT 0x248/* AC Next Keyboard Layout Select */ #define KEY_EMOJI_PICKER 0x249/* Show/hide emoji picker (HUTRR101) */ +#define KEY_DICTATE 0x24a/* Start or Stop Voice Dictation Session (HUTRR99) */ #define KEY_BRIGHTNESS_MIN 0x250/* Set Brightness to Minimum */ #define KEY_BRIGHTNESS_MAX 0x251/* Set Brightness to Maximum */
Greg Kroah-Hartman
maintainerPATCH 99/105 HID: add mapping for KEY_ALL_APPLICATIONS
In reply to Greg Kroah-HartmanFrom: William Mahon <[email protected]>
commit 327b89f0acc4c20a06ed59e4d9af7f6d804dc2e2 upstream.
This patch adds a new key definition for KEY_ALL_APPLICATIONS and aliases KEY_DASHBOARD to it.
It also maps the 0x0c/0x2a2 usage code to KEY_ALL_APPLICATIONS.
--- drivers/hid/hid-debug.c | 4 +++- drivers/hid/hid-input.c | 2 ++ include/uapi/linux/input-event-codes.h | 3 ++- 3 files changed, 7 insertions(+), 2 deletions(-)
drivers/hid/hid-debug.c +3 -1
@@ -823,7 +823,9 @@ static const char *keys[KEY_MAX + 1] = { [KEY_F22] = "F22", [KEY_F23] = "F23", [KEY_F24] = "F24", [KEY_PLAYCD] = "PlayCD", [KEY_PAUSECD] = "PauseCD", [KEY_PROG3] = "Prog3", - [KEY_PROG4] = "Prog4", [KEY_SUSPEND] = "Suspend", + [KEY_PROG4] = "Prog4", + [KEY_ALL_APPLICATIONS] = "AllApplications", + [KEY_SUSPEND] = "Suspend", [KEY_CLOSE] = "Close", [KEY_PLAY] = "Play", [KEY_FASTFORWARD] = "FastForward", [KEY_BASSBOOST] = "BassBoost", [KEY_PRINT] = "Print", [KEY_HP] = "HP",
drivers/hid/hid-input.c +2 -0
@@ -1048,6 +1048,8 @@ static void hidinput_configure_usage(strcase 0x29d :map_key_clear (KEY_KBD_LAYOUT_NEXT );break ; +case 0x2a2 :map_key_clear (KEY_ALL_APPLICATIONS );break ; +case 0x2c7 :map_key_clear (KEY_KBDINPUTASSIST_PREV );break ;case 0x2c8 :map_key_clear (KEY_KBDINPUTASSIST_NEXT );break ;case 0x2c9 :map_key_clear (KEY_KBDINPUTASSIST_PREVGROUP );break ;
include/uapi/linux/input-event-codes.h +2 -1
@@ -278,7 +278,8 @@#define KEY_PAUSECD 201#define KEY_PROG3 202#define KEY_PROG4 203 -#define KEY_DASHBOARD 204/* AL Dashboard */ +#define KEY_ALL_APPLICATIONS 204/* AC Desktop Show All Applications */ +#define KEY_DASHBOARD KEY_ALL_APPLICATIONS#define KEY_SUSPEND 205#define KEY_CLOSE 206/* AC Close */ #define KEY_PLAY 207
Greg Kroah-Hartman
maintainerPATCH 100/105 tracing/histogram: Fix sorting on old "cpu" value
In reply to Greg Kroah-HartmanFrom: Steven Rostedt (Google) <[email protected]>
commit 1d1898f65616c4601208963c3376c1d828cbf2c7 upstream.
When trying to add a histogram against an event with the "cpu" field, it was impossible due to "cpu" being a keyword to key off of the running CPU. So to fix this, it was changed to "common_cpu" to match the other generic fields (like "common_pid"). But since some scripts used "cpu" for keying off of the CPU (for events that did not have "cpu" as a field, which is most of them), a backward compatibility trick was added such that if "cpu" was used as a key, and the event did not have "cpu" as a field name, then it would fallback and switch over to "common_cpu".
This fix has a couple of subtle bugs. One was that when switching over to "common_cpu", it did not change the field name, it just set a flag. But the code still found a "cpu" field. The "cpu" field is used for filtering and is returned when the event does not have a "cpu" field.
This was found by:
# cd /sys/kernel/tracing # echo hist:key=cpu,pid:sort=cpu > events/sched/sched_wakeup/trigger # cat events/sched/sched_wakeup/hist
Which showed the histogram unsorted:
{ cpu: 19, pid: 1175 } hitcount: 1
{ cpu: 6, pid: 239 } hitcount: 2
{ cpu: 23, pid: 1186 } hitcount: 14
{ cpu: 12, pid: 249 } hitcount: 2
{ cpu: 3, pid: 994 } hitcount: 5Instead of hard coding the "cpu" checks, take advantage of the fact that trace_event_field_field() returns a special field for "cpu" and "CPU" if the event does not have "cpu" as a field. This special field has the "filter_type" of "FILTER_CPU". Check that to test if the returned field is of the CPU type instead of doing the string compare.
Also, fix the sorting bug by testing for the hist_field flag of HIST_FIELD_FL_CPU when setting up the sort routine. Otherwise it will use the special CPU field to know what compare routine to use, and since that special field does not have a size, it returns tracing_map_cmp_none.
--- kernel/trace/trace_events_hist.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
kernel/trace/trace_events_hist.c +3 -3
@@ -1985,9 +1985,9 @@ parse_field(struct hist_trigger_data *hi/* * For backward compatibility, if field_name * was "cpu", then we treat this the same as -* common_cpu. +* common_cpu. This also works for "CPU". */ -if (strcmp (field_name,"cpu" ) ==0 ) { +if (field && field->filter_type ==FILTER_CPU ) { *flags |=HIST_FIELD_FL_CPU ; }else { hist_err(tr, HIST_ERR_FIELD_NOT_FOUND,
@@ -4365,7 +4365,7 @@ static int create_tracing_map_fields(strif (hist_field->flags &HIST_FIELD_FL_STACKTRACE ) cmp_fn = tracing_map_cmp_none; -else if (!field) +else if (!field || hist_field->flags &HIST_FIELD_FL_CPU ) cmp_fn =tracing_map_cmp_num (hist_field->size, hist_field->is_signed);else if (is_string_field (field))
Greg Kroah-Hartman
maintainerPATCH 101/105 tracing: Fix return value of __setup handlers
In reply to Greg Kroah-HartmanFrom: Randy Dunlap <[email protected]>
commit 1d02b444b8d1345ea4708db3bab4db89a7784b55 upstream.
__setup() handlers should generally return 1 to indicate that the boot options have been handled.
Using invalid option values causes the entire kernel boot option string to be reported as Unknown and added to init's environment strings, polluting it.
Unknown kernel command line parameters "BOOT_IMAGE=/boot/bzImage-517rc6
kprobe_event=p,syscall_any,$arg1 trace_options=quiet trace_clock=jiffies", will be passed to user space.
Run /sbin/init as init process
with arguments:
/sbin/init
with environment:
HOME=/
TERM=linux
BOOT_IMAGE=/boot/bzImage-517rc6
kprobe_event=p,syscall_any,$arg1
trace_options=quiet
trace_clock=jiffiesReturn 1 from the __setup() handlers so that init's environment is not polluted with kernel boot options.
--- kernel/trace/trace.c | 4 ++-- kernel/trace/trace_kprobe.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)
kernel/trace/trace.c +2 -2
@@ -233,7 +233,7 @@ static char trace_boot_options_buf[MAX_Tstatic int __init set_trace_boot_options (char *str) {strlcpy (trace_boot_options_buf, str,MAX_TRACER_SIZE ); -return 0 ; +return 1 ; }__setup ("trace_options=" , set_trace_boot_options);
@@ -244,7 +244,7 @@ static int __init set_trace_boot_clock(c {strlcpy (trace_boot_clock_buf, str,MAX_TRACER_SIZE ); trace_boot_clock = trace_boot_clock_buf; -return 0 ; +return 1 ; }__setup ("trace_clock=" , set_trace_boot_clock);
kernel/trace/trace_kprobe.c +1 -1
@@ -31,7 +31,7 @@ static int __init set_kprobe_boot_eventsstrlcpy (kprobe_boot_events_buf, str,COMMAND_LINE_SIZE );disable_tracing_selftest ("running kprobe events" ); -return 0 ; +return 1 ; }__setup ("kprobe_event=" , set_kprobe_boot_events);
Greg Kroah-Hartman
maintainerPATCH 102/105 btrfs: fix lost prealloc extents beyond eof after full fsync
In reply to Greg Kroah-HartmanFrom: Filipe Manana <[email protected]>
commit d99478874355d3a7b9d86dfb5d7590d5b1754b1f upstream.
When doing a full fsync, if we have prealloc extents beyond (or at) eof, and the leaves that contain them were not modified in the current transaction, we end up not logging them. This results in losing those extents when we replay the log after a power failure, since the inode is truncated to the current value of the logged i_size.
Just like for the fast fsync path, we need to always log all prealloc extents starting at or beyond i_size. The fast fsync case was fixed in commit 471d557afed155 ("Btrfs: fix loss of prealloc extents past i_size after fsync log replay") but it missed the full fsync path. The problem exists since the very early days, when the log tree was added by commit e02119d5a7b439 ("Btrfs: Add a write ahead tree log to optimize synchronous operations").
Example reproducer:
$ mkfs.btrfs -f /dev/sdc $ mount /dev/sdc /mnt
# Create our test file with many file extent items, so that they span
# several leaves of metadata, even if the node/page size is 64K. Use # direct IO and not fsync/O_SYNC because it's both faster and it avoids # clearing the full sync flag from the inode - we want the fsync below # to trigger the slow full sync code path. $ xfs_io -f -d -c "pwrite -b 4K 0 16M" /mnt/foo
# Now add two preallocated extents to our file without extending the # file's size. One right at i_size, and another further beyond, leaving
# a gap between the two prealloc extents. $ xfs_io -c "falloc -k 16M 1M" /mnt/foo $ xfs_io -c "falloc -k 20M 1M" /mnt/foo
# Make sure everything is durably persisted and the transaction is
# committed. This makes all created extents to have a generation lower # than the generation of the transaction used by the next write and # fsync. sync
# Now overwrite only the first extent, which will result in modifying
# only the first leaf of metadata for our inode. Then fsync it. This # fsync will use the slow code path (inode full sync bit is set) because # it's the first fsync since the inode was created/loaded. $ xfs_io -c "pwrite 0 4K" -c "fsync" /mnt/foo
# Extent list before power failure.
$ xfs_io -c "fiemap -v" /mnt/foo
/mnt/foo:
EXT: FILE-OFFSET BLOCK-RANGE TOTAL FLAGS
0: [0..7]: 2178048..2178055 8 0x0
1: [8..16383]: 26632..43007 16376 0x0
2: [16384..32767]: 2156544..2172927 16384 0x0
3: [32768..34815]: 2172928..2174975 2048 0x800
4: [34816..40959]: hole 6144
5: [40960..43007]: 2174976..2177023 2048 0x801<power fail>
# Mount fs again, trigger log replay.
$ mount /dev/sdc /mnt
# Extent list after power failure and log replay.
$ xfs_io -c "fiemap -v" /mnt/foo
/mnt/foo:
EXT: FILE-OFFSET BLOCK-RANGE TOTAL FLAGS
0: [0..7]: 2178048..2178055 8 0x0
1: [8..16383]: 26632..43007 16376 0x0
2: [16384..32767]: 2156544..2172927 16384 0x1# The prealloc extents at file offsets 16M and 20M are missing.
So fix this by calling btrfs_log_prealloc_extents() when we are doing a full fsync, so that we always log all prealloc extents beyond eof.
A test case for fstests will follow soon.
--- fs/btrfs/tree-log.c | 43 +++++++++++++++++++++++++++++++------------ 1 file changed, 31 insertions(+), 12 deletions(-)
fs/btrfs/tree-log.c +31 -12
@@ -4297,7 +4297,7 @@ static int log_one_extent(struct btrfs_t/* * Log all prealloc extents beyond the inode's i_size to make sure we do not -* lose them after doing a fast fsync and replaying the log. We scan the +* lose them after doing a full/fast fsync and replaying the log. We scan the * subvolume's root instead of iterating the inode's extent map tree because * otherwise we can log incorrect extent items based on extent map conversion. * That can happen due to the fact that extent maps are merged when they
@@ -5084,6 +5084,7 @@ static int copy_inode_items_to_log(strucstruct btrfs_log_ctx *ctx, bool *need_log_inode_item) { + const u64 i_size = i_size_read(&inode->vfs_inode);struct btrfs_root *root = inode->root;int ins_start_slot =0 ;int ins_nr =0 ;
@@ -5104,13 +5105,21 @@ again:if (min_key->type > max_key->type)break ; -if (min_key->type ==BTRFS_INODE_ITEM_KEY ) +if (min_key->type ==BTRFS_INODE_ITEM_KEY ) { *need_log_inode_item = false; - -if ((min_key->type ==BTRFS_INODE_REF_KEY || - min_key->type ==BTRFS_INODE_EXTREF_KEY ) && - inode->generation == trans->transid && - !recursive_logging) { + }else if (min_key->type ==BTRFS_EXTENT_DATA_KEY && + min_key->offset >= i_size) { +/* +* Extents at and beyond eof are logged with +* btrfs_log_prealloc_extents(). +* Only regular files have BTRFS_EXTENT_DATA_KEY keys, +* and no keys greater than that, so bail out. +*/ +break ; + }else if ((min_key->type ==BTRFS_INODE_REF_KEY || + min_key->type ==BTRFS_INODE_EXTREF_KEY ) && + inode->generation == trans->transid && + !recursive_logging) {u64 other_ino =0 ;u64 other_parent =0 ;
@@ -5141,10 +5150,8 @@ again:btrfs_release_path (path); goto next_key; } - } - -/* Skip xattrs, we log them later with btrfs_log_all_xattrs() */ -if (min_key->type ==BTRFS_XATTR_ITEM_KEY ) { + }else if (min_key->type ==BTRFS_XATTR_ITEM_KEY ) { +/* Skip xattrs, logged later with btrfs_log_all_xattrs() */ if (ins_nr ==0 ) goto next_slot; ret = copy_items(trans, inode, dst_path, path,
@@ -5197,9 +5204,21 @@ next_key:break ; } } -if (ins_nr) +if (ins_nr) { ret =copy_items (trans, inode, dst_path, path, ins_start_slot, ins_nr, inode_only, logged_isize); +if (ret) +return ret; + } + +if (inode_only ==LOG_INODE_ALL &&S_ISREG (inode->vfs_inode.i_mode)) { +/* +* Release the path because otherwise we might attempt to double +* lock the same leaf with btrfs_log_prealloc_extents() below. +*/ +btrfs_release_path (path); + ret =btrfs_log_prealloc_extents (trans, inode, dst_path); + }return ret; }
Greg Kroah-Hartman
maintainerPATCH 103/105 btrfs: qgroup: fix deadlock between rescan worker and remove qgroup
In reply to Greg Kroah-HartmanFrom: Sidong Yang <[email protected]>
commit d4aef1e122d8bbdc15ce3bd0bc813d6b44a7d63a upstream.
The commit e804861bd4e6 ("btrfs: fix deadlock between quota disable and qgroup rescan worker") by Kawasaki resolves deadlock between quota disable and qgroup rescan worker. But also there is a deadlock case like it. It's about enabling or disabling quota and creating or removing qgroup. It can be reproduced in simple script below.
for i in {1..100}
do
btrfs quota enable /mnt &
btrfs qgroup create 1/0 /mnt &
btrfs qgroup destroy 1/0 /mnt &
btrfs quota disable /mnt &
done
Here's why the deadlock happens:
1) The quota rescan task is running.
2) Task A calls btrfs_quota_disable(), locks the qgroup_ioctl_lock mutex, and then calls btrfs_qgroup_wait_for_completion(), to wait for the quota rescan task to complete.
3) Task B calls btrfs_remove_qgroup() and it blocks when trying to lock the qgroup_ioctl_lock mutex, because it's being held by task A. At that point task B is holding a transaction handle for the current transaction.
4) The quota rescan task calls btrfs_commit_transaction(). This results in it waiting for all other tasks to release their handles on the transaction, but task B is blocked on the qgroup_ioctl_lock mutex while holding a handle on the transaction, and that mutex is being held by task A, which is waiting for the quota rescan task to complete, resulting in a deadlock between these 3 tasks.
To resolve this issue, the thread disabling quota should unlock qgroup_ioctl_lock before waiting rescan completion. Move btrfs_qgroup_wait_for_completion() after unlock of qgroup_ioctl_lock.
--- fs/btrfs/qgroup.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)
fs/btrfs/qgroup.c +8 -1
@@ -1198,13 +1198,20 @@ int btrfs_quota_disable(struct btrfs_fs_ goto out;/* +* Unlock the qgroup_ioctl_lock mutex before waiting for the rescan worker to +* complete. Otherwise we can deadlock because btrfs_remove_qgroup() needs +* to lock that mutex while holding a transaction handle and the rescan +* worker needs to commit a transaction. +*/ +mutex_unlock (&fs_info->qgroup_ioctl_lock); + +/* * Request qgroup rescan worker to complete and wait for it. This wait * must be done before transaction start for quota disable since it may * deadlock with transaction by the qgroup rescan worker. */ clear_bit (BTRFS_FS_QUOTA_ENABLED , &fs_info->flags);btrfs_qgroup_wait_for_completion (fs_info, false); -mutex_unlock (&fs_info->qgroup_ioctl_lock);/* * 1 For the root item
Greg Kroah-Hartman
maintainerPATCH 104/105 btrfs: add missing run of delayed items after unlink during log replay
In reply to Greg Kroah-HartmanFrom: Filipe Manana <[email protected]>
commit 4751dc99627e4d1465c5bfa8cb7ab31ed418eff5 upstream.
During log replay, whenever we need to check if a name (dentry) exists in a directory we do searches on the subvolume tree for inode references or or directory entries (BTRFS_DIR_INDEX_KEY keys, and BTRFS_DIR_ITEM_KEY keys as well, before kernel 5.17). However when during log replay we unlink a name, through btrfs_unlink_inode(), we may not delete inode references and dir index keys from a subvolume tree and instead just add the deletions to the delayed inode's delayed items, which will only be run when we commit the transaction used for log replay. This means that after an unlink operation during log replay, if we attempt to search for the same name during log replay, we will not see that the name was already deleted, since the deletion is recorded only on the delayed items.
We run delayed items after every unlink operation during log replay, except at unlink_old_inode_refs() and at add_inode_ref(). This was due to an overlook, as delayed items should be run after evert unlink, for the reasons stated above.
So fix those two cases.
--- fs/btrfs/tree-log.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)
fs/btrfs/tree-log.c +18 -0
@@ -1286,6 +1286,15 @@ again: inode, name, namelen);kfree (name);iput (dir); +/* +* Whenever we need to check if a name exists or not, we +* check the subvolume tree. So after an unlink we must +* run delayed items, so that future checks for a name +* during log replay see that the name does not exists +* anymore. +*/ +if (!ret) + ret =btrfs_run_delayed_items (trans);if (ret) goto out; goto again;
@@ -1537,6 +1546,15 @@ static noinline int add_inode_ref(struct*/ if (!ret && inode->i_nlink ==0 )inc_nlink (inode); +/* +* Whenever we need to check if a name exists or +* not, we check the subvolume tree. So after an +* unlink we must run delayed items, so that future +* checks for a name during log replay see that the +* name does not exists anymore. +*/ +if (!ret) + ret =btrfs_run_delayed_items (trans); }if (ret <0 ) goto out;
Greg Kroah-Hartman
maintainerPATCH 105/105 Revert "xfrm: xfrm_state_mtu should return at least 1280 for ipv6"
In reply to Greg Kroah-HartmanFrom: Jiri Bohac <[email protected]>
commit a6d95c5a628a09be129f25d5663a7e9db8261f51 upstream.
This reverts commit b515d2637276a3810d6595e10ab02c13bfd0b63a.
Commit b515d2637276a3810d6595e10ab02c13bfd0b63a ("xfrm: xfrm_state_mtu should return at least 1280 for ipv6") in v5.14 breaks the TCP MSS calculation in ipsec transport mode, resulting complete stalls of TCP connections. This happens when the (P)MTU is 1280 or slighly larger.
The desired formula for the MSS is:
MSS = (MTU - ESP_overhead) - IP header - TCP header
However, the above commit clamps the (MTU - ESP_overhead) to a minimum of 1280, turning the formula into
MSS = max(MTU - ESP overhead, 1280) - IP header - TCP header
With the (P)MTU near 1280, the calculated MSS is too large and the resulting TCP packets never make it to the destination because they are over the actual PMTU.
The above commit also causes suboptimal double fragmentation in xfrm tunnel mode, as described in
https://lore.kernel.org/netdev/[email protected]/
The original problem the above commit was trying to fix is now fixed by commit 6596a0229541270fb8d38d989f91b78838e5e9da ("xfrm: fix MTU regression").
--- include/net/xfrm.h | 1 - net/ipv4/esp4.c | 2 +- net/ipv6/esp6.c | 2 +- net/xfrm/xfrm_state.c | 14 ++------------ 4 files changed, 4 insertions(+), 15 deletions(-)
include/net/xfrm.h +0 -1
@@ -1551,7 +1551,6 @@ void xfrm_sad_getinfo(struct net *net, svoid xfrm_spd_getinfo (struct net *net,struct xfrmk_spdinfo *si);u32 xfrm_replay_seqhi (struct xfrm_state *x,__be32 net_seq);int xfrm_init_replay (struct xfrm_state *x); -u32 __xfrm_state_mtu (struct xfrm_state *x,int mtu);u32 xfrm_state_mtu (struct xfrm_state *x,int mtu);int __xfrm_init_state (struct xfrm_state *x,bool init_replay,bool offload);int xfrm_init_state (struct xfrm_state *x);
net/ipv4/esp4.c +1 -1
@@ -673,7 +673,7 @@ static int esp_output(struct xfrm_statestruct xfrm_dst *dst = (struct xfrm_dst *)skb_dst (skb);u32 padto; - padto =min (x->tfcpad,__xfrm_state_mtu (x, dst->child_mtu_cached)); + padto =min (x->tfcpad,xfrm_state_mtu (x, dst->child_mtu_cached));if (skb->len < padto) esp.tfclen = padto - skb->len; }
net/ipv6/esp6.c +1 -1
@@ -708,7 +708,7 @@ static int esp6_output(struct xfrm_statestruct xfrm_dst *dst = (struct xfrm_dst *)skb_dst (skb);u32 padto; - padto =min (x->tfcpad,__xfrm_state_mtu (x, dst->child_mtu_cached)); + padto =min (x->tfcpad,xfrm_state_mtu (x, dst->child_mtu_cached));if (skb->len < padto) esp.tfclen = padto - skb->len; }
net/xfrm/xfrm_state.c +2 -12
@@ -2537,7 +2537,7 @@ void xfrm_state_delete_tunnel(struct xfr }EXPORT_SYMBOL (xfrm_state_delete_tunnel); -u32 __xfrm_state_mtu (struct xfrm_state *x,int mtu) +u32 xfrm_state_mtu (struct xfrm_state *x,int mtu) {const struct xfrm_type *type =READ_ONCE (x->type);struct crypto_aead *aead;
@@ -2568,17 +2568,7 @@ u32 __xfrm_state_mtu(struct xfrm_state *return ((mtu - x->props.header_len -crypto_aead_authsize (aead) - net_adj) & ~(blksize -1 )) + net_adj -2 ; } -EXPORT_SYMBOL_GPL (__xfrm_state_mtu); - -u32 xfrm_state_mtu (struct xfrm_state *x,int mtu) -{ - mtu =__xfrm_state_mtu (x, mtu); - -if (x->props.family ==AF_INET6 && mtu <IPV6_MIN_MTU ) -return IPV6_MIN_MTU ; - -return mtu; -} +EXPORT_SYMBOL_GPL (xfrm_state_mtu);int __xfrm_init_state (struct xfrm_state *x,bool init_replay,bool offload) {
Quoted 9 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 5.10.104 release. There are 105 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Wed, 09 Mar 2022 09:16:25 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
Quoted 9 lines
https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.104-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-5.10.y
and the diffstat can be found below.thanks,
greg k-h
5.10.104-rc1 Successfully Compiled and booted on my Raspberry PI 4b (8g) (bcm2711)
Quoted 8 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 5.10.104 release. There are 105 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Wed, 09 Mar 2022 09:16:25 +0000. Anything received after that time might be too late.
Building powerpc:allmodconfig ... failed
In file included from include/linux/module.h:12,
from drivers/net/ethernet/ibm/ibmvnic.c:35:drivers/net/ethernet/ibm/ibmvnic.c: In function 'ibmvnic_reset':drivers/net/ethernet/ibm/ibmvnic.c:2349:23: error: 'entry' undeclared
Greg Kroah-Hartman
maintainerQuoted 11 lines · Guenter Roeck
Quoted 8 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 5.10.104 release. There are 105 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Wed, 09 Mar 2022 09:16:25 +0000. Anything received after that time might be too late.
Quoted 6 lines
Building powerpc:allmodconfig ... failed
In file included from
include/linux/module.h:12,
fromdrivers/net/ethernet/ibm/ibmvnic.c:35:drivers/net/ethernet/ibm/ibmvnic.c: In function 'ibmvnic_reset':drivers/net/ethernet/ibm/ibmvnic.c:2349:23: error: 'entry' undeclared
I'll go drop the offending patch, thanks!
greg k-h
Hi!
Quoted 4 lines
This is the start of the stable review cycle for the 5.10.104 release. There are 105 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
CIP testing did not find any problems here:
https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-5.10.y
Best regards,
Pavel
Signature · 2 lines
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Quoted 9 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 5.10.104 release. There are 105 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Wed, 09 Mar 2022 09:16:25 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
Quoted 8 lines
https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.104-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-5.10.y
and the diffstat can be found below.thanks,
greg k-h
On ARCH_BRCMSTB using 32-bit and 64-bit ARM kernels:
Signature · 1 line
Florian