Skip to contentSkip to conversation

hwrng: nomadik: Change clk_disable to clk_disable_unprepare

PATCH In review Miaoqian Lin 3 participants 3 messages Mar 7, 2022 – Mar 14, 2022

Subsystems (2)
Crypto API Hardware random number generator core
lore
Share & tools
lore

Miaoqian Lin

author
#0 lore raw

PATCH 1/1 hwrng: nomadik: Change clk_disable to clk_disable_unprepare

The corresponding API for clk_prepare_enable is clk_disable_unprepare, other than clk_disable_unprepare.

Fix this by changing clk_disable to clk_disable_unprepare.

Fixes beca35d05cc2 ("hwrng: nomadik - use clk_prepare_enable()")
Signed-off-by Miaoqian Lin <[email protected]>
---
 drivers/char/hw_random/nomadik-rng.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/char/hw_random/nomadik-rng.c +2 -2
index 67947a19aa22..e8f9621e7954 100644
@@ -65,14 +65,14 @@ static int nmk_rng_probe(struct amba_device *dev, const struct amba_id *id)
 out_release:
 	amba_release_regions(dev);
 out_clk:
-	clk_disable(rng_clk);
+	clk_disable_unprepare(rng_clk);
 	return ret;
 }
 
 static void nmk_rng_remove(struct amba_device *dev)
 {
 	amba_release_regions(dev);
-	clk_disable(rng_clk);
+	clk_disable_unprepare(rng_clk);
 }
 
 static const struct amba_id nmk_rng_ids[] = {
Signature · 1 line
2.17.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Miaoqian Lin

The corresponding API for clk_prepare_enable is clk_disable_unprepare, other than clk_disable_unprepare.

Fix this by changing clk_disable to clk_disable_unprepare.

Fixes beca35d05cc2 ("hwrng: nomadik - use clk_prepare_enable()")
Signed-off-by Miaoqian Lin <[email protected]>

Thanks for fixing this!

Reviewed-by Linus Walleij <[email protected]>

Yours,
Linus Walleij

maintainer
#2 lore raw
In reply to Miaoqian Lin
Quoted 10 lines · Miaoqian Lin

The corresponding API for clk_prepare_enable is clk_disable_unprepare, other than clk_disable_unprepare.

Fix this by changing clk_disable to clk_disable_unprepare.

Fixes beca35d05cc2 ("hwrng: nomadik - use clk_prepare_enable()")
Signed-off-by Miaoqian Lin <[email protected]>
---
 drivers/char/hw_random/nomadik-rng.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Patch applied. Thanks.

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt